From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C68E810D3 for ; Wed, 27 Sep 2023 11:26:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E42F6B0193; Wed, 27 Sep 2023 07:26:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 293B66B0194; Wed, 27 Sep 2023 07:26:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 182876B0195; Wed, 27 Sep 2023 07:26:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 092936B0193 for ; Wed, 27 Sep 2023 07:26:39 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CF69BB43CF for ; Wed, 27 Sep 2023 11:26:38 +0000 (UTC) X-FDA: 81282149676.19.7A6AB49 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 0A60F4001B for ; Wed, 27 Sep 2023 11:26:36 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PUT96mbn; spf=pass (imf07.hostedemail.com: domain of konradybcio@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=konradybcio@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695813997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lgKBGHNSPs4XtFZXP2rzrV4/ir7APIOiXRK1dglU+cY=; b=ingRRo2Jp8oFhqz3Kf5YGYCVamMUoJ9TyWMSTc6tlJtLfvY5L2X2e6M2nPlAFSy3kfLRe8 orEQVsEuUNjUiMfRawHaOnV07PjDZejY80HVLEigs2nomyw/jOfTrfa7z3toOFN+wOzBOS hIC3K8zhBxowIPcNCY/N3kBJiYDJfTg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695813997; a=rsa-sha256; cv=none; b=XnD2bw5sl4ZhVxBOiWmKM2cNNNbQhGCuERXJIgbQXivKIL7oZ6P6RqBjVjnsC6Xwy+V1zR zk/7WCpRmP8po3raq9Ta+VFHn+lEemlUJikqq31w8jmjpx1m/apmUJvlb2H1Mrk7mvxF34 lHrdSvFk6F97tUd+Ng4/rEMAyJ3pPY8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PUT96mbn; spf=pass (imf07.hostedemail.com: domain of konradybcio@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=konradybcio@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1E99D617E8; Wed, 27 Sep 2023 11:26:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D3D1C433C8; Wed, 27 Sep 2023 11:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695813995; bh=3/kJu0BAtwkj3xJ9fdAbiBLvvVYc2eBsWVfENf9O048=; h=Date:Subject:To:References:Cc:From:In-Reply-To:From; b=PUT96mbnyi935kDaCn6iWqoadw2bcA5kl4k5iOwiWGVd430pk0xIrzndkmBat8MT6 0kgG86LdZn0mBlaK6ESrTrJL4oEBfAmtN+6LE0S/RzPiHrbxol7GaPi7XJmmildsqY eBhXOFzT2JHo6zduNlkR7dzPza1YNVJNYB7DB0wmVK0aFOi21/xgo01VOCxRzWNATC 9Po9tWszGFN4QfmCVi7LcZjj3wx1uAMUzFDb/Kw5aXfc1Cejc/oc0Nj3D9ix7OTS08 lOFDjKx2BHGWP/mUcw+Xegt+mYMeu+CljZ6q9LBOrum31vCHoJW8oJaWD0lD6lfyMS 1zHLK7RyC+Mww== Message-ID: Date: Wed, 27 Sep 2023 13:26:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/8] hugetlb: restructure pool allocations Content-Language: en-US To: Mike Kravetz References: <20230925234837.86786-3-mike.kravetz@oracle.com> Cc: Anshuman Khandual , Xiongchun Duan , Barry Song <21cnbao@gmail.com>, David Rientjes , Miaohe Lin , Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , Naoya Horiguchi , Joao Martins , David Hildenbrand , Michal Hocko , Oscar Salvador , linux-kernel@vger.kernel.org From: Konrad Dybcio In-Reply-To: <20230925234837.86786-3-mike.kravetz@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 9zzfxd57cqpce99e4o8nfeer1tthps7m X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0A60F4001B X-Rspam-User: X-HE-Tag: 1695813996-155359 X-HE-Meta: U2FsdGVkX19V7o3nWPtla8fztZfIFf/cM3k/NZasMNAhylpJIE9gGvrzBO8Bq40nZsaPIHoG6rmmbW7SZZxaAcHtYXdS/9B0T2V9v3scfCrR2pdRX8cV5vs9VGQGLRXYKa9LtJw/3ZZsOIXqCqJhet7fRtd3LuQfSqW34mzAkf58jB7BQENScBYKVJmWRVu/JR0KO9HTCYor4r6yqKCbrzcqzFQTw+/Ec9tKG7mZqc5fR1rF5Umo5PBIgHDLQpBlRbCm9meyo9D28U/LjtRYliYE9YFWMMshHaPeIqElP5orzERs8/aV5pVGkhb40uKl+ESFizo6Glw41H1HzY20vlGKiAZ7rLpy90BnXDlIZEEOcJf44Bodid4y7rg3536tqZtQzaudhcDkTbfx4uAtH8kdP4Qft5n/4DPB0Eh6kd//jm4oIdrH4IzlTcNyiEaL1/dloSX/aoEmc/pvCaiOIjOS2pYZWLR4OyGq7ELV3M8E3cluLJ0GC6Ea7bU/WyZjpUHMttq1aIJYuO1OG5tvJc+hYqoVjTrVMKSuuhpIldlI/oYiIoEyfiBcgcjF6ZwE5MKLyrYqH4NCNU7uHplbmhq6fCo1uon6nGqY+ED0iPg4zt87q0H2bnqRiHJ9Zv1NjUseT7+KU0/ic25HkRQIoMLTDQox9cPPChhAyY4fELO1c6ZL9kmDt/KgAxAvzvSUvLKUl1Synbo9ajfH3Ph5P5YeUfP6b0cXw14xR5tcMmxbol5/NG0qbjrTWpumbKvHAnPXPPcUawZCXmeXx2o3ia1Vs5xoprDUG4rKRwy7qh1u7SyfMtAIh9VuAZ9vgVTGF2hV9ifauipPAa4NZ2E2sN83EJviAuzF3flCGtwrNvv6eaEK2qWSYY+y796nZP0rgkb0dLiwT8NZSzEMzz/gXuIKddpYPkdV/PwVZxa/e83FNavlroeypB8NLfUEkFPE+BaqFF3/lQ1kZnIQQom SdhqAtZt Xu4VVcpVTfOL2HDoOxdLeZWm7bAGzGNGMniGgjUSxIrRe1J1hly4LjDgQ9RoagL8oHGa8uKT8IyynCR0GtVXYR7tU9ir9RlZjRyYyAlJEKGQOtkfQGNfuptBAh7ZWI/1pqtAX0F5L82jIQyKa7JwzHM5QjDhjA2uqz9Tmu3PAgxtzGOvKS5zB4JV1JCf8/+n5FdzCJqk/WUEu2jZGyQumJHEf99j3q0pkuTRENva16B5wd3ELOEfAgz0E9N+v2qN5Il8pdnp+g7p9U1DuP8LP6xhKp4A5XwG//XZYpSBhgWmGtSr9KR8P8RSBMwZM+/ArMtgW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.09.2023 01:48, Mike Kravetz wrote: > Allocation of a hugetlb page for the hugetlb pool is done by the routine > alloc_pool_huge_page. This routine will allocate contiguous pages from > a low level allocator, prep the pages for usage as a hugetlb page and > then add the resulting hugetlb page to the pool. > > In the 'prep' stage, optional vmemmap optimization is done. For > performance reasons we want to perform vmemmap optimization on multiple > hugetlb pages at once. To do this, restructure the hugetlb pool > allocation code such that vmemmap optimization can be isolated and later > batched. > > The code to allocate hugetlb pages from bootmem was also modified to > allow batching. > > No functional changes, only code restructure. > > Signed-off-by: Mike Kravetz > Reviewed-by: Muchun Song > --- Hi, looks like this patch prevents today's next from booting on at least one Qualcomm ARM64 platform. Reverting it makes the device boot again. Konrad