From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D824C433F5 for ; Tue, 14 Dec 2021 17:51:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D72A16B0071; Tue, 14 Dec 2021 12:51:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D22136B0073; Tue, 14 Dec 2021 12:51:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C11336B0074; Tue, 14 Dec 2021 12:51:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id AEF956B0071 for ; Tue, 14 Dec 2021 12:51:00 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 715C385415 for ; Tue, 14 Dec 2021 17:50:50 +0000 (UTC) X-FDA: 78917140260.31.90A8BAE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 0586440015 for ; Tue, 14 Dec 2021 17:50:45 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A38B1D6E; Tue, 14 Dec 2021 09:50:47 -0800 (PST) Received: from [10.57.34.58] (unknown [10.57.34.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 862113F5A1; Tue, 14 Dec 2021 09:50:46 -0800 (PST) Message-ID: Date: Tue, 14 Dec 2021 17:50:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v2 10/11] iommu/iova: Move flush queue code to iommu-dma Content-Language: en-GB To: John Garry , joro@8bytes.org, will@kernel.org Cc: linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org References: <0752bfc207b974e76eab7564058b5a7b9e8d5e6e.1639157090.git.robin.murphy@arm.com> From: Robin Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of robin.murphy@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=robin.murphy@arm.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0586440015 X-Stat-Signature: x9qtmw7wqhuqwe81gpsqq4njbmxmmrtm X-HE-Tag: 1639504245-211252 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021-12-14 17:18, John Garry via iommu wrote: > On 10/12/2021 17:54, Robin Murphy wrote: >> +=C2=A0=C2=A0=C2=A0 iovad->fq_domain =3D fq_domain; >> +=C2=A0=C2=A0=C2=A0 iovad->fq =3D queue; >> + >> +=C2=A0=C2=A0=C2=A0 timer_setup(&iovad->fq_timer, fq_flush_timeout, 0)= ; >> +=C2=A0=C2=A0=C2=A0 atomic_set(&iovad->fq_timer_on, 0); >> + >> +=C2=A0=C2=A0=C2=A0 return 0; >> +} >> + >> + >=20 > nit: a single blank line is standard, I think Hmm, you're right - I've grown fond of leaving an extra little bit of=20 breathing space between logically-independent sections of code, and for=20 some reason I thought this file was already in that style, but indeed it=20 isn't. Joerg - let me know if you feel strongly enough that you'd like me to=20 change that. I'm going to have one last go at fixing tegra-drm, so I'm=20 happy to send a v3 of the whole series later this week if there are any=20 other minor tweaks too. Thanks for all the reviews! Robin. >=20 > Cheers >=20 >> =C2=A0 static inline size_t cookie_msi_granule(struct iommu_dma_cookie= =20 >> *cookie) >> =C2=A0 { >=20 >=20 > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu