From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44444C25B78 for ; Tue, 4 Jun 2024 13:18:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2ABC6B00B6; Tue, 4 Jun 2024 09:18:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD9F46B00B7; Tue, 4 Jun 2024 09:18:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B53DF6B00B8; Tue, 4 Jun 2024 09:18:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 980716B00B6 for ; Tue, 4 Jun 2024 09:18:23 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 500D0C013F for ; Tue, 4 Jun 2024 13:18:23 +0000 (UTC) X-FDA: 82193260086.17.B3F9571 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 0B132C002A for ; Tue, 4 Jun 2024 13:18:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TQy0k1jE; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717507101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EiYrE/8TjWzRIPpqq/yqqnp1VVjY1fjK18SjvOdopT8=; b=TDJlLvti4O6zXiU5+QCjK+qT9RmNGJPo/F6o+1CIhYdwe3Vspj29HG/xHyEgLhANLcZPha aHfqsKgFZapgvqj2o52owYvL3bmRCzLZTDjQ81N7U+/owqQreGCJCy2sOooxy3lwsJY/lJ wzhxQ5bXtLwAfSDSPCeKEk9ypJw3Pkw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TQy0k1jE; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717507101; a=rsa-sha256; cv=none; b=XIG9x5JvIQVMku+lvVyasOSE6R89P4pYvh2RiZrJuflY3c1JWfasa/VXW8nKl2rwLb+u/9 EkC2RLLIeoVq3sGpKJ/r7FPGkAgzBQIyWKQ+ozskEsscpBFTSH/W07gheaQZP8GAuzFrRZ 2oRovuPctTQ4di5HBe5ff+XJn4p7pbA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717507099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EiYrE/8TjWzRIPpqq/yqqnp1VVjY1fjK18SjvOdopT8=; b=TQy0k1jE2LZdEouAFdS0lhss9AOcN39cTdsm2SgQZ7qyKZlCpkFN3383GG8hRj3homdtZV 3/27pmnsXXgFsRtx6AldqeykeZgIkwuG6vh9foxa+dSjvB3VH1etxgNcU436jyUtKcFJ7k 1QZB107s35ImUKvjBDLian1oPkWDBJw= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-pVUmMyJKO3aLjH_vw_X2Lw-1; Tue, 04 Jun 2024 09:18:16 -0400 X-MC-Unique: pVUmMyJKO3aLjH_vw_X2Lw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2eaa6f40ef2so8349771fa.3 for ; Tue, 04 Jun 2024 06:18:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717507095; x=1718111895; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EiYrE/8TjWzRIPpqq/yqqnp1VVjY1fjK18SjvOdopT8=; b=gADdMGpdOraEPSF/ZWSA1o/HpiXdNorqipXdIAYtxROu8lcaxf5gR6W3Gv5ve1Rlz5 Jp0YCmfHbdOpDVe1vfiMWSOzEhVIidxtyT7lGbPQiZmC6jTjmdw16ct14ib3Vebhhphx ryxVQv4FmV0vApOCN29cxLMe5gnfMZucNtAAkWDx3AYbWm+6d2U4lfKRtMO3akQaCsME auEv0DUAyHcsTvoUv996aH+LrGAurU+rDNKp6EnuOcVE96Vaypk8p9L13Mm9srgyo4c2 FP3GOMqW3EZfwgjKM3g6Rl5uZfpsLsliPplWNCvthXWorkuNR8oqbRmkYOWenJT/QK9k HosQ== X-Forwarded-Encrypted: i=1; AJvYcCVzunhs1TTuMPr9ZuRELfdBhZdJnpUbzEfLmbgBftnZrI3Yj0L8mrelNNwygkpLca21hiLZeg1z5vf9rQqooVR8B+k= X-Gm-Message-State: AOJu0YwCob9VxLmYL66qTwn84nNINc9hAxinkqQUV/CJGvxClQu5gRVZ l0Y4gaR9Et/ENpMnQBbxE7k0pMQkqXTdO4gNIi+NJgcfVjtZtVwHe8bEEU0rLRv9RwW666YNGKZ x7y2jo5AAn4P7rq/q/9sa3j99BVQ73RpbfPWY48XmRz4n5fa+uG9XyaW1 X-Received: by 2002:a2e:870d:0:b0:2de:73b5:427c with SMTP id 38308e7fff4ca-2ea950b5396mr74938741fa.9.1717507094924; Tue, 04 Jun 2024 06:18:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFc8FtSCIGrimFOyzAMyZpApvLn0WSmU3RQODLDr1Zjhs5mSc8kXNRN+R/+HqMDMHyVpnbL9Q== X-Received: by 2002:a2e:870d:0:b0:2de:73b5:427c with SMTP id 38308e7fff4ca-2ea950b5396mr74938501fa.9.1717507094508; Tue, 04 Jun 2024 06:18:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:3a00:a025:9b06:549e:c16b? (p200300cbc73a3a00a0259b06549ec16b.dip0.t-ipconnect.de. [2003:cb:c73a:3a00:a025:9b06:549e:c16b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd064bbb1sm11496884f8f.101.2024.06.04.06.18.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 06:18:14 -0700 (PDT) Message-ID: Date: Tue, 4 Jun 2024 15:18:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/10] mm/ksm: calc_checksum for folio To: alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <20240604042454.2012091-10-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240604042454.2012091-10-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0B132C002A X-Stat-Signature: gpgya7sdm8uboi7hzg16c6ayuq4uojxx X-HE-Tag: 1717507100-688983 X-HE-Meta: U2FsdGVkX18tQbsNK9G3zuUVFQAu1GdUSUV++QT649b7RLmlsQHDRBSIC9Lzpy+Cyx8V9SwVlBHXFMoknN0slDI/lHC9X5PtQ9qQp3HXgI4F8ZjuoulgYW/Tki/ptj6E7VEFhRwCZtaWcfspEOVje+8eTYLgxXG9+9LQM4CdG5leBWUog5pYU1/H9k6U7g/N/UiGZ0qe6v6aYOW2EXMaDwt9zdS1JWowC19JmO5HIZ+ABcDz0BfS9sWm99CL2u9nW46diVWGaXTiUNYDFGrY3DEehVu28ABk0O8C9hLyR73am/na9c5IUrXpp2yZ53VumdZ/SvLscMoEwY7McQ5SEEzgZfaqH+g+TUwOibOcihhDR6jUZ92syzctyfhEBgoJX79gykKYVwjBSCGFL6oO+noGZiQ3ASkiAe0/9AB9Ms0LdwnSvlM+4JPV81oBfLeH6cMflVQ1OpmqznmNUDesmwZ1aYv9Vwi6rAfY8YyTfbErWtMsK20fjxOdyE94RHkSwq7XRyi+/jqolJ71gyk0RT/8p468lQIj8jK8opj/nsPdEEvj296+kftxTEQK0Z+8BVguvp6mB6zePpBHtcHkBuf9i5wgNsDtFsZVmEfy9JsUwR+F4Mi00bQum1bAHq5yXXdruRRRqUAmAUhPpFxUiyFgk68GIcRwXvP46yYE0qMy7JNBPt4GEDP93/hmGqRL8qN3D5nrH1GDj865mVee6PcPvkPnaPd/vMHBYVXNsjYacl1tM8gCs/anZHh+nT+2kf3iRjWHrfLQ44nTCbL1uiicW0WNhpIkQ37XKV/y6HZRz83G03lSJatfLn/dXM7VNPNH5GMlT/6dg9sepUjLILD16/hhdYz8coE3YseB4BbcIscg/292gCFJBnMhyUXH05Se5rCbn1UYPJcJUDsOWCSK/agFvnzAUyMp6ruKVtn/v0QyynIQ8S5eq1CwMBqKqEgKkXsIsJnsxNYAJZM w0FBgD/Q 1p2iXaA4ENOvCpIgp8X1T9Ea/dbb66L+JgNhj6eohi8MCg+2mnQrpBQW30wLEI2to79wL8LXJK8JCiC+dYW2Bg+4ox+IEGfkWfLHM7//lrX6Kx/xFF6ppIM2gEk3OG6gdUiC8hrETC7jMhVMUd/SOYGJd1jwD5ImLl0jiwAjJdSiPyobTB1VssGhKdFD71pP1PEdrDWiKZD1l6NEXLiQvlHrp2XcHGrIL9ddjvVXELzMlgC242jXbwE1zaysWuEMVBGpDeumGFXgNv24E9mf3kIYHO2IE8/jEb4QYqE/tVAnyUkRGtjNLav64UW0u2KgHsfEkXKk4xqNRF1W9/VE6BO3vtTmUyzO+Ik+0vqorIRiIF2FNJ/OmLQu8gELscb4gmR0JjThTetfygcCLaT4kN3rVUW/gylil3xhNP603nhljccV5rz8qVXjEe1EKRryDCbhbcHWBsLcDVG0D72BheRUpcSny3jD5PNmZVyxxeWnAgZlqwO8Zfptxi+3tqx+aFhELsLrmzpxdw/jtxtZsJSFKE0cl5pwErqj+xAjgGX0cDx9vj7f8gQKnHbllFg+5SxdH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.24 06:24, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > Let's check the whole folio for contents change, don't count it if the > folio changed. > > Signed-off-by: Alex Shi (tencent) > --- > mm/ksm.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index b9c04ce677b9..dc2b5e6a9659 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1258,11 +1258,13 @@ static int unmerge_and_remove_all_rmap_items(void) > } > #endif /* CONFIG_SYSFS */ > > -static u32 calc_checksum(struct page *page) > +static u32 calc_checksum(struct folio *folio) > { > u32 checksum; > - void *addr = kmap_local_page(page); > - checksum = xxhash(addr, PAGE_SIZE, 0); > + int nr = folio_nr_pages(folio); > + void *addr = kmap_local_page(folio_page(folio, 0)); > + > + checksum = xxhash(addr, nr * PAGE_SIZE, 0); > kunmap_local(addr); > return checksum; > } > @@ -2369,7 +2371,7 @@ static void cmp_and_merge_page(struct page *page, struct ksm_rmap_item *rmap_ite > * don't want to insert it in the unstable tree, and we don't want > * to waste our time searching for something identical to it there. > */ > - checksum = calc_checksum(page); > + checksum = calc_checksum(folio); So for a large folio you suddenly checksum more than a single page? That's wrong. Or am I missing something? -- Cheers, David / dhildenb