From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE228C5AE59 for ; Tue, 3 Jun 2025 20:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 383FE6B0508; Tue, 3 Jun 2025 16:17:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3343B6B050A; Tue, 3 Jun 2025 16:17:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FD0E6B050B; Tue, 3 Jun 2025 16:17:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 02EDB6B0508 for ; Tue, 3 Jun 2025 16:17:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A4B3CBF1AC for ; Tue, 3 Jun 2025 20:17:57 +0000 (UTC) X-FDA: 83515200594.20.BF4B50D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 4521A180017 for ; Tue, 3 Jun 2025 20:17:55 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XvRMfaHe; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748981875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+1RY0HD1hn+NYzthB/zompikE+mEYPZqKqX1tH5KHaY=; b=rgjzYij2RpTNT0NzWOVDU+k71hJzUKnNxeXrKhuVQWR0hUeGR6bcWJfC7kf9s85c4RJ07F T5h7ya6U5Zmn9WvVGhIABmDIoWSP9UbqeSHtmSLpn8cU8bHnWYiCtWAfI8Z8FVZJmNaAGl PvjmR/YybARRnC3IYUsnvxfy8e8tAGg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XvRMfaHe; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748981875; a=rsa-sha256; cv=none; b=WM0nEPul6wK5YC7yxSRKCObGgo3Wlxr4Tyb5knD8EEE/m+f9OGCoxyAHAzEe51hFFIaZf/ oLje0LFw2F19xC9JzMrvQtRe//5QbbHOhdOT66QcNdboT5oGKksL3TFFqmXYLKFzz8UJNv pbwb3ABtesfYp3aU5VygRUt80qBoSbM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748981874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+1RY0HD1hn+NYzthB/zompikE+mEYPZqKqX1tH5KHaY=; b=XvRMfaHe1/k9t4zawF1KvhCzQgPVRNwTwMvGmQKY1Mmsu3DeqjcuqvUKM2my/mUvJ59Ry2 lhMppi07uaBlCB7GUzXSgdjNaUMm1w5s6tSbnvO0f8n1ilojKUU+u5S0qsb+d1SOqm0v4x m5Mi7R4VZeGoFB46W2vQmilnxfunXuI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-8omiHjdYPBSjIEiJ5ls7Zw-1; Tue, 03 Jun 2025 16:17:53 -0400 X-MC-Unique: 8omiHjdYPBSjIEiJ5ls7Zw-1 X-Mimecast-MFC-AGG-ID: 8omiHjdYPBSjIEiJ5ls7Zw_1748981872 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43eea5a5d80so38376575e9.1 for ; Tue, 03 Jun 2025 13:17:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748981872; x=1749586672; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+1RY0HD1hn+NYzthB/zompikE+mEYPZqKqX1tH5KHaY=; b=soLVGYs0mu1KFs/FzhgEoa5EwVynqcLnex+v6Bz22KK++aWqXdMYRveiAcGJpeOuML 95qfcvQCe1nueuDQOGVaooamgY0ZIqzpdvRo2iuoTHbiV5Sl61eAZ7O+LTccVvhfAe5N h7l27cmZBJyxxbXol0EMeXbzPZDzxPjgkkFPT+NFZry+KpSbrjmrR5gRBbUOLjSj4LqE VohBI6TxWNNAsV7UNurIMSCm1yWo7SEVRVddFf8vi1agfYC2sfdRDU4en/PxHejbpc2g W+xIFVYU42NUqVZfwWO/y1AdhgOiYiMrQsziT8784nmZunO+z07lVcB9tC0ZORhXBp64 xg2g== X-Forwarded-Encrypted: i=1; AJvYcCVFtedQR5PfYtM48TBc5P1FnJ6FKCMzXK4rRkli/BdJWcWysgKOMcMieQAXocf0nXDEiGQRz1hdEg==@kvack.org X-Gm-Message-State: AOJu0YxM2L49wHAMK0w+53hxE658kqi9LmHCq9ejlxfMaOX8hvXBEwSt s9tw+lEFEO9YYoVqzE66wQlel+IFCvfn6FSTYwyiaTjN3PoTxPtzocg6LxPw9QOJ6ugfBopbqIt nkqvmOSmUWMNGW3fJ7bxXpVimnv03JO47wVuaIcdxZ5oJoQbUCN1p X-Gm-Gg: ASbGncuRlymNQkrHU8S73cnh0PnOz18Z2hArySwbnAScp6PtdcH8ylyanEMRODv/JPD VXXbVKCTzmXN+HD7+RnjJ+fzyYSApJdNfGCp6pwYLzeGsXVVMxAqRQ5J0OuzPNMuIqUjXyGA/uY KiaCUO5/S9f59k97pPpWs/7XRa+sll8hlvr1S3IXTUhvf/oFkMbza56hUnP9OLg76Wie9A+bc2z BcawYWeeuJOiGLnOnvtOSfHr54Mlg0uBRJhVRQYoDX6lTwcU9//xDdql6L4DOBYszTaDhGwSeUr yecjvyBFl9DF//GW/TWFF8CHWnPpTtM7oarXSpM2MT7mGbF637d5vGUBZT4jAd/376hEkgTx0V/ homTvbsCudiieBK2ZoxdMHqHyYJ8grFdOvbINba4= X-Received: by 2002:a05:600c:4e01:b0:442:f4a3:b5ec with SMTP id 5b1f17b1804b1-451f0a64f08mr817295e9.4.1748981872240; Tue, 03 Jun 2025 13:17:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEI+PPvXmScqjXvKy8YY53Kw8ucqabBmzAl8IGnjFusqugiTsGUr0vRqgzAeBk4ls8nsgjCCw== X-Received: by 2002:a05:600c:4e01:b0:442:f4a3:b5ec with SMTP id 5b1f17b1804b1-451f0a64f08mr817025e9.4.1748981871817; Tue, 03 Jun 2025 13:17:51 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fb0654sm172866835e9.21.2025.06.03.13.17.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 13:17:51 -0700 (PDT) Message-ID: Date: Tue, 3 Jun 2025 22:17:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/memory: ensure fork child sees coherent memory snapshot To: Jann Horn Cc: Matthew Wilcox , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, Peter Xu , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250603-fork-tearing-v1-0-a7f64b7cfc96@google.com> <20250603-fork-tearing-v1-1-a7f64b7cfc96@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YMqC6-r8aILgHI0J71cfsqXfYDuUOhqtuS4OPIrwANI_1748981872 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 4521A180017 X-Rspamd-Server: rspam09 X-Stat-Signature: tmh4s3cafma1ou75t1q7ptaujdrfk7dk X-HE-Tag: 1748981875-80816 X-HE-Meta: U2FsdGVkX19vinlHlaQCQ2SlxVrx3pzsoQ1iDwM83IKmnNKRu4/HPUEVc7gXLwcZs8PcaU+oi2mhEcsErtyikoWccc9DvP6DGMMpQmYyUgHXd8+m58WTQ2hc46dNmrZUz6D7KUMF/VTbvLMp8+tooAOYXYkFXXaCpLN4lxc/0iBezpYByPCHHxnTw3PThe1NTBpDJWRLEnHnqY/jTNU9svc/geTHm2/nVPtKRsVRaLMCxJCiqkIbM6UC/GN4qh6vf8RWkGS6xnOFXX8LfjzzrI+9VRPFk0J/Dd5zGjlxHEKbGZk9Xjy+XB8TyL8lV/CI/7HnrdYIVEiLa8FhDgRm1bAiCGdlmd2S8D3K07YdPZHfFKaJ9C/+TFyTIjH5f28RKvhZXmb3TEorBZWJwt+YA9bOX+4zkHjqjLn1pldMhpAbiWHEUKQhLQINDuZGXbLdqXeIEJl5LO6q5ECuH1DG6MedUTnZlNg0PmvbqbVFN0S0jRg2D7yWCkLfPZtJI+c2zxuTBb6TnpZ4mR/Ap66iSmVvkeqp6LVaXjfbXX6Z+O+74xCnUdv93TBs0EXK/ztH3cgRyy0RLNgR9c58s18eCwRB3LHdlM66Y3/9u839UW5N+pUmy3XBUIOvz4ksB/LB5EFQMrDC1m2b1VdCi2Cr4Y419kRAHJzT5t2C32Y+bgjFpSV4vnBRGTIn1uLHSi+7kiG0aA0XRpjHOzV/oZAFYIzMbNZdTGNBEdIxL26WqhXIPW6dakCDHK3FzlGi3uiLRdDUeWAiytinJ0N99cy++SRNZIV3B2lJgBFrBbMyoNCxvvpNbp3ZunooP+VPeRDWO/ZM2tKMr8XwFS7l9gJ5CT+EpVU3BIAZmrm1CIYPLn7D4Ek2cyWNfnFSLqLvlB3GgcZJLNSodOZswd7daFLvPGuuPMLWybHJNPsEskTtj0GiMpWzxxt5l8isH+8oyQ3Ai4tZKH8+RhAftlqMd+X S13eHvxa Sztr3N9PAu3M6N3mlK+9Kd9bnGHLoBeXZFLPYwj8TnPZWjuYuQd3edk4rkg3+5f7sm/rAbLdEw53a2C4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 21:09, Jann Horn wrote: > On Tue, Jun 3, 2025 at 8:37 PM David Hildenbrand wrote: >> On 03.06.25 20:29, Matthew Wilcox wrote: >>> On Tue, Jun 03, 2025 at 08:21:02PM +0200, Jann Horn wrote: >>>> When fork() encounters possibly-pinned pages, those pages are immediately >>>> copied instead of just marking PTEs to make CoW happen later. If the parent >>>> is multithreaded, this can cause the child to see memory contents that are >>>> inconsistent in multiple ways: >>>> >>>> 1. We are copying the contents of a page with a memcpy() while userspace >>>> may be writing to it. This can cause the resulting data in the child to >>>> be inconsistent. >>>> 2. After we've copied this page, future writes to other pages may >>>> continue to be visible to the child while future writes to this page are >>>> no longer visible to the child. >>>> >>>> This means the child could theoretically see incoherent states where >>>> allocator freelists point to objects that are actually in use or stuff like >>>> that. A mitigating factor is that, unless userspace already has a deadlock >>>> bug, userspace can pretty much only observe such issues when fancy lockless >>>> data structures are used (because if another thread was in the middle of >>>> mutating data during fork() and the post-fork child tried to take the mutex >>>> protecting that data, it might wait forever). >>> >>> Um, OK, but isn't that expected behaviour? POSIX says: >>> >>> : A process shall be created with a single thread. If a multi-threaded >>> : process calls fork(), the new process shall contain a replica of the >>> : calling thread and its entire address space, possibly including the >>> : states of mutexes and other resources. Consequently, the application >>> : shall ensure that the child process only executes async-signal-safe >>> : operations until such time as one of the exec functions is successful. >>> >>> It's always been my understanding that you really, really shouldn't call >>> fork() from a multithreaded process. >> >> I have the same recollection, but rather because of concurrent O_DIRECT >> and locking (pthread_atfork ...). >> >> Using the allocator above example: what makes sure that no other thread >> is halfway through modifying allocator state? You really have to sync >> somehow before calling fork() -- e.g., grabbing allocator locks in >> pthread_atfork(). > > Yeah, like what glibc does for its malloc implementation to prevent > allocator calls from racing with fork(), so that malloc() keeps > working after fork(), even though POSIX says that the libc doesn't > have to guarantee that. I mean, the patch here is simple, and there is already a performance penalty when allocating+copying the page, so it's not really the common hot path. Merely a question if this was ever officially supported and warrents a "Fixes:". -- Cheers, David / dhildenb