From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1DB1D5C0C8 for ; Fri, 8 Nov 2024 14:13:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70E216B008A; Fri, 8 Nov 2024 09:13:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BE3E6B0092; Fri, 8 Nov 2024 09:13:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 585676B0098; Fri, 8 Nov 2024 09:13:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 39D736B008A for ; Fri, 8 Nov 2024 09:13:29 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D618E40CDF for ; Fri, 8 Nov 2024 14:13:28 +0000 (UTC) X-FDA: 82763119404.26.2165B80 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf10.hostedemail.com (Postfix) with ESMTP id 5227BC0013 for ; Fri, 8 Nov 2024 14:13:10 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=O6f5Gh3+; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf10.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1731075146; a=rsa-sha256; cv=pass; b=OuXk7K69nOOrMbiaD/ig8dyAGinfWrFQ24EVEwdx3fty8wDB5IdfyRquVhUcrAsuDwwcK4 f8keFTcIrYuDzBTg4fsO16i3u4clUb1Q9pl1ZU8ob5KIOA74BQ5ndwVsdk/wU7gOS4cdPb 00AfObs7BPfrfiMV3DOJMv8Yglu94WE= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=O6f5Gh3+; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (imf10.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731075146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wLsbq45VP+QQQn7ywL3Aaz1egL8UHgg6/j8C4aCGAxc=; b=in3Gei0mJlo6GD6LR7PaY3ixnJgnqEeiVoJGYeaJcDwC+ZWgUMZNG1T+jejquWayFVUURN 1mUUEo7MRhlecjlKsILPPbwi6yf1Tf6y7xoytsZHL1Fhp5SlogjHrd8kUusFGL5q51Vbr6 iO1z2Q/KYtyUCLM2uKS87M98YBob2IA= ARC-Seal: i=1; a=rsa-sha256; t=1731075193; cv=none; d=zohomail.com; s=zohoarc; b=NwmT7/Pdl21xBFxBOyhq4+cLzeyqeFWIofzBjMhMGWF9ZqSdsINnOSpEQLnsXDeLyeQDmfAl3FuwamS7/OKdB/G1d/xJM97v9OQMgOuCM2t+yYsCti/2WoQ01g6cnUJg5wIBvR9PtRXAWS3PF9igpTll2ANHnq7CYQmLSgtQ9Xo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1731075193; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=wLsbq45VP+QQQn7ywL3Aaz1egL8UHgg6/j8C4aCGAxc=; b=ZO4LXMirHUpbJBSmZ+gkJY4vtQyJf7WDNRsslI4WDGgln9/9LUK1gmOUv9ABfLEqmmnp9d4/14W/ZI2vdW7zv7Zs3othbJPzald+cNRezWnvHxPXnWEAKdoQhC9lx2XQBy/BW0V2742EUM1UUSFCrY9ZP6biTGs844VQTbFXdcY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1731075193; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=wLsbq45VP+QQQn7ywL3Aaz1egL8UHgg6/j8C4aCGAxc=; b=O6f5Gh3+9c+jVXqcKij73CEmPAyiYI4qjNuuhLdi1srnVxOquVpE2AHekhKa11o3 f4Vn55H0yeBO6LLUCloatvJQUMLtT2ciEX37NDQpyJvLOoDkOVDQc3V52kcNJRapcGL EH3+AvSdZKAKVzVH9w3QVe3JU7H8VCAdnQtxnfu8= Received: by mx.zohomail.com with SMTPS id 1731075192437247.0495706688124; Fri, 8 Nov 2024 06:13:12 -0800 (PST) Message-ID: Date: Fri, 8 Nov 2024 19:13:04 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start To: Donet Tom , Andrew Morton , Shuah Khan References: <20241101141557.3159432-1-usama.anjum@collabora.com> <5883b1c0-13c6-4593-9dd5-17f34c1319fe@linux.ibm.com> <13a96176-1bfa-4567-8ce5-a2b75b110afc@linux.ibm.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <13a96176-1bfa-4567-8ce5-a2b75b110afc@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Rspam-User: X-Rspamd-Queue-Id: 5227BC0013 X-Rspamd-Server: rspam11 X-Stat-Signature: 1mtdf9uyftcrpqy1zhaj8hhttjeqi1jy X-HE-Tag: 1731075190-588195 X-HE-Meta: U2FsdGVkX1/gerpVECpKVCsooTp9d9B09t6j6U6n3aFhkT3o11Sk/o6ITII8BUJmH8w00bDQED1bqj+sf7FmALNeHVqfcR1IRlOv4DIHzx/YkytyZOb3Un3jUyeVV0vafeGOGDVJElWREWzbwK/YRUygC26EGy8p9c+nwdFx8ra2LBYCAdEFldmygZsYvilUwrxsDq8LsVSwTGrdTtr3pRKAvVTrGDHezQdew1J/kVuXWCLFzx00W1Tx401kBOj3CW/cbc3Gwctezqhkmre+oqmxrSw/Uc5r3YJXhXKVoMwN6WGPb8HqrHVMw9f1J1bL5hF4gHL08SNsFfHF4UWQgZfiTs2lTthlprImdP7/qw8S0tmWupr6gVmUIpiA9PGmkBMEd+xvFOz7sm2vGeUXglN+L6nGRJ4i92n/86/o6ZAMmEzoO/iYT4GcF0QY7cGTs3rSfVAvxG+AHOPo7TxIvKB4V1o6lnf0GQzpkYHtnOJE8MGAeJ8MXJADEf5q94UZMoc8X0oBpyFf4g2BHVvyQDl5/Y4ZmAB0xxY19Gz9akC+YScMvFAr6JAUqAaZjKEJ4dSVrQYr8msCVf/cb1OTKSYahKRveeTlxuNhf644w85qAblSxofDc2xRd62jkjJ4kQhZFrOJ9WQxy1o3fMLCsPa+3rrE0CWFXjKtdt6CXDlB85F1ldMdRLdiBVgaxN3YnRNqbMyZ2brC17LsbUK2Esz5GVZ9tDKaK3KPA9BB3HZECHjSMRmrvFyk/YP7J6DXM6KOT4+gN4gMbVPVkhPw/bxMwCyza6lMP5wTQeNEpjY8UCHqxVMu5tJUmnUrY6J2fClITH+X9UP1MJE3jMYC0cYKear+tCWJP9OXhCja6Axrq9RabAUrXNbn5IEOal2aPaEafRk3wg7R4M3qrIA4fS283e3a9fffJV8J9rkIP4ZmyMx/47+srAtaqF6eUOn2EBeXWL1+Y51JtXaC22O sgw7uVEa 1PCcfKawgrVL4uHQzBFs61Vdkd6L1vIRho/tHwhiqNSqK213QZsF2VYs+/pMtLFuX3YIv7oRR9nQbM7RahAa5U6JXQun13w3dz/aDdqBPuwwQoxakt2l28AvFna6v6cq8BLS3WmpNj18vWwFEgwLhJm7TqtShhr9inmHL+KCWo79CrGDKvs38aTV1Fs8n8X3UzDTTos81wx2Un/hLSANNR4paemDwtYX6D49lerEJw98xpckzG5e+BLEzmENs0dYmjsymB4NCaBy4X7WQOk7CX1ay8b4FncVTeAyS5al7jxnpl7hHU8Nq2/wZG96pp+I8DDhOh5vfjDKg3lmDlMyuEpRvVZ23Yi3qgKYodHBKj2AIr4TXrDuey4+OAkxdhTae6d0Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000082, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/8/24 3:49 PM, Donet Tom wrote: > I think below changes are required. > > iff --git a/tools/testing/selftests/mm/hugetlb_dio.c b/tools/testing/selftests/mm/hugetlb_dio.c > index 60001c142ce9..4b52106b8124 100644 > --- a/tools/testing/selftests/mm/hugetlb_dio.c > +++ b/tools/testing/selftests/mm/hugetlb_dio.c > @@ -44,6 +44,9 @@ void run_dio_using_hugetlb(unsigned int start_off, unsigned int end_off) >         if (fd < 0) >                 ksft_exit_fail_perror("Error opening file\n"); >   > +       /* Get the free huge pages before allocation */ > +       free_hpage_b = get_free_hugepages(); > + >         /* Allocate a hugetlb page */ > >         orig_buffer = mmap(NULL, h_pagesize, mmap_prot, mmap_flags, -1, 0); > >         if (orig_buffer == MAP_FAILED) { Please can you send a fixup patch as you have working test setup? Otherwise I'll take it up and try to test on working setup before posting the fixup patch. Please let me know. > >  With this change the tests are passing. > > ./tools/testing/selftests/mm/hugetlb_dio > > TAP version 131..4 > # No. Free pages before allocation : 100 > # No. Free pages after munmap : 100 > ok 1 : Huge pages freed successfully ! > # No. Free pages before allocation : 100 > # No. Free pages after munmap : 100 > ok 2 : Huge pages freed successfully ! > # No. Free pages before allocation : 100 > # No. Free pages after munmap : 100 > ok 3 : Huge pages freed successfully ! > # No. Free pages before allocation : 100 > # No. Free pages after munmap : 100 > ok 4 : Huge pages freed successfully ! > # Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0 > > Thanks > Donet > > -- BR, Muhammad Usama Anjum