From: David Hildenbrand <david@redhat.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: mm: fix the incorrect 'FileHugeMapped' field
Date: Tue, 17 Dec 2024 12:59:04 +0100 [thread overview]
Message-ID: <dd96e6d4-b8fe-4360-b6eb-f6375df9eaf2@redhat.com> (raw)
In-Reply-To: <d520ce3aba2b03b088be30bece732426a939049a.1734425264.git.baolin.wang@linux.alibaba.com>
On 17.12.24 09:55, Baolin Wang wrote:
> The '/proc/PID/smaps' does not have the 'FileHugeMapped' field to count the
> file transparent huge pages, instead, the 'FilePmdMapped' field should be
> used. Fix it.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> Documentation/admin-guide/mm/transhuge.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst
> index 156a03af0a88..dff8d5985f0f 100644
> --- a/Documentation/admin-guide/mm/transhuge.rst
> +++ b/Documentation/admin-guide/mm/transhuge.rst
> @@ -466,7 +466,7 @@ AnonHugePmdMapped).
> The number of file transparent huge pages mapped to userspace is available
> by reading ShmemPmdMapped and ShmemHugePages fields in ``/proc/meminfo``.
> To identify what applications are mapping file transparent huge pages, it
> -is necessary to read ``/proc/PID/smaps`` and count the FileHugeMapped fields
> +is necessary to read ``/proc/PID/smaps`` and count the FilePmdMapped fields
> for each mapping.
We should probably change the above to clarify that this is all about
PMD sized things.
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-12-17 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 8:55 Baolin Wang
2024-12-17 11:59 ` David Hildenbrand [this message]
2024-12-18 6:28 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd96e6d4-b8fe-4360-b6eb-f6375df9eaf2@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox