From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DFBC71136 for ; Tue, 17 Jun 2025 10:02:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3CA96B008A; Tue, 17 Jun 2025 06:02:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC4F06B00A1; Tue, 17 Jun 2025 06:02:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A65D76B00A8; Tue, 17 Jun 2025 06:02:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 91E8C6B008A for ; Tue, 17 Jun 2025 06:02:00 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 49595C01EE for ; Tue, 17 Jun 2025 10:02:00 +0000 (UTC) X-FDA: 83564451600.20.E969666 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id ADB4840016 for ; Tue, 17 Jun 2025 10:01:57 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QU2rtsN8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/Fl2UmtK"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cMW8JP6a; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=V8HLv7ZL; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750154518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=is6xPlFFjHxaFmKq3lSjTwC88hPdy6cHcQ1nJWax3T0=; b=WhSlzfR/P4MU0HzD76ABn8A9e6akIqZWFPWKqhS1LY94dOSp+F0kEZcmhtx397/edSDUE7 gr3aK5jvk82dRFuItOa2VrxT3gyYkYn8JvCkaiwn81pKGPPsmGEUFPDgzua650KDOudrsD 6LpscxCpZn25bAd8Ipbk3yVxvb0bvLg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QU2rtsN8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/Fl2UmtK"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cMW8JP6a; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=V8HLv7ZL; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750154518; a=rsa-sha256; cv=none; b=Ir+LBCywNBI2D9h0jZBnbM+123LgD4JDrRVEl6ad4HQ8dcZXiYN9dXu9LGjpp+s1aFDWi7 I0F9TR2uddrIVOTaqyzaxEE95KXR1VlnrsPB6FkAECuF5D8Q2DLNjrVfHhHcn7IQ/P6Gqc GWBRSps3B6tvDqakpBCLNodpTj3i5Bo= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E25C51F391; Tue, 17 Jun 2025 10:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750154516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=is6xPlFFjHxaFmKq3lSjTwC88hPdy6cHcQ1nJWax3T0=; b=QU2rtsN85tcH+wAy9eWHh5Jot7RqHm8qNSAEa9JeeeM7lhQk9X+04lxHyviETFMmE+2eCM X3k8OG04UaxPwcwH76ZE8RZSYyoCcpQmE43wuXDcem8sOplH4v3gndq/LNzrkKxzVEeJZ+ m1CKFCWSstiGFlc7tljmUl0/uK9E8Fo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750154516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=is6xPlFFjHxaFmKq3lSjTwC88hPdy6cHcQ1nJWax3T0=; b=/Fl2UmtKYM9yIYVjZvFCQUpdtqQlxJrbTSF2Z1l3i6g3LubAyPbSf3AqVNUuoGdDQPpDtK 6aUhHG5W2DA2EsBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750154515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=is6xPlFFjHxaFmKq3lSjTwC88hPdy6cHcQ1nJWax3T0=; b=cMW8JP6atbgqTRHQjqXliTY+BkezB3w/0SJf7wle4TZHdVxU3jFxEwRdLfMLRRw9Yg8YKp dMANAK3zfk+PUv5Ein+MSIcbGtaExrjpYqc+GLgI5pOiRL3jodND20lv7yCk92k15+oqDA 5i5KTmjJk6vCEFwR+dRvjffGdQpejF0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750154515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=is6xPlFFjHxaFmKq3lSjTwC88hPdy6cHcQ1nJWax3T0=; b=V8HLv7ZLKCpHrbSjFo8ZraJqDW6bM88t+CNzTxp2Hu9z6uZbnCPJU3EePtF6cKQuE6Inu7 WrxyACqzoA3dh0Bw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C5A5013A69; Tue, 17 Jun 2025 10:01:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ow5/LxM9UWiyFQAAD6G6ig (envelope-from ); Tue, 17 Jun 2025 10:01:55 +0000 Message-ID: Date: Tue, 17 Jun 2025 12:01:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] frozen pages for large kmalloc To: Christoph Lameter , David Rientjes Cc: Andrew Morton , Roman Gushchin , Harry Yoo , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250602-frozen-pages-for-large-kmalloc-v2-0-84a21f2c3640@suse.cz> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20250602-frozen-pages-for-large-kmalloc-v2-0-84a21f2c3640@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: ADB4840016 X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: n6ibucco6cks59xhpjqksj9wtfxppz9p X-HE-Tag: 1750154517-268303 X-HE-Meta: U2FsdGVkX19zQ9vR9LNEmDiSETJqYQiv7hxmDpSKM9jOFQoiy/YMWjTNG2dSmUE3l2UZVTj4akAzMbDaRbWZRSLRlKFif7A+zDHgjYAI5dXXfKyshzLVis2xYBbAauOBFQwUqWNLaJYr7HV+FvvMgpbHSh4opYSPGSsjo2OPszDLgzJPzFZ2lEQDrwWYxcc59jJDBHzOoAi7Cs5DiQGcYe0UQY8GbPtcsF2U/9AzaxNI2t9jhdDI4G9UQ3of8uJ+xVFL/VDIt5TrBEDxhAeiuYUFfZLk/L5HpW7z42rlEnilKiTm9ZB7YMNoHo4l4ynlU+/qHzRJgoeH+bwB0rz+8YWNPRiU4F56dBpT6nGeqtuhJPt3ezbgLlCy37CE6ckBJi7yRcZ82dBmlDbpfVradFCmRlQG/rFU8Qt0Nt8QiKzz0rP7938MTneg37zUpZ/ig6zdXK89QOG9YqkokxGuSjsbywCEjNfdvmdtxtyrgICqt/xaN0uX+HFauWpmv+sPmvAAu63x39c7WPdBJ/iVchZRf7BYQAG+cjTrXquIOr6seLUmCNq6PoQK4sNYlwYmQnP76zUYaZ0evgneuL6jyYkioOTGqB74aFqdVhUku97B/8GYvfpxd4rTAMguEKrhNrHBGSEvYMnI138LiUW30bnVxmxbEUrD0pbKqRGkxCfPZQNEgLRBhzqwL8QGGjtRe2kwp4WZMiUgl0A2Wn4xa9UI+maK3hoLBHt1kluNAR8cxPOtH99M2UWYIauQ3GXOk2QF/ZMXyREO04DSjFwjz6iJDszH4FX9XsLghOJyFP41Pwl1FlMkalqgTusA0XCjvpY9LzvHb1yvSYbINGwJTp3nMy7yVBASshHfvmu7s/zeHI510sGqOlLeXHZ9zdXSXXbGgRzcrrFu7j488VsKXG1Ylj/DBd7NK903YJxXnDTvpmvGFeKTybvnhvmltB1jHZnbgzl7ZapOb1ItxZR zu4fZOPt F04jiO+yUUsUiujJznvedHUNrF5SdpS1e4iEmsM0/GbZZRbx7qaKk00eeWvvf45CEX5vr1F3p/7thEiB/NgfLpP8MfzNAXRkqTpxRb1gXEjufZiPdboC3ofA/4TXAA6MotJxN7lcM+rba8+4EUBx6iQMnyUEMR907zzAMwPjqVUZtEFrgLUvZjA8tGhTZYCjZhKE04bLkKXAGShSjwn/tvVpY3lq6I2Y8icQoM/475korUrK433xVO+I5zNQnDFkqa+uIwCPtUGkuwICbw1ZidzP/+ZsBxyqMedSRU0AwW9hURFA8eNqVWOz/d4jOPkZ7FQ/WaDPUPsynBI6SwLtDu3w9j1vMWkhHie7GEjVLMkJHkgWwgYw3La1Yft52MAZWWb7sEnlXmhJRGxQ0vEcDF8652LunSBq/3rgv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/2/25 13:02, Vlastimil Babka wrote: > In [1] I have suggested we start warning for get_page() done on large > kmalloc pages as the first step to convert them to frozen pages. > We exposed to -next and indeed got such a warning [2]. But it turns out > the code is using sendpage_ok() and thus would avoid the get_page() if > the page was actually frozen. > > So in this version, freeze the large kmalloc pages at the same time as > adding the warnings and refusals to get_page/put_page() on large kmalloc > pages, the same as we do for slab pages - in patch 2. > > While doing that I've noticed that large kmalloc doesn't observe NUMA > policies, while the rest of the allocator does. This turns out to be a > regression from v6.1, so I'm restoring that first in patch 1. There is > no Cc: stable as it's not fixing a critical bug, but we can submit it to > e.g. latest LTSS afterwards. > > Given the timing I would expose this to -next after the current merge > window closes, thus towards 6.17. It's now in slab/for-next. Went with Cc: stable for the first patch in the end. Thanks for the reviews! > [1] https://lore.kernel.org/all/20250417074102.4543-2-vbabka@suse.cz/ > [2] https://lore.kernel.org/all/202505221248.595a9117-lkp@intel.com/ > > Signed-off-by: Vlastimil Babka > --- > Changes in v2: > - Reword commit log of patch 1 to acknowledge it's restoring pre-6.1 > behavior, add Fixes: > - Change the order of the two patches to allow possible backport of the > NUMA fix. > - Link to v1: https://patch.msgid.link/20250529-frozen-pages-for-large-kmalloc-v1-0-b3aa52a8fa17@suse.cz > > --- > Vlastimil Babka (2): > mm, slab: restore NUMA policy support for large kmalloc > mm, slab: use frozen pages for large kmalloc > > include/linux/mm.h | 4 +++- > mm/slub.c | 9 +++++++-- > 2 files changed, 10 insertions(+), 3 deletions(-) > --- > base-commit: 9c32cda43eb78f78c73aee4aa344b777714e259b > change-id: 20250529-frozen-pages-for-large-kmalloc-bd4d2522e52b > > Best regards,