From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C03DC28B2E for ; Tue, 11 Mar 2025 05:28:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC2F8280003; Tue, 11 Mar 2025 01:28:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A728F280001; Tue, 11 Mar 2025 01:28:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 914DF280003; Tue, 11 Mar 2025 01:28:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7395E280001 for ; Tue, 11 Mar 2025 01:28:08 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7F3445771C for ; Tue, 11 Mar 2025 05:28:08 +0000 (UTC) X-FDA: 83208139056.29.3D3A051 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id BF49C100005 for ; Tue, 11 Mar 2025 05:28:06 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741670886; a=rsa-sha256; cv=none; b=Gk7y/DxCUthgwiWsMqpqjtzwUaPwbea24nhs6Yfcyl6p8G3hfyZ9WckEaxqAJ2oh6Bf5xC nab0wKeKETKHu+fFgNiUJ6P6IZRLF4mYHMIJImONcQ9rh3sIWWGVFE9qfp+3Db1nkVhedq BO5Bu0+b/2jdfU+TAZmxh+HBDVV60Pw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741670886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=idtijonUR82wciv7MpNlhTjrGb8TG+upu8WInWSFPbA=; b=DwaWwxZ4/hMlT54xfSiSRDIHV95EZS/UUb61fTSfY5WhDhqu86uydkAIpp4aCN/WVouWuD J/ldg4qZQgcjiPdLpw1iAv77eFqoesSaQM9f8WmvwLCIsFnHYOdwN6n2+msp0fGOmXO+lv o4wMpZ/J+DuoZmTtHhtwgwZMY8WwK9E= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1734D1516; Mon, 10 Mar 2025 22:28:17 -0700 (PDT) Received: from [10.162.40.19] (a077893.blr.arm.com [10.162.40.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2EA103F694; Mon, 10 Mar 2025 22:28:03 -0700 (PDT) Message-ID: Date: Tue, 11 Mar 2025 10:58:00 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm: use ptep_get() instead of directly dereferencing pte_t* To: Ryan Roberts , Andrew Morton , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250310140418.1737409-1-ryan.roberts@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250310140418.1737409-1-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BF49C100005 X-Rspamd-Server: rspam11 X-Stat-Signature: phsador3izz9zhxojsoqijgq75kfs1ag X-Rspam-User: X-HE-Tag: 1741670886-435647 X-HE-Meta: U2FsdGVkX1+s3AH7udOFpW55Qm9pOo5b/FUXDR1v3BvdEJmouz11CM98/zMSW108GAxuPllA099gld1J5Ojcrvel1XbBOjAE2fZvl7W3tEmuNOrHY/h2KJSYids56wm44Hjmt1+0r4N4jSkhy8u1rDSR3yPxF0Seczvd733WM4Qp5djZGMArKjCo+/QIzAykZ+wClpYHvk/GMki6uScvrJbnyM3PyM/a7VZtiMyFpkcG3bcEZNLXR5zxNcATVk5Xv9zfXUKwU0ZZFF0ufTaWTBzfy/fzS3ZiVZLIcFTT0Jkdil+hbS4gsRhhxLwlfYFEwSLFY8nzHL7iSMSVVg+XrpBOoVSiYy0tgQFdGJRmy5QbEKXKr7n7/gkTDMy26LDLEYLDXgFa86J1rDHtwsVFI/9n41z5FNsGsVy8JzfXW+pypl+ewe9GzGe02i6H/VNwi1H7OhiGll+0PRFAcMOQtUlawNbMx0x7yf8o2dPOZo+FyaEVzkAmH+dm/5uoMCBoljYSY7tJDuLQBt0CzM/ytCfZQXQkId/m31nBgsk3+iNUcwEyiepYErDHTbLBcbLGnlUxQtBfXJ+a2rKmk7fiAqPzKxG9OYCMr3PhLZmS179qX6Z3E3ecY/RpIHIK0qVOWF+fe21n2+UphlS+aklbDoWHmG131TozbhMBD8sJZ8/ZqpUJfMWM1RPlm4r79mABoBxko5tI8fanTEOu++M/eqxsu9SD3VDFiAwV5tKIvvNC80ieTyLyt1HFXpxSnvg6/v1P7qu4pjLaYvAm/5ghnObbxBtwLNtVUp1TYlm3timhl8exFVLFe22pOKsWkr84kPBXkitFvq52UYIuc6ccA/YsoD17EYUJBc6BpQgufIhGABAtWD8QKWw0GCPiELygPNSyq8w/qwuF3q1KWj902LjxhtFj1gQzkbQB1JFxgu1qwo147SwBfDCJ8ItvEM9wEcN5mkoHeM79lJjLkjW MAvNtzyq hhRXaZRVCuv+74E3NHqLHPgrhQqFDD+wHwT/lw325CjkUClvxdnbfDDeYl/n5XCzQ9XjSSXbQ4G/Fr6uwz7b6V0E2aa5ox4Bmxfk8Vn6cdxBmF+17VKuSNlgo04HfPTnvaadK8sEoLcgcjEDaWkqJ/edb6xgzfdQrqypJykiT/7757JiuM+ECbixb2y91LUT2dq+CXv5MbiPjo/49HSczrl0xgvvRyEPQGaUFnj0mgC3JvALax8I0GPmHPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000045, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/10/25 19:34, Ryan Roberts wrote: > It is best practice for all pte accesses to go via the arch helpers, to > ensure non-torn values and to allow the arch to intervene where needed > (contpte for arm64 for example). While in this case it was probably safe > to directly dereference, let's tidy it up for consistency. > > Signed-off-by: Ryan Roberts > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 22e270f727ed..33a22c2d6b20 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -202,7 +202,7 @@ static bool try_to_map_unused_to_zeropage(struct page_vma_mapped_walk *pvmw, > return false; > VM_BUG_ON_PAGE(!PageAnon(page), page); > VM_BUG_ON_PAGE(!PageLocked(page), page); > - VM_BUG_ON_PAGE(pte_present(*pvmw->pte), page); > + VM_BUG_ON_PAGE(pte_present(ptep_get(pvmw->pte)), page); > > if (folio_test_mlocked(folio) || (pvmw->vma->vm_flags & VM_LOCKED) || > mm_forbids_zeropage(pvmw->vma->vm_mm)) > -- > 2.43.0 > > LGTM. Reviewed-by: Anshuman Khandual