From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C64C54E41 for ; Wed, 6 Mar 2024 15:03:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A97D6B0071; Wed, 6 Mar 2024 10:03:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 732346B0072; Wed, 6 Mar 2024 10:03:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AC666B0074; Wed, 6 Mar 2024 10:03:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 43C6A6B0071 for ; Wed, 6 Mar 2024 10:03:54 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C49ED140BCB for ; Wed, 6 Mar 2024 15:03:53 +0000 (UTC) X-FDA: 81866933946.11.A277F94 Received: from mail.cybernetics.com (mail.cybernetics.com [72.215.153.18]) by imf19.hostedemail.com (Postfix) with ESMTP id D7F0E1A0045 for ; Wed, 6 Mar 2024 15:03:46 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cybernetics.com header.s=mail header.b=W8ww5OEB; dmarc=pass (policy=none) header.from=cybernetics.com; spf=pass (imf19.hostedemail.com: domain of "btv1==795ae83820b==tonyb@cybernetics.com" designates 72.215.153.18 as permitted sender) smtp.mailfrom="btv1==795ae83820b==tonyb@cybernetics.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709737427; a=rsa-sha256; cv=none; b=7eiWtnrVhX3to9m08Rw2hIz7YhRCKhFGrtD/1pvAJ9VWB7zL2aW5QLkKoVqu0JGl5LjPeC 88mClj283bBjHdwdycohso5sF3kQBReM4ZjYpuRDMLZvwQ5m1xvpTnpDIOAGGlB2JtjGdF KyvzJgyqK3SMxVkTlCqEinj3GeywCEM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=cybernetics.com header.s=mail header.b=W8ww5OEB; dmarc=pass (policy=none) header.from=cybernetics.com; spf=pass (imf19.hostedemail.com: domain of "btv1==795ae83820b==tonyb@cybernetics.com" designates 72.215.153.18 as permitted sender) smtp.mailfrom="btv1==795ae83820b==tonyb@cybernetics.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709737427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7qc4ffRYNtvZccYs4/U0SMXhHZBv427Ly9EChqUIDts=; b=l07qJqClwV5CW/8vv0dEX8HHJfOJZacVQX2i19J/GYtcskH//3TBaWQdUIn/He6itcKhNM svBfEZuSQ8NrWhULkg4qgWdy2QAc/qUCpvkluf4yq8VKIcr+Cf7VMHaKN9MzkfNwrkcQRI viOcLOpZ8RWGYYPmYoptdGcJyvPV++Q= X-ASG-Debug-ID: 1709737400-1cf4391a1c953b0002-v9ZeMO Received: from cybernetics.com ([10.10.4.126]) by mail.cybernetics.com with ESMTP id HUS1vVEvB72oJaDX; Wed, 06 Mar 2024 10:03:42 -0500 (EST) X-Barracuda-Envelope-From: tonyb@cybernetics.com X-Barracuda-RBL-Trusted-Forwarder: 10.10.4.126 X-ASG-Whitelist: Client DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cybernetics.com; s=mail; bh=7qc4ffRYNtvZccYs4/U0SMXhHZBv427Ly9EChqUIDts=; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Content-Language:Subject:MIME-Version:Date:Message-ID; b=W8ww5OEBmzs8NaHgEkoZ 7JNFDiLMMztKUdLXIcL/jSdNGT9JhIKQmG9mbb3+85HA/frx4z5JdSgfNArLSPFbzOKkZ/LjXeiYo AMvEQeTqhnjGUnnl8aH1Jvb+Z+9Mj3gGIEnba//g5rLTdMt6+P2hhKTNxk+GA6yzXWGhhxf/Gk= Received: from [10.157.2.224] (HELO [192.168.200.1]) by cybernetics.com (CommuniGate Pro SMTP 7.1.1) with ESMTPS id 13115879; Wed, 06 Mar 2024 10:03:26 -0500 Message-ID: X-Barracuda-RBL-Trusted-Forwarder: 10.157.2.224 Date: Wed, 6 Mar 2024 10:03:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] block: Fix page refcounts for unaligned buffers in __bio_release_pages() Content-Language: en-US X-ASG-Orig-Subj: Re: [PATCH] block: Fix page refcounts for unaligned buffers in __bio_release_pages() To: Greg Edwards Cc: Jens Axboe , "Matthew Wilcox (Oracle)" , Andrew Morton , "Kirill A . Shutemov" , Hugh Dickins , Hannes Reinecke , Keith Busch , linux-mm , linux-block@vger.kernel.org, linux-fsdevel , "linux-kernel@vger.kernel.org" References: <86e592a9-98d4-4cff-a646-0c0084328356@cybernetics.com> <20240229225630.GA460680@bobdog.home.arpa> From: Tony Battersby In-Reply-To: <20240229225630.GA460680@bobdog.home.arpa> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: UNKNOWN[10.10.4.126] X-Barracuda-Start-Time: 1709737422 X-Barracuda-URL: https://10.10.4.122:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cybernetics.com X-Barracuda-Scan-Msg-Size: 785 X-Barracuda-BRTS-Status: 1 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D7F0E1A0045 X-Stat-Signature: huoidtsm9pjcfeyhqma6n1x1t3w1dw6o X-HE-Tag: 1709737426-845345 X-HE-Meta: U2FsdGVkX18K4SA2u3cIFM+5x0Ufih4R1ckW6gdGqYQJ4xKF6JmAFB5AESdGCJOKfvQrRmUfyLNtXXzcAqZt+1NPf5vwmoHaFm2ljppYi3XlF1KV+jDx4Y4PZcaHwr7bG/jytsPTJuOOBy1elcA/z8fXV3mMv25bKa/Flqeo1MxdUoHX8lCsvVYcGO82zsdlYr96EinAqkh1iAIk+M5uhQZ5Pw0OZtwka/hFa6EI30ZaKZZoqfP/ZigAD6LrvZjWsWNAS6Rk3le0czwqnLAIHASsvUtLsH9yAxSQ+z18RLwTBX9B0SDGD3WoHtrZcjO6mtlwqtnOe8Ed1RAIDKFt/UHvTgZ9ZyKj9LySPLpdhljAGm9I8aHeHACBh0iIMMrDrEx0tRqPr4IMh6Fpt6G8gzJG3Pnse7SGxc83WwDuEJlg9opUpudOdBkOyas3rswXM5TWuNWQgnErMq7H8sJUyOYcEQM5xcuMeGDUQBW15ZLm6JO71BJNH5LinnrxSnCiBR/hj/9oENSswIPwCY50u78la0zBxZZcgTdjiAxWXqW4fH9tfXv8Q3ilVEDpoXiR0GoD2w3LnFm753H7p8XnMv3GKWGBuIRgHGw8PSRSi7DMORpc5ZGZOllDCg+RHWh3Dw5OZtOrIx/xiOk+6iO0iHwvNYjQZxZKyy7kvmheCTFPhyO85gyoY4UIEP16bCj7hAQ/j8U+EITSgdASSEYwQtcu1+1aESB9ZbkQLudzoak7hr1q0nqOz0ERoQeKk+UAbjpyaGzbN7raQ1nijmoEqTWxCX+jEvAbfKoEz1llH4XF8eD3wk98cz7z7eE/X0aXkbJU3Sg4n46vpNCZoMcbuwBgYmH1w/ntPEZsO1HccUsvc/UgixgvF+pRO0xvsg5HUmUg7rFNaWF0GL1oYeA8vpj5zf+GDAqvOtN3oZWiP9ff8EtjG/NFAuotTaYD+uJrDXneJWA4Qg3n3dPJhyi Ws9m8Rsc eeJ2geF6VtUSb/sSKxEwtrS8P4a1oz7bvLEZnTmHZu7fUj/kvYRoEHiU1+RFTanFTujmM3AUVNpsRAEvI6eNQAfZ0vE1fSTYVSwIYlZLqhtnzVJwYYdTR/NAkgvYV6kRfEauW2hZugaTKlFUQ+vkuP1UUL7+rI9uoFRo5UoVdPjiWB2ac8+8TfXy/ASXIByXTy10Yl+yUlDs1HVhvcNr64oy+OWOZ7SZgVivrwBuzWDcrIhm/lZcc6gllq8I7lhzom5N0E88BZeBV89+ncGg6z963+/3AuC3seciHoAEwpd5MVkFRChhg5XKGwvzIYkpAVu764TG6Dmwug7jqRob96DlIl9yiJRCeifgLRlxAlJPY+c+7mP/5jAwtd6nHHxbIVagRfjXeyizx6+zUFQIGH7j8In5gu1CMRHvLPXE9zCvOT5C3qi7MkA4syWswQIGSJs9t8/aQcy7u1PJT+2rUvaMAukhArTpvF0LIe+cVmpZlg8tdeevELfj/E29PwwEyCfLcsB6VCGYUZIDqQuaOUjIpzV/l4VV5AylCgDmssImzdCVOdkaCnKx9M9jpEDK8iMjgCnEcQuuVq2lr7j+f8Tp7DQp4bWaAYm7D3PFSMykVa8Ur84mV7SGfdgPCxBgsgEKYAY61LqPM3Y/mpgTTVmiEiikCJFFqCYPuefkSJYAL2YU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/29/24 17:56, Greg Edwards wrote: > On Thu, Feb 29, 2024 at 01:08:09PM -0500, Tony Battersby wrote: >> Fix an incorrect number of pages being released for buffers that do not >> start at the beginning of a page. >> >> Fixes: 1b151e2435fc ("block: Remove special-casing of compound pages") >> Cc: stable@vger.kernel.org >> Signed-off-by: Tony Battersby >> --- > This resolves the QEMU hugetlb issue I noted earlier today here [1]. > I tested it on 6.1.79, 6.8-rc6 and linux-next-20240229. Thank you! > > Feel free to add a: > > Tested-by: Greg Edwards > > [1] https://lore.kernel.org/linux-block/20240229182513.GA17355@bobdog.home.arpa/ Jens, can I get this added to 6.8 (or 6.9 if it is too late)? Thanks, Tony