From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14CC4C021AA for ; Fri, 21 Feb 2025 07:21:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AEF26B00A3; Fri, 21 Feb 2025 02:21:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 45C096B00A4; Fri, 21 Feb 2025 02:21:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D5D36B00A7; Fri, 21 Feb 2025 02:21:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0F29F6B00A3 for ; Fri, 21 Feb 2025 02:21:10 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AFE50A140F for ; Fri, 21 Feb 2025 07:21:09 +0000 (UTC) X-FDA: 83143105458.03.199B8C6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 537D2C0007 for ; Fri, 21 Feb 2025 07:21:07 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=13ISwTLh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MbEQV4vq; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=13ISwTLh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MbEQV4vq; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740122467; a=rsa-sha256; cv=none; b=JuDF+bzvjqdTYhkNzg2Mb2woz/NONWlfKvTOw4ZobjQ2EfKEZfzv+oNPR1N85viu7hQspd z+GEK0RWMzEa7Co4QlOw/p3ePxu5YrxGnu07PRXfL64dPs9JikHpxyp5tKZibSH4hVpyWq yoRMhH2OQR6zYANeNJHGNT3ZbmF73MI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=13ISwTLh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MbEQV4vq; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=13ISwTLh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=MbEQV4vq; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740122467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DkakeWbsGukiMnW97oQAx8ayHild3NPAZ1YdIM1LqhI=; b=XXy0nmetdm6WAR0neiJzofl5+EEMS5Ss0VptD/E2DwxC2W5//FUMCN5W9qWPoROfuYl2D7 S1zGqgBL7QrXl8OYxJaYrXgOzGMiu4XEsGh73J/DJeJPI7HGYBhtDCFIrZ1wlTLBhzbzVr ZkkZ1/3uUCvADEQAYu9HMdntxjEhEoA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3799F2118A; Fri, 21 Feb 2025 07:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740122465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DkakeWbsGukiMnW97oQAx8ayHild3NPAZ1YdIM1LqhI=; b=13ISwTLhiHn1g6JSg3URuSubUvJVryUgahfKfZE0yduGwcttNn1ND2BHPvTogl5OH0RZux pmNCQ2yMoG3OgEDnZWo7NeqREhlP+/DOoMNW6L5YivITv9L5WhJMKXTGUFuMr10mKDHRew 4ldtL6b+I5g0bm6dNXfCrnQAv6GHnEc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740122465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DkakeWbsGukiMnW97oQAx8ayHild3NPAZ1YdIM1LqhI=; b=MbEQV4vqaZlbp7pe95VfxXYVCp+EYDttZ2cCcwwGPz/3UGTkWhioe8BG0GSvRgz0TDKG7r PiUT7nhuprGhdUDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740122465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DkakeWbsGukiMnW97oQAx8ayHild3NPAZ1YdIM1LqhI=; b=13ISwTLhiHn1g6JSg3URuSubUvJVryUgahfKfZE0yduGwcttNn1ND2BHPvTogl5OH0RZux pmNCQ2yMoG3OgEDnZWo7NeqREhlP+/DOoMNW6L5YivITv9L5WhJMKXTGUFuMr10mKDHRew 4ldtL6b+I5g0bm6dNXfCrnQAv6GHnEc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740122465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DkakeWbsGukiMnW97oQAx8ayHild3NPAZ1YdIM1LqhI=; b=MbEQV4vqaZlbp7pe95VfxXYVCp+EYDttZ2cCcwwGPz/3UGTkWhioe8BG0GSvRgz0TDKG7r PiUT7nhuprGhdUDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1838713888; Fri, 21 Feb 2025 07:21:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BJwVA2EpuGf0egAAD6G6ig (envelope-from ); Fri, 21 Feb 2025 07:21:05 +0000 Message-ID: Date: Fri, 21 Feb 2025 08:21:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bcachefs: Use alloc_percpu_gfp to avoid deadlock To: Dennis Zhou , Kent Overstreet Cc: Alan Huang , linux-bcachefs@vger.kernel.org, syzbot+fe63f377148a6371a9db@syzkaller.appspotmail.com, linux-mm@kvack.org, Tejun Heo , Christoph Lameter , Michal Hocko References: <20250212100625.55860-1-mmpgouride@gmail.com> <25FBAAE5-8BC6-41F3-9A6D-65911BA5A5D7@gmail.com> <78d954b5-e33f-4bbc-855b-e91e96278bef@suse.cz> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: 537D2C0007 X-Rspamd-Server: rspam12 X-Stat-Signature: qhhorcfzjjzxe1yitwikm9o5exsa8he5 X-HE-Tag: 1740122467-598453 X-HE-Meta: U2FsdGVkX19eXj4n5agMgxnVilImC8luNwpnPtZ3qWJDbw4C0Ig1zKIQI25c608DOvldnoddw6I5O81ykXSqhjYesspKl83w0uQCeKU7Q4VHYGS9Pf3h50Kn4zN+pBtxImnDGn2wetWrx28K/JN9s4EjKkkQ2V0zOBy29TKC3uwdNzMsgvfDh/ABMTz0c2c8zInzYHnOlO6kp9MHGsZ0icgHgOqCXdcluwKJUeiTAuXFCARhNGJuE66B5TV42gYm/8/D1kBalr6A7ipWbPvzETeQ8QuMxfrf6aUi6Nxt8PD0Fwyenm1Wl5z9Z2UuE8PbZ+BLuoOd/qn/Yc8U2hAgBrzuMCSM5FR4mzcfo4dg5apPKna1RnHVuY+3BZMMgQsSdhtvt2qRREi7j9elwFFQmwQoP/mQNmxnVO8ht/UXuF5EvksuM6ekuTRJmHgOL2W5rt1/OT/0IiSLa1OTWR+WqVvbewDiy6fXotuqxklaFeVMNgUuo93WJtwlOrJEZapKkUy5Yc0QNA9ckmFbYrO7/Ee441amvfebQzWBZx0XrjwP74YnbEN/k9yHBT6jBTiborOmFs7MM6LD8bG+peeMGuppSvAt+fF2NErHma0NLpdKsHdost/KRhqruyies5QyfzIe/xAvHGcTe8SF5TuJKKRMmj6Bvm0Gw1ufk7IZqkN6xO13IlqejvIaRRL+9tQnAWTiXeMvKDUTLykEJ3Mw2edgqhybEOnGNfD5KUsEaInn91EIoJmHQ8ag9dcQ+GrCYT77WHHwJrgstv7ZQ4GYzSdC9iQvwKdtMFWLKvNM3hHeUOkq7SkvH7rs+31syy4HJ+gzvYk5W7nvkrqWfKg8iDQyvqqynIH9vUmi+b4XR0eGOQSL0bRN1MBqbwpdow0a6uwTwDDK9bY/yc1THNNmMsjGo5U5aHv6ontftgCuudlHGad/7xslRKBPNddtWQ+mAdneg97zsj40WcSGXJ5 Qt3BqdJC vqfuKFbSQbjgN/GyajRExMlIcJrh+3FXlm3RCrCPM1YeuU78VkKer63bV7eVVHRttObzq+szul1VBuDxEK7cxMjSXb+0pNqfdnU+qxp8VjlpDXIbmBsSsolhSGMsxL0RvX1554SQLiO3dKklmavNZIeCXU5mjyduF7IB1xt4HASKPGTw0ReCCMr37tlaXp5XdTjjl+DhBUn5vqUflAC/YmGj3yewnnZB2bclHhRGxprHYjG1+9VP6CWWw0RPj2LFu5ocTfoZGTyHI/GTbB0WTCngGfB9pSXryOGbvHOnmddJC3Mv4OcUBF9s3helsegRgjDKd+vh3XhMwOMV41fi+dflyjunO/YW4UNBS9q3wkoGajS3ERshVGRwx3vewbKCBd3+b5l74E4J9rsXTmTI3G/I2NLnrDKcvzThleyTHm3wSU0R236Umd/PQntuaRllQs49+EC43IvlAwVi5kunUlMqeBJkeWi9xs3rl8JO3v/smaI11fMEuYsO0YMqy7dItDEsZUfDdKF1utqXuJ/q4JfgnEUheXpsfc2Ux X-Bogosity: Ham, tests=bogofilter, spamicity=0.000561, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/21/25 03:46, Dennis Zhou wrote: > Hello, > > On Thu, Feb 20, 2025 at 03:37:26PM -0500, Kent Overstreet wrote: >> On Thu, Feb 20, 2025 at 06:16:43PM +0100, Vlastimil Babka wrote: >> > On 2/20/25 11:57, Alan Huang wrote: >> > > Ping >> > > >> > >> On Feb 12, 2025, at 22:27, Kent Overstreet wrote: >> > >> >> > >> Adding pcpu people to the CC >> > >> >> > >> On Wed, Feb 12, 2025 at 06:06:25PM +0800, Alan Huang wrote: >> > >>> The cycle: >> > >>> >> > >>> CPU0: CPU1: >> > >>> bc->lock pcpu_alloc_mutex >> > >>> pcpu_alloc_mutex bc->lock >> > >>> >> > >>> Reported-by: syzbot+fe63f377148a6371a9db@syzkaller.appspotmail.com >> > >>> Tested-by: syzbot+fe63f377148a6371a9db@syzkaller.appspotmail.com >> > >>> Signed-off-by: Alan Huang >> > >> >> > >> So pcpu_alloc_mutex -> fs_reclaim? >> > >> >> > >> That's really awkward; seems like something that might invite more >> > >> issues. We can apply your fix if we need to, but I want to hear with the >> > >> percpu people have to say first. >> > >> >> > >> ====================================================== >> > >> WARNING: possible circular locking dependency detected >> > >> 6.14.0-rc2-syzkaller-00039-g09fbf3d50205 #0 Not tainted >> > >> ------------------------------------------------------ >> > >> syz.0.21/5625 is trying to acquire lock: >> > >> ffffffff8ea19608 (pcpu_alloc_mutex){+.+.}-{4:4}, at: pcpu_alloc_noprof+0x293/0x1760 mm/percpu.c:1782 >> > >> >> > >> but task is already holding lock: >> > >> ffff888051401c68 (&bc->lock){+.+.}-{4:4}, at: bch2_btree_node_mem_alloc+0x559/0x16f0 fs/bcachefs/btree_cache.c:804 >> > >> >> > >> which lock already depends on the new lock. >> > >> >> > >> >> > >> the existing dependency chain (in reverse order) is: >> > >> >> > >> -> #2 (&bc->lock){+.+.}-{4:4}: >> > >> lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 >> > >> __mutex_lock_common kernel/locking/mutex.c:585 [inline] >> > >> __mutex_lock+0x19c/0x1010 kernel/locking/mutex.c:730 >> > >> bch2_btree_cache_scan+0x184/0xec0 fs/bcachefs/btree_cache.c:482 >> > >> do_shrink_slab+0x72d/0x1160 mm/shrinker.c:437 >> > >> shrink_slab+0x1093/0x14d0 mm/shrinker.c:664 >> > >> shrink_one+0x43b/0x850 mm/vmscan.c:4868 >> > >> shrink_many mm/vmscan.c:4929 [inline] >> > >> lru_gen_shrink_node mm/vmscan.c:5007 [inline] >> > >> shrink_node+0x37c5/0x3e50 mm/vmscan.c:5978 >> > >> kswapd_shrink_node mm/vmscan.c:6807 [inline] >> > >> balance_pgdat mm/vmscan.c:6999 [inline] >> > >> kswapd+0x20f3/0x3b10 mm/vmscan.c:7264 >> > >> kthread+0x7a9/0x920 kernel/kthread.c:464 >> > >> ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:148 >> > >> ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 >> > >> >> > >> -> #1 (fs_reclaim){+.+.}-{0:0}: >> > >> lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 >> > >> __fs_reclaim_acquire mm/page_alloc.c:3853 [inline] >> > >> fs_reclaim_acquire+0x88/0x130 mm/page_alloc.c:3867 >> > >> might_alloc include/linux/sched/mm.h:318 [inline] >> > >> slab_pre_alloc_hook mm/slub.c:4066 [inline] >> > >> slab_alloc_node mm/slub.c:4144 [inline] >> > >> __do_kmalloc_node mm/slub.c:4293 [inline] >> > >> __kmalloc_noprof+0xae/0x4c0 mm/slub.c:4306 >> > >> kmalloc_noprof include/linux/slab.h:905 [inline] >> > >> kzalloc_noprof include/linux/slab.h:1037 [inline] >> > >> pcpu_mem_zalloc mm/percpu.c:510 [inline] >> > >> pcpu_alloc_chunk mm/percpu.c:1430 [inline] >> > >> pcpu_create_chunk+0x57/0xbc0 mm/percpu-vm.c:338 >> > >> pcpu_balance_populated mm/percpu.c:2063 [inline] >> > >> pcpu_balance_workfn+0xc4d/0xd40 mm/percpu.c:2200 >> > >> process_one_work kernel/workqueue.c:3236 [inline] >> > >> process_scheduled_works+0xa66/0x1840 kernel/workqueue.c:3317 >> > >> worker_thread+0x870/0xd30 kernel/workqueue.c:3398 >> > >> kthread+0x7a9/0x920 kernel/kthread.c:464 >> > >> ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:148 >> > >> ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 >> > >> > Seeing this as part of the chain (fs reclaim from a worker doing >> > pcpu_balance_workfn) makes me think Michal's patch could be a fix to this: >> > >> > https://lore.kernel.org/all/20250206122633.167896-1-mhocko@kernel.org/ >> >> Thanks for the link - that does look like just the thing. > > Sorry I missed the first email asking to weigh in. > > Michal's problem is a little bit different than what's happening here. Yes, but it's related enough. He mentions commit 28307d938fb2 and there you find a similar kind of lockdep splat. > He's having an issue where a alloc_percpu_gfp(NOFS/NOIO) is considered > atomic and failing during probing. This is because we don't have enough > percpu memory backed to fulfill the "atomic" requests. That, and we don't allow NOFS/NOIO to take the pcpu_alloc_mutex to avoid deadlock with pcpu_balance_workfn taking it and then doing __GFP_FS reclaim. > Historically we've considered any allocation that's not GFP_KERNEL to be > atomic. Here it seems like the alloc_percpu() behind the bc->lock() > should have been an "atomic" allocation to prevent the lock cycle? That's what the original mail/patch in this thread suggested: https://lore.kernel.org/all/20250212100625.55860-1-mmpgouride@gmail.com/ Note it proposes GFP_NOWAIT, possibly GFP_NOFS would be enough, but then the current implementation could would make it "atomic" anyway. But then it could end up failing like the allocations that motivated Michal's patch? So with Michal's approach we can avoid having to weaken pcpu_alloc() callers like this. Yes it's counter-intuitive that we weaken a kworker context instead, which normally has no restrictions. But it's not weakened (NOIO) nearly as much as pcpu_alloc() users that are effectively atomic when they can't take pcpu_alloc mutex at all. > Thanks, > Dennis >