From: Alistair Popple <apopple@nvidia.com>
To: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org
Cc: "Alistair Popple" <apopple@nvidia.com>,
lina@asahilina.net, zhang.lyra@gmail.com,
gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com,
jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com,
will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com,
dave.hansen@linux.intel.com, ira.weiny@intel.com,
willy@infradead.org, djwong@kernel.org, tytso@mit.edu,
linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev,
linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com,
"Björn Töpel" <bjorn@rivosinc.com>
Subject: [PATCH v5 25/25] Revert "riscv: mm: Add support for ZONE_DEVICE"
Date: Tue, 7 Jan 2025 14:42:41 +1100 [thread overview]
Message-ID: <dd557b20d49a08f6172e6cff76753850300fda57.1736221254.git-series.apopple@nvidia.com> (raw)
In-Reply-To: <cover.425da7c4e76c2749d0ad1734f972b06114e02d52.1736221254.git-series.apopple@nvidia.com>
DEVMAP PTEs are no longer required to support ZONE_DEVICE so remove
them.
Signed-off-by: Alistair Popple <apopple@nvidia.com>
Suggested-by: Chunyan Zhang <zhang.lyra@gmail.com>
Reviewed-by: Björn Töpel <bjorn@rivosinc.com>
---
arch/riscv/Kconfig | 1 -
arch/riscv/include/asm/pgtable-64.h | 20 --------------------
arch/riscv/include/asm/pgtable-bits.h | 1 -
arch/riscv/include/asm/pgtable.h | 17 -----------------
4 files changed, 39 deletions(-)
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index 7d57186..c285250 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -43,7 +43,6 @@ config RISCV
select ARCH_HAS_PMEM_API
select ARCH_HAS_PREEMPT_LAZY
select ARCH_HAS_PREPARE_SYNC_CORE_CMD
- select ARCH_HAS_PTE_DEVMAP if 64BIT && MMU
select ARCH_HAS_PTE_SPECIAL
select ARCH_HAS_SET_DIRECT_MAP if MMU
select ARCH_HAS_SET_MEMORY if MMU
diff --git a/arch/riscv/include/asm/pgtable-64.h b/arch/riscv/include/asm/pgtable-64.h
index 0897dd9..8c36a88 100644
--- a/arch/riscv/include/asm/pgtable-64.h
+++ b/arch/riscv/include/asm/pgtable-64.h
@@ -398,24 +398,4 @@ static inline struct page *pgd_page(pgd_t pgd)
#define p4d_offset p4d_offset
p4d_t *p4d_offset(pgd_t *pgd, unsigned long address);
-#ifdef CONFIG_TRANSPARENT_HUGEPAGE
-static inline int pte_devmap(pte_t pte);
-static inline pte_t pmd_pte(pmd_t pmd);
-
-static inline int pmd_devmap(pmd_t pmd)
-{
- return pte_devmap(pmd_pte(pmd));
-}
-
-static inline int pud_devmap(pud_t pud)
-{
- return 0;
-}
-
-static inline int pgd_devmap(pgd_t pgd)
-{
- return 0;
-}
-#endif
-
#endif /* _ASM_RISCV_PGTABLE_64_H */
diff --git a/arch/riscv/include/asm/pgtable-bits.h b/arch/riscv/include/asm/pgtable-bits.h
index a8f5205..179bd4a 100644
--- a/arch/riscv/include/asm/pgtable-bits.h
+++ b/arch/riscv/include/asm/pgtable-bits.h
@@ -19,7 +19,6 @@
#define _PAGE_SOFT (3 << 8) /* Reserved for software */
#define _PAGE_SPECIAL (1 << 8) /* RSW: 0x1 */
-#define _PAGE_DEVMAP (1 << 9) /* RSW, devmap */
#define _PAGE_TABLE _PAGE_PRESENT
/*
diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
index d4e99ee..9fa9d13 100644
--- a/arch/riscv/include/asm/pgtable.h
+++ b/arch/riscv/include/asm/pgtable.h
@@ -399,13 +399,6 @@ static inline int pte_special(pte_t pte)
return pte_val(pte) & _PAGE_SPECIAL;
}
-#ifdef CONFIG_ARCH_HAS_PTE_DEVMAP
-static inline int pte_devmap(pte_t pte)
-{
- return pte_val(pte) & _PAGE_DEVMAP;
-}
-#endif
-
/* static inline pte_t pte_rdprotect(pte_t pte) */
static inline pte_t pte_wrprotect(pte_t pte)
@@ -447,11 +440,6 @@ static inline pte_t pte_mkspecial(pte_t pte)
return __pte(pte_val(pte) | _PAGE_SPECIAL);
}
-static inline pte_t pte_mkdevmap(pte_t pte)
-{
- return __pte(pte_val(pte) | _PAGE_DEVMAP);
-}
-
static inline pte_t pte_mkhuge(pte_t pte)
{
return pte;
@@ -763,11 +751,6 @@ static inline pmd_t pmd_mkdirty(pmd_t pmd)
return pte_pmd(pte_mkdirty(pmd_pte(pmd)));
}
-static inline pmd_t pmd_mkdevmap(pmd_t pmd)
-{
- return pte_pmd(pte_mkdevmap(pmd_pte(pmd)));
-}
-
static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr,
pmd_t *pmdp, pmd_t pmd)
{
--
git-series 0.9.1
next prev parent reply other threads:[~2025-01-07 3:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 3:42 [PATCH v5 00/25] fs/dax: Fix ZONE_DEVICE page reference counts Alistair Popple
2025-01-07 3:42 ` [PATCH v5 01/25] fuse: Fix dax truncate/punch_hole fault path Alistair Popple
2025-01-08 22:30 ` Dan Williams
2025-01-09 4:38 ` Alistair Popple
2025-01-07 3:42 ` [PATCH v5 02/25] fs/dax: Return unmapped busy pages from dax_layout_busy_page_range() Alistair Popple
2025-01-08 22:30 ` Dan Williams
2025-01-07 3:42 ` [PATCH v5 03/25] fs/dax: Don't skip locked entries when scanning entries Alistair Popple
2025-01-08 22:50 ` Dan Williams
2025-01-09 5:21 ` Alistair Popple
2025-01-07 3:42 ` [PATCH v5 04/25] fs/dax: Refactor wait for dax idle page Alistair Popple
2025-01-07 3:42 ` [PATCH v5 05/25] fs/dax: Create a common implementation to break DAX layouts Alistair Popple
2025-01-09 0:14 ` Dan Williams
2025-01-09 6:15 ` Alistair Popple
2025-01-10 6:56 ` Dan Williams
2025-01-07 3:42 ` [PATCH v5 06/25] fs/dax: Always remove DAX page-cache entries when breaking layouts Alistair Popple
2025-01-07 3:42 ` [PATCH v5 07/25] fs/dax: Ensure all pages are idle prior to filesystem unmount Alistair Popple
2025-01-07 3:42 ` [PATCH v5 08/25] fs/dax: Remove PAGE_MAPPING_DAX_SHARED mapping flag Alistair Popple
2025-01-07 3:42 ` [PATCH v5 09/25] mm/gup: Remove redundant check for PCI P2PDMA page Alistair Popple
2025-01-07 3:42 ` [PATCH v5 10/25] mm/mm_init: Move p2pdma page refcount initialisation to p2pdma Alistair Popple
2025-01-07 3:42 ` [PATCH v5 11/25] mm: Allow compound zone device pages Alistair Popple
2025-01-07 3:42 ` [PATCH v5 12/25] mm/memory: Enhance insert_page_into_pte_locked() to create writable mappings Alistair Popple
2025-01-07 3:42 ` [PATCH v5 13/25] mm/memory: Add vmf_insert_page_mkwrite() Alistair Popple
2025-01-07 3:42 ` [PATCH v5 14/25] rmap: Add support for PUD sized mappings to rmap Alistair Popple
2025-01-07 11:36 ` David Hildenbrand
2025-01-07 3:42 ` [PATCH v5 15/25] huge_memory: Add vmf_insert_folio_pud() Alistair Popple
2025-01-08 3:54 ` kernel test robot
2025-01-07 3:42 ` [PATCH v5 16/25] huge_memory: Add vmf_insert_folio_pmd() Alistair Popple
2025-01-07 3:42 ` [PATCH v5 17/25] memremap: Add is_devdax_page() and is_fsdax_page() helpers Alistair Popple
2025-01-07 3:42 ` [PATCH v5 18/25] mm/gup: Don't allow FOLL_LONGTERM pinning of FS DAX pages Alistair Popple
2025-01-07 3:42 ` [PATCH v5 19/25] proc/task_mmu: Mark devdax and fsdax pages as always unpinned Alistair Popple
2025-01-07 3:42 ` [PATCH v5 20/25] mm/mlock: Skip ZONE_DEVICE PMDs during mlock Alistair Popple
2025-01-07 3:42 ` [PATCH v5 21/25] fs/dax: Properly refcount fs dax pages Alistair Popple
2025-01-07 3:42 ` [PATCH v5 22/25] device/dax: Properly refcount device dax pages when mapping Alistair Popple
2025-01-07 3:42 ` [PATCH v5 23/25] mm: Remove pXX_devmap callers Alistair Popple
2025-01-07 3:42 ` [PATCH v5 24/25] mm: Remove devmap related functions and page table bits Alistair Popple
2025-01-07 3:42 ` Alistair Popple [this message]
2025-01-08 6:26 ` [PATCH v5 00/25] fs/dax: Fix ZONE_DEVICE page reference counts Andrew Morton
2025-01-08 21:51 ` Dan Williams
2025-01-09 1:34 ` Alison Schofield
2025-01-10 6:03 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd557b20d49a08f6172e6cff76753850300fda57.1736221254.git-series.apopple@nvidia.com \
--to=apopple@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=bjorn@rivosinc.com \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=djwong@kernel.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=lina@asahilina.net \
--cc=linmiaohe@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=logang@deltatee.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=peterx@redhat.com \
--cc=tytso@mit.edu \
--cc=vishal.l.verma@intel.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox