From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43989CE8D5D for ; Thu, 19 Sep 2024 08:11:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2CFA6B0085; Thu, 19 Sep 2024 04:11:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDC7E6B0088; Thu, 19 Sep 2024 04:11:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7D026B0089; Thu, 19 Sep 2024 04:11:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8A87C6B0085 for ; Thu, 19 Sep 2024 04:11:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 11ED2AAF8D for ; Thu, 19 Sep 2024 08:11:44 +0000 (UTC) X-FDA: 82580768928.21.5B795C5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id C410D40009 for ; Thu, 19 Sep 2024 08:11:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="XMRG/h0G"; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726733469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KaHWviSwStlUAVwLVJYKy9f7cLTGqkmyt8OLVarqxlY=; b=MledlUrgGUojaNhtvvVb3wArdg6oDaiicwJatKUJ+IsbbIWmQoRPjrNQjk3HUrzQX95u6q 8V5VW2so87uV+by0VS2E6xG8wOke8ues/70XVpMQ9AIgl1noQ9I0a8ghIWx03thJz7y7u+ QJt+rOjOHJd49UzcMKL6IinPi0Ljzr8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="XMRG/h0G"; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726733469; a=rsa-sha256; cv=none; b=Sf6TFG57YyLGGV2lFfTbbRHz5qlyjLiIF1rQIBlY7rdedvyZCfIsHHD4yu1jWjl5BR0HdH iTas6rx5sBbNtsPh1i2RxebnOHF5MxUvhlbOF+ig6m+XsyLQV25pmoGMOtGvvkjYQtOtpO ezbKsn3zijdRaFiZTve/jJPszfaAmrI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726733501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KaHWviSwStlUAVwLVJYKy9f7cLTGqkmyt8OLVarqxlY=; b=XMRG/h0GEBU53hE+P7058ba5ghVUTFsNnuirXZZOHArPi/eByZnPADIf1FyZqll5ZZH+Rk 1x5RsCauETh5vqQidUexj27HdALUPZy0B0wfo8KvsrTzyx3DmdN47R9ZGN9rl4qDNiw86q pogGdoGx6Jqg2SKQ43SZ/cEC6CwbcQc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-166-z9SjeAvDMKOAtW2piqg8oQ-1; Thu, 19 Sep 2024 04:11:39 -0400 X-MC-Unique: z9SjeAvDMKOAtW2piqg8oQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-379d1bf5b4dso198818f8f.2 for ; Thu, 19 Sep 2024 01:11:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726733498; x=1727338298; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KaHWviSwStlUAVwLVJYKy9f7cLTGqkmyt8OLVarqxlY=; b=xTR0uvSiQCwTgTtVZihtkShxZXatHQgdTiUcoQFTvvFLq9SPoAj0BUzMb+/hXk0ZoZ NCG8k1mY7JrotAFxzkXqL2FxAx/1TFamn71QTsvToxBc+4LREz193f1ZeZa6utQqKrWD UuWemSlv4ITkxs43MjRAyDfI1JmE2ukzFm5baRwbOHnwLi0PqbpfCmyL5AOwldYDyopn oRnlAnla05j5gT+ZO4W2xdLZfzpAV3oiOfynD0NQye0PJGXO3s9+L5MdUqbzFdwCqrtv IQOBbQOEGOdYO44nWQTSn5OxjMhixfnq0I1ZCmu9vgUzgbNMV+goRiRFZvuVfzyQxb+m 4ZVQ== X-Forwarded-Encrypted: i=1; AJvYcCV2LxO3TsdVoFzwugqf9gri0vgeZZOb3aWAGQkr3DSqB6wy21CFvOt8rFby1r5tAwslxXzsW9edJA==@kvack.org X-Gm-Message-State: AOJu0YyPgRn9/N6dVBE+/mUc7LjTZdYo3Q0GCyjpgTtG3Bod2jos/gaU yTUQogfofcH3E7QkfaTn4KNAM1LR4frySGntATi1wdXWhsuMXuN9E155aP0cI2vaRYh1az231Sn bz/sPY+hReV1sNqfOvYEov7fvTk7do1THUtK5Vt+zzfcrMio3H3OLVrRLyqc= X-Received: by 2002:adf:9bd2:0:b0:368:3b1f:fe40 with SMTP id ffacd0b85a97d-378d61e2b03mr10065684f8f.20.1726733498551; Thu, 19 Sep 2024 01:11:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKQ/jttSe1KlWSJPcJZtuxWozWYScVH6g7ZKlUKTNHr5tymvuRzhhkDw/ToHydCuJDCaUPnA== X-Received: by 2002:adf:9bd2:0:b0:368:3b1f:fe40 with SMTP id ffacd0b85a97d-378d61e2b03mr10065667f8f.20.1726733498029; Thu, 19 Sep 2024 01:11:38 -0700 (PDT) Received: from [10.131.4.59] ([83.68.141.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e7800138sm14354908f8f.68.2024.09.19.01.11.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Sep 2024 01:11:37 -0700 (PDT) Message-ID: Date: Thu, 19 Sep 2024 10:11:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 1/9] mm/gup: repin_folio_unhugely To: Steven Sistare , linux-mm@kvack.org Cc: Jason Gunthorpe , Kevin Tian , Nicolin Chen , iommu@lists.linux.dev, Andrew Morton , Matthew Wilcox References: <1726319158-283074-1-git-send-email-steven.sistare@oracle.com> <1726319158-283074-2-git-send-email-steven.sistare@oracle.com> <6aea6530-9f9c-4a9c-9c9c-2c29e8ae9e9d@redhat.com> <98004c8e-f941-480e-b1be-8f6fd925871a@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <98004c8e-f941-480e-b1be-8f6fd925871a@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 54pa3b4jw5t51a49xwxt7ub34qjwrks3 X-Rspamd-Queue-Id: C410D40009 X-Rspamd-Server: rspam11 X-HE-Tag: 1726733501-410354 X-HE-Meta: U2FsdGVkX1/12fEFx4ZiZJmWODtQLMeCKN5R1mCSr5Sc8DSPy/3yN96VhMznTHdFIoWZt8NLnJAvKimjCQldDO2fbvfeXL67XIGdNZJAJZoDUmht56VBiWM5QIqHNVJ7EyqgOehoBPMi0a6RsqawY5ZHHdMZdWLXpgYMn0wnAJ/sqtEpVjXeHKBZNpdJnolTvDYP2ReVirDE/IRMnwrs7yUEgGMZcBti3bmYmC3E14tp/DQqzgTfBgTj7I2ua9arsyRk+k7/rg9Zyu1qqwAJTwIlHvVnYc+A2yUnZKv2yMAJiOUMyWRM1a3WXFc4WYGqUDJeE96Z7FFWnWIgP5H8JlnkLbK3FzgymK5UeuyfiRuLIGafzjbFckjbHQT2u+5/dz5Yo3trTiYk8EB75W7LNbMaDhP5ezRW4Ym1bi9WfE38bvUbtRMCbfGsOUOkwG5WyIDkADUpItaR/vIpGfEAZFPDiY7n+ibA+WjDu7EFlod8E66bF2UXwweyxsEuO2U7pdPAr9Gkkg0+lrstjkx5d62yb+HvgB1vl/ay0eIszlqlkbghbuKXroveYB0OcVqL8cmcUymqDn/IQs2kfvfWdPD1dikpJ5k+FktrSZXc8jdROLVyR1YiF1xpCryE9dx4nK12xlvn+p+9KvBnmWmiSjPlH7x5p4V41NHKw1GD+6uTA2J7lvXYHeGlM1O68wp8k21AqHbPONltMiio5WfA9wC4aZPtN+VxcjBsW2a3pi5qIb/psO7S0Quq57Aa8Le8vXQSe2vz75uWiwGg8UmYNo+CfwK39AUQyCKykfXKOMMtmLYJWIo6Dc37INSRVFBqOIINNMEyRiAOcA8JROzupt+df22qb3vLDFga98YCPsxDlSi1LsxjWrSBrOH/tHCzgbtyoc8BBh7Bibcn9BiIJr/DwGKq/WGoI9jDfgbAlJ5n5XTk2eELGNV4yOnSX3EdKLKjCi1jVRI7PL/P1X6 1WpI9gYB WIUzxZ+ySXcd7V3mbjAhhLIEA6M9w+jRsEhT9L41fZXSBxvvdQ5WoijzWKaSdqX9/jOIUej0FoF/6Ngwo9tT46qxZFPLoBLVtMUNv/08FD2xnC0QBRtG6iFv60p78FkJmE0yI1AZsXFXoWO07EVdoVx8VCdxJmp8dyuLqvQYsVCTmgJhHSVvJcxlTlGIsjxcVFYzGqKybBr8HS01Q8HFuBb1ScM4ClLoEqs2sufzTKJmGs9cfJnvk66k0p+4OsVqbDFJCXwajWdVeSeoj8A9GGialvSB6pRNoSnsAGV8I+W+9kTXQd3IEs1SkyCW6iX0BVRYP9e37lpf8qNxP+xn/eMZ82kWyPPfyj50EyT380gxUR63DgbPxwltKYYXm6OA9Ype3EFaaMSziTHl6x7/C/biw7tSzL4VgpOg+HJDKJr6rbkv4JfKdNVJATfU+ylhFUBMU1X4wyE2fNTWa07/pUbUExnmQURkectTEFA29iOFiIabpgq5ZPa+RZ5WlaHI26V6YqB6i561dUoT6ypR4GVOJySZpbtSXRzwCwdeutKaxZv8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.09.24 16:51, Steven Sistare wrote: > On 9/17/2024 8:25 AM, David Hildenbrand wrote: >> On 14.09.24 15:19, Steven Sistare wrote: >>> cc'ing linux-mm for review of this one patch of the series. >>> >>> This proposes a new KAPI function repin_folio_unhugely(), for use in this >>> patch of the iommu_ioas_map_file series: >>> >>>     iommufd: IOMMU_IOAS_MAP_FILE implementation >>>     https://lore.kernel.org/linux-iommu/1726319158-283074-7-git-send-email-steven.sistare@oracle.com >>> >>> - Steve >>> >>> On 9/14/2024 9:05 AM, Steve Sistare wrote: >>>> Export a function that repins a huge-page folio at small-page granularity. >>>> This allows any range of small pages within the folio to be unpinned later. >>>> For example, pages pinned via memfd_pin_folios and modified by >>>> repin_folio_unhugely could be unpinned via unpin_user_page(s). >>>> >>>> Suggested-by: Jason Gunthorpe >>>> Signed-off-by: Steve Sistare >>>> --- >>>>    include/linux/mm.h |  1 + >>>>    mm/gup.c           | 18 ++++++++++++++++++ >>>>    2 files changed, 19 insertions(+) >>>> >>>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>>> index 1470736..ba8344f 100644 >>>> --- a/include/linux/mm.h >>>> +++ b/include/linux/mm.h >>>> @@ -2514,6 +2514,7 @@ long pin_user_pages_unlocked(unsigned long start, unsigned long nr_pages, >>>>    long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, >>>>                  struct folio **folios, unsigned int max_folios, >>>>                  pgoff_t *offset); >>>> +void repin_folio_unhugely(struct folio *folio, unsigned long npin); >>>>    int get_user_pages_fast(unsigned long start, int nr_pages, >>>>                unsigned int gup_flags, struct page **pages); >>>> diff --git a/mm/gup.c b/mm/gup.c >>>> index 947881ff..f8f3f2a 100644 >>>> --- a/mm/gup.c >>>> +++ b/mm/gup.c >>>> @@ -3720,3 +3720,21 @@ long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, >>>>        return ret; >>>>    } >>>>    EXPORT_SYMBOL_GPL(memfd_pin_folios); >>>> + >>>> +/** >>>> + * repin_folio_unhugely() - repin a folio at small page granularity >>>> + * @folio: the folio to repin >>>> + * @npin:  the number of pages pinned in the folio >>>> + * >>>> + * Given a huge page folio that is already pinned, and the number of small >> >> s/huge page folio/large folio/ >> >>>> + * pages that are pinned in it, adjust the pincount to reflect small-page >>>> + * granularity.  Each small page can later be unpinned individually. >>>> + */ >>>> +void repin_folio_unhugely(struct folio *folio, unsigned long npin) >>>> +{ >>>> +    if (!folio_test_large(folio) || is_huge_zero_folio(folio) || npin == 1) >> >> Why not the huge zero folio? That looks very odd here. > > The zero page is treated specially here and elsewhere, it can never be deleted so > reference fiddling is skipped. Please point me in mm/gup.c at that handling. IIRC is_zero_folio() does *not* include the huge zero page. Yes, we should likely be special-casing the huge zeropage in mm/gup.c, but it's not that easy because PINs can outlive MMs ... so *not* grabbing a reference could currently be harmful. But that has do be changed consistently, not with doing things here different compared to other gup.c functions. > >>>> +        return; >>>> +    atomic_add(npin - 1, &folio->_refcount); >>>> +    atomic_add(npin - 1, &folio->_pincount); >>>> +} >>>> +EXPORT_SYMBOL_GPL(repin_folio_unhugely); >> >> Can we ... find a better name? For example, it's "large" folio not "huge"... >> >> And repin is really misleading. We are simply adding more pins to an already pinned one ... > > Jason suggests a better name in the other thread. I would prefer something that simply adds more pins to an already pinned folio. Much easier to get. -- Cheers, David / dhildenb