From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E54FEC433FE for ; Sat, 8 Oct 2022 02:55:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 574DC6B0071; Fri, 7 Oct 2022 22:55:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5252C6B0073; Fri, 7 Oct 2022 22:55:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3ECF56B0074; Fri, 7 Oct 2022 22:55:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2DAAD6B0071 for ; Fri, 7 Oct 2022 22:55:45 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EA9BDA134B for ; Sat, 8 Oct 2022 02:55:44 +0000 (UTC) X-FDA: 79996267008.06.E5C4576 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf01.hostedemail.com (Postfix) with ESMTP id DEFF04002F for ; Sat, 8 Oct 2022 02:55:42 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MkqSG38KKzlXrw; Sat, 8 Oct 2022 10:51:10 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 8 Oct 2022 10:55:39 +0800 Subject: Re: [PATCH] mm/page_alloc: Fix incorrect PGFREE and PGALLOC for high-order page To: Yafang Shao CC: , Mel Gorman , References: <20221006101540.40686-1-laoar.shao@gmail.com> From: Miaohe Lin Message-ID: Date: Sat, 8 Oct 2022 10:55:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20221006101540.40686-1-laoar.shao@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665197744; a=rsa-sha256; cv=none; b=M2QMHI7o1+DwQkXn7FblVQr95mylD5xtuLxFfXrXHs1QhGFSLE6d1dAR+cEdXYVnAz8rc6 yAzNyQXTgUqhVolCOYKjguEEHN+fPPMXCgYpeybNMAV//pJjXkk44QZEhlKr82uPtCcdx6 w2YakrTVEhWBpLsaduAAkq7aC2zgXFs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665197744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GwfOcpBODQvUAnWy01mr4SIxKIj3AEwJiK9PBS23Mas=; b=Xz3aHWFx+lLneLLBOUH5cIZMkfIaykDvv3Zwbh/D4uxF+feEI6TSBVdauHZ70Inbd9NHZm 65Uh8mXiw1dXUlj4j2ET9Nn8CBIEuAccUer1hAPGI/cKerZLAECfsH7oH+ly9ArPy2Z9rs xyeKuZnwFTzbkULFvjQg6ZyphD1KZbY= X-Rspam-User: X-Stat-Signature: uszhxcm7faw35zdjw3pr5ezgij319sqf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DEFF04002F Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-HE-Tag: 1665197742-107782 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/6 18:15, Yafang Shao wrote: > PGFREE and PGALLOC represent the number of freed and allocated pages. > So the page order must be considered. > > Fixes: 44042b449872 ("mm/page_alloc: allow high-order pages to be stored on the per-cpu lists") > Signed-off-by: Yafang Shao LGTM. Thanks for fixing. Reviewed-by: Miaohe Lin Thanks, Miaohe Lin > Cc: Mel Gorman > --- > mm/page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e5486d4..3c0ee3b 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3440,7 +3440,7 @@ static void free_unref_page_commit(struct zone *zone, struct per_cpu_pages *pcp, > int pindex; > bool free_high; > > - __count_vm_event(PGFREE); > + __count_vm_events(PGFREE, 1 << order); > pindex = order_to_pindex(migratetype, order); > list_add(&page->pcp_list, &pcp->lists[pindex]); > pcp->count += 1 << order; > @@ -3808,7 +3808,7 @@ static struct page *rmqueue_pcplist(struct zone *preferred_zone, > pcp_spin_unlock_irqrestore(pcp, flags); > pcp_trylock_finish(UP_flags); > if (page) { > - __count_zid_vm_events(PGALLOC, page_zonenum(page), 1); > + __count_zid_vm_events(PGALLOC, page_zonenum(page), 1 << order); > zone_statistics(preferred_zone, zone, 1); > } > return page; >