From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE72C433EF for ; Thu, 28 Apr 2022 17:13:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AB588D0014; Thu, 28 Apr 2022 13:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25A558D000F; Thu, 28 Apr 2022 13:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1216C8D0014; Thu, 28 Apr 2022 13:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 045938D000F for ; Thu, 28 Apr 2022 13:13:07 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id D1C3482802 for ; Thu, 28 Apr 2022 17:13:06 +0000 (UTC) X-FDA: 79406933172.15.AC86794 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by imf09.hostedemail.com (Postfix) with ESMTP id 7ABDC140055 for ; Thu, 28 Apr 2022 17:13:02 +0000 (UTC) Received: by mail-ot1-f43.google.com with SMTP id y14-20020a9d460e000000b00605ee347da1so988273ote.8 for ; Thu, 28 Apr 2022 10:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UBP7y2RvEXxVN92BvqAi7m+pLWAZ5atsFjO8+tg56fk=; b=Vcv2k97RR1epKhR1NUb5TDyl7ffQ1Gs/U2EaOWViBSxBV2K5mnoTB5Dk7V8rgEsnzA Xh9twu69XPL3owjHPgs5K57Dq1UH4/7JUWsjLn98QLs43+U7mAUW0/33O7buWhhnvVjw HjYfxbtbuBtzNqyn1y39tXpMn6AU+Gz3C/FmVTUCX4mKHO3TETxqe2xtUOOEBdansDGm 2+kdDl/4yRszPMS5PVPaOz+IXghdzI9Hie1E4xFN5jT97E71Ma+JvES94/1S99h/VKor EPl23NnvKb1SrBAZIuHoSwWcIVwPdaC0aOfjdJu61qAGz+4bQH1bE7KOoGL14zd2HHig pnTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UBP7y2RvEXxVN92BvqAi7m+pLWAZ5atsFjO8+tg56fk=; b=HJvG98p3MqyTvuaRMExVTi+yRxhJokfd5X8fzKoFk7tZN0qCqO51lgLNgw4Ck/TVoM NlhRFIhMw6A8qodTx5gooj4Te4Nq9VYrXOQzr0KoviaBQ7baMBMcyfAMQN4g36tLURgQ StIzaPwjz3hV1HM9vNwaJaBZqCy1/+MciO6q5+MceyBitQtA4RXP4mDtjzmxzFglJd2d 9vKw8h0F2wmk5Flxca9HF3KEckiy2urYY7rpzqZKQjZi77BNidHGAC3xn9HHBV3jHKbl /rXNVRl8BEwTXFs/lGbziygyxttqw8Bd2vgcg9R6oRcU0GpFXE00SSbu7dEVmNIuLNoR BYpA== X-Gm-Message-State: AOAM53067Tm7v3ropK6PpmMTxxQbc8l+PrdQXnLQj66UhhUA1URbIBlb HS3WEddI5kYXY/qC+rhnsEU= X-Google-Smtp-Source: ABdhPJz0k1H5zMmO7FeRxSiziHAs6QXmdLS0h3iz7iXvgx+oRMvqv/AD2IwfdjeL00lzP2YnBECbCg== X-Received: by 2002:a05:6830:1d55:b0:5ff:7c6f:ba6a with SMTP id p21-20020a0568301d5500b005ff7c6fba6amr12302592oth.240.1651165985510; Thu, 28 Apr 2022 10:13:05 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id g2-20020a9d6b02000000b00605e077186asm196392otp.11.2022.04.28.10.13.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 10:13:04 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 10:13:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v8 23/70] mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap() Content-Language: en-US To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Yu Zhao References: <20220426150616.3937571-1-Liam.Howlett@oracle.com> <20220426150616.3937571-24-Liam.Howlett@oracle.com> <20220428160949.GA2923383@roeck-us.net> <20220428163512.kmx3yvghn3txpjee@revolver> From: Guenter Roeck In-Reply-To: <20220428163512.kmx3yvghn3txpjee@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 84ogwowcgcaj74stbiaxperg9fqcxhg7 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7ABDC140055 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Vcv2k97R; spf=pass (imf09.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.43 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none X-Rspam-User: X-HE-Tag: 1651165982-295498 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/28/22 09:35, Liam Howlett wrote: > * Guenter Roeck [220428 12:10]: >> On Tue, Apr 26, 2022 at 03:06:35PM +0000, Liam Howlett wrote: >>> From: "Liam R. Howlett" >>> >>> Avoid allocating a new VMA when it a vma modification can occur. When a >>> brk() can expand or contract a VMA, then the single store operation will >>> only modify one index of the maple tree instead of causing a node to split >>> or coalesce. This avoids unnecessary allocations/frees of maple tree >>> nodes and VMAs. >>> >>> Move some limit & flag verifications out of the do_brk_flags() function to >>> use only relevant checks in the code path of bkr() and vm_brk_flags(). >>> >>> Set the vma to check if it can expand in vm_brk_flags() if extra criteria >>> are met. >>> >>> Drop userfaultfd from do_brk_flags() path and only use it in >>> vm_brk_flags() path since that is the only place a munmap will happen. >>> >>> Signed-off-by: Liam R. Howlett >> >> This patch results in boot failures on alpha. Trying to revert it results >> in conflicts, so I was unable to cross-check. Bisect log attached. The failure >> is silent - boot simply stalls after "random: crng init done", so attaching >> a boot log doesn't add value. > > Thanks. I can only find Gentoo iso for testing, is there any other > options? > You could try with images from https://github.com/groeck/linux-build-test. Guenter