From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FDB4C19F2B for ; Thu, 4 Aug 2022 01:04:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 805EB8E0002; Wed, 3 Aug 2022 21:04:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B4688E0001; Wed, 3 Aug 2022 21:04:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67D028E0002; Wed, 3 Aug 2022 21:04:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 562D78E0001 for ; Wed, 3 Aug 2022 21:04:07 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2C75DA0DA1 for ; Thu, 4 Aug 2022 01:04:07 +0000 (UTC) X-FDA: 79760113734.23.EDC32A7 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf08.hostedemail.com (Postfix) with ESMTP id D49FE16000A for ; Thu, 4 Aug 2022 01:04:05 +0000 (UTC) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Lyr542xbwzjXX1; Thu, 4 Aug 2022 09:00:56 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 4 Aug 2022 09:03:59 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 4 Aug 2022 09:03:59 +0800 Message-ID: Date: Thu, 4 Aug 2022 09:03:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] mm: memory-failure: cleanup try_to_split_thp_page() Content-Language: en-US To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: Miaohe Lin , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <20220802021256.162269-1-wangkefeng.wang@huawei.com> <20220804004552.GA3631345@hori.linux.bs1.fc.nec.co.jp> From: Kefeng Wang In-Reply-To: <20220804004552.GA3631345@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659575046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Itsy3cJcDRg8rOOMnmQh1IRfnC3lz+TjeLwlI/X0W6U=; b=q7srPlOEd4DPKcr8C/3bzJr8DmVgHTFawr4zMWMMiqugWMZrEBqYY3F1Bpmvad8GDJe3ov MK1rrnJlq87R/N4okYYnJd15Ccfutf8GJ6sOrM9mwn7QZWO8QEkU+pD0HYMByKUCe0j2O0 6xcfVK+U/hSSIgZKrd3WDbVWCxIkM3E= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659575046; a=rsa-sha256; cv=none; b=mnseM+dIzbsy0ZyGZzFsV1F1HtGuI01g2fLgr415fjLr8iUhVQtxMxIv4WwrP+qL1w0xq2 Muz2FolhgfLEvEGf6AOMg3EOPme2WNfTbizY1H2ByNaQKYx7CO3zyY0NtzVGAVnDk4i7X6 Yw7qVtgkPF9KS13vgrL+eiqNhtjxL1I= Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D49FE16000A X-Stat-Signature: fcp3yj3dqjqjy1ddoe33xpqnxiu6q4pw X-Rspam-User: X-HE-Tag: 1659575045-368129 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/4 8:45, HORIGUCHI NAOYA(堀口 直也) wrote: > On Tue, Aug 02, 2022 at 10:12:56AM +0800, Kefeng Wang wrote: >> Since commit 5d1fd5dc877b ("mm,hwpoison: introduce MF_MSG_UNSPLIT_THP"), >> the action_result() called to show memory error event in memory_failure(), >> so the pr_info() in try_to_split_thp_page() is only needed in >> soft_offline_in_use_page(). >> >> Signed-off-by: Kefeng Wang > Thanks, looks good to me. Probably this patch may come before > "mm: memory-failure: convert to pr_fmt()" to be a cleanup. > > And recently another patch [1] is trying to change the same function, so we > might need to resolve the conflict with it. I expect it's not so hard, but > I think your series had better come after [1] because [1] is a bug fix and > might be backported to stable-5.19. OK， I could repost after[1] merged into mm tree,  thanks. > > [1] https://lore.kernel.org/linux-mm/20220803025243.155798-1-fengwei.yin@intel.com/T/#u > > Thanks, > Naoya Horiguchi