From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5BCC47258 for ; Thu, 25 Jan 2024 03:56:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 684AE8D0002; Wed, 24 Jan 2024 22:56:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 635488D0001; Wed, 24 Jan 2024 22:56:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5235D8D0002; Wed, 24 Jan 2024 22:56:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 415758D0001 for ; Wed, 24 Jan 2024 22:56:39 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DBCB612017F for ; Thu, 25 Jan 2024 03:56:38 +0000 (UTC) X-FDA: 81716471676.29.6BF50F1 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) by imf04.hostedemail.com (Postfix) with ESMTP id 108B840003 for ; Thu, 25 Jan 2024 03:56:36 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=WqgOG0dd; spf=pass (imf04.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706154997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ejp8VHBDj1AdDFZcvCgj41MZXiNxrrGKntHro4P/XIo=; b=TdEhcLosvmkpFcG+RJgATESRWd0IaWvEmNAs80fMsLrStIE6avHunLOmfVSC+fY0HuIi2+ imQ+HUbWf5EQNuohv82ofJ8ncMKGbYXtamnFtcAFBnpZsnM8J6hqsjPvlUfZEgMLJkwSPz mHl1IVqVpqRoGtmyyWTkgwstpenLD5Y= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=WqgOG0dd; spf=pass (imf04.hostedemail.com: domain of gang.li@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706154997; a=rsa-sha256; cv=none; b=lTO8fMA5D2NKtnR0MecEU+rE/zJFVCkpfIYJZMIvjdytK64hAVV5GdWO7yizyqqJuJdTss w87yBhwJaiqQm555a7fWdSeYrehKjRQS0InOZHaqza+LDaUyXt/3ta5i2F+0mo+Vwn9m9v 3el2IxSUJVzPrPLnTjaD/ljX3etEjDQ= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1706154995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ejp8VHBDj1AdDFZcvCgj41MZXiNxrrGKntHro4P/XIo=; b=WqgOG0ddtuHTY4S6GoOjGtCQZGFrbdA9VvHCzPJ55YfdomgXf1qpZwrd+/+TL9PlS+yjVb ZC+j2DJ8pJN9A0Qj1HgSeYui6DLTjjhuAkRVOIm+bgBvggQ4ccDFXCYVSmrqbk5155GUc3 8+8AtsWFKJ7U44LJ//wlxhSkBcXzS9I= Date: Thu, 25 Jan 2024 11:56:21 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v4 7/7] hugetlb: parallelize 1G hugetlb initialization Content-Language: en-US To: Muchun Song Cc: Linux-MM , LKML , ligang.bdlg@bytedance.com, David Hildenbrand , David Rientjes , Mike Kravetz , Andrew Morton , Tim Chen References: <20240118123911.88833-1-gang.li@linux.dev> <20240118123911.88833-8-gang.li@linux.dev> <15E775EC-8E4B-4145-8931-067DF60E55F1@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: <15E775EC-8E4B-4145-8931-067DF60E55F1@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 108B840003 X-Rspam-User: X-Stat-Signature: 5m3zo5aitmqha11mytdoif845uej9wxi X-Rspamd-Server: rspam01 X-HE-Tag: 1706154996-588395 X-HE-Meta: U2FsdGVkX1/3E8fL7/5j8Iy536iTKxDB8ZPbmJ9HPX+SK/z9jJYxY3BfDeG2fhDkxelthkLJOhCXt+IUW3ZJBc7qyiQ8UzywsoFcXWL8jxZL7i2wDfSoSIcDRhXu3iUYLbkgC8Wd4/ZGDu+xvndsJGYJ66HynWqf0oIONUnb45Zi22RSTnHplZk90XpX9qI4sJ8vALEidmHeIVksZSEE9CId968mYBx81u4nGJXKwPvYrPL1+zk70KS50npou45o7uIHOlKNjhtUbShgHJzpx0DQfpEX1tO0jByBUgAOqIT7LRIYjuLA9gzPaPxKRosqEUFwShTxuiVqJ5Txa//GoU6zyOeZNh5Ax2ydy6y36TU6DvDDBfMlboe0yL3cxqeok2JQVbCTiuNgquAFI/xi/9ZPqxlTSXXORIAa/qJ79LLHlWqBSLgKAMIiSRqn1mGI3KrhnTYBA7RsXG03HZ05so/evJZzzFX5m28W1U//w6pwt+OEnUr1qGKeW8iP4r540FfzWNXtGoqYmr4n+sHYT1aaWofMnUuqKNUlI44ryVpoZmMbeIVakr5x5dEXVsf97C+Voai7u9/LsDVvt6pxSv43T5ankfhOWNEw/EhJQlwU5ZNGeBe7kd/y5T+tJTKfwHo8RfWwstaJaWRgC665oHypsxL7ozuT/oqiyKgxQp+5wCSfTx4R0/GXJ2xW9jPVc/wDO2/ZnYcteY24HqDDkGCgF9JGvge7JoF6meyIJP2qt3jEJ0VWoyi3UDSJcttvPJlIukN7clIuFj9lQZJdHlLEsdqUlaISyLZZEs2rv5/bXDi1oXW0kGg86RIAfyPwCXWID/Z4MBhngtnPvW9WP9FuVXXQ1dj4zP2wsu7plULoyWrR5xyT5vuk863MBXvsMXATyKGMbO+MHQ9FCz6baOAHxcvSu5C+DcfUTYFmG0Gr/dBetXz5HmarOUQAcRyiW3fPSPcFx/c3OSPw0ko Ce2bg6RD yw2XTDg34FZet2oJNhyFvIEcYMZVevsf+2xkrcnfGP/q+fjpRjmnmpMdpggENzYK5KtF54JmqcTxze9k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/25 10:48, Muchun Song wrote: >>>> + if (huge_boot_pages[0].next == NULL) { >>> It it not intuitive. I'd like to use a 'initialied' variable >> >> Would it make the code look a bit redundant? > > What is redundant? > I was thinking of adding a global variable at first, but it's possible to add a local static variable, which is more concise.