linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: more vma cache removal
@ 2022-10-11 17:55 Alexey Dobriyan
  2022-10-11 19:06 ` Liam Howlett
  2022-10-11 19:34 ` David Hildenbrand
  0 siblings, 2 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2022-10-11 17:55 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm, liam.howlett

Fixes: 7964cf8caa4d ("mm: remove vmacache")
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 include/linux/sched.h |    2 --
 1 file changed, 2 deletions(-)

--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -870,8 +870,6 @@ struct task_struct {
 	struct mm_struct		*mm;
 	struct mm_struct		*active_mm;
 
-	/* Per-thread vma caching: */
-
 #ifdef SPLIT_RSS_COUNTING
 	struct task_rss_stat		rss_stat;
 #endif


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm: more vma cache removal
  2022-10-11 17:55 [PATCH] mm: more vma cache removal Alexey Dobriyan
@ 2022-10-11 19:06 ` Liam Howlett
  2022-10-11 19:34 ` David Hildenbrand
  1 sibling, 0 replies; 3+ messages in thread
From: Liam Howlett @ 2022-10-11 19:06 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: akpm, linux-mm

Acked-by: Liam Howlett <liam.howlett@oracle.com>

* Alexey Dobriyan <adobriyan@gmail.com> [221011 19:55]:
> Fixes: 7964cf8caa4d ("mm: remove vmacache")
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  include/linux/sched.h |    2 --
>  1 file changed, 2 deletions(-)
> 
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -870,8 +870,6 @@ struct task_struct {
>  	struct mm_struct		*mm;
>  	struct mm_struct		*active_mm;
>  
> -	/* Per-thread vma caching: */
> -
>  #ifdef SPLIT_RSS_COUNTING
>  	struct task_rss_stat		rss_stat;
>  #endif

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm: more vma cache removal
  2022-10-11 17:55 [PATCH] mm: more vma cache removal Alexey Dobriyan
  2022-10-11 19:06 ` Liam Howlett
@ 2022-10-11 19:34 ` David Hildenbrand
  1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2022-10-11 19:34 UTC (permalink / raw)
  To: Alexey Dobriyan, akpm; +Cc: linux-mm, liam.howlett

On 11.10.22 19:55, Alexey Dobriyan wrote:
> Fixes: 7964cf8caa4d ("mm: remove vmacache")

It's not an actual fix. Such tags can be misleading.

> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>   include/linux/sched.h |    2 --
>   1 file changed, 2 deletions(-)
> 
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -870,8 +870,6 @@ struct task_struct {
>   	struct mm_struct		*mm;
>   	struct mm_struct		*active_mm;
>   
> -	/* Per-thread vma caching: */
> -
>   #ifdef SPLIT_RSS_COUNTING
>   	struct task_rss_stat		rss_stat;
>   #endif
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-11 19:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-11 17:55 [PATCH] mm: more vma cache removal Alexey Dobriyan
2022-10-11 19:06 ` Liam Howlett
2022-10-11 19:34 ` David Hildenbrand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox