From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE0ACE77197 for ; Tue, 7 Jan 2025 11:00:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 432278D0006; Tue, 7 Jan 2025 06:00:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E0728D0005; Tue, 7 Jan 2025 06:00:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20B3A8D0006; Tue, 7 Jan 2025 06:00:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B7F0F8D0005 for ; Tue, 7 Jan 2025 06:00:28 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5F622140889 for ; Tue, 7 Jan 2025 11:00:28 +0000 (UTC) X-FDA: 82980362136.08.0915644 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf23.hostedemail.com (Postfix) with ESMTP id EB2A114000A for ; Tue, 7 Jan 2025 11:00:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=ROfnfAjC; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=NErG5sKX; spf=pass (imf23.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736247625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FiK30QNYa9jfsRxCEoLAQIHdXT+hKQ85h2GhyGypKR0=; b=zgelyIpJgRrz7WrATqtR85YADt5mXrZ2JA/o3zL7wWSwBgTNLsiQu1X/mk0xud3gS5UXWC v8B63zHuArHnVhp2cpkV5KSPYoUFF8QS5hNxPImMckOh0NJc9IBis0f0VJNSkawaeFtqfp t3KO2Qw1M0Ux5wKCapuWCtkEAqnDWN0= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736247625; a=rsa-sha256; cv=pass; b=0S7ECYzw9nW2G34BReqiUh2scjktVHZiWh8d5ACgy0yINw0V/QenGtVNkA+yOjswCiEj0o lanOJcla8ahcTLUoQaJAzm87Ra4eYrhO89QP4JvWYslKoJSZsXj/edz3COyDTxVPt6ubhp Rlvm2pDN0dtOsd4ol47NSdAhTZH//w8= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=ROfnfAjC; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=NErG5sKX; spf=pass (imf23.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5072tqBq020492; Tue, 7 Jan 2025 11:00:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=FiK30QNYa9jfsRxCEoLAQIHdXT+hKQ85h2GhyGypKR0=; b= ROfnfAjCQq0cDTNKR+XYbPiP0ew+qrUgFLxNcizXtMQ599njPkS7VkcUq1FHygL5 4YbaOY1RKAMj49WBTTxYAD/M48ePfinCpLYP38kvVngV0eSN87fIUeN7m8J8bi3m MIdyl3v3JQfzR0Px90YBrIQK8kp7jh8ZK7Fcej45cXy4ACarsbz/Rcymqh3CJ87s lzDsxJ9avfXgLKOLAYdpU82ZyYouKwhsCVjV59c4Q4baX7exLblmJtPlHLLS2MAZ /D5eDIT1Qj+LCW3743zvHSvcNMnK9i1uK9seLubtjg4/8itW+jW/Yyv1eMB7ApmX 2PY22NeN8qwkTAVbzteEUw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43xuk04mqv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Jan 2025 11:00:16 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5079R2Z2027594; Tue, 7 Jan 2025 11:00:15 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2176.outbound.protection.outlook.com [104.47.59.176]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 43xue8ku3d-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Jan 2025 11:00:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RobIs2xNBxVHLWEj73jZtc3J8QjEvW8ueTJU/rBvD1Rb3CiaQICK/QR2NOD/ut4ez9Ax/Kq5BkoVOmZrBIK+PcBCvBJyRDmtouft6QQD23QfDfjGtSAxjuLcyWztcI8CetC/bL5Dmg/RWpXJVncGH6lUVX5YinBhSO+nj/arHpwGIM9HW/oi6XNx2NBXGgewnWQmUkeXcVb9xRQOUafat8rK4IJvEreMA+bWgxBd3kxqyu/MTIeHLb3fe700LbW1CNGHubsbb/adNAqvrUavaBvolQuI3Dk1dItKpGatr6rSd/RGFLF6cENzrZommNA/xwxzSx6HEkMkDmyQuEeHSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FiK30QNYa9jfsRxCEoLAQIHdXT+hKQ85h2GhyGypKR0=; b=kN+0dxPeMMt2vIwLfVxRnnso3DIMrYNRUW8FWURZrSc2ReqTB5MNkalxTWXmLs56d7J2sjpQmM8O19xXzCq51UoN0fiXRGNkSvOBftmhy3blvPBiCwJ/yo53nq8PSCdu8QboXJQvPkHTwzKuvIvPEN1K+0yW7E71/yTHxGYZwRFeUh1YXyEeVi8OoEigsGkHnGM0XAZu88Fi+27yXUz3eLp1H+I1UKX1K38xTQ4BfhrgHYLmoxju/Oxjam+VQRmn4D0/Af+F+kogO9lnBn2syoST1SMHlV4Hgb75oRgxzMgq/dqLNPM1uxCMHxSwcedoclI44NG4hev1HXdnGRMS/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FiK30QNYa9jfsRxCEoLAQIHdXT+hKQ85h2GhyGypKR0=; b=NErG5sKXo2Hcaa16hENO7fKtUHqOheJNRp9Q0BhmKyJeUOIBRCMY1QxqYIfiZwG8j3LS/7qAyg4o3i48lHpCoXnWM4wXiJI5smri821lhcyuoEZBfsEohltOmBLT9SUWUBcIF+tvIlx1ReSGYpEGQv4NPnYyjX54Y+Ap7JLSdYs= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by SA6PR10MB8182.namprd10.prod.outlook.com (2603:10b6:806:43d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.18; Tue, 7 Jan 2025 11:00:13 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%4]) with mapi id 15.20.8314.015; Tue, 7 Jan 2025 11:00:13 +0000 Date: Tue, 7 Jan 2025 11:00:10 +0000 From: Lorenzo Stoakes To: Huacai Chen Cc: Huacai Chen , Andrew Morton , linux-mm@kvack.org, Koichiro Den , Sebastian Andrzej Siewior , Mark Rutland , Charalampos Mitrodimas Subject: Re: [PATCH] Simple fix Message-ID: References: <7gd4skn6l4i3liu6cvzmgqlrwxc3rukrnau7lnpyhmfyjuvqwl@gdwgybedp5gs> <20250107011848.689556-1-chenhuacai@loongson.cn> <3a5ad843-6d00-4e8c-9f77-f53282cef4b3@lucifer.local> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO3P123CA0005.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::10) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|SA6PR10MB8182:EE_ X-MS-Office365-Filtering-Correlation-Id: 69b6e183-085b-46b0-a093-08dd2f0a75d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?alZhTFRTejdnVmYrOUZwZjhVNFV1SUxobzF6ZU0xUmxxZVFIVjZUekNRSTNw?= =?utf-8?B?TFBMS0RTSnlicTEvNzVFMERUSjg5dGpnSTg1VGorclhhL3cxNk1PelRvRndw?= =?utf-8?B?a2VNb2ZldHIwUkRqZlRMdDJSZ3JWeE5MaHBBOFJkSEcvVmxmc3dMOTJWekRZ?= =?utf-8?B?bFAzalRDbUFsaGYxbmVxSHVrSEVGZlFyeVFJeDhYVHZCVWVGRGh1OWorVlhj?= =?utf-8?B?SWhjL011S29kLzU0NjhlcHg4bnorQ2F2ekE4eEpteDRzWWx3T0pTL3F6clFZ?= =?utf-8?B?WXBsSDZGS29YRUkyWUFvdy9pRW0zMmFYRWphMEYvMTZtUHBZOUFjZzM1dDdG?= =?utf-8?B?YXhObmJwbm1PY1JLZFZBTnFZKzBkNzFxcER2Q1lQMXExNFUvZEcrSXJxNmJY?= =?utf-8?B?NFRoc3RmUWRVbWxRTmlLRlJlK0lQSWc3S2ZTVzQ2TXh6cThrNUo0d2JNc0Fl?= =?utf-8?B?elhFTEFSTjB3VGh0LzVoZE51bm9DZ1ArcldjejZ4U2s2UUJWN29EZ2VJNi9P?= =?utf-8?B?NEo1MHZqZFhZNkwvamRoYm52aFY3ZjRFRWpFNFlOT08vdlFnL0hwY1QrQlR4?= =?utf-8?B?RmtiT3J1aVZ2RlhPV3I1Unl4Rk9WVjhKdTYxbVM3cHBUWjJvK0tKSVd3TWFo?= =?utf-8?B?ODhZRExTZjJiaXVVdnFYRkxYZE52Y01XVU5wMGgwYTFqa21vQldJdmVsSnJl?= =?utf-8?B?UkhLYkYxTUlIQ2haR0twbGVwUklLYlpXTWFleDUzQ1hIV24xT0pLQXBLOC8y?= =?utf-8?B?TitwNU1OdEE5OEJZaVUxZUJabUFHQnpXVzBCck0rUzN5ZGYrT0M4Y2hiMGVw?= =?utf-8?B?R0xrMldOWXhYMDJJUDNwbWZNQ3BsbzJrcWtab0FhbjlMSkRQb0VKM0d4NW5k?= =?utf-8?B?TGV2TEdNRVRNWWJTREhrUE1uQ2ZLa2VFTW13ZXR0MURaVkt6VzlYNkg0d2Va?= =?utf-8?B?TElMb1NyUTJaNWt0NUNGckViMGhQbnZNUkNpTEJnYkgvNk5JNU50OHUzd016?= =?utf-8?B?cHFaM01sTWpubE5tRE5iV3J4bTB5b2VlQW9ia0puNHBjQ3FtMFFtaVZua2dt?= =?utf-8?B?YVJNRVFUaSsyMHM2amNjQ3NTQ2Y5NXJWWFY4TWIzdm4rUklaNUhVckJ1MmFw?= =?utf-8?B?bERWSS85T1N4RXVqU3hlb1RDWThlcjRIcUFERnFaK1JRVEUvMlJENDhGdHU3?= =?utf-8?B?TnQzVDFxaThwSWhXdEZjY1E5SzBXbVhiMTBDZWdVemF4ZVBLMGtEYWtaUFl1?= =?utf-8?B?amN3bitTYmI2TFBaZjNHaTJlK2RRWFNqblVzaks0K0N5UFoxN0hLdkFlamZ0?= =?utf-8?B?cUZHZjNWQ25Kazhqcm9vWENhNXZLMDZLNjZ4clFOa0xtUDU4YWF5RmxLQ0kx?= =?utf-8?B?TGcxQ1RDYmVxdCtHZm1wbnl6ZDFZREcvczEwbEcvWEFmbU03czM3L3A5REYx?= =?utf-8?B?QXM5dlRZeWF5bUV1cVBsSkYzZURqc2J1b2UxcGdMZFUzQ2Vad1dNZm9lZkRi?= =?utf-8?B?ZnhBNitoL0djL21vVFlMbENTTU04Q0xOYnJFRWRPTXlEZFFiblFSY3I1cmxQ?= =?utf-8?B?Q0Y0ZitpZzZoTkwyTjBCYlNXb0hDaFpTWExCVlVubjBQeTU2NUpWMmZjUXpw?= =?utf-8?B?N0QxWDBBQk9lVzh0ZnY0MjA0ZTFYQkZuNXhwckJUc0h4Wk9ucEcvZk9KTjNJ?= =?utf-8?B?QkJaLy9pYjJ3Skx2YzcrMjFCMy9vR1B4bzBBRFpyT0c2RHJOd0laYmoveTh1?= =?utf-8?B?S211RTlERExyVndhM09LbUZnbHF0QkhhM0lCRTNBaDhxd3NwQ21DRU5VTTV1?= =?utf-8?B?VkhQZWxaRnI4NlVIOHpOL3ZRNmMxMDRycU5rWU9VVkdmTy9BbWJpNC9GS2Nk?= =?utf-8?Q?bzWfw58fJTgNZ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjZJNVJJdDBDWTlJL2RxU1JaZjNrVERrRk9CRkpqNkZHdzlMWHVJaUFNdGlK?= =?utf-8?B?ZkhIQi8xTWtBYkduWUxVZVdtajJjTWVPWCtGcWdiOUZUUENsdmdreHF4dGhG?= =?utf-8?B?MkkyUndaa0FiQ1dBMm9ocG4zOEdmR3BrcFlOeDFadjhYS0dpRXAvdVZuUUpB?= =?utf-8?B?ZlFaYUFBaC90aXpFU1RMQlptSi9ONC81SnQwVTFReDFMTklqWlhPM1VPYjZ3?= =?utf-8?B?STRyVzVpeWxXV0I3Y1ZjK1hiR3RlRWREZC92M3U5OGV4bGgyMUZlZWtpVDl1?= =?utf-8?B?NXNhN3I2a212emlCTURlNTFUSkJMR2MrV3ZlTUJFbGZjTGxtYjM1cWZ1VC9j?= =?utf-8?B?Uk9ZRnFjeDhjczZqN0o1QUpXOWY0QUhFZlNkOVB3WTM3ekZ5OFhYUmlFOUNO?= =?utf-8?B?a0RZWjMrek1tODJFZ00zeWRRRUMzdUdBZHlLWlovRWQwRFZCdyttcU1vSUFS?= =?utf-8?B?QVpaTzRhdE8remFSMTdmVXJDeTduRHd2MUNSK2FINnFEZWVXdC9ZcTdiQ0JW?= =?utf-8?B?UGtUbFV6RkZPSE5oc2JIVVNFc3R4YXoyT3VuM0dRMkE3dWZqTEJqNUp4eklR?= =?utf-8?B?czZFSU0vaENGVG9OR25GUU5uUGJvem5RMG80b0xpNGMwRk5CaUZIY2M2bXg3?= =?utf-8?B?cTc5K25hRlJjQisrcXdTWC8vR04wb3B0UmxQRTVBWGlxR0h3ZWxad1hhSTVJ?= =?utf-8?B?NWd1TEdrWTZUZ1BrOGxmdlVKdmYvQmtHQkdVMmtNNkJKTTBWazh3d29xeGN0?= =?utf-8?B?L3VtTVFyYUxPNGR0RFBFb2NlWnloZGxkekZFSXNhdlpUZXE3eGlteWlFSHht?= =?utf-8?B?Zm1xTHhWb1lXY1ZNTUpPZjdJZXN1dkdnYzdNaUZBeUpiSEJZM3FzTk13d1Qw?= =?utf-8?B?dkNWMWo4aXRYdDZjUnREejJCZndRdGlOTng5WnJtUjV3SkJBbktYVUQxMThJ?= =?utf-8?B?dCtyZTI5VmtqQ1BOL3lKRWIxdUZtRzlNWWh5aThQT1pOQVJ6dGVySjg0NXVr?= =?utf-8?B?SFNqeUZzSzR5NTlPMlJPbi9FTnlTR09ZOXpWRXNyb2wyZHZ0c1VUSFNVK3JJ?= =?utf-8?B?Z2NWY25menJyR2RHS3dMR1BraTJPZVNEeVRUUWxJNER2WGhVNlpMOHZUS1dm?= =?utf-8?B?TUx3MHVCN0NpdjFPd3AxR290dmZOZytZU1Jrd1F3dkc5OU5qL09SN24rZktU?= =?utf-8?B?Y1ZVY2NQTUtzZXEvczRldFJtQ1ErUkFUZE15VU5yM2ZCUUNGOHRDeGh5eHNF?= =?utf-8?B?byt6V2dqWVczR2U0YzNDZW02V1FmNmZPNTFaU0IxNW03VzFxeVpnTmtUa1lv?= =?utf-8?B?ZUh5VThoZjZrRzBxVXY3ZUQ3eno1TENFemw2bkc5d3diWWx3UC9XRi9zY1Bj?= =?utf-8?B?WURkY0FoaXZhY0txcllFZ1lxRjhheGpnaUkwcmdWaWQzR29PRERZWGE2bCtI?= =?utf-8?B?U3YvS1VSdWxRVzJVRUszQVAzRll4NVprVms3SjJ3akVWV2JYM3hTcFp0TVpN?= =?utf-8?B?T05GbkMxR3dJcjU1a0NNcUxSb0FUNy9KR3NKMzBtZTVaZG1MUEJIZmxCc3pk?= =?utf-8?B?ajh0bUpFUExnNEpzbG1IcVZTR3ZyOHNOVGpZQ3JndVYrRmZ2ZURCZTFtdytW?= =?utf-8?B?OG5rZkhGVUlwVlhFSzZUYUhTWm1iR2JkbmlYN0ZIMzVaaEZxZFpucVF1VEFl?= =?utf-8?B?N0N3MXREUXF2TW1YbStqa0d2RFhsVE1Rd1QyeGd6bGhhWDdsMGFFUVJCcTNN?= =?utf-8?B?amFTYVQ4QkJvTDBndFU1VjZUK2ZlUVFkUFU0T0NuYTYxak9yUDNMMDJ0ZXBs?= =?utf-8?B?NlZFNzBkS0x4RG9jVEphSlhvYnRNek5Fd0hwTVlIQ1k0UDZpZ21JVmhJWXdD?= =?utf-8?B?bXVmalNVd1k1RXQ0bGNZamlrR2xBQ0k5aWJnNmppQy8rbkdNbHlhS1dZMi9T?= =?utf-8?B?dXlpcVVzT3FKZWFXTXkyajJoT3B5Z0llN3I1OUFFazZLc2dZR0YxVGQ0L0h3?= =?utf-8?B?VzVnRGZZcXloREtLOHFaWTlSZm14cll2aS9GeERzcUZhdk03OWJJVXh6Mmxn?= =?utf-8?B?cGRRaWJqZmc1d2RPV0MvYTNWbDhWdFBSR3lodGRXMzVmU05FN092Nlk1ditW?= =?utf-8?B?SEt1MVpodHZkc1lTeFVKdllCWEdhQnZtaWNwRWcxQ1FORitwdHlkRnlOU3Zy?= =?utf-8?B?dkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /1h8z9qi3zqCv5F3VYdP5Uw9tZXTqkGIQSjgLGF3ldKrDU3WMKaLTtiT9TVy1DwBcTnUYDXF0Q0GyEdIkGCsJKqZDLHNY+ZZDoWo5luCdKD2vSlrDxSfbL3AumfwLvg4CAY8hWCkLQ3WnGGE+J8dZD24XErEslDg7RaFKfshaOFuDpxNA+8DUs7LTC6Swm3JQdQuoTNev6WeKcVTpPMt42U+WVY+3GMw/M4XNE3d8zSQvAcVaBsfjepkvgaK8eHUDRbQC2FsklF9FSe3TrT/a1SnUpuXJHQ3mnW3b72XJdNutxJP5s8NXFvxLhHUReJxwWWJyBBwyaoIZCbJUaRlJhyjytmyINtxq1bPFr8JhlYrRUfU13bweQj84FpeOm+CaS+xc5edrzRdEDW1z1g9EAOi+hiQVtyod90mh/YQzjirFz+6S5MLqK6Y2PD/YQrIP1Kqkjyr9bd1j8YuDtv5jjeAYJguNCfbLBFlvJtEpQr9kAinAkH4nsuGYNm9j2WkgcLFux5pvh13IDSIlEU6coZdk40fdIerW6o1xCg2ySpvlGwetl2DAceGqy8z+Bya+ZhY+wKlfDJPMm4F7XtziDT9afKQ+bC1Aod/jPFe+l4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69b6e183-085b-46b0-a093-08dd2f0a75d2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2025 11:00:13.2566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KLeHt8V9S4mZUSgHdLlPSKqlQqUBqdUNBxFjnuLL3mMhe1kWus5p4E6Fed1KrCLaLAg2vTqiRaLPMJ8mQvR8f1X6ILwhfFeV+WpSdLsixqs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA6PR10MB8182 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-07_01,2025-01-06_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501070091 X-Proofpoint-ORIG-GUID: mxbfzpcA8aTnAPKKSCIeyzkkno3RIu8N X-Proofpoint-GUID: mxbfzpcA8aTnAPKKSCIeyzkkno3RIu8N X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EB2A114000A X-Stat-Signature: otp6hogkky7ymqi1f5wy5ggtmux7jnu7 X-Rspam-User: X-HE-Tag: 1736247624-177530 X-HE-Meta: U2FsdGVkX1+Pm19dCHjff2Isya6b41qKeGGa5KwCKLWLFY5drqM4G3YxyUkhhLT7caymk4iFvBBdVLHTTgpcjhOjlwehcq+FC49McxJ0n/7jV+vCTVoDfz2IpQTwXgDh9fpyfKdUCbOMSKmKu1kVSYIdHJvTSGpaP8I/Cf0WSekeckVOLE3/lFhg2i1elgnZyzhHfSKnifLiyns1bRA6zDlrOUc2L5eTB4G16dv/+pkOzvffDS2DMJ5jSnIdix5XYYEbhqi5HYAzOEpem2BBooP66AWWY+PDDqr/W5EirOQJOWYJrDxoIrukmbwAROzpo032y9YpnHwFh8ZEcGlC0J17qVZ9huxxDSccFfpM5bc92nvead9wK5F68QwxFoaQc639qhuqn10WeYaXbT0iV/dFG1Ut/u510RCe2/d7OBqu/VfMgarg6/cErqlK03NeVtu7e5C+h9KETf2FinEg8KZ3bjhX+8ajLnpzZpE3ew5GlTCe3FD3Fr4NVYgsdpw0UVpeqhiNHUAa0BvG8yeIKWFuVFjVO2owF6qW1VEu2PrqCpnbThJ94GXTynh+/5K3xljQPXxWZkKbUZbnALAKXEbbVJHy11emOM5qgZNR/ibLc9vWtujCjO5iiO6W769NgY/a9DRYdzC3jJL/Hy8m1JiHvHuROb37bHJurfHjqC3GRZmVhMD4Y9K8N0P0gMFdq8R4jM090OBNCtU8SimyWaC5KokBVH/YZkqfBprjLjHLEZWrvJZ9l25Vr4UJ2Mw1D9SyZy4m2hsvUzx+09d65z++wALJ4xJ+dCufGOryJKs1xDuW3ANU92M/++xlL738YvUy1GO0IcEH2GRhZljS6EfgAcvKTnZfq1kdFdWycmBF+5WHcvKETDnuHdoy2E9DpjbXbQ7dzWiuwA7TIr1Q7vxH446EjrnXfW6sviJcpbYaWePng9/HhF0hmntkTDmVNmieFJaOdNQCuvOl7W3 tFQhw5RL TA7zb+OPkXQoAiYYt8AXc7RJRuZgwqQvjyxK8DXMk3f8BR8A/cNNJ54xYs1u+5EcsqinD+X6Tq7mt9wHbX8lmH5BcSYQKL8EsnHpbq7JnJqBnR8Y0aKZclIZzZQsdh1Udq26+MRzrQH/Au/HAH9mFhjwZO0DZNnQiHU/DcSqfvZe28GaQ7EarMWWy/ek2KmuEQCOy7ifwnAZu4ng3OwgrwgU0VtJKccOERF0MP8AGeJw1i7RQpieyVreEgtDmeGELhv0ab2VLmMKBA+bPuRXOA9RmdDtgLjpLXS8Z4CciLWJ2JDiJWZQgSNhvxqbxa61mNnXJnb+qShN3O1dKe3tFb/kJ2BNcaHahB/NaKgI4S/uB8vMRcWnuzos/9DPRuxDL9Ki9uXuZ+2tAV6950rbapE3PcgVGnOzPDKgKgrtE3NQwlnTZ31BCNo1gmVV0wCewx41lf3zkNuT0AbJYyR6bbGQVr9uR4Gd7oDVzTgAnynTBvif3ihVdAMj2alNju9LPjsk5xjavL7oN3vnGedRWJr65MzQyPReg4NohO9HXsTSwyCOJl4OXQuN+DqAzYNsAB+DGhkkc52YmkocyLvVwJ5On0ZWKJ2esNuLiEVm2evkDkXycUxKQnEFesQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000072, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 07, 2025 at 06:29:03PM +0800, Huacai Chen wrote: > Hi, Lorenzo, > > On Tue, Jan 7, 2025 at 4:48 PM Lorenzo Stoakes > wrote: > > > > On Tue, Jan 07, 2025 at 09:18:48AM +0800, Huacai Chen wrote: > > > Hi, all, I like simple fixes, so is this acceptable (based on an early > > > version from Koichiro Den)? > > > > No not at all. This is bizarre - in the mail you are replying to Koichiro > > agrees with me that the approach of his code that you've sent here (I don't > > know why) is fundamentally broken and suggest another. > > > > I am at a loss as to why you've sent this? Perhaps a miscommunication > > somewhere? :) > > > > In any case, please don't send '[PATCH] xxx' mails that aren't intended to > > be patches, a better form of this would be to say 'oh can we just do...' > > then to put this code in the mail underneath, without any '[PATCH]' prefix. > I wasn't in the CC list, and I also found the bug yesterday, so I can > only reply to this email with "git send-email --in-reply-to". This is > the reason why my reply looks so stranne. > > > > > But please do review the discussion - the below is insufficient as simple > > as it is (sadly) because the boot CPU's delayed work will never be > > executed. > Koichiro's simple fix causes the boot CPU's delayed work to never be > executed, this is obvious, and of course I have read the early > discussion. And so I improve it, with a "cpu_online()" checking, then > the boot CPU is unaffected. With respect Haucai, this is not how you engage in kernel discussion. You could simply have replied to the mail or given more information, you now have two people telling you this, please take it on board. And it caused me to miss your actually quite valuable suggestion so this is beneficial for all! :) ANYWAY, moving on to the technical side: > > Huacai > > > > > I will take a look at Koichiro's new approach as soon as I am able. > > > > Cheers! > > > > > --- > > > mm/vmstat.c | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/mm/vmstat.c b/mm/vmstat.c > > > index 0889b75cef14..1badc24a21ff 100644 > > > --- a/mm/vmstat.c > > > +++ b/mm/vmstat.c > > > @@ -2122,10 +2122,15 @@ static void __init start_shepherd_timer(void) > > > { > > > int cpu; > > > > > > - for_each_possible_cpu(cpu) > > > + for_each_possible_cpu(cpu) { > > > INIT_DEFERRABLE_WORK(per_cpu_ptr(&vmstat_work, cpu), > > > vmstat_update); > > > > > > + /* Will be enabled on vmstat_cpu_online() */ > > > + if (!cpu_online(cpu)) This might actually be workable as something simpler, on assumption there can be no race here (I don't think so right?). Koichiro - could you check this and see whether it resolves the issue and whether you feel this is sensible? Might be worth expanding comment to say that we disable on offline, enable on online and we're just providing symmetry here. > > > + disable_delayed_work_sync(&per_cpu(vmstat_work, cpu)); > > > + } > > > + > > > schedule_delayed_work(&shepherd, > > > round_jiffies_relative(sysctl_stat_interval)); > > > } > > > -- > > > 2.43.5 > > > > Cheers, Lorenzo