From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2AECC4828F for ; Sun, 4 Feb 2024 19:47:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05E316B0071; Sun, 4 Feb 2024 14:47:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 00E326B0072; Sun, 4 Feb 2024 14:47:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF1206B0074; Sun, 4 Feb 2024 14:47:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CDB896B0071 for ; Sun, 4 Feb 2024 14:47:13 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6F6511602E7 for ; Sun, 4 Feb 2024 19:47:13 +0000 (UTC) X-FDA: 81755155146.28.CE8468B Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf03.hostedemail.com (Postfix) with ESMTP id 8A8972000E for ; Sun, 4 Feb 2024 19:47:11 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GllXkFrf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707076031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5xfuEOvNkpMrvgeaTj0gZfx3Z6HaCNzQxxz5WJ1g3Tk=; b=N2YApg9ftxIFxfuYtY2re3wKoEH6kBvCOS515MH+f/4g+GttkveRX0gKTC8fuL0N5pwNgX wY6UyEkK5eyvIDToRTdPgGYglllvE5aLBHqKr317O48KicQxih5utdD5+tsEIo/nJsVBkt k5Ir7lvtOvmp/7LCklZkMMqgAoGJh1A= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GllXkFrf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707076031; a=rsa-sha256; cv=none; b=lISVah6BOryNe4mnC/5TqkFcfScB1xZVR59VKvhkfzxwrWrqKjHXYBjk575cLhaoTmcpgy P8BIFrc2ZBD6pYjzxnYkJWyxiahffbhzc/cE1JdwWyF1NiH4yfN63p6+G0+7y9wpFuI/cI EUs8mv/8IqqMslgkbqPgfS5VW+V8aKo= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-40fc654a718so20104805e9.2 for ; Sun, 04 Feb 2024 11:47:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707076030; x=1707680830; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5xfuEOvNkpMrvgeaTj0gZfx3Z6HaCNzQxxz5WJ1g3Tk=; b=GllXkFrfwX1nyVm5ZI4nYAfX5CMDc9IvKzTOTwDp6eS1kIUalSBnWceId+DAgiiR3/ ygpxiwrJR375eOzVabZJECfET81bqAFLwNJKEhoddKbFMNvhQNjce5feCeM7lpoqNmSp 8jBEJJjZ3rr0jAy6nc4dlXUGMG5fM9DkTIzRuYZ3OSDFudhbobZb9R2XmOry1Wb4FG6S DiIdjkDadN+C9dXhs6EU16rXNq0wjXfkiQqcnC2KJsq6OGZZ2K0jZdwRGxGiODsYjEW8 +KMo/vyihuHid1OJyzCFaAKYkQRZhCfTpmSslucTX5nEqRbWKYvWeMAot3oD6I/vpRVv rOtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707076030; x=1707680830; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5xfuEOvNkpMrvgeaTj0gZfx3Z6HaCNzQxxz5WJ1g3Tk=; b=cEf912XQKdOUcdUJmNWhphALhRryVwfwVlKQkh6eyEc1tzFPFPx5V5bxUMQal18F+X 41P0c4b1swMU63nBbvxejVSi9cp1nWXvfswC3xMK/lp8E8LV651djM8CWNA/Y9JrhX3i /0kV4SyqSGig0x+lsuvej8jFSeqyXJs3ZKVALOnzAAahjXunolE655p6BXhlVY3ETotm KrjfmAe6yE48KkUn0Vs70xfiZILbVpaI04QglA7BYpDfvrqWbvt5F3tlHPGWg1bLERSl YhQWGFmhJVHgzVP02jLq+YFd/I0uc1pfpKPAyH2ELcIT9BqFOOkzW+yHrxPf0i2qUYwo nzgQ== X-Gm-Message-State: AOJu0YxKqxz1We1tfI0gcIZaFRo97cSTmm/EUzZZDX867gExZqcv+LTa 6FdE9kBmSnYQt0/YX+7CfBKoDJ0S5d/eY1ltGKKYiBcMnadub3Q+ X-Google-Smtp-Source: AGHT+IFJwMO115l0nbWMfn/jjOsvAs7jH6l/wfBwF/C6Y258tA8EmwObt6q49PLWRe6Gr0jvGe2hxA== X-Received: by 2002:a05:600c:3585:b0:40f:c234:1fcc with SMTP id p5-20020a05600c358500b0040fc2341fccmr3034205wmq.29.1707076029788; Sun, 04 Feb 2024 11:47:09 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVWx8pZheC091wJB9SwKMVSGQhcbLv+vOnxpwSAwPWFBeOVfqwpVU5CORd/n6wfIYic/owsO/n4VC6E9yk2TkQyRXATn4YnveOM0auQskKUl+tZkijwTZCnMhUj0aGncXc5LcTzHRu8CHSupeux5MmX2TuOYypRQmTujGjCHkkdJ5VjO2zDcY3OiXZqdBDT6M8s8qEWsdPPq31DQsXRgclFohb7oMKRSfNwuVAaNmc+SxSu0RIUmZDvCUrdaaKZNHMPwCek81t3u7e7+Gx0k9+sL6w= Received: from localhost (host109-150-53-182.range109-150.btcentralplus.com. [109.150.53.182]) by smtp.gmail.com with ESMTPSA id p13-20020a05600c1d8d00b0040fb30f17e8sm6631270wms.38.2024.02.04.11.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 11:47:08 -0800 (PST) Date: Sun, 4 Feb 2024 19:44:55 +0000 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Oleksiy Avramchenko Subject: Re: [PATCH 1/1] mm: vmalloc: Add a scan area of VA only once Message-ID: References: <20240202190628.47806-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240202190628.47806-1-urezki@gmail.com> X-Rspamd-Queue-Id: 8A8972000E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mzbzqh6skakq9aeuieco7n36o7jzo6dr X-HE-Tag: 1707076031-235542 X-HE-Meta: U2FsdGVkX1+Vv/vcOSOQgfXOfvVSsbpuiXJuQJMq7g23zRQ+1zeNY7dAhPxdmCSQC8DNYdLnvnna6IxjtlsqX7LDTy1PaHdT6SCcDgGWed7wkcbLfFaS2WnY6amUx0Ip64gMg3AWw0ryd2yW3XDpzveqCllf1MSTMN6krCFwmZQN793pA6LMNPw4VRXq39vdDvxX9tPooH5aL/pRQZyCQuug+ngXASdRdbv7DWECsJ/+KPyz0Z2lZT8+/p5itSR7NWc+zfJKRHrzP+gFy6zZyAMVHv3FhwF+0kuZpuegCbvqbQYQhtxNfyv/0EfJ+VeHQhMLvPnTVIr1PuHn5PZqmWmZVztwGgD6zihqWimFXNSfFaFPnLjsD3UrBs2s8Ybb63BrC982paxo+BM7LQWLwve40Cza8aXVR1YYv/9/GFU+TuWsx+D04SfBSc7Fq7aTq9crgo+8GblRkV+wMHK1PgqAvZeIGJjgHjnaxOpnvLaTs1/gsfkmyvzmM21mI0vfUtNwsKsOUrQ/XLmJA75K6U9x3G0di15nhB9cfDENl+PKD2h1vuOSHt/fLgGfu5KSMmogFfk8/K+s26LQ1ur6Ng/RKvIkudYlspeKIxE1Z6Il1XKuR3kvGCig7GRvZsJgPSw85ba+uDcinK+Tldkh2Z01fUjYbSaD8Td+5ibLs5GoBZkHFe1hVIQdVHhOAUd8gdP8vzCDxlmb2epLkzHsbrcUIpL1myiQyTwky3bI2cAymMeLzsuyOnA0btI9/f+KTqiPGftUalYQHdsvp56zI+mJwYYt9QsrDCDKn+1O0u4TSWZUVFANWMk7S3PF5eso9dTuP3TjnLvbGnWB3qlUSnqU9XMntu0xW+1Fg0tw67TO7rIbHzprbnCE0bZ354MNJYWw9Ucv7dFxArepgOg0ITn0onLlp1reuZ4/RfebhmYTLFOiKwk793It54HUNb2PcISyP/lkeZ3/DqxcumJ v2NAt0+q WykSPdihb03Ahm0azS80LxtHKwa6EyDs6nJtoa69tvJ8FXtX7vijq3X/MiTgHog7IYT7LnefSamfPKACquK9h9PqSsG/Slv0/Mvwgsn5zcgD9sjw+Tx9zrGqi222oEdCKFbWYovzZgtc8wgQPh3H3qWWwHpUQt3+1hO7EBWt7ZGzeoAkjowycNfB+8pWrcyFPqWNs91ONlwj/lEh0tw5zaEDm3fK74iLu7CV3KcGkzovo3/Ysg/tHnlM5FZgflZjtq95qkzj6d+qwRtfkrKKUajJBkBKps1jkjIDxxao48TRGSpezvzpk3WrtQd0ARG/5jfL37/Wdz4vOIZH0j6lIHcGqbkXcYpZ2ebmjb8Y3J0Bm5YDxS6ALa8LgNDKBBSKgOTgsEyHE7wVIGP3IUblrTFNDFc4Kz17FaXTx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 02, 2024 at 08:06:28PM +0100, Uladzislau Rezki (Sony) wrote: > Invoke a kmemleak_scan_area() function only for newly allocated > objects to add a scan area within that object. There is no reason > to add a same scan area(pointer to beginning or inside the object) > several times. If a VA is obtained from the cache its scan area > has already been associated. > > Fixes: 7db166b4aa0d ("mm: vmalloc: offload free_vmap_area_lock lock") > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 449f45b0e474..25a8df497255 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1882,13 +1882,13 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > va = kmem_cache_alloc_node(vmap_area_cachep, gfp_mask, node); > if (unlikely(!va)) > return ERR_PTR(-ENOMEM); > - } > > - /* > - * Only scan the relevant parts containing pointers to other objects > - * to avoid false negatives. > - */ > - kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask); > + /* > + * Only scan the relevant parts containing pointers to other objects > + * to avoid false negatives. > + */ > + kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask); > + } > > retry: > if (addr == vend) { > -- > 2.39.2 > Looks good to me, feel free to add: Reviewed-by: Lorenzo Stoakes