From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCEC6C433ED for ; Wed, 28 Apr 2021 14:55:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F4F261444 for ; Wed, 28 Apr 2021 14:55:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F4F261444 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AA0C26B0036; Wed, 28 Apr 2021 10:55:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A77996B006E; Wed, 28 Apr 2021 10:55:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F2286B0071; Wed, 28 Apr 2021 10:55:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 759DE6B0036 for ; Wed, 28 Apr 2021 10:55:05 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3B99852B7 for ; Wed, 28 Apr 2021 14:55:05 +0000 (UTC) X-FDA: 78082073370.28.CEF5202 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 4A8B8A0009CD for ; Wed, 28 Apr 2021 14:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619621704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eyPgVLQ8QqSzdhm5Its6lpg7OSkmtmLOaMRnkKo5XDE=; b=hSh1Ur4q5eLZznei85dAR1ejuecmGTAEtBwaJd0qT0Jjp+pt2WnUkYZHc9R9rNaFJLvGh+ oFaREYYaOSrA9kFEGGaLfYCCZ2fbh7azZh/CtQWaIhgNPM27Cmv9v/gCT7L4zKf4p0GgtM SmKkXq/aiazIo0xhhmnW9DB0PdBDxBc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-7-vtUupUwCPxaxQmTt9Jbfcw-1; Wed, 28 Apr 2021 10:55:02 -0400 X-MC-Unique: vtUupUwCPxaxQmTt9Jbfcw-1 Received: by mail-wr1-f69.google.com with SMTP id j4-20020adfe5040000b0290102bb319b87so22476546wrm.23 for ; Wed, 28 Apr 2021 07:55:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=eyPgVLQ8QqSzdhm5Its6lpg7OSkmtmLOaMRnkKo5XDE=; b=AH1NVubdy6XekR3roMLfBgr86Me7fOdhYko3vyCecDUPfdkV1VLUtNReuhsty3nw5E Y+LUgA0i4aAWdJSwHiAO2OvjtwP+G7QXSsoOQg0gaidCxlnmWSLoD4rOnMdkQGCL8Gr7 lWUo53vBhnxQ3DxGCaWZQDSdfe4cLdKSTH5tqrK0gfgX97evKKdQbYcx3nY/jQ4owaUp 8OdkPeYdHu/3j9qhHUREp7xSIAJvf5wx0WwWrJXcHGZWd1nsSKoQPiX20oAMLJSpxSuY s7lDEMbFDbZdS0QF3IzdP8QrHWTgs/GrD7nIv56XhUPckvRvGypg+dSi0JHIIpVugXFT MdUQ== X-Gm-Message-State: AOAM532L+GN/GSO9dCLfg67EF6zgzt6C7dNUfqlifY6uB9P0+ukNY84I ek1ffLL5fVN/8XHzaME7zk6NThYLn5f828iy4YesO8F0mnz+huwm2x3AfxZA8XiosqemQwhmhFH iy3wzeq5qBpc= X-Received: by 2002:adf:f40f:: with SMTP id g15mr36782476wro.46.1619621700894; Wed, 28 Apr 2021 07:55:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2omIZFer/FLV7Ds0zWcKZ0aHnNOtSJaGZpfHLIOWrSUaC6cKswy50XYb9NxOeC4nsy7dAIw== X-Received: by 2002:adf:f40f:: with SMTP id g15mr36782442wro.46.1619621700564; Wed, 28 Apr 2021 07:55:00 -0700 (PDT) Received: from ?IPv6:2003:d8:2f38:2400:62f4:c5fa:ba13:ac32? (p200300d82f38240062f4c5faba13ac32.dip0.t-ipconnect.de. [2003:d8:2f38:2400:62f4:c5fa:ba13:ac32]) by smtp.gmail.com with ESMTPSA id m14sm4262344wmi.39.2021.04.28.07.55.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 07:55:00 -0700 (PDT) Subject: Re: [RFC PATCH] mm/page_alloc: fix counting of free pages after take off from buddy To: Ding Hui , akpm@linux-foundation.org, naoya.horiguchi@nec.com, osalvador@suse.de Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210421020426.5914-1-dinghui@sangfor.com.cn> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 28 Apr 2021 16:54:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210421020426.5914-1-dinghui@sangfor.com.cn> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4A8B8A0009CD X-Stat-Signature: 11nercxzfaqreswzazem43ektkdqsjzw Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619621700-577306 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.04.21 04:04, Ding Hui wrote: > Recently we found there is a lot MemFree left in /proc/meminfo after > do a lot of pages soft offline. > > I think it's incorrect since NR_FREE_PAGES should not contain HWPoison pages. > After take_page_off_buddy, the page is no longer belong to buddy > allocator, and will not be used any more, but we maybe missed accounting > NR_FREE_PAGES in this situation. > > Signed-off-by: Ding Hui > --- > mm/page_alloc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index cfc72873961d..8d65b62784d8 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8947,6 +8947,7 @@ bool take_page_off_buddy(struct page *page) > del_page_from_free_list(page_head, zone, page_order); > break_down_buddy_pages(zone, page_head, page, 0, > page_order, migratetype); > + __mod_zone_page_state(zone, NR_FREE_PAGES, -1); > ret = true; > break; > } > Should this use __mod_zone_freepage_state() instead? -- Thanks, David / dhildenb