From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CA1C25B76 for ; Sat, 1 Jun 2024 20:57:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BABD96B00A0; Sat, 1 Jun 2024 16:57:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5BE56B00A1; Sat, 1 Jun 2024 16:57:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ADB66B00A2; Sat, 1 Jun 2024 16:57:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7CEE36B00A0 for ; Sat, 1 Jun 2024 16:57:34 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 02E69A07E2 for ; Sat, 1 Jun 2024 20:57:33 +0000 (UTC) X-FDA: 82183530828.22.C608976 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf08.hostedemail.com (Postfix) with ESMTP id 87B18160006 for ; Sat, 1 Jun 2024 20:57:31 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tpknI5pC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=17HFFBhh; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ca9BZNED; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=n0u95+ll; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717275451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sdwLj2tSWPNRHYkE+3C7SIZSn6lY5twCIc2iCsFfwNM=; b=0sGJBh2c2CZHfLMIeaxhq9i2mw53K/xoxhaV338nMvl9J0vRu3UERMjLWk09UK5gy7QIwo ql3tYv21AiECH6hq6ZqCHnYDsoZmsjMlJqUm6AQGH/WSLtCLxgSeiUuS9h3KPqT+aygxa6 4C2VbEPLZGUlqJYFfq+1doQX/LlIjPw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717275451; a=rsa-sha256; cv=none; b=XBKpIq+Zg3RbuczLAjkDaY+qjxcSELtlGiEoDKBKiDebm1OGjkZt47KU3ItRprS1Y50dkn rIhsNh+lz2ofzKQ3vpJ3VdEZp7PCrXE37cOtUAlMjEtvowaTLvqx3lfsLieplH3CZ1+vfq cBpIdJFTjbfuJuc1qpCYHGvdLSRdJf4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tpknI5pC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=17HFFBhh; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ca9BZNED; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=n0u95+ll; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DE4BE1FEE9; Sat, 1 Jun 2024 20:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717275450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sdwLj2tSWPNRHYkE+3C7SIZSn6lY5twCIc2iCsFfwNM=; b=tpknI5pCyrN+tGi6dibNCwO/BkeEgWCtHethdmF3THSqZfZF/1/CgAMt5WB+hGp5LQP97p zBSXoipUbdS8pT6FbwML/EUHueDFWMK1VY2GeFI3oJzZbuMYp9zY8BWALhvo17l0N7PqEX DzWhr6oYEhgyhROB9tpEdbJi7kQW83U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717275450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sdwLj2tSWPNRHYkE+3C7SIZSn6lY5twCIc2iCsFfwNM=; b=17HFFBhh4Ul/dDi3Zdi/u0u2X9H0e68qPFVOx1G7S1Y5e5AOv3c1Ci3Vmc86SFyX9dFlay l4Eu1BWI3nEeSuAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717275449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sdwLj2tSWPNRHYkE+3C7SIZSn6lY5twCIc2iCsFfwNM=; b=Ca9BZNEDts/a/va7zEWTVUH/mGZ7SLs5vPuuMjFiGsJkD3AWQc+qn2mxZx16ZE9qUlIQDt g+Rdp/jF3VFIBanR8bqEo8a8hcTIiWM5cZ7BugEgld9tByCPPZRh1rZEcN82s+BvVMI0g9 2mAlgcb/kIajOxAgweBAEFA6zM4l9bM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717275449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sdwLj2tSWPNRHYkE+3C7SIZSn6lY5twCIc2iCsFfwNM=; b=n0u95+ll0YnCbLbkSfdozk+of17rlI8cH8DQQfIyWSm7t39n2Z9khEMyyHWpWAGQSp1jtb lGtqytl3W+U6LZAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ABDCB137C3; Sat, 1 Jun 2024 20:57:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Z8NOKTmLW2a6TwAAD6G6ig (envelope-from ); Sat, 01 Jun 2024 20:57:29 +0000 Message-ID: Date: Sat, 1 Jun 2024 22:57:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 3/4] mm, slab: add static key for should_failslab() Content-Language: en-US To: Alexei Starovoitov Cc: Akinobu Mita , Christoph Lameter , David Rientjes , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Steven Rostedt , Mark Rutland , Jiri Olsa , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, LKML , linux-mm , bpf , linux-trace-kernel References: <20240531-fault-injection-statickeys-v1-0-a513fd0a9614@suse.cz> <20240531-fault-injection-statickeys-v1-3-a513fd0a9614@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: 47p1763npapqatrqrn4hxdmkxim4modb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 87B18160006 X-HE-Tag: 1717275451-504514 X-HE-Meta: U2FsdGVkX19LnZKmn/qsndJPWKADxvdNw3fByIy8rwgP4Qi1Qk4th0nB6orlf+evG/5Dvclp0FFuITCr0dEkLBEidvshCR8Y1WahdYEIs1nBONDl6JCl5FglH7emOXVY0PtiMixyCgTE5Pk533Am16g+etQC6ZF1LSXkGHiPXIZmBwqQKrsneNbXFzjZPUGmqmZdEGI2tWBHJGDVWylMBZIOnyB7KjLICQlYD2rFM3oxvyhTkPofGpLAAC8aJP5GwBHQJwHXFb6Ax4stAI3wNUOCo7Qf9jrGnmRDWzTSa1xd2yt/L1nrTlOZaNFOhH7Qyxs62qa6ikxA+rdR4uHEzGxXXPbA/QGqjegGtU652DbxSHla8clKOW/RzKkSvf0gti5EMtv7UhoGN5h4yiQAYMQl3CXK/E5Kn7bmV311ix6Q9D5vNHXHLlkbbG1pYKhRq6Yii+O7JwRPYk/gIEv2pd4Grz6tPnjESFtdR4NsUpyrVXJ8VbhAlkKZIv830H/GcEGlN6WvsE8EJtzVSrivD3HkwqWlmP+L3uMD8Pft1faeMwayCwiaUNGtNEIoiXzxmiSrJ5XmXFoMOZgqfD+IQmLvuZkA/qLj4pGEGOQbLxxHXJfV4NDl+cBCwg7LpmeVbc0FmthrLBxDhx7SUA4qZwob2VYEt7FMlE+8BKefytguId8xk1coJpZCKIT+vEHoYWo9XatT0sT8zDKsSp8xzGdeWtaYAx9zJS2svJJ8PAOyLo2IlF/yEf1WlRPVAzRySigwCJ820oxgAUX9brlTXdrZ4W7eFZMMWp+1NoVjdtx026vxihKYwn7GjRfXrKuwu3D379o8adYa3hk5gI1ZUwllJu3RwK9Gv+pTsN953NgxtCGlHf/L602ElHxO9zHq09/ym3bE5NV4RjQMVwLmqJFCO30rIeMEKQoqPGv6JhC5fH9ymu77GhLTfaKzC96WaYeIrUktlIvYxxrgNoH n39/iO3I js2Yl1GGBqQM0jgc4ydMf5zSwotbMZG+aaRgN+V/otFP1uwF4R+LTsUXY7j5JJUYvF6beVkPxDhKtvnip8Ks8C2yq4IZjqV5Lwn7jySfbHh+eZRHP63wXABKSuDj7sUWmhCCnuYEo2LoeG/T22dS+lTK4/Tj68QcqEMo1nMUQ0D6utn+ADRVzOF2GuHAr5S5UAzEa2GjFO0JRXW4khhWCrMbTg3JPI8q7pla902HaU8s7UpTbgi+494F6Qr78II+epEwXlmdgdEd3ozcZBQz94rCg7TVw5/dO9vGV3kwe56LdRANWd6iMGfaiChN8VTdqh0jFO46P1WN68nFTc+x6weLwseaVyiXbxD6KoTadZ+ktKG9cFG7B6r9NfVby1WfSRTdAhVDnlKApwI0XbbUDxfTN/FvThiniFdWsFzhUmmjZZ6dhsSJl5+0BfF3iAf6iWutA2sZFfbK/BLtaIx93KjOkOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/31/24 6:43 PM, Alexei Starovoitov wrote: > On Fri, May 31, 2024 at 2:33 AM Vlastimil Babka wrote: >> might_alloc(flags); >> >> - if (unlikely(should_failslab(s, flags))) >> - return NULL; >> + if (static_branch_unlikely(&should_failslab_active)) { >> + if (should_failslab(s, flags)) >> + return NULL; >> + } > > makes sense. > Acked-by: Alexei Starovoitov Thanks :) but please note the cover letter where I explain how I need help with the bpftrace side (and ftrace, but that seems sorted). Without that part, bpftrace will silently stop doing the injection as the static key will remain disabled. > Do you have any microbenchmark numbers before/after this optimization? Also in cover letter, but will include it in the patch commit log next time.