From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C68EB64D8 for ; Tue, 20 Jun 2023 18:16:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2931E8D0002; Tue, 20 Jun 2023 14:16:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21C878D0001; Tue, 20 Jun 2023 14:16:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BDD38D0002; Tue, 20 Jun 2023 14:16:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EC8E58D0001 for ; Tue, 20 Jun 2023 14:16:23 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 94D12404DC for ; Tue, 20 Jun 2023 18:16:23 +0000 (UTC) X-FDA: 80923931046.17.A66F00A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 7343840027 for ; Tue, 20 Jun 2023 18:16:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HzyKSuS6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of luto@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=luto@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687284981; a=rsa-sha256; cv=none; b=H2mOSTxBUg9Ipntk735qFRfYrNYj8qUfpNwz5w2iwadvj7wEo6IRiB6ZOpaDmommSxz+fE KUL5jx7OHGyEive1v0c/mPKBn6tp0Fs/1mPVr5cmhbOg+xiTVB/BpjV76tbHyXSQOYjdbB TxiN0aryRmwekar/YyGxOkjorMNZYt8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HzyKSuS6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of luto@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=luto@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687284981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TRoV2drQzYFdGEs4OKJ/O+257ZaY1o+ATiXwWVNWKxA=; b=1QT/mcqFdRPsz0R/amYXQRspLKtBZJ53gCodR6x/+Yj6yyQANtX3784e0PENJwmdz4hVLR RAgjVpWlpwE/vUw935MrxPn2KSxtTiFcUwJ3OEMndCRLylJHfuGr5GQlBw4d9zo5duJ8Fk BP9us+QSw409TfEI1OcxW4iOUrk4/2Y= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 90A206134C; Tue, 20 Jun 2023 18:16:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9529BC433C9; Tue, 20 Jun 2023 18:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687284980; bh=8/x6FlS2rdNYsdrdl/GrGUwfaFDrHFmp22LUn9md4KU=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=HzyKSuS6Rvzj9LJHbW41RA3tTfiERV2LElnMulbM0jOTGlMbCHbEWUXUHdNFoO388 mjXw+NoYnVhjwr0fL7/11n+AuaNt5xUzSnjAIhQjwlHflOjfbP8y6HHHVE8//uNEWr oYAt6c1ZgNG8nOJOVbpiiVKJyPfqgEz/uKg40ExaglW71HwvPBwB6SPfGJiEcEex7Z z5UTlpCWIa7VnEPVS9w9KIbVrVCZxORZxXD//6CymjGD1A+I/E/J/I3cRHqcbDR2N1 By5HeAMstlV4xK71qUyVjLtLZKNuwXSelKmHOSuX9I15MpoT/TW7dAthwt/7v741Rk MGhtj/zvkzpcQ== Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id 8A0FB27C0054; Tue, 20 Jun 2023 14:16:18 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute3.internal (MEProxy); Tue, 20 Jun 2023 14:16:18 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefhedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet nhguhicunfhuthhomhhirhhskhhifdcuoehluhhtoheskhgvrhhnvghlrdhorhhgqeenuc ggtffrrghtthgvrhhnpedvhfeuvddthfdufffhkeekffetgffhledtleegffetheeugeej ffduhefgteeihfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpegrnhguhidomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudduiedu keehieefvddqvdeifeduieeitdekqdhluhhtoheppehkvghrnhgvlhdrohhrgheslhhinh hugidrlhhuthhordhush X-ME-Proxy: Feedback-ID: ieff94742:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1671831A0063; Tue, 20 Jun 2023 14:16:18 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33 Mime-Version: 1.0 Message-Id: In-Reply-To: <20230620180839.oodfav5cz234pph7@moria.home.lan> References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> <20230619104717.3jvy77y3quou46u3@moria.home.lan> <20230619191740.2qmlza3inwycljih@moria.home.lan> <5ef2246b-9fe5-4206-acf0-0ce1f4469e6c@app.fastmail.com> <20230620180839.oodfav5cz234pph7@moria.home.lan> Date: Tue, 20 Jun 2023 11:15:25 -0700 From: "Andy Lutomirski" To: "Kent Overstreet" Cc: "Mark Rutland" , "Linux Kernel Mailing List" , linux-fsdevel@vger.kernel.org, "linux-bcachefs@vger.kernel.org" , "Kent Overstreet" , "Andrew Morton" , "Uladzislau Rezki" , "hch@infradead.org" , linux-mm@kvack.org, "Kees Cook" , "the arch/x86 maintainers" Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7343840027 X-Stat-Signature: 69b8ow7pf65155bzgsp919sqhj6hfbq8 X-HE-Tag: 1687284981-548831 X-HE-Meta: U2FsdGVkX18Sg/bPW7FJj7wRs4UR7QlkzB/21p9JKlWAYPQkq+1SY4iC4qnZLi00Jf4ImQkUIDY/gKSlVPe41bpie2jaj8NF+Hxg1QyaxTb9WWtANp8qE/fqohXCX8itrlCj5J59/FX4iqCikB+6tPGIWjyk9gm850ScB/+q6ne/oLLIX4N8SrrrmKeQGfx1LHMuWlpoKxqufK1BQV9dN9CVBLKvnri7pmJ/lwgDsjQCjl4gp5vB369GL2yaJX4sPbUM9GGGdv0ouUhFpKtpX0SzBd1RawqLUKXk8CJmPsh7DORRfdP6zvBIBX6d+87+kvNwq+wDGkWX94v+7bqjvHOIBIXYgwOQKo/MjyrjifT08WaTpLLyFkchpjb1ljNSD757+t44+UiXG3q0OQPNpyp76CaJny7WJ5qw09Xt7Ytm6cQuE1dywXy02Ahf9z69M5WVgaHoCYtnw0l2ck1wk49EtxDQvZsI0n26W1oXBGZtABWOtlLCNgGMu43ydqGGInKGHNJZXy35kXKPdatnRd1QbngzAKBi//qFi3lVKY9KZcAxExgcyKLI0vwq0J3Rg+REOJY69IFqLvTXKM177AcFmXJBXMlixWlf1LFYg9fMojf254JaVccKjNw/MyhyC8kBOWj0B7XxZUnj/MtAZ15mh31KbSGuKZAWtXMXtze2VuCFlF8ZHhYcl5Q3W4IOrkXnhIOr18A3KWHD6VgAfdGR++umYwb2iHY0Ls8rSMQgavKQGAHV4R7agLGYkKENfHSrRbNaqiwfHl7Jj006wMC5/TiS7XAwwWmLz2JDm6EzNVyA8K1iA6E9vMy9O2zbpDbKxLkfND2H2pD5zZ5uYlDY0s3ik83LlOI7GOIhjJmHjPqktJ3BPv453MljOMYJh/031kpGWDzfDzBwWv7BHlPBvMuS7O7GKrwybQp3lJ40qeQegMrxX1bawVmOqbmA/xsuxGDU8aHo+sBOm+/ 0kVgFOuK yuJe4qNG3vkOnqXqgG4V5/5uQvvldZ6nyVbyX1ndR/qmGNGKE36fWb6++6HKXR/Y1rNTKNasQquBRaDPbZ+nghH3MiB0OY4A7i48FMz0RZeUGFtaCgWda/OvOcsDIL0HdPrOu/g68mo5vfcv0GFTIl71QgxXf0pQUUdJ8cvWZpDhJRjnv1P8nK8v/IWXoBLhZ+0YLa8uTe1QOfG+ztdiny4eV1IcCZ57JqzZyWSZz++p0FlSMb9Big4eTDANa9IuVqsndyRwztCEeT3RUxbJAe0MpyGH7GTKRzjM1hyTUHKAx+OzwZTQmBydWnXmOHLjCdRyPVLrexBKFdn7QOEOHkbb7IhQURf/70fQaCNFpPX4/bfqvY04scjyO/IWXvQb425TJq0LlKUw2S9mNvqwhM33mMYpHB4Rz4oMw347QA9UsZDTkNfBIzohLu0zKn+sCLQ/Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023, at 11:08 AM, Kent Overstreet wrote: > On Tue, Jun 20, 2023 at 10:42:02AM -0700, Andy Lutomirski wrote: >> Code is either correct, and comes with an explanation as to how it is >> correct, or it doesn't go in. Saying that something is like BPF is >> not an explanation as to how it's correct. Saying that someone has >> not come up with the chain of events that causes a mere violation of >> architecture rules to actual incorrect execution is not an explanation >> as to how something is correct. > > No, I'm saying your concerns are baseless and too vague to address. If you don't address them, the NAK will stand forever, or at least until a different group of people take over x86 maintainership. That's fine with me. I'm generally pretty happy about working with people to get their Linux code right. But no one is obligated to listen to me. > >> text_poke() by itself is *not* the proper API, as discussed. It >> doesn't serialize adequately, even on x86. We have text_poke_sync() >> for that. > > Andy, I replied explaining the difference between text_poke() and > text_poke_sync(). It's clear you have no idea what you're talking about, > so I'm not going to be wasting my time on further communications with > you. No problem. Then your x86 code will not be merged upstream. Best of luck with the actual filesystem parts! --Andy