From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 745EBC021A6 for ; Fri, 14 Feb 2025 09:29:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BD906B0082; Fri, 14 Feb 2025 04:29:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 645A96B0083; Fri, 14 Feb 2025 04:29:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50DF66B0085; Fri, 14 Feb 2025 04:29:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 330DB6B0082 for ; Fri, 14 Feb 2025 04:29:29 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DD7481A1FDF for ; Fri, 14 Feb 2025 09:29:28 +0000 (UTC) X-FDA: 83118027216.26.EDAD583 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by imf04.hostedemail.com (Postfix) with ESMTP id 10ABA40007 for ; Fri, 14 Feb 2025 09:29:25 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=pdaduCTi; spf=pass (imf04.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739525367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b6mdXYOfZ9pTQzmmFy++yT48ZTyBGn00CrwkhOAHtZ4=; b=DV+23OdvPHvmE213vJtqKQEaDWMn+6tbd92HCzx6nAuL+D/gsnj7mLJVd9afA49CNruMPy WhRhQb+U4cV+fUzvf+sNJjjNUGIlZ6FJSgTQHAnrmB/ApzWKnq2kFEZ+dPXZl4IIrN80g8 eYmDsgEzp1sIOC4dIcuzP+ITiWb79Yc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=pdaduCTi; spf=pass (imf04.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739525367; a=rsa-sha256; cv=none; b=WvvvsiiK9DPT2LblS2vn3edm78TJlBOzhYb7fk/zXhb2PNIyLw9VzcbdXdFUlr/tmwZ2Gj LF++vdFZz0KQ5/DfDeOFkVoRH+CyBoATUfaI7Op2P0hFDVRd6ut1efUOT1KC0uXrRu+687 Q5RGC/DQq0+n0n66B+HY75mukBBw59A= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1739525363; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=b6mdXYOfZ9pTQzmmFy++yT48ZTyBGn00CrwkhOAHtZ4=; b=pdaduCTio49Caiuk75ArWg9RcMmH7nrE1dk1qdwuQDqeEd1/NOT2ST1kjUoOsxYA+tI4L/r6m2DO/fCUEhZFN4BJbuXJkYag+cxPXKxLlPTJeuEglbBvoeQagceR3wX27Te880oj+keTnoIpIEwJFnPYiTYTn5wu8PcQTjyCDAc= Received: from 30.246.161.128(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WPQRTw-_1739525360 cluster:ay36) by smtp.aliyun-inc.com; Fri, 14 Feb 2025 17:29:21 +0800 Message-ID: Date: Fri, 14 Feb 2025 17:29:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/4] x86/mce: dump error msg from severities To: "Luck, Tony" , "bp@alien8.de" , "nao.horiguchi@gmail.com" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "linmiaohe@huawei.com" , "akpm@linux-foundation.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "baolin.wang@linux.alibaba.com" , "tianruidong@linux.alibaba.com" References: <20250211060200.33845-1-xueshuai@linux.alibaba.com> <20250211060200.33845-3-xueshuai@linux.alibaba.com> From: Shuai Xue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 10ABA40007 X-Stat-Signature: 6jr8i14xd6ghi71h9dcz55oksxygiuaa X-HE-Tag: 1739525365-111306 X-HE-Meta: U2FsdGVkX1+HdsRiF/biDNwvPausnoWv2Z5p/NgYqtMNzvpMfbkdU5+Fnx6Nj+ESk1x0RBURstxsqQnI2ayxL3qD4JysGPG9Srtgd2PFLbmQojh1gIgY1s975/t1i6vXl/O+D0UIfA6tyoAjFtVasUkjsJKgCTBr0TivYoHizNLZfqnDPj68ihxG5C8PsFH301k8KolokW4DpIOt78Da7nA8NosNfEqIoj8ZGGD0foKU4QX8nc2/Wd8OMVww9aih0plxkXonBEBId0Mg7AdggKxRsOdU+Rq4BBvdy4579DuKs1fBXiiSSur7XgCZsp3baVWdLDYUpzpXYxtLW46+Sy69vYvqNxbE1uDSBg+2KbPos4BjTxjv/KBNpk8kQ478VOwFI4XKN3o1yDxZyqOzqNdPVOK6pSV6BBzZhgwb1VRZUuEjxTuQ7ODbNvlVOVVHbC6X/9Homs2suOUz3Zq4eQMB6ywIGiDg5iH8WjSa9IIFnZS8QW8SMjNRSiQSQBUNeeB4zo3o0K7cQZwdo7PMqKq3sjZ8unb6hr42CQCQCvOmtRW6y8iB0YAXoASfY5uqoCtrckG7L1y8tLAgpfLMRtb8V3fziEiM8rvPUZuH1xZa2LxrJ1dx+oLHD3hAE5A8AKLXYIctFR4XEwYUCPnbUZfDru/EYi7rb/tYdALJgFKeCEVNL4N1uA3BYz2ONgC2zDsIpaNEykBCL/k1FoAiPnuCk12o0JuS6hL10IsDJ3xAM0IZXZIqmCyQSW85Vu86RwHrEHKVhkPYIxXTvP1VMqJ2Jm//AQrMRldWoMH7QLWVWakGfQpfm2bSsDkMzIJQuXa/mzgL8PtE96dafs81HrW62wQaPKgyWm1smQzQPpR+RsAanZx8td7ym8mLWwM5nzN7pRnETxgzU0dDx6wJvIK064Qqvx83KrM+YTuzGn4eR8WDaX8mO4cUDQInepu4da6WAd6B0DRIA8Pm/qA P9S2RmaE cFBF1KMceLASmPD9H7XmPCD2q1gEUq/qGWapomPaKrCCDX2gJKiXBCKbZlQydfY8+q20jvng80ZLKPtcA4s/AJyo/aYYF2Lwoerqq+7liJ+OGhUuFYjkLosdo59pMTHHFhOTmEI7ZhwMOYfUoKD/ywK5IVOQO9ej6GBSvXT4n51cmFXVgD/H0Ph0BgWe/clHYE9NnoM789y9kch8XZiSngeGSWUNoT4gE1I836H7Fciuo5UDfrxxC4G1rxGxnZzFtGWV9CbETKOLTiLpbdY+yDNjnOF70hlr8sKFFUumo0SDfV00yqjBJKRhQMQDoQqwF+H3aDJsxVFBzWxAvMRGHf3T+X4coxZvRlQU/oo3jd24ZY4fJU6qyfII2LrDUq2dtThWuF+b2mgO2LR5Zcii1p4DVTdMR2//02GRZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/12 00:44, Luck, Tony 写道: >> The message in severities is useful for identifying the type of MCE that >> has occurred; dump it if it is valid. >> >> Signed-off-by: Shuai Xue >> --- >> arch/x86/kernel/cpu/mce/core.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c >> index 2919a077cd66..c1319db45b0a 100644 >> --- a/arch/x86/kernel/cpu/mce/core.c >> +++ b/arch/x86/kernel/cpu/mce/core.c >> @@ -1456,6 +1456,8 @@ static void queue_task_work(struct mce_hw_err *err, char *msg, void (*func)(stru >> if (count > 1) >> return; >> >> + if (msg) >> + pr_err("%s\n", msg); >> task_work_add(current, ¤t->mce_kill_me, TWA_RESUME); >> } > > This is called from the #MC handler. Is that a safe context to print a console > message? It wasn't in the past, but maybe changes to how console messages > are handled have changed this. > > -Tony #MC is a kind of NMI context, as far as I know, since commit 42a0bb3f71383b457a7db362f1c69e7afb96732b printk/nmi: generic solution for safe printk in NMI print a console message is safe. Please correct me if I missed anything. Thanks. Shuai