From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C3F1C433EF for ; Tue, 1 Feb 2022 18:34:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEA338D007B; Tue, 1 Feb 2022 13:34:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A3D8D006D; Tue, 1 Feb 2022 13:34:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6038D007B; Tue, 1 Feb 2022 13:34:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id B7EF98D006D for ; Tue, 1 Feb 2022 13:34:20 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 69D148239AD7 for ; Tue, 1 Feb 2022 18:34:20 +0000 (UTC) X-FDA: 79095061080.25.F67B896 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf18.hostedemail.com (Postfix) with ESMTP id 8D1131C0004 for ; Tue, 1 Feb 2022 18:34:19 +0000 (UTC) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 211IEIg2011727; Tue, 1 Feb 2022 18:34:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : from : subject : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=SssQSsCrk2rTcLLcvTbLg39vzmjuPN/9GLdfCJo4ZLg=; b=v2XBQKdSnH81F2y8E53myjPrWFr3disk5pRdS5/zznR+12hlp+BCpdXJtp4JPwYC0ImW l2tLZPmkOjukha0g1EPF/sGprhqQL5C7RaeZcdrBz2QBHEcnGgdYmzwvJsQIsOXknDCr 6h1uQ3wTujT+16KY5Tu3gBCBtvrgy8UJSRAahm8aHIMJSsIykMW5kJjnTyLYX4zHlCD3 FQf3RbexOEL9NOCMLUZJNQwSb0WwWzsAcxQakpbs44zUiGpXDEyYk/rFl+vYRoIRYn/x BRvxl6DfUielSp/fH8hSmt8QZblmLuDGt7/OgvN9VYbWGg5eEcjlplPU5kbgcdkKGJrg qA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3dxj9wbrxk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Feb 2022 18:34:14 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 211IHAQT038321; Tue, 1 Feb 2022 18:34:13 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172]) by aserp3020.oracle.com with ESMTP id 3dvwd6pkvs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Feb 2022 18:34:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bnRyfZ9J2W/50WKeWJkgDiQSfPX4em81rw6Dwdn6OecuEHY/5CVzsscBquwbglyVN1u5EsBa8Wu16t2H7adOpvao/SRzQ1g9sotd7VXXszSdMbq3A97FPHPybWJTNFZeZYN79ojx6PrFlRyNPVGEm+7Ku1dHNJ1VuHXgN4URs0Kn/0J3/J5oy0Mf6TFF3YRbik3kc4zZUYKQOoqUt+2tlx/wXB92aHr2M76qTY96sN1GFieXVcu7B/wlVRCG5JdWMh9w5QaRFOauanjwI0vUU3dYlXag26D1alZC8dawrBOlb9KU3DSHDkmjeOx/ivcAIpaWBSAh607NVjjsrmRCyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SssQSsCrk2rTcLLcvTbLg39vzmjuPN/9GLdfCJo4ZLg=; b=g9OBZRKlrCT9ejRP2IGD/KVtsyYCLoIdhGuwS1MVicbiQgiCs9agEJN+m+culW7iz5Jug8d+NmP/PbGJYAGhFXuOnOnUe0K2lSEpOXsRAOso+ICPEsB6WRrr55RTozbRNFK6m2O6qEYMrpC0G1InP3PzoXrppbNXnq8EXp4V0yPqLE0oMudFaOJBRKSuCbiIqETJuYwKM9JOCjnBnonbbcZiL1iIPtqyttrOsLG3b4Yo+asOMK4+7jDpvqBXihD89m1ZyOCkTfGd/bhB7hnFtYRuAw0SxHEvUdRqEPl9eIPxVspazJVsUduyXD/qWVZgRfHsDw0xYTDFTbpU0nplpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SssQSsCrk2rTcLLcvTbLg39vzmjuPN/9GLdfCJo4ZLg=; b=thka+Fwt1ZFzHwy+x5ZeEAaR23uew3PnP6puRrw0wBFzGz3bVgA18jFS3Mxn9p2Pzg1jPvSelnFNvWtzYoi4f3x+qF/bd/HAprgJ1sTFaI28IWlbbV0GRWUL9sZPCD+VZp4wiJwP7LnxAtf3mSPoA+cVgQ9cmkVFhBlFOAZMOFk= Received: from BLAPR10MB4835.namprd10.prod.outlook.com (2603:10b6:208:331::11) by BYAPR10MB3734.namprd10.prod.outlook.com (2603:10b6:a03:127::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Tue, 1 Feb 2022 18:34:10 +0000 Received: from BLAPR10MB4835.namprd10.prod.outlook.com ([fe80::4910:964a:4156:242a]) by BLAPR10MB4835.namprd10.prod.outlook.com ([fe80::4910:964a:4156:242a%4]) with mapi id 15.20.4951.012; Tue, 1 Feb 2022 18:34:10 +0000 Message-ID: Date: Tue, 1 Feb 2022 18:34:03 +0000 From: Joao Martins Subject: Re: [RFC] Missing compound_head() in memory-failure To: Matthew Wilcox Cc: Jane Chu , Naoya Horiguchi , linux-mm@kvack.org, Andrew Morton , Dan Williams References: <30a327fd-ae49-7412-ef77-9ec19480626e@oracle.com> <74d4bd51-6f16-542d-9710-3c609346cfe7@oracle.com> <54f9f4bc-48ca-5c18-d923-a779c2c80b86@oracle.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0237.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::8) To BLAPR10MB4835.namprd10.prod.outlook.com (2603:10b6:208:331::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ee6daec-3cd7-444b-c210-08d9e5b16fd1 X-MS-TrafficTypeDiagnostic: BYAPR10MB3734:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /wnolkq8DjsyG4jA9t0jerGPvp+wLfzZdgy//Tm6HFicJrlWEKJsQLTgUHl8/kGSvBLtr2KaRXAMAxsYpIMbygyIhsk8ocbFVz9e/1mt6jEE5C5t1F65lomijrXJ9cUXaE8wLWyKVLBssT3XNGOF8MkxXzKeR39wafatJZiiORnI7G6z7SNsoimjhJa27t3suSWMre6mC2QR24Mc9Hk2An3ESbv2+vy1JS7gI3un+2Vl6jOwe7EL9QAjo/QUiEilQdj5oc2S1O6unmGa+8KtY6cEAXSPyqkPK83LkoRpPJIfFuSjrWR2hXnIVOV74AY3mejdxWkE8DYr9+yj+yJMqCagYOB5d+W/G3ZXRXvtkru0tPBVrylNJPPEhluoQR4NBP1yDqpi9/kMMuPmHU7FYuUOoU1LFuQgF1TuVP70ug+AtugtWidHZxPEmFlMti9HUrxUH9dLOjP0hVU0QTj2cHBIplzP5rOAmMqcTb0ZZ1BFgLkV2lwNp39wuj0FmeR1T0AQ51VBHeJEoebpf4S+sspyIPLRlzQ5dSu1V+nqhPWFjHFP0VgayfIf91p+8RtZCkUha0ftN5Y0CKTHQjbG+OOuaB6hkx9QzNCzOaQdYoL1Yup4lUzjPmKME7K+KO5YcNX5B2MebZ9OCXyYzBwYOMEnpaq8kWZD4mIVCywHJ+w2tWucIIoUfh2jvH8d2kgDQcNuw502hbqO4CeOYxYJUUAON7IgmyAllc484mUUs/0x8G+dg78FlzILIA3S128Oka8me6bl2MdxXanGlaMjflk6OJDrodXH4CDW+uHVbD0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB4835.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(186003)(6916009)(31686004)(966005)(508600001)(2616005)(5660300002)(36756003)(6666004)(38100700002)(316002)(6486002)(26005)(6506007)(6512007)(2906002)(53546011)(31696002)(86362001)(8676002)(8936002)(83380400001)(4326008)(66946007)(54906003)(66476007)(66556008)(45980500001)(20210929001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1A4bU04VkdpclphaXgwdGpQbW5jalpnTVE1dmdYS3VWY3Z3VW9aWTA5cElT?= =?utf-8?B?ZW4zN1ZHUDFCZ3BUUkdyMk5ST3ZTTkpyMG9kMGlnQU9KQm1GcisySVlRU1VL?= =?utf-8?B?V1JweXQ3Y3g2WWhCUlBhK2VUZ0FoNVhNeGxoMkx4MnlsOHI0dHB4V1FxSWpy?= =?utf-8?B?UVByY0pyN0ttT2hvTVZIOWZGQVh4dEZKSnNIVmVYdkNaQ2gweUhXLy8xRXc0?= =?utf-8?B?UUx1Vm1yL3hkdzU3MVVqaElPL0VxdU45d2g2bzZwUVFIYlNHWFpyUm01ZlFs?= =?utf-8?B?NWNodm13ZUI2NzNVbEduYmp3a0R6dU1PTWtLVEI3QUZab2NIemV1SFpMcFBO?= =?utf-8?B?WlFCY2dpZzFKZjBsVll6V3VJblN3bzZQbm85Q1lqbFVqOUloR2NGREVzcFhI?= =?utf-8?B?bW1LVzFzNCtrb2djLzRvbk5xZFpnbSsyMkN6R1QyNG9hZEpScW9tN2NuOXF2?= =?utf-8?B?YVpGV1BhU3Z1aHdMYVpaSXRIWGJiK2NSeU0rVEh4MFhBRzNIVEo1TmRIZTgz?= =?utf-8?B?OXFxaHpzeTlEWGZhaC9iUGlJWGhPRzlXNE1DUnBmUGx6MmgxV3RuamhTZmM3?= =?utf-8?B?SUR2eEFyNDlyVkNKYUVmVnE1aGJ5UlBrVUNOaVkyTmV2YUpTNytudG05T3pt?= =?utf-8?B?MlB4WmxORnF4a3dkWkI5aTR3blBQTDBDakk2aWNBODdYMVYzbXNFVnlFOVZr?= =?utf-8?B?N2w2ZHYwUnRpTEJvQUxEeE9Zc0crOG1SVjJHdVhpak5CcXhYMGJOYkNiVXVZ?= =?utf-8?B?d09KaER5bkNhVm80VzBjWjZEOU1Yc2JuN09EenRYOE1nd1Ntem5QZXZSdkJT?= =?utf-8?B?dXdxTjhCemt0bjVqL3B1bzBUU3NLNXhnZnhrWXUwVDF0Nk44SVBZYUZNTlNl?= =?utf-8?B?VTJGcHh2UTlLOHFNMy9mdjdtU2FISE1PNDhncWM1TGliMGd2K2Vjc1Z4a2Nw?= =?utf-8?B?WksxSHR6aHl3bExNTDYrRkNhLzlkMjVQSGRweHFRWlIvU2FHbnBsRzR3VnF1?= =?utf-8?B?czhpV0tONWtLeU9EWU91OUNOZTcyTDRaZ2oreGxRaWc4N0djTlROK2ZuNzhs?= =?utf-8?B?SUZ2TEZmN05JeWJKQ0ZLZG1zd2dOWUJhYjVwNThwcUREMTB5dGZTSUtIVURG?= =?utf-8?B?cHlMTkhNdWxvV0N3aXl5ZmVDbjhGUWpoZS9PQWdzUzEvaWU3cWdYV1hSUnpH?= =?utf-8?B?ZUw0ZjMzVnlmQmRXQWJvTjl4S3BnQnJBZUYxWVdsdE9VdmZpL2tGNU1rTlBR?= =?utf-8?B?YWI4VDFKQlB4azYwOGFTaitDSldDNFpDanJwYUlZTE8rU1VrR3ozcHlhTGt0?= =?utf-8?B?RmljYUIwbGNJazMwaWRHQmZUZGFPVmxjT0ZYNDF1K01FZWxBd0pBL1V4TXNo?= =?utf-8?B?Nm5WN1NuRzMwbWNSZktGUW1jaVJNdkt3QUQvZDFpZ3E0Vm0zdWZVY25jcUZC?= =?utf-8?B?U1l6cGpKWDFZbEhOM3FIQlhoelhpbWJvVUtnQmJFc0xwd0Y1eHlUeTZHY01D?= =?utf-8?B?bGpvNW1wTEw3TzBTT25mUFV1WlNIbkFEZndvdi80WEx1RHVIRGFXeFFhaXVa?= =?utf-8?B?ZkxMOENwa0RrZHQ4K3hyUDJPVGM3aFJuaEpMVVdzaFY0QjRUd2ZZc1doOWZG?= =?utf-8?B?MHcwUEJoVzBrUWpjSWdNRThSUGl0N2JlbjJ2aGt2NklVNXM4QThvNk9LdnJi?= =?utf-8?B?ZWZGYzhpMmhQOTNQd3A5dmpVUlAzMG81Uk5oS05WdGRmUkFkNkdnTnBlckwy?= =?utf-8?B?UnFIcUc4OVJ1ZG5lanA4N1NvZUU5Q05nSXdVbk5VMTdPVWZvd2REK25KcW9P?= =?utf-8?B?NmkrOXZhZ1Qxc0RsYUE0Nkk4NmsrMlVIUWVBQ2t4eTVEOFRFWVZjTTF4aVRD?= =?utf-8?B?d2g2RnRIYWJKRkRUUEZUNGpzVjQ4QUdEN3I0WlI3QjE0VzVMcFVPL2c0b1Jt?= =?utf-8?B?QXVleU41SmpXcE9zUzRvQnFCUFRiWmZTeG9JWkhKYld6SCtOdkNaeS9tc0Ur?= =?utf-8?B?K3ZWYU9SemlXNEE1bFI2TlJ2ckdFaHRDb2dva01SVDFJVlJWTW9xeEc2NWVH?= =?utf-8?B?Qkp1cXc1bnhWbGpSdnZ0U2tQYWhjeWF0MWg4UGxNcWZ3T0hZRzhRcDc1Ukp5?= =?utf-8?B?VnVDbGFBbTNTbnAwM2pCUG9haTlIUzBCNFVlck12WGNvdTEvVmx5aFh4Tmth?= =?utf-8?B?SFdPWEtqaXN6Vm5PQUlwRVNFVDdMWXd1QjM2YVdpV1dPejNneUw2Z3NhUzJ3?= =?utf-8?B?TVdLNXVFalhZbnZPVEIzaFQrSWlBPT0=?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ee6daec-3cd7-444b-c210-08d9e5b16fd1 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB4835.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 18:34:10.0281 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oyKlqjOKp8oJe3ijueNH7Lfvk4RaHJAnzouvcIVl809n+t/dgp3MydnZgiRm567odEqlfEsgxB6zdXR/GMqZ0eNYci0qwHXuWQmHvm/WAIw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3734 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10245 signatures=673430 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202010103 X-Proofpoint-ORIG-GUID: p11RQnlwQPWqdPQlmyeCCxIrkc9CmXni X-Proofpoint-GUID: p11RQnlwQPWqdPQlmyeCCxIrkc9CmXni X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8D1131C0004 X-Stat-Signature: 13ibkb5cc18dyuc81nzauksdxbdofrzr X-Rspam-User: nil Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=v2XBQKdS; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=thka+Fwt; spf=none (imf18.hostedemail.com: domain of joao.m.martins@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=joao.m.martins@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-HE-Tag: 1643740459-848438 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/1/22 17:47, Matthew Wilcox wrote: > On Tue, Feb 01, 2022 at 05:40:57PM +0000, Joao Martins wrote: >> On 2/1/22 16:01, Joao Martins wrote: >>> On 2/1/22 15:46, Matthew Wilcox wrote: >>>> On Mon, Jan 31, 2022 at 08:54:39PM +0000, Joao Martins wrote: >>>>> On 1/31/22 20:29, Matthew Wilcox wrote: >>>>>> Unless I am mistaken, you have to pass the compound head of the page >>>>>> which has the error to collect_procs(). Am I mistaken? >>>>>> >>>>> -rc2 already has a fix for it: >>>>> >>>>> https://lore.kernel.org/linux-mm/20220129021420.PgBIZm-q9%25akpm@linux-foundation.org/ >>>>> >>>>> Earlier in that function there's a: >>>>> >>>>> page = compound_head(page); >>>>> >>>>> So the @page passed to collect_procs() already is a head page. >>>> >>>> It's wrong though ;-( You set the HWPoison bit on the page after >>>> calling compound_head(), so you set the bit on the head page instead >>>> of the precise page that had the poison. >>>> >>> Considering that on device-dax we would unmap the whole 2M page regardless >>> of the poisoned subpage isn't that actually representative still? >>> >> >> To say this another way. We do set the HWPoison on the head page, >> and not the subpage as you say, but we end up propagating the resultant >> MCE action on the superset of pages in the whole PMD or PUD. >> >> What I was trying to say in perhaps a convoluted way is that device-dax >> case isn't different than HugeTLB that only wants to poison head. If there's >> a head page, there's likely a PMD or PUD populated (depending what the device >> was onlined with) and thus that's what gets unmapped. There's no idea of >> subpages being treated any differently, at least as far as device-dax is >> concerned -- unless I miss auditing some other code path. > > Using HugeTLB as a model is not a good idea. THP is the model to > aim for; one can choose to map pages askew (ie not aligned with a > PMD), and I don't think you'll find all the mappings with the current > code (eg if someone has mapped a single page of the hugepage). > Don't know if that last sentence referred to THP or DAX -- but to be extra sure, on device-dax current code you can't map or remap subpages of a hugepage. Even if you open a device-dax fd and touch just a subpage, what gets mapped in the user mm is the entirety of the PMD (or PUD). You can't even map a single random page, it always needs to be aligned /at a minimum/ to the namespace boundary (which is the page table granularity i.e. PTE, PMD or PUD). >> fsdax IIUC seems to rely more on the subpage bit being flagged but no >> functional change here for fsdax as there's only base pages there (no heads). >> >>>> I'm fixing this up as part of the folio patches, but you may wish to >>>> fix it earlier than that. >> (+Dan in case I misrepresented or missed something) >> >> Should we deem it a problem, I'll fix for the next -rc. >> Just in case, here's the diff stashed: >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index 2e2f740c63dc..661c23df8115 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -1577,7 +1577,7 @@ static int memory_failure_hugetlb(unsigned long pfn, int flags) >> static int memory_failure_dev_pagemap(unsigned long pfn, int flags, >> struct dev_pagemap *pgmap) >> { >> - struct page *page = pfn_to_page(pfn); >> + struct page *page = pfn_to_page(pfn), *subpage = page; >> unsigned long size = 0; >> struct to_kill *tk; >> LIST_HEAD(tokill); >> @@ -1631,7 +1631,7 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags, >> * Use this flag as an indication that the dax page has been >> * remapped UC to prevent speculative consumption of poison. >> */ >> - SetPageHWPoison(page); >> + SetPageHWPoison(subpage); >> >> /* >> * Unlike System-RAM there is no possibility to swap in a