From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62C6CC001DE for ; Fri, 18 Aug 2023 07:11:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF32D940058; Fri, 18 Aug 2023 03:11:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA1EB940053; Fri, 18 Aug 2023 03:11:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF603940058; Fri, 18 Aug 2023 03:11:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9C9C4940053 for ; Fri, 18 Aug 2023 03:11:14 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 68A071CA138 for ; Fri, 18 Aug 2023 07:11:14 +0000 (UTC) X-FDA: 81136354068.23.DF8200D Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf16.hostedemail.com (Postfix) with ESMTP id 0127818000A for ; Fri, 18 Aug 2023 07:11:11 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=CboI3jVD; spf=pass (imf16.hostedemail.com: domain of jaypatel@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=jaypatel@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692342672; a=rsa-sha256; cv=none; b=Vj46s7lmE+VV2sk5W/K5K+nFwTR8OMu+u6R1oV/YIdXyM48uLUZjyFQOcDQ7tZRzTdiUdf LM7HOQEdwOL/9Znq6Wq7Fil6YpgwoILHTqd+BEUJHm1AOP26XrN/UE+7RstVjt+JAbBpic PYlwE0o38GI8+zQQXJXVFUZ6xclshd4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=CboI3jVD; spf=pass (imf16.hostedemail.com: domain of jaypatel@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=jaypatel@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692342672; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KXTyljC1PGxfD7a41MS7yLuWCYN4oKOGjG0mRBwBEuA=; b=FcIx8P0vl7gc3H23IYyXtOtQfoOdvfZONzqHo8LmePlNPLHVxl2Qn4asqOimNjAJxgahzJ /mgTtRtuAKUIfXiRbPA8ptip4LavUNUd1E6Xw1zIaYVr2wZL4aXaZLWbb0yC0qJARWZdXJ 4RW7uqCXQn8RHD22249Afoa75wIVtec= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37I6wa1Q014632; Fri, 18 Aug 2023 07:11:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=KXTyljC1PGxfD7a41MS7yLuWCYN4oKOGjG0mRBwBEuA=; b=CboI3jVDTeT9aVTVn9VtQKVc8bL7uZNG/C789DXOB5tyoMMqgdU0MtrxKt7oIs2SzhTC uH04OpAXPYonbK59az5dfY67vfaAWc2+JgaZkSpW5oYkP8n6pN9ix+1hDcVtJHioJGRh D3RgPy6jiPpcsJ5t145vfl8Pfl7zQ8Hg4qGNaIHEF1k2i0ShigZrMDJhCy8LudWOH229 gPaFzgQt8bbRL9A2LaIDkIMgn/MWncx1rrqYOAdy2RG4cjGqY6QYRGKMx3zFKuodWxF/ dDEau827esFIAOT7PUA8WIj1meh15/xEQ3CQh8OfVLbSbm3tUNhUpRcx7FB0+etSKdVM YA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sj3nhgnay-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Aug 2023 07:11:05 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 37I6l5LS011100; Fri, 18 Aug 2023 07:11:04 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sj3nhgn6m-10 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Aug 2023 07:11:04 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37I6ChQx007848; Fri, 18 Aug 2023 06:46:04 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3senwkvt40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Aug 2023 06:46:04 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37I6k2M738404800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Aug 2023 06:46:03 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A780558055; Fri, 18 Aug 2023 06:46:02 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A5E525804B; Fri, 18 Aug 2023 06:45:50 +0000 (GMT) Received: from patel (unknown [9.179.31.12]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 18 Aug 2023 06:45:49 +0000 (GMT) Message-ID: Subject: Re: [RFC 0/2] An attempt to improve SLUB on NUMA / under memory pressure From: Jay Patel Reply-To: jaypatel@linux.ibm.com To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Vlastimil Babka , Christoph Lameter , Pekka Enberg , Joonsoo Kim , David Rientjes , Andrew Morton , Roman Gushchin , Feng Tang , "Sang, Oliver" , Binder Makin , aneesh.kumar@linux.ibm.com, tsahu@linux.ibm.com, piyushs@linux.ibm.com, fengwei.yin@intel.com, ying.huang@intel.com, lkp , "oe-lkp@lists.linux.dev" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Fri, 18 Aug 2023 12:15:33 +0530 In-Reply-To: References: <20230723190906.4082646-1-42.hyeyoo@gmail.com> <30b5d85348d84891bf61d7c57370d8b46df8e1a0.camel@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 4d5sBftuWBI-rcgiRv2Guppafcok5ntb X-Proofpoint-ORIG-GUID: ikHfJvHK2yjaJQ3v3PkfUxZsI8ZVdkHz Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-18_08,2023-08-17_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 spamscore=0 mlxlogscore=819 suspectscore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308180067 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0127818000A X-Stat-Signature: zgse9wytkegprrg9j5d8ww699ra8m54y X-Rspam-User: X-HE-Tag: 1692342671-218125 X-HE-Meta: U2FsdGVkX1/JtLUJfU1xyxTn6FsQeF4SfvG3fM2egefHfYGJDbj+nbOBP7BrzgS8yvlesjef6B4SKjCKRr+L6qkrdEXiAuZivMbIn6P7nhDIIuTpZTNZMJQFA8BSaw20zupPXdZR9P6Wbygh5Y7DnGs0HKHvmvGBzD4JSAiM2XD9Sw/rfPuGhXgpyyJacvm3aHvz9q4LH2TUzS9mliLTrZL22UqOVHGHM/Z3E9iGyRFdgLcTXSQmRUiEakwrwAtFPemwLeY3PtUuDwQwGkUoPqi2WYWK5XS07KFPzrHU43H5xEkYbS1z2SfYrJSuCF0DJufliZ7y5fd3aFE4GU4/3+IgI+MpyThE+InU1WG2PyHQ5PCplQfA9ZqHetcvatXz21f/SfJ9dgzSLUKNwqR49axsqo1lujo3vwmZxeBdmOUxfJ6axw3RyMQSSAJ9igKm0tHyxK8jDEXzViwfKvDN1sO++9tc7ILbZh3ILTQI9AfnRDzUdqhONGXiO/bnjyTCU7wSlYbbbaRyjXm9xUJvQJMHhbUb6wtDW9A1vh9bUUfpBycUftGSNdJ6MH/XmrKjLqP294v9k0MsbzUKOBRggbx+OQTMKFVTt5TGtTzliN5dpiaf6lpdKahY24I9doG/H2PcI42hEoIsVuN/XplVapzwbEB1YnsSZO4SrXfjCd9Jz2M3CrxLS309SaViIamPWdujKPcE9Efnu6kG2tHP7D74ik2kRH85mFEVg2vC098sTCCBV+khSy115gLuer8PXngGhX2zyY/Z5oYTUVrIgA/PBwJCjTCP9GonzS5GO1E4pW6IhWazvM/D9djZWyxwT/n3TpA7IKXbyqZBlMMshzeSNVS9NjCBKGMpaXZ4BJcCamlOtnI836RtHLJaMWRrSWjQ8g7ol7sMTvkXVrLCFAbtMzeg2Aa45Gsj47jmRyMhJ7TR0By5454bLas1vYnEkje5hkmq5JAYBAVR5aG L6Phd3po xzsHWJ7yXr4TOSQaUHvHdIM/uhg79GZc+V1SiBPLAYwTpVw7L23WsMzvmEhpVeDK81+A1Z1xKFOGCV/Rm2/+GWP/AmThsACAxWc5kfkW+pJWaljP6bTmguAT8MzW/5/geF73BmU3b8C+uifWellBjpedl5eW97OYzv85eHdlmpTvEFAUkTFD5AGAvthCvKwzuTufoJ8HSSWf4IkqQ51ZOLWO5olgd8DOqw/98GNYh7x5UTHGw11o8EfImijAc3pJWof3oqD5dMqGBw5oPSj1YmyIp109Op69EuRR1vWX8IPFumRlbqou8HbQV+gB7TCXsDJxbOzStpvSUHamE5uuSdn9z9NWO8TB+JbSeuVke34zaN7mr8/4/ftEiyV/im5UvE8smthJqzJQ6RW3FdVR3X0vRd/yfIdlqZYJTrp5LWwcf7ZaKWAg9fnU0YeNvDq2lWo63To11HaQkgiw32FVcOqLG9EPH5VWvP0xX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-08-11 at 03:06 +0900, Hyeonggon Yoo wrote: > On Thu, Aug 10, 2023 at 7:56 PM Jay Patel > wrote: > > On Mon, 2023-07-24 at 04:09 +0900, Hyeonggon Yoo wrote: > > > Hello folks, > > > > > > This series is motivated by kernel test bot report [1] on Jay's > > > patch > > > that modifies slab order. While the patch was not merged and not > > > in > > > the > > > final form, I think it was a good lesson that changing slab order > > > has > > > more > > > impacts on performance than we expected. > > > > > > While inspecting the report, I found some potential points to > > > improve > > > SLUB. [2] It's _potential_ because it shows no improvements on > > > hackbench. > > > but I believe more realistic workloads would benefit from this. > > > Due > > > to > > > lack of resources and lack of my understanding of *realistic* > > > workloads, > > > I am asking you to help evaluating this together. > > > > Hi Hyeonggon, > > I tried hackbench test on Powerpc machine with 16 cpus but > > got ~32% of Regression with patch. > > Thank you so much for measuring this! That's very helpful. > It's interesting because on an AMD machine with 2 NUMA nodes there > was > not much difference. > > Does it have more than one socket? I have tested on single socket system. > > Could you confirm if the offending patch is patch 1 or 2? > If the offending one is patch 2, can you please check how large is L3 > cache miss rate > during hackbench? > Below regression is cause by Patch 1 "Revert mm, slub: change percpu partial accounting from objects to pages" Thanks Jay Patel > > Results as > > > > +-------+----+---------+------------+------------+ > > > | | Normal | With Patch | | > > +-------+----+---------+------------+------------+ > > > Amean | 1 | 1.3700 | 2.0353 | ( -32.69%) | > > > Amean | 4 | 5.1663 | 7.6563 | (- 32.52%) | > > > Amean | 7 | 8.9180 | 13.3353 | ( -33.13%) | > > > Amean | 12 | 15.4290 | 23.0757 | ( -33.14%) | > > > Amean | 21 | 27.3333 | 40.7823 | ( -32.98%) | > > > Amean | 30 | 38.7677 | 58.5300 | ( -33.76%) | > > > Amean | 48 | 62.2987 | 92.9850 | ( -33.00%) | > > > Amean | 64 | 82.8993 | 123.4717 | ( -32.86%) | > > +-------+----+---------+------------+------------+ > > > > Thanks > > Jay Patel > > > It only consists of two patches. Patch #1 addresses inaccuracy in > > > SLUB's heuristic, which can negatively affect workloads' > > > performance > > > when large folios are not available from buddy. > > > > > > Patch #2 changes SLUB's behavior when there are no slabs > > > available on > > > the > > > local node's partial slab list, increasing NUMA locality when > > > there > > > are > > > available memory (without reclamation) on the local node from > > > buddy. > > > > > > This is early state, but I think it's a good enough to start > > > discussion. > > > Any feedbacks and ideas are welcome. Thank you in advance! > > > > > > Hyeonggon > > > > > > https://lore.kernel.org/linux-mm/202307172140.3b34825a-oliver.sang@intel.com > > > [1] > > > https://lore.kernel.org/linux-mm/CAB=+i9S6Ykp90+4N1kCE=hiTJTE4wzJDi8k5pBjjO_3sf0aeqg@mail.gmail.com > > > [2] > > > > > > Hyeonggon Yoo (2): > > > Revert "mm, slub: change percpu partial accounting from objects > > > to > > > pages" > > > mm/slub: prefer NUMA locality over slight memory saving on NUMA > > > machines > > > > > > include/linux/slub_def.h | 2 -- > > > mm/slab.h | 6 ++++ > > > mm/slub.c | 76 ++++++++++++++++++++++++++------ > > > ---- > > > ---- > > > 3 files changed, 55 insertions(+), 29 deletions(-) > > >