From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A582C61DA4 for ; Thu, 9 Mar 2023 10:14:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1CF86B0072; Thu, 9 Mar 2023 05:14:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCE6C6B0075; Thu, 9 Mar 2023 05:14:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9549280002; Thu, 9 Mar 2023 05:14:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A73936B0072 for ; Thu, 9 Mar 2023 05:14:38 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 813FB1C656F for ; Thu, 9 Mar 2023 10:14:38 +0000 (UTC) X-FDA: 80548950636.29.6648C7A Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 9C25640015 for ; Thu, 9 Mar 2023 10:14:36 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=PWwo0aIU; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf17.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678356876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zRjlS/x1jsvYaRzB7frJltPlqGScRQ8RsMJB8GeG8A8=; b=pXBHc/kM6ov2bX6RPXelZgeQ3+SNaBI7eKyIAlD6FB9fxxV+JpXPdAhczizxVrFu2Ru5+P wwrd6QvljOXlTdq/egRT0wHCFWWceeyac1GY49x8WZxtdxh/iEju28UiVpmIc78jXnBiEA qBfS5w8195S+34w530xK37K9To4RWAI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=PWwo0aIU; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf17.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678356876; a=rsa-sha256; cv=none; b=Nd0r8NnhhcQ+2AYhdtF6SVXNRXVGPg75ePJiWbp7JyFEPUKg0l5+GQKkA3dGn2J2Pa/mMT 6c0zYv06Ape5u/nflJSC1LDO3qcnRdjI4MqdszADcATrF/bCLAVrY3kWordwJzRAQhuhFD eZAsRFWUIl5ZxDm6ypFq1AnPDOt3XWQ= Received: by mail-pg1-f172.google.com with SMTP id z10so706035pgr.8 for ; Thu, 09 Mar 2023 02:14:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1678356875; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zRjlS/x1jsvYaRzB7frJltPlqGScRQ8RsMJB8GeG8A8=; b=PWwo0aIUCjfe13Q7qlY6rxAmoK2xdmWW6koz0OWgwvKXIuMOK3o1ph+kiodD4utt4q UR35AHWkL7JXhrvaldUcBocysfrDDnrqC4NgP8JAPRp9JpnIGsJLik12ZHJtUUxIpx8m 8hZy4NTtnu5lhTzXP2gdRMffcjGEzv2p9yPv43zd641d/UI2iW94/vN1ENJfINrmWs3T fqbgjRQDGU1RUl1v023fraZEMrKlhQtrW716lBaeFNpwjGT0yzofa+bfyigzHXdSaOpl wMpd9Y3vkRwVAG3p0207+SlUXpruanA/R5I8XgOhWF+O6NVmTlRqUA3Er79Geshj0oxG cvTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678356875; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zRjlS/x1jsvYaRzB7frJltPlqGScRQ8RsMJB8GeG8A8=; b=4rjENr/D9W7jjBtPGitgLIsHzbRfbLcsKqC7v2z6HCeH/DaX4aa0rCOrPAiKRFuTJh iawxZlYqG+ya84DmMUkWPL55XfxQU5YWjVTBxFHhW7ptojIuc1P+qr0i7LxGDC1py25+ mHQ7IOOw5Qv6WLmvuvOXTIhIj4CNCb9e3cD0QcXzeqrl4EEeWs4bVg5Sc7bYOmHpTiBO cQ/J+UpV/Imglruk+I57965a4Y8MyAzzD+JkaZwsseGTvvOQbA40XRgTrUDRmKJibiJe 241iPHqwDOqHRfHl55X3OR1VpgrCfrEid1D/dx0bGublmOSWYx9mSwqetB60n7JO8lj0 k9KQ== X-Gm-Message-State: AO0yUKUPfD0NUc//8xBbi6JWvyccO70ECgaevoJjOFPwLc9Gdr63C5Xq pCGaMpYrPuLN/P6TmJO1OQi86w== X-Google-Smtp-Source: AK7set/yZ/A0txod0XKplAfsCRbSc43n6gugxtldDG+TfYxLxoPRYJn+eC4d1QtWhT3e2OJNm+5IRw== X-Received: by 2002:a05:6a00:e0d:b0:5fc:cd83:92f1 with SMTP id bq13-20020a056a000e0d00b005fccd8392f1mr20783930pfb.1.1678356875644; Thu, 09 Mar 2023 02:14:35 -0800 (PST) Received: from [10.70.252.135] ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id p22-20020aa78616000000b005d55225fc07sm10816891pfn.73.2023.03.09.02.14.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Mar 2023 02:14:35 -0800 (PST) Message-ID: Date: Thu, 9 Mar 2023 18:14:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 5/8] mm: shrinkers: make count and scan in shrinker debugfs lockless Content-Language: en-US To: Vlastimil Babka , akpm@linux-foundation.org, tkhai@ya.ru, hannes@cmpxchg.org, shakeelb@google.com, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, david@redhat.com, shy828301@gmail.com, rppt@kernel.org Cc: sultan@kerneltoast.com, dave@stgolabs.net, penguin-kernel@I-love.SAKURA.ne.jp, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230307065605.58209-1-zhengqi.arch@bytedance.com> <20230307065605.58209-6-zhengqi.arch@bytedance.com> <96f34c88-ca9a-1c3c-e02a-7c5cd1a269e4@suse.cz> From: Qi Zheng In-Reply-To: <96f34c88-ca9a-1c3c-e02a-7c5cd1a269e4@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9C25640015 X-Stat-Signature: ataboeu3orhpeywgdfi3nnr1r8toqgi7 X-HE-Tag: 1678356876-589684 X-HE-Meta: U2FsdGVkX1/lkepx/vXc+bOD2MQ8SzV4dQoLMsn1q1/S7+Ml9rEEL2I0BX48qfD8PhS07dY0ML9XIXtBOMRSLJMlLQSo0ryw0lWVkknGrqvY++cyay6lgpyApAha+6fIw2XvLjRg4ShfEudz10VTI3HEbbqCjPJhy0x5++X4m+tBUDmKpJ0/6bELwGRLp34thECFiQPgnbS1zxKyf8iU0cbkCYc2FJUP6kxoFpNVrLI7J2uD7vylwFMqGNqv4dmra2JfssGa7mVGhdbGdU4R11KejmkCfW9eEksS557kAs+uHdBOCtQQQzzuaObaxQqjT5gBwiheZ9XYjnH33AQ2H/Mv9OSILMo6peOawt5+CjcB3FPCk5LBwIMJ8s2eBiwq4NTnGIWumXOH3f5ngcO1bJgdy9UTfZgMvzzpdZgzYg44yj1e9xb1LB45mC14K1qMdcflWCckc4Hqs/7Q8Yeg+8Sa43ZGwrEe0VfVP5umdoFlPSzW/5yzm2a3RF5atLvhW7TJ0J62cB5Rair/HQv/iJo8CHtjn7WzQ7+c0OR9DnPYvhqXVhe6S0V9eVxs9zpXZL1hsLynDyN3kNPzujJ2T56K0ZTpZaUxpQaRp3WHi4j/ssxfA80rSEJzluY9i0aEj2BN3Xm8i2GRxa6ihemjkVd47mMq6N2n78PwLEZLIdzhr26nN+XDsrMBKwmnI33TNqrhf0HMVWvIa3uMwYuUBXlEHea1lWYCLOA5ar4+E8C0jwom2mnWr4Md3ti8iRyyM8srvKAyyNdxkMf/v1KGdtBYu7fPUI4g2i1GKSRdhIcA40O58fLIUTeCyiIqUMAyoEZrvmoOQYKRfWqZXjLiw087g4y97X/ot/Vnuidr3rXXc4I07iHuC6dCV3SLzUqB14mWdV4naVjLG9BkohItoeKGXVtxxxCJRSjutNMH99QgxQwDyJUARgw01z1V0Si8KSNJXaSz/bYcuF3Bpem jrTEAGLa rkk+2hEpvd0RK/K6VweLqQxO3Ra+tUkjYOb6m01CqdI3RPJW881U6ucWYRhEPcQzIXKpRnmPwuLXR2x61CkxlEh63B4eIGHX7gyONWyNQI8wR9qc6O7gCycDrsyd/tJIpQkLG7fsc9i41yNAPKrQePeoWzuqB4A9kzZ70F/aJOvGijwOtkhKkfD30cLn7KSxJY/bd1S4z3IuNHSxEDrfRmwnW4BMjxBXWL1EzrGaIjzLEYxDaqsaIpv1v1PXgSf3oJkRQOeCIY72BDwL+rI+TnFNk/KDj6+N6kQwMJDFiwwBCrwAI9Uh8ww4gDnBifBMFNXRzolGmzM1n2fsq37yvzZv5VZn4/Z+WlGPMogPYcSk1hVca2hlVDxZXFW36HSMRNCoU94p9zukSiKuNXkGSXCkMfwFm4+wjSJ9YI1agQWJnLUMdE2jmKKCdkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/9 17:39, Vlastimil Babka wrote: > On 3/7/23 07:56, Qi Zheng wrote: >> Like global and memcg slab shrink, also use SRCU to >> make count and scan operations in memory shrinker >> debugfs lockless. >> >> Signed-off-by: Qi Zheng >> --- >> mm/shrinker_debug.c | 24 +++++++----------------- >> 1 file changed, 7 insertions(+), 17 deletions(-) >> >> diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c >> index 39c3491e28a3..6aa7a7ec69da 100644 >> --- a/mm/shrinker_debug.c >> +++ b/mm/shrinker_debug.c > > Forgot to mention that this file should now likely also #include Got it. Will do. Thanks, Qi > >> @@ -9,6 +9,7 @@ >> /* defined in vmscan.c */ >> extern struct rw_semaphore shrinker_rwsem; >> extern struct list_head shrinker_list; >> +extern struct srcu_struct shrinker_srcu; >