From: Miaohe Lin <linmiaohe@huawei.com>
To: Xiu Jianfeng <xiujianfeng@huawei.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<naoya.horiguchi@nec.com>, <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs
Date: Wed, 7 Sep 2022 09:59:46 +0800 [thread overview]
Message-ID: <dca9a2ea-1d7d-7a9a-a7d7-6782d589a432@huawei.com> (raw)
In-Reply-To: <20220906093530.243262-1-xiujianfeng@huawei.com>
On 2022/9/6 17:35, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
LGTM. Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks,
Miaohe Lin
> ---
> mm/hwpoison-inject.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> index 65e242b5a432..d0548e382b6b 100644
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -63,13 +63,13 @@ static int hwpoison_unpoison(void *data, u64 val)
> DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
> DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
>
> -static void pfn_inject_exit(void)
> +static void __exit pfn_inject_exit(void)
> {
> hwpoison_filter_enable = 0;
> debugfs_remove_recursive(hwpoison_dir);
> }
>
> -static int pfn_inject_init(void)
> +static int __init pfn_inject_init(void)
> {
> hwpoison_dir = debugfs_create_dir("hwpoison", NULL);
>
>
next prev parent reply other threads:[~2022-09-07 1:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 9:35 Xiu Jianfeng
2022-09-07 1:59 ` Miaohe Lin [this message]
2022-09-08 5:15 ` HORIGUCHI NAOYA(堀口 直也)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dca9a2ea-1d7d-7a9a-a7d7-6782d589a432@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox