From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEDA7C4828D for ; Mon, 5 Feb 2024 17:53:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C7BC6B008A; Mon, 5 Feb 2024 12:53:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 379296B008C; Mon, 5 Feb 2024 12:53:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23EE36B0092; Mon, 5 Feb 2024 12:53:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 124B56B008A for ; Mon, 5 Feb 2024 12:53:46 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A5D661A0AFD for ; Mon, 5 Feb 2024 17:53:45 +0000 (UTC) X-FDA: 81758498010.30.624576E Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by imf15.hostedemail.com (Postfix) with ESMTP id A7D5FA000D for ; Mon, 5 Feb 2024 17:53:42 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707155622; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XtYMOG1SJQp8FWc8cxA6458BP2AvFjfbpz00OmkSfTg=; b=v3915syLxrivbM90Fp66nPcdtz96tEzswwhrPSJolO6o3J24BqaxIZN71KQGBE8TysRFpt hHB6OSMUqWgIG7v0+OOGd8zjnQ1A2egi8u+2oiU6/eOxafESshPz1sw96J3KcVqepRRC4R jT81AFiD1ogGNN/YbItuJL4LGIQE+28= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of regressions@leemhuis.info designates 80.237.130.52 as permitted sender) smtp.mailfrom=regressions@leemhuis.info ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707155622; a=rsa-sha256; cv=none; b=lVLa2kJZhdNfTd0RVY1rjEiBCaUuZy872fYYA2NIBZzckLdxsyrVewIqWECzs2KvoUORW4 kR++utfY3s1QlRG48Qzhu6ePN85jZU6ejtJzgKhytwPMoHOF4u2MfzIDh7J8tFECIJQe0Q Xc1k0ba9BPx3LV3kgbHSMW4dA474BnE= Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1rX39o-0005nx-UH; Mon, 05 Feb 2024 18:53:25 +0100 Message-ID: Date: Mon, 5 Feb 2024 18:53:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit Content-Language: en-US, de-DE To: Greg KH Cc: jirislaby@kernel.org, surenb@google.com, riel@surriel.com, willy@infradead.org, cl@linux.com, akpm@linux-foundation.org, Linux kernel regressions list , yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "stable@vger.kernel.org" , Sasha Levin , Yang Shi References: <20240118133504.2910955-1-shy828301@gmail.com> From: "Linux regression tracking (Thorsten Leemhuis)" Reply-To: Linux regressions mailing list In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1707155622;aff3a991; X-HE-SMSGID: 1rX39o-0005nx-UH X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A7D5FA000D X-Stat-Signature: 64rcsust7zn4ua4no5zud93ihbiakzfp X-Rspam-User: X-HE-Tag: 1707155622-45812 X-HE-Meta: U2FsdGVkX1/k76mZPo7o0qPjkbqIOMqb7cBXPCARrjaNQfLJB+fJ0xODjKlxdTJ265ArB59Z3x8Dvfsd9MRzyVXY2bXwAU/4OTn9nzvH1toGkqOzFZgJA935NbGX/N95Lw0FOL3PubXiXwx43JqX9WA9mq+9LPMw0++w+krIV119fbtTO4uZj8SLF0GFZniQuUehb+ZdL7RoTrVDTkky9FCuqcDvjyW2H6j0FRYf36S45QykyJujAOsb6AzPf9/VoUd+uMqSH4z+gEqL7/iHTt5XWjQOuBNFahSA/xhPesG4ykoTiHcXsIotPTQe2SQ3Dg3MRuyTgLvnyYEznbX6P+abnaGsjtcpF5Bh1Hu0/DkJObVOAvaGpatP3/Zs8nVR+cs9FTMZblE3IA6GgufNakdT527jdfn2fMGaqAU6UTbJ0ttN2QiBAkdDflhK0Kd77NnraBChq8ZL1azaGIHmDRlTWl3GsEnNqfazGk8WZ2+IquSQsfPA6aDWTULTZbabT2EQurzs7BnXOD8uQxWLiWaT68+IZ7BicJCaW9qiSv/hvASeka3rlJJaCR/v0OsO70OGI9BTDJ1mSB2F4tIneXJ14omM+7b8saMeGA6PUHhXFbHDMaUoUnzLB33D5zDQAn/neJa7M+E4uQ8fjrJCObImzBot6BNlF0WyJmzT4UgivYyMTXS+9b/Gv8/qGP1gfu3tqodyHsa4FHBwclvDzOvMUdk3ER/ggjF2nbZ4Rj6B68paMVSwZ8PO0EBPW9sMkwhJlIkWc+p/ujXHbdijr2erukcfX/yCH9ZihvmqR2gcWB8Q0/iesV0IIJ2TK3eux6MYw1dOswKWIwqSmKP00+TfQpRStCjXFFgfcPIS1bXMXoFMF4qA8483n5Sboi0MW03kJZfuclc6zhT15ipELV7qR+JoV3tKPd1ngI0fuPhgKQcC369f/VeI3pez4amo1sdYDjpLGt/c/c0StPa K3f8QNJk //cBGx2ZLge/4nWBt7wIFBE3SCbsArnIWAEgkZhEmj1WijbYkqpESGdkPC3peII5XvM5ENRhBTUwW06qsffHuwvnTkVlzOMvMYfgdHYYGQqqICfbw8/NM0h2rpt2C9swphweqIQYV1n/tvxQfPuKglhtHW3tI0PlLfCRWN9Dzumv30vnMVBsnSGGqqe3uNzSRDiL6rqWcT4D/LQbhHWAskYauvcflNrkFnT06n75uTZGCiCVSmLAcRp6dvZM3MQyVJY7c1JoZj2hd4uAB6kOyJEY997Jl1bWKkKbzaExltdxRQmVkKCMt9on5ZstEtJvueV4pEHohQZaDeDtx6QDQSrih2LOKRwKJNUyOrSZrLwfG6Xgw0I7q8vsfsE2GvKQNpJPH7AgV4Yui1TtI2ruArzanUk/SAi3297SJvKwKr/uf9N+HWvS4ueztV/DBcfezSji5PS1f3VEwKXKWaPQuvnV4SvpghzBiKcznezaB7vtCmnde6iy8DFoRyVQnMq7lRRgdlkoLsm6Hk7BBu2SHUmGXx9jeSt9XSQhb7nfzqqTGwDVKkXy+fvGqBwdcEU0/5iMc2AHX1vcc9lAbsVC6kdEkp6JszkX6WVRJPMqjQzyI2h6yqvrwsM6HwW6V6Y6RrVEVo5jh7z0kfySKv/Ob+0gxTreyFJEJMtrbJftNB5PLgdlQ7vvnU3259Z09hm02lqgPeYGPH8622dM7h+3QjNHBNhU17XSFP8T5kuzwx11Zkxle68HS1TbNQzz9ywG1J70QWjPgZib77jbXYzXXk3YiD7QwfpESSt86SKXncABhrP1avU/bME5RYQ/aMdqoDzbt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [adding the stable team] On 05.02.24 18:07, Yang Shi wrote: > On Sat, Feb 3, 2024 at 1:24 AM Thorsten Leemhuis > wrote: >> On 18.01.24 14:35, Yang Shi wrote: >>> >>> The commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP >>> boundaries") caused two issues [1] [2] reported on 32 bit system or compat >>> userspace. >>> >>> It doesn't make too much sense to force huge page alignment on 32 bit >>> system due to the constrained virtual address space. >>> >>> [1] https://lore.kernel.org/linux-mm/CAHbLzkqa1SCBA10yjWTtA2mKCsoK5+M1BthSDL8ROvUq2XxZMw@mail.gmail.com/T/#mf211643a0427f8d6495b5b53f8132f453d60ab95 >>> [2] https://lore.kernel.org/linux-mm/CAHbLzkqa1SCBA10yjWTtA2mKCsoK5+M1BthSDL8ROvUq2XxZMw@mail.gmail.com/T/#me93dff2ccbd9902c3e395e1c022fb454e48ecb1d >> >> [FWIW, this is now 4ef9ad19e17676 ("mm: huge_memory: don't force huge >> page alignment on 32 bit") in mainline] >> >> Quick question: it it okay to ask Greg to pick this up for linux-6.7.y >> series? > > Yes, definitely. Thanks for following up. In that case: Greg, could you please consider picking up 4ef9ad19e17676 ("mm: huge_memory: don't force huge page alignment on 32 bit") for the next linux-6.7 rc round? tia! Ohh, and btw: you might also want to pick up c4608d1bf7c653 ("mm: mmap: map MAP_STACK to VM_NOHUGEPAGE") if you haven't already done so: its stable tag contains a typo, hence I guess your scripts might have missed it (I only noticed that by chance). Ciao, Thorsten >> I'm wondering because Jiri's report ([1] in above quote) sounded like >> this is something that will affect and annoy quite a few people with the >> linux-6.7.y. >> >> Ciao, Thorsten >> >>> Fixes: efa7df3e3bb5 ("mm: align larger anonymous mappings on THP boundaries") >>> Reported-by: Jiri Slaby >>> Reported-by: Suren Baghdasaryan >>> Tested-by: Jiri Slaby >>> Tested-by: Suren Baghdasaryan >>> Cc: Rik van Riel >>> Cc: Matthew Wilcox >>> Cc: Christopher Lameter >>> Signed-off-by: Yang Shi >>> --- >>> mm/huge_memory.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>> index 94ef5c02b459..e9fbaccbe0c0 100644 >>> --- a/mm/huge_memory.c >>> +++ b/mm/huge_memory.c >>> @@ -37,6 +37,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> #include >>> #include >>> @@ -811,6 +812,14 @@ static unsigned long __thp_get_unmapped_area(struct file *filp, >>> loff_t off_align = round_up(off, size); >>> unsigned long len_pad, ret; >>> >>> + /* >>> + * It doesn't make too much sense to froce huge page alignment on >>> + * 32 bit system or compat userspace due to the contrained virtual >>> + * address space and address entropy. >>> + */ >>> + if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) >>> + return 0; >>> + >>> if (off_end <= off_align || (off_end - off_align) < size) >>> return 0; >>> > >