From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92BD7C021B2 for ; Thu, 20 Feb 2025 20:47:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 064FE2802E2; Thu, 20 Feb 2025 15:47:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F30D92802A7; Thu, 20 Feb 2025 15:47:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D83542802E2; Thu, 20 Feb 2025 15:47:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B34C92802A7 for ; Thu, 20 Feb 2025 15:47:47 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 391EB142EE6 for ; Thu, 20 Feb 2025 20:47:47 +0000 (UTC) X-FDA: 83141509374.26.2903E96 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 9DFBC40011 for ; Thu, 20 Feb 2025 20:47:44 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U2Abcr6L; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740084464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UWa/VI5uRsZXHuQw0tps/qrLYGstCupI7xowb98dNUo=; b=aJkYpptz07j6g1/5rBFFArjYqWqrdBo/4/Qer8wbHTPpEGvDk+o8ETvmo1pRneYsUwjXM4 S4FGDjoqf7c+rKBqpsOQYJeGq8o9uGdPCvYV0LxWzER5dvWdgdZ0HO4MW+iW2oGhTGALyQ Lrq0J1Ee4bx3Hy713EqtptB8WuRDRyk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=U2Abcr6L; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740084464; a=rsa-sha256; cv=none; b=qBhw1cg3DQ4HZ+/jTQWFLPY4kab3SA7dDFHd/P60SWkw8c8EgheccbB6vWFAG9Son8aVyh ocs8aHSvMNzQa0yAnNQVwvV5uZM5/6QI4O7oatCYzbpIm7jwNpWviolxe5t91M4sYMarSo NrY/YvGEEP4rUFZ5FJ+WCT/IypuSUMs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740084464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UWa/VI5uRsZXHuQw0tps/qrLYGstCupI7xowb98dNUo=; b=U2Abcr6L6GTt4cE4lWGZZMfp+vLZ99wJF6UsHWcz5L8fjZNMu6HtgapDS7sAyTxwFNYXUC Exmi4LYTIJhhVTUHnLYznK9tOvIbF+DPJoDj1xDG04RImUb2/1FtHYUKcJvcPwukmqZLDw lo2CO9RfQuBaUKrHPvHYTUcrIaovcZM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-536-YYYduxrxPAKWeG6mdZCrdw-1; Thu, 20 Feb 2025 15:47:42 -0500 X-MC-Unique: YYYduxrxPAKWeG6mdZCrdw-1 X-Mimecast-MFC-AGG-ID: YYYduxrxPAKWeG6mdZCrdw_1740084461 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38f2f78aee1so653176f8f.0 for ; Thu, 20 Feb 2025 12:47:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740084461; x=1740689261; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UWa/VI5uRsZXHuQw0tps/qrLYGstCupI7xowb98dNUo=; b=ayCOLKKPZrxCU6X0FB8Rj5sj8aZAFAkLMy9zGz0s0925L2WMFsWYiwFLnTjCcc7twG V+V9rUpEhGLs5GR4Cj9gWIBbJzlYD+ve915QmWK0LnWeyXEEi9ZG6c6ztTKNLlY97fKt J7mKETCWoGU9lKJGzLhF6UDIGp9bPiNnwu4YQ0rCr+r+q2ldpw+H+4lfYIvTkCBpqrSv jovTbW+AHTQ7hKbQbv4aASr6m8Wm37u6EBVwrQd+y49arPvd+Cj7MJzPLcm0YjdFGiLR n7Iq3dd+T6zWfDEAYXCL5M0+3ckaW+8apSHgwXFAFqCUP70pVsjUYF0ODXfjwa4UXa4x 273A== X-Forwarded-Encrypted: i=1; AJvYcCW8KEXAgW6EowidYmdtZc6CUlOWFFmRNy9jsvkjzdFplaKZjn6xXK4mVdGhMDUGT95t9sjFddJKQQ==@kvack.org X-Gm-Message-State: AOJu0Yz1Ryy2hhLo4NTqsUqEQrQvpbHUDqRPQhHrRUou3G6UQMAtFcn7 FAD677SoR6JUOn+dId6zfPXs3RW5g4rJIroEgQlkKZX/abfVlVlJr/xf8d3ApegvDkOQ9eqBsEI Rw8lXWKDAFQUbgiIO+rdKHIXRihwjx/sPML+Qm7hzzqZxeVvv X-Gm-Gg: ASbGncsAn3hlGN+U3vqj5GBiK9p2rA7E7i9/PRWBY6iEe6Mu/tS1I+VPsFL0hL62HwQ KH/9jNdecuOnniLopUEbG7FZ/+PdNIRIaQoSwKcQomJx1PSJSJ6lkMicCSSSl4dcPOuOPt5b4X4 Ol+lRoCUepU2N3wxhD9poEbvIgul9xUBciAQ8trzvwaUznoCX35AEEpdQc1xmIUeHH1LRuFl/86 mhFPgakf5EaBVyPLMQIdhEZYZoYnHEYJJaFf+bizU9nf74C1R5C2CrM1ooKQp5o6WLevLGjcPbo J1UJJbh16AdbrhHBrLqdyGvIbmn3KXalOgYfrY0EnhLPSzZbCUIBVJ2O6ViilC9yGpiIcurfmTT zgbpV5ClRLR+PcVzLAlCAusyhsFX6Vg== X-Received: by 2002:a5d:6c6f:0:b0:38d:df15:2770 with SMTP id ffacd0b85a97d-38f613fa36emr4305989f8f.0.1740084461435; Thu, 20 Feb 2025 12:47:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IED5+c6tEW/Vsfn4MBjvvsy6NZ5D+6mydxsFRFN0iSZBXlvCjjfCDLrkxUMrvOiiKXHvUtGiQ== X-Received: by 2002:a5d:6c6f:0:b0:38d:df15:2770 with SMTP id ffacd0b85a97d-38f613fa36emr4305974f8f.0.1740084461094; Thu, 20 Feb 2025 12:47:41 -0800 (PST) Received: from ?IPV6:2003:cb:c706:2000:e44c:bc46:d8d3:be5? (p200300cbc7062000e44cbc46d8d30be5.dip0.t-ipconnect.de. [2003:cb:c706:2000:e44c:bc46:d8d3:be5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f259d5f4fsm21580909f8f.78.2025.02.20.12.47.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 12:47:39 -0800 (PST) Message-ID: Date: Thu, 20 Feb 2025 21:47:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] mm: page_ext: add an iteration API for page extensions From: David Hildenbrand To: Luiz Capitulino , linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhao@google.com, pasha.tatashin@soleen.com Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, muchun.song@linux.dev References: <3f0e058aef3951b39cf6bb4259c247352d4fe736.1739931468.git.luizcap@redhat.com> <4cb93166-29fd-4aea-965b-5dfb62d4dc8c@redhat.com> <0a8bd481-0b97-416d-935e-84828016445d@redhat.com> <70971ae0-3933-4e55-983a-24c6b65ef913@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <70971ae0-3933-4e55-983a-24c6b65ef913@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HdmLl_eWdUOfKWDPVVlN0vBjSbxBZbNAZOD0jzkAP7g_1740084461 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9DFBC40011 X-Stat-Signature: s8otn5qyn45fnpfi86hmccoe54kswcgp X-HE-Tag: 1740084464-162473 X-HE-Meta: U2FsdGVkX19olL5+iA1iIfNkzXigPCvgF0sbBZ9Pni3TGSzAK/tmNcj/Ewm1/0T9wPfdGM4DeHR8keb1m35TrTD6OatAgDZXW+92eV9BXnnQfzTw8ztGBSEJOwhBv+xKjo8JJgQ+t0URvaefKEtiuuy7/l8ZrC4YJvvsraCMmdmT/MhLBTOO4ab28mHGyOxsbzBfBo7qtCOtwRB7Pi504vx9IWByXzmcPv5f0cbjJocJsO1FRHyoTUbo+Rb2XdrPPsBWcdmBH+7MhGnk7gVLxfn/Xoj8Q8phW17yCaeMXhVihrzU1dNuAum1x1wfWuMGg8Bcvf+DqxIxNaec63LCodrztPPSGRZI8DxWcsSQHNRcjoGqAB6O+ZfZMibKqJLsLXidc06GKguApDSw6hiEceRDQNOEnTfV0iTMKhB/2EDM8UsaakUUh63lnSzDAvR0FIdCJKVpm00qcSoWZkBfZ7uXFJO/lFPcSWw9C7afTX4C4ucTl7K6t21ZmyDrRzszZ4Ku+i5GrNeuAUOxvsK4PH4287U5DZ9xgt6FexYyJy8Hcwyui8O0rcn/VS/Q+bWimkhnkzB6jcH/6p4kY6YexXQTmlBGAIsY3o2AhzS0LNB4cuerDtiSdFfQFO7m+SlWgGp1agbHyvj0QMMrZxtLcMp50HxGBaXlmf9Rh+NZhycUB6/2XGvOZW8czdye2AbGP3ZwXoslIfv61M90X752nRRe5yf2odRONWMTrsx8UCuCIL/nHoOZTU0N1ba9VOjCivo3xbvJUMahEFnecZwrpciahifQ5QOBLTF1aGWoAdlwkAUMGiM4Z7+j31Thjj0DrYdT8NVP51KR0D1Rm1IT8qTA8f8WA2y3+POOzG64Yzl/SxZn6FIp8fO7SdUg0SuNfg4E8UYDyrlvik645nvGeCquh9dWBUmbMSaNV1fkciYC7tMjSt3op3ok9Zkgw+ycg2uwsgJoreaV/YUD3qb KSNeLlu6 fny0eXzi4mo+MrF3iOriZlyRSzJcv2d+Wy0dw37oZTIcCZqBfvb6uGG1dtiRLpdaX++nCV17vyUaKnsphIGXktCQpW39Gt6KgAMxUKs6/JEwIDspSB1WzhQ+KB5kbmecz08L0Nz8rePOnC9wPXBu5LzxtIpFCHGQX5PNIOAxOgO+nCWUuChbCbi10NFX0zNTLczdIl727yfxKH4ZmPV4GkFdbsLGVVi3oirX1neLkv4XaxPAtsNH7oP7d6MaHT4KMzYetdLyhRjoe3InPvro4xBHNQZUXIH3gyW5I6elkNRpvXPsG1bumtgpbYh1Pd1Uu336JB59RE8La5v2co6sqggJ+RoyrPCznhvqRVCkTMFCNVC18oExHPqjLEXMYJ0xDVlyd3x67rzB1d/ruPeTsIycT1GxU+cVHDYHwmN79k340EsHR+QaqEz+/wjBmo+b35SRG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000108, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> I personally don't like over-using inline functions, also I don't think this >> code needs optimization since the current clients make the affected code paths >> slow anyways (and this also applies to the likely/unlikely use in page_owner >> and page_table_check, I'd drop all of them if you ask me). But again, I can >> change if this would prevent you from giving your ACK :) > > Well, 512^512 function calls for a 1 GiB page just to traverse the page > ext? :) Ehm, 512^2 :) -- Cheers, David / dhildenb