From: David Hildenbrand <david@redhat.com>
To: Luiz Capitulino <luizcap@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
yuzhao@google.com, pasha.tatashin@soleen.com
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, muchun.song@linux.dev
Subject: Re: [PATCH 1/4] mm: page_ext: add an iteration API for page extensions
Date: Thu, 20 Feb 2025 21:47:38 +0100 [thread overview]
Message-ID: <dc78326f-38ac-4207-be59-2b753e0dc26b@redhat.com> (raw)
In-Reply-To: <70971ae0-3933-4e55-983a-24c6b65ef913@redhat.com>
>> I personally don't like over-using inline functions, also I don't think this
>> code needs optimization since the current clients make the affected code paths
>> slow anyways (and this also applies to the likely/unlikely use in page_owner
>> and page_table_check, I'd drop all of them if you ask me). But again, I can
>> change if this would prevent you from giving your ACK :)
>
> Well, 512^512 function calls for a 1 GiB page just to traverse the page
> ext? :)
Ehm, 512^2 :)
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-02-20 20:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 2:17 [PATCH 0/4] mm: page_ext: Introduce new iteration API Luiz Capitulino
2025-02-19 2:17 ` [PATCH 1/4] mm: page_ext: add an iteration API for page extensions Luiz Capitulino
2025-02-20 10:59 ` David Hildenbrand
2025-02-20 20:36 ` Luiz Capitulino
2025-02-20 20:45 ` David Hildenbrand
2025-02-20 20:47 ` David Hildenbrand [this message]
2025-02-20 21:12 ` Luiz Capitulino
2025-02-19 2:17 ` [PATCH 2/4] mm: page_table_check: use new iteration API Luiz Capitulino
2025-02-20 11:05 ` David Hildenbrand
2025-02-20 20:37 ` Luiz Capitulino
2025-02-19 2:17 ` [PATCH 3/4] mm: page_owner: " Luiz Capitulino
2025-02-19 2:17 ` [PATCH 4/4] mm: page_ext: make page_ext_next() private to page_ext Luiz Capitulino
2025-02-19 23:52 ` [PATCH 0/4] mm: page_ext: Introduce new iteration API Andrew Morton
2025-02-20 10:49 ` David Hildenbrand
2025-02-20 20:23 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc78326f-38ac-4207-be59-2b753e0dc26b@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luizcap@redhat.com \
--cc=muchun.song@linux.dev \
--cc=pasha.tatashin@soleen.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox