From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 006E5C27C44 for ; Fri, 31 May 2024 08:32:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E83C6B0089; Fri, 31 May 2024 04:32:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8986F6B008C; Fri, 31 May 2024 04:32:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7870A6B0098; Fri, 31 May 2024 04:32:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5C4476B0089 for ; Fri, 31 May 2024 04:32:09 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 00F1540D5B for ; Fri, 31 May 2024 08:32:08 +0000 (UTC) X-FDA: 82178023578.23.1BC4410 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) by imf11.hostedemail.com (Postfix) with ESMTP id E225340015 for ; Fri, 31 May 2024 08:32:04 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=soJ2cCCU; spf=pass (imf11.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717144325; a=rsa-sha256; cv=none; b=kTdfcu8mWprADLJu3aLI191CNkWtI8JdbHo1yFPSz6mn+mc93XB/CWqdUuh+0qiRH5eN0D bwGcRc3pGEgVezjSBUufiktYDON/aULsRhbDqhqDPfkSt8Hl+SVnkjKrIW70q/KX970eUw HYQRvuP+kKBQGlWVtGy2g6rzGRI1Fwc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=soJ2cCCU; spf=pass (imf11.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717144325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mHgLHUhxCEeWxCNJSXHptpDk0n+7D3OisdJ7k6oe/I0=; b=nV/3SyQVOOpWkXlXR1A4gTtX0bNYWY0HVDQBwFeAjnAsEDCegnJW6z5GifCxw87UzGmpOj rFwij4kyLPfPBuV742yCfdw8VtuONgQEMaaStVB9tK17um2vdPrtiU8lNl8vx04rBewW1m 5hEvqs+aY3eeGZyBSgL43i2Cbmhz42k= X-Envelope-To: cl@gentwo.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717144322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mHgLHUhxCEeWxCNJSXHptpDk0n+7D3OisdJ7k6oe/I0=; b=soJ2cCCUVPJxQoiCy/lPzeERw1gF34QVlNZzGq+cIC/9svcXTzgyuArdQ4wWeyQ8WPCD1B fH83u9/bQNfenATiqU1AT5HQ87YSBVl64atkNJ6aLKw84sNpYBERWwdvkfYNyKu7we4xfh 17w/oYT+wOiNx4PQwdHcyxUmt1owLls= X-Envelope-To: penberg@kernel.org X-Envelope-To: rientjes@google.com X-Envelope-To: iamjoonsoo.kim@lge.com X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: vbabka@suse.cz X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: 42.hyeyoo@gmail.com X-Envelope-To: feng.tang@intel.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: zhouchengming@bytedance.com Message-ID: Date: Fri, 31 May 2024 16:31:31 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/3] slab: check the return value of check_bytes_and_report() Content-Language: en-US To: "Christoph Lameter (Ampere)" Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com References: <20240528-b4-slab-debug-v1-0-8694ef4802df@linux.dev> <20240528-b4-slab-debug-v1-1-8694ef4802df@linux.dev> <4e4d45b5-c684-2d93-49d2-b179a088c2d5@gentwo.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <4e4d45b5-c684-2d93-49d2-b179a088c2d5@gentwo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E225340015 X-Stat-Signature: 5hw6da6burak1cs5zte47doowfptzcm8 X-HE-Tag: 1717144324-144001 X-HE-Meta: U2FsdGVkX18ZIzGRjH+jNh/L4CBAsxy7KMiu4TI2KljGxRyOQ89iUkXpd99UIDu2wLp8VSM3Fb32b9DBFiewgJPL19Ntzb/UK7GK5gLyBrJoTI/MRtjCKenJRSYHP4ectNKCLpFQ1bmAKchBX7PBVPlNDB5Ux+XOUrxZj2wHj23xv2YhbhU49nEIpVqdjEmbot9dzdkzMkb+E90nRVGsjpGXKbH3YEwes104lFANknf+TLoZQBdGxQt2UC+WkSt0DZHZLnpOBrGDpvJRvDdtCDH5ttFpAc91fWhEEj0Cvh2KrvqDCBrVH7PzJU//H36BcVbUIvfhQBpW660gxMYNBTBKxuZi2QVt6LLi6LOdj6yzREZUYNGDYwki2+FKTuFJ2mZZ6uSJ8Xwdimj6PgvOGjeni2aQXKsBuJNS1LCtKhXCTdmlIKSDY+Q4UUxYtDRGKkgpjtaiULiVxvCxLscD/G9+DXXmBuD3I8VmUyaJCqK7nnHRbY2yfYKww52Xc+E7FjxojDxRn4JVrLC7MB3USy4sXD4IF+20SpVL80d7OBoDsnW7hXYa4p7RX2qDvYAK8HyjmE18HE5+yXCZoqIUugvxHedY9Pycv0vGT5aaqi0ICUiC/KuzmhrZfUweBjH+889I1Tmyr0lY/O0NcIlLQyB12ec163hBDke1kyBbTLhFRTBE1azrOa3jXZpUPbEEdx5HAGInfoNwLXqTPKuHOr4TceXEUGk/ioAA45oNGG8MGEw2fvL9pqowz75aSHb6V2ybnQIcXzw2EHjrrIaRVBfYptEzY00TgByRhkuXcoOnBLODefntyJfPblJsn78FwBED7DMu3VShbqa5my52RnBd/R9FeEy/1+4uKfezoGL2OUcvM4MfE+pGAX7yY8/hMAPxhb+9S7ie7Vnfrz0U3yjtD4pETrAzJ8cjM4j7/HpsLsaAhYR4gxkgQnkIOMiBI3UR9e6UUFq0ZzHQev6 sIdmI3Os 2FlO+x5K5pBiPHp1UJrmgwbeTA+E0fRXluZWGHD4aEmIm2SBTy/aSne/c/Hrwzx1UA2ir+4Th1tsw5LY4iIi7bfWn7qn8W1vb1VgrQMSShesvELM8DXp55A3XYzo8hc3JuucsCVM6xikPoJdSbmhcVqBXL1OR/xD8yH1TZP127mFQXtI3HSd/b7yhWV5xwHuRyu5FhhESfzhR+wmtcRgXeecuMe9MV5HmzGsZ6CtKsLQU7RtEIebedBfPDCURLvl4Fapw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/30 23:20, Christoph Lameter (Ampere) wrote: > On Tue, 28 May 2024, Chengming Zhou wrote: > >> diff --git a/mm/slub.c b/mm/slub.c >> index 0809760cf789..de57512734ac 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -1324,9 +1324,10 @@ static int check_object(struct kmem_cache *s, struct slab *slab, >>         } >>     } else { >>         if ((s->flags & SLAB_POISON) && s->object_size < s->inuse) { >> -            check_bytes_and_report(s, slab, p, "Alignment padding", >> +            if (!check_bytes_and_report(s, slab, p, "Alignment padding", >>                 endobject, POISON_INUSE, >> -                s->inuse - s->object_size); >> +                s->inuse - s->object_size)) >> +                return 0; >>         } >>     } > > This change means we will then skip the rest of the checks in check_object() such as the poison check. Yeah, only when this padding checking failed. Now, we always abort checking and return 0 when the first checking error happens, such as redzones checking above. Thanks.