From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A8AAEB64D9 for ; Wed, 28 Jun 2023 01:56:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F5638D0002; Tue, 27 Jun 2023 21:56:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A6208D0001; Tue, 27 Jun 2023 21:56:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 793928D0002; Tue, 27 Jun 2023 21:56:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6C2EC8D0001 for ; Tue, 27 Jun 2023 21:56:45 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 34C89A0A72 for ; Wed, 28 Jun 2023 01:56:45 +0000 (UTC) X-FDA: 80950492770.10.EB277FD Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf06.hostedemail.com (Postfix) with ESMTP id D95D2180003 for ; Wed, 28 Jun 2023 01:56:42 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687917403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JFWCrlFyvu4PLbbpNWvsXsHc80gLE7sB+704eM9bFyQ=; b=jMEi2emZgps8E2or26RqNrzmv7k2vigW72AXEsvPt+fnyL0rZprVrVl5pT//sRdn3sDIfu /spEG5zbHrONCSeRRSmoiCKnH0NFx5V1hAPyR17r9suFBgY0TLPbVl75tvwsbZAcWxIVVc UPFUcW4wGGxG80oaHphkuhno/FdeGK0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687917403; a=rsa-sha256; cv=none; b=XdNSGYjMSy9+VZ7qqXf2EecjQq+UXUx1O6pKbo6ZV6LmmKOXniISh1OPvVNCg508eEiz4r RnFWFBMiG/Q+6oylFmxfmrMq7TQPPnDtrPZZYIqEpB9rtyr05S6MIQUeHTsBTRkWTaMpuc NE3U8OdvvC04pijtJH2/ikuSVF9rQ7A= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QrPkp6pbxzlWKQ; Wed, 28 Jun 2023 09:53:54 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 28 Jun 2023 09:56:38 +0800 Subject: Re: [PATCH] mm: memory-failure: fix unexpected return value in soft_offline_page() To: Andrew Morton CC: , , References: <20230627112808.1275241-1-linmiaohe@huawei.com> <20230627123046.ef7e791208214bbfecd71e42@linux-foundation.org> From: Miaohe Lin Message-ID: Date: Wed, 28 Jun 2023 09:56:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20230627123046.ef7e791208214bbfecd71e42@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: tcbkko4qz8phungnse5jw8buedbiktoc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D95D2180003 X-HE-Tag: 1687917402-421282 X-HE-Meta: U2FsdGVkX19ukzsQdxq5/c5ORsuWaFyVqF4tDRXyDsA8lWpM/h6d16gfk9UA/2PG4K3M/0AxC2Xdr5YnRfpBjPewP17TyY7jE8ikp+mPl6Xs+a83cEenaAyrvBrDncw0uWwgjP4NfDWJ72Zg2Gz2MR9DkxRmWc2RAqsONglq+8MVpidJrnD/De2lbkZzOrthf1TKvoXLOTrubrWTczH2YahrbDddUuzJdojtyG6ylm0myBaAQcgHC+VQDsiB4yESt8ciKZ9vvVhx8Lf0Z3uuRjCvVrpYTEwxq49J5pBm2STVHyVnGZ3sSjIcuOISRq5nbloL/k8Qmr92QBJfXBRXizKOyXJv9XOcsGDAqdkadStcCYRqgidTouuez4t1Ri3wWZrZ+WIm2nj9FEH1gUrvl9mpyQC/1umfoA5NY9BgKSPVCDYeWYCwG3Z5irJm73FuR3AI5N/s2PZxFKepLTrg147aV53A+2XXLws+JmuskW4/z9Fc2uRFOMPC2hgUs16VxBBrlq22MrGlZWvnPgnZ8HtcY8/xveDTwXa4TxlCsKUSPD9GdmxNDxwaLspW1OK8uzpwMHQVizpcrkA4RsAn8AxPBAUHWqiK0MlQ0e143MacFJ0BClCNrd+P8ow3w1huNN7h9Fnh4ePnM+T+9m+CLjpYTaBAXjHVT1u9RFZ/gqdSjE5hi+1C2nygeEt1Ka9RChzEE6o0QqTFej8v0Gf7MuPTrCvX0EmDQGEzVGrne+T293LQyPTyLu0fOYQaJW3q9yq+jXPg2+2pNRvfMCk+mc7v/9cN13M3qIv/R/qwgld4xD0lkOzDnNYMluvPLv0I0oVwaIj/qnyXV4bEUXyX44E0EENpgasQ7OOC6ADCOcMDG5ui71yEk/M/OHQ9sAs4XB+heul9f5ybeB0YyPZ0CLfM3+j414sJiwMvVQ3TC2ExTYlH3NHSCgMhuLH7PoGkpx7Cx5uD20vzKOoYOv/ snvVopTL B+sonj7K06iQWgKrm+aD2bJH4ovxBKSKUcMHDc9NQuEOK/pXEETBGEkmEH4JUtBt7Gzb/mxIEegKb1xWWKfB+IkbLIil68sPHk0/Uljql1lo6F30bfsKAUchNsXbjiSRv36B20Obdts700BSl2jUXeosog+mduqqsosfRQdIJmB14BMeRIUPRLXvpmXV3JtYbvTwBAnpyhov2lww= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/28 3:30, Andrew Morton wrote: > On Tue, 27 Jun 2023 19:28:08 +0800 Miaohe Lin wrote: > >> When page_handle_poison() fails to handle the hugepage or free page in >> retry path, soft_offline_page() will return 0 while -EBUSY is expected >> in this case. > > What are the user visible effects of the bug? The user will think soft_offline_page succeeds while it failed in fact. So user will not try again later in this case. > >> Fixes: b94e02822deb ("mm,hwpoison: try to narrow window race for free pages") >> >> ... >> >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -2737,10 +2737,13 @@ int soft_offline_page(unsigned long pfn, int flags) >> if (ret > 0) { >> ret = soft_offline_in_use_page(page); >> } else if (ret == 0) { >> - if (!page_handle_poison(page, true, false) && try_again) { >> - try_again = false; >> - flags &= ~MF_COUNT_INCREASED; >> - goto retry; >> + if (!page_handle_poison(page, true, false)) { >> + if (try_again) { >> + try_again = false; >> + flags &= ~MF_COUNT_INCREASED; >> + goto retry; >> + } >> + ret = -EBUSY; >> } >> } > . >