From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A773FC7EE29 for ; Wed, 7 Jun 2023 05:38:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AB366B0072; Wed, 7 Jun 2023 01:38:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 134F96B0074; Wed, 7 Jun 2023 01:38:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F16FB8E0002; Wed, 7 Jun 2023 01:38:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DCB8C6B0072 for ; Wed, 7 Jun 2023 01:38:05 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 573A2AE210 for ; Wed, 7 Jun 2023 05:38:05 +0000 (UTC) X-FDA: 80874845730.10.4186A57 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 67160140006 for ; Wed, 7 Jun 2023 05:38:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=RqWuz7dm; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf09.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686116283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BR9XdO0qnlIFuqVPFVy2qvPDgGOCoJxc9twOGMCZLfU=; b=QihHBenGMh4j6mac7PRgK5b4ruU0AKZMOGIqmuE0eoeQ349hJSs8gWTa7DDbmVmLvW7274 TRxxd1cQ0vz/rc7rniWOI+CQXe52HiSN5TsclGjuiq0GUzXFDMvkIygBhdYF5pUQnWP0cJ VcQPU5KktPzoVN3QRQkhc6PTWCP8BgE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=RqWuz7dm; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf09.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686116283; a=rsa-sha256; cv=none; b=LA/xBjMY32cDeTPzg0huceyu+n4nDkO71w9Rajvrdh8a5kELt6+MdKN+K/ii1pQQvEzpmB KltPXmvqJlWgnXvZD97GHcsdYc74A+tZccUbAzJIBdnqxAXiCo4iUDJErbkE/J82YlxkB4 5FDpL8eMY6qXdnjkN9Io35MvC4QmL24= Received: from [192.168.10.48] (unknown [119.152.150.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0AE0F6606EEC; Wed, 7 Jun 2023 06:37:58 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686116281; bh=f1FBPoNEcIA/RvJGHRkui9e4p0KP/htHwb3NWS5C6Vo=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=RqWuz7dmAksyq7kNhCW7jH2xEUBFNlEXFcdkOy5tJx6sppe4KZKiZXOuzcTjL2uNi 6CKyglBlAuCGTMstK50tH70sJrgkw0BuMc7bPUAlRTOxIceQmp30IsJUcDL/qNyz3/ xCsZ9G8plPr8vHpuKC8YWoDNeVTFUrnaiPtfjUS9ds1hJ8+TACSKsGYe5reTmR8x8U NZO5jDLWNmhNuQo0fu6vN62wrnTbqXvgbaTUWC9K0AD3Jr4h/h33YpvNpJUuUD5yK/ dlUTlpfkWDk1wvfKphK8xmu/7jYh82AGBncS/CJVJiCb77P7bbDs9bTHjuEibluBTM 4hF1TZ86vOKnA== Message-ID: Date: Wed, 7 Jun 2023 10:37:54 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: Muhammad Usama Anjum , David Hildenbrand , Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML , Jonathan Corbet , linux-doc@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built To: John Hubbard References: <20230606071637.267103-1-jhubbard@nvidia.com> <20230606071637.267103-12-jhubbard@nvidia.com> <8e208e0f-699c-2c34-d66e-bf6d488a7a1e@collabora.com> <14573e7e-f2ad-ff34-dfbd-3efdebee51ed@nvidia.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <14573e7e-f2ad-ff34-dfbd-3efdebee51ed@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 67160140006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 844j78a8catean9xw1c9isfff6bm7nkn X-HE-Tag: 1686116283-72898 X-HE-Meta: U2FsdGVkX1/f9us+zlGWPAhgvt8+mhFmEcCZKAgUMRZKba2BtSudJxrOINSe/XiDW1jy0/wCsqLHwYrk0qEwHGIfdosXxcxTD+c3KLgnQ5wsr/2YWO/FSxsMAsXaGWcG8nQgxpMoGf73UMwIwn+0L58a8YBy+P1zRSdi/4qql1NZHK7Nts45wmT0GL0XEPG6r1wWT4KU3+JvwU/I+xRdNnAhEhfIM9UH/HMpAmxmuS3sEd9J4+TZAEtbADuEMLDpJZr+yuA8u9o01vii30nju3VL85K/pVDtx7JBTBLhU7+SeZSDQzZnYi7ipavIKjZ2FhdrYTNLgl0IHxeSei7teMdCGol5c8hEWlMB+I1LYtRmcMsIH2nP1JG/oy7iZgkSGOxkVryTfe3pSp5yZiTkPhDcrh4BvqNR8bpn4q5YqRK8hw+IK1U/vodALywl/ABM34UrHo9K1x5MkijmSVKKnlEoGNBvW7SlL5mPBOmZ+OT+v3+dTSihgW85Q+I3+AuhWc3t68/nrPAig+p66SOW/B1fAAaUAVPw2RgF1ckPdt2Mg91JHqvniPeVqOix2mvuDKQ1uD4v2bc/Iea6tFkbmlyXqQ/oieH6yFxLaOoC43dafS8hB6ORxpOwiBDpILMsoObFUq6cuPZhgA+aThrnTbuj3ntV7CeZ+qZVZs97t0JYxVNyiYYvuuECNcB4AJk3iJNVo4H6V8y1kosa1XWlbKB9Iaon3k45rTb2BuRlPWgB2A2AIV18UpClvvrLZfKll/JiTmSKTwxDZ666qWaGL9RWHg+nOEe4h5xEyD+IDrSHojJS60T1yDZbfdRBb6Abcu4DsLkYvZNraPYnLsDtrkEbMDWT1UIys9ysEA6Gd98b/QJ8q91fiUfw8knJFN48r/ArkdtmD/aPa9dDPVPL6aHsv2GSumavkdmQsfJjHzUUsMpL1oJcjEeRCJMDhttjfQ0YFzgVqXmh5sWH3oz xlGw0WUS c1uYjDlYjelSR5z04Ef4M8zbnIa02fKma9/eYkJQxWxiiNYOvQR3ElSUfYSru4wSVQet/WrCgaDCy8Jms4jstpbO+Ogf/KGnTEZigp0RYyFJ2TfvP0qPJrMvcHLKL0xJAPTiU1Ksy60hGnhIkjcnikjqmYGpLjjk+46CAWQdjmngZBzjrplZQWoFWwG2LXIjZHVLx1mCfX8SsdHyizEfH/8tW/B669flaAsYPsVZTOGl6oClX/Z02dxA+BWnj4jSvClUThSd8cF4VGp4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/7/23 1:10 AM, John Hubbard wrote: > On 6/6/23 00:38, Muhammad Usama Anjum wrote: > ... >>> +kernel_header_files: >>> + @ls $(KHDR_DIR)/linux/*.h >/dev/null 2>/dev/null; \ >>> + if [ $$? -ne 0 ]; then \ >>> + RED='\033[1;31m'; \ >>> + NOCOLOR='\033[0m'; \ >>> + echo; \ >>> + echo -e "$${RED}error$${NOCOLOR}: missing kernel header files."; \ >>> + echo "Please run this and try again:"; \ >>> + echo; \ >>> + echo " cd $(top_srcdir)"; \ >>> + echo " make headers"; \ >>> + echo; \ >>> + exit 1; \ >>> + fi >> Thank you for adding this. This is outputting error for every selftest >> directory. We should try to make it even better by just aborting the >> Make-ing process the first time headers aren't detected. We can do this now >> or later, fine by me. >> > OK, I see. Yes, this can be improved by adding the same mechanism to the > selftests/Makefile, that is in selftests/mm/Makefile. > > I'd like to keep both, because as I mentioned earlier, mm folks like to > run just that one Makefile, sometimes, and selftests/mm/Makefile is not > invoking the top level Makefile. Rather, it includes lib.mk--which the > top level Makefile does *not* include. > > Arguably, using includes instead of recursive Make, would improve this > framework: reduce duplication such as the above. But that's a larger > project and just food for thought at this point. > > Anyway, this works nicely on my system, and I'll attach it as a patch > also in case you want to try it out. What do you think of this: Nice patch. Thanks. Lets add this patch as well. Please add the tag for this new patch: Tested-by: Muhammad Usama Anjum > > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile > index 90a62cf75008..bdca160063d8 100644 > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/Makefile > @@ -144,10 +144,12 @@ ifneq ($(KBUILD_OUTPUT),) > abs_objtree := $(realpath $(abs_objtree)) > BUILD := $(abs_objtree)/kselftest > KHDR_INCLUDES := -isystem ${abs_objtree}/usr/include > + KHDR_DIR := ${abs_objtree}/usr/include > else > BUILD := $(CURDIR) > abs_srctree := $(shell cd $(top_srcdir) && pwd) > KHDR_INCLUDES := -isystem ${abs_srctree}/usr/include > + KHDR_DIR := ${abs_srctree}/usr/include > DEFAULT_INSTALL_HDR_PATH := 1 > endif > > @@ -161,7 +163,7 @@ export KHDR_INCLUDES > # all isn't the first target in the file. > .DEFAULT_GOAL := all > > -all: > +all: kernel_header_files > @ret=1; \ > for TARGET in $(TARGETS); do \ > BUILD_TARGET=$$BUILD/$$TARGET; \ > @@ -172,6 +174,23 @@ all: > ret=$$((ret * $$?)); \ > done; exit $$ret; > > +kernel_header_files: > + @ls $(KHDR_DIR)/linux/*.h >/dev/null 2>/dev/null; \ > + if [ $$? -ne 0 ]; then \ > + RED='\033[1;31m'; \ > + NOCOLOR='\033[0m'; \ > + echo; \ > + echo -e "$${RED}error$${NOCOLOR}: missing kernel header files."; \ > + echo "Please run this and try again:"; \ > + echo; \ > + echo " cd $(top_srcdir)"; \ > + echo " make headers"; \ > + echo; \ > + exit 1; \ > + fi > + > +.PHONY: kernel_header_files > + > run_tests: all > @for TARGET in $(TARGETS); do \ > BUILD_TARGET=$$BUILD/$$TARGET; \ > > > > thanks, -- BR, Muhammad Usama Anjum