From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B794BC77B73 for ; Tue, 23 May 2023 00:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 387766B0072; Mon, 22 May 2023 20:45:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3368F900003; Mon, 22 May 2023 20:45:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D7C6900002; Mon, 22 May 2023 20:45:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 102286B0072 for ; Mon, 22 May 2023 20:45:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DDB9240541 for ; Tue, 23 May 2023 00:45:32 +0000 (UTC) X-FDA: 80819676504.28.390A8D4 Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by imf26.hostedemail.com (Postfix) with ESMTP id 3FF98140013 for ; Tue, 23 May 2023 00:45:29 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=none (imf26.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp has no SPF policy when checking 202.181.97.72) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684802731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XP5gJZLpwu9etC9/wGSQmBWiQVYCbfrqG5XzKhYr7qQ=; b=rXsOAfkxEdGSZRQwY8+9vBav4264roi7GgCWFl7wUM/BMj7CyqZ5V9rlCzblY9gjFNXUkb gPz+i/AvKK6X6mVjn3orUSKTk3iVoU/ZFpe1OL+Y+Hhl7v4y7u1kY6IwEe7jzxdcpJMII1 Ci1J1GH7ckiKFdHhNjlYokgH9WuSWxk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684802731; a=rsa-sha256; cv=none; b=Y2fGvlouLGCO02/oVdzAw59G6zyzr021A/+nWQAysngH5nkrgi68HOa4Vvq6Qd8BcoDZyX 5WFkFSMiSebTDjlBoHr70h3CoDEnlqKaZVxruWhrYUhtn2E6vCkAuiGHcY4tX+vGOg6SD/ REIEdsS/Rw8sVKVkr6QPyb5oRpqSON4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=none (imf26.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp has no SPF policy when checking 202.181.97.72) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp; dmarc=none Received: from fsav414.sakura.ne.jp (fsav414.sakura.ne.jp [133.242.250.113]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 34N0j3to015017; Tue, 23 May 2023 09:45:03 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav414.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav414.sakura.ne.jp); Tue, 23 May 2023 09:45:03 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav414.sakura.ne.jp) Received: from [192.168.1.6] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 34N0j3W9015012 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Tue, 23 May 2023 09:45:03 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: Date: Tue, 23 May 2023 09:45:02 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] lib/stackdepot: stackdepot: don't use __GFP_KSWAPD_RECLAIM from __stack_depot_save() if atomic context Content-Language: en-US To: "Huang, Ying" Cc: syzbot , syzkaller-bugs@googlegroups.com, Mel Gorman , Vlastimil Babka , Andrew Morton , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , linux-mm , Johannes Weiner , Michal Hocko References: <000000000000cef3a005fc1bcc80@google.com> <48a6a627-183d-6331-0d8d-ae4b1d4b0101@I-love.SAKURA.ne.jp> <9c44eba9-5979-ee78-c9c8-626edc00f975@I-love.SAKURA.ne.jp> <87edn92jvz.fsf@yhuang6-desk2.ccr.corp.intel.com> <0471c62b-7047-050a-14f5-f47dfaffaba7@I-love.SAKURA.ne.jp> <87a5xx2hdk.fsf@yhuang6-desk2.ccr.corp.intel.com> <871qj7zz8z.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Tetsuo Handa In-Reply-To: <871qj7zz8z.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: p6yeemz6y95dfb965hsi9ekopfmpehwj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3FF98140013 X-Rspam-User: X-HE-Tag: 1684802729-875099 X-HE-Meta: U2FsdGVkX186S1qAh6FuHYSp3ZgaNNq9XeHv2ePoMFn4MpB6Ea+4YNJu11mqWtvV81+pJ30bZMieS6dQJXSvFKKgMW6vCd9nmIFUtuqcPEmZ6Fb65gqfVjv6iq1hnQRzD3lPun8iOVpIxtfqnwqTawp01grfo48tToygi98oX6P9tUkjzqWmlBi5f+7QIpS5wUXNmM5RzTIMg62pk5oAlVlLLUjyatZaAqKAqdvw/2B2QrXLD5ajj7SE9p1cwPrGyd3Rr+FSpQ1bbPTrxb0Zkk2/I0aqmA23N1qzc0aIL0tsPI209thamt/gzQmEDMiFxSmki22uoNZj3CCBUzFqms+SuHenaFu4Gi1ByJFjTxSi4AoKR2WOZhh3xmAau7zk2Ky0eR/P35eYUyPeeMs4399FU5UcvYAFkTcz0quN4EJ0WRNmUbMqdsTWzt1RCmAems0AhQkczuEyJd6Wyq/nPzSAn9iqquUhYbYNF5qyUzL99YsRuUr/FFEvLP3bpagGkHbEWFPX2jPhkMVhpjCXcjJlI9h6c50IRN4igAAZPFmE34E7dE1j8UlzLpD8nH6vhtWrESHQ5xFOIutRWhj+MpDrIuzcoMNT/EnUaQWdP3K3jbbvXCbgfXGFf431e0kZJA1zd4NEMlnOkxOgMPHsyYxaMkgVViBcPRcbvuzdH0vGr5TjaZAznTrHOzELW3yojeAzgoRnpYw02OWDaS9hpCZMd5nHwGvTS5eYyEiBJUmvp5XJkzsWb2NShd41CeS5xhTyC6bpirD/XRuPSZnv5ocy3RW8wAtW/N1p/SMdWlPArayG7L7FCShLXQTQ4HdW5ELpo4ECo0qvNEVAxwjayRPAZWpeUpPptvQx73EtEPyYw4VsrvYdHafF1HaVNG2cXuN5osltySokgUo1nhkS+CfuGzhw9niQGLAZYI9yB2LqO+qmPF+Osb9E2i+nE15UhE5x6XWxy1jHhqR+cfM R/rESgTy 1YDjn4XiHeuhzAjB66xYfkXQMBIIzeeeZcF39IDpq/b/886F6iVIrvKDx7g2LdJ3/dRmFA5SQktlon8eMyjSWpBxbVtcs0jg8yNU8z8yWRKvTueEUQbKiiqSbwsl+YQnyOelDOOFS19a28U/1OsJj+RbDPlqRtkegy2EWoslFqddhdJK0LLb0DwKx4sCLduNe4lyM5EN2bQOBQbNN5ULljrxrsipxpcKNM3hVNIFrR7BWg8Y48rqCk5wmU51mu99Z66Xpf85arQYHc3Vld+XCqdWxM0NhxoIY2uayDjdBL7/MsnK5BbdlbUqNGDfdw0wlIP77UvA43fRb8wVXiUlUk4gWDqjZAEhwdKazgncG55l9P6qd/eZGXFLKJE2zU0DNWemiZ8vAKvVtOkGv+GDEPrvuK1LYJQY5TCcDzEUVV5NJWT8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/05/23 9:07, Huang, Ying wrote: >>> Except debug code, where do you find locking issues for waking up kswapd? >> >> I'm not aware of lockdep reports except debug code. >> >> But due to too many locking dependency, lockdep gives up tracking all dependency (e.g. >> >> https://syzkaller.appspot.com/bug?extid=8a249628ae32ea7de3a2 >> https://syzkaller.appspot.com/bug?extid=a70a6358abd2c3f9550f >> https://syzkaller.appspot.com/bug?extid=9bbbacfbf1e04d5221f7 >> https://syzkaller.appspot.com/bug?extid=b04c9ffbbd2f303d00d9 >> >> ). I want to reduce locking patterns where possible. pgdat->{kswapd,kcompactd}_wait.lock >> and zonelist_update_seq are candidates which need not to be held from interrupt context. > > Why is it not safe to wake up kswapd/kcompactd from interrupt context? I'm not saying it is not safe to wake up kswapd/kcompactd from interrupt context. Please notice that I'm using "need not" than "must not". Since total amount of RAM a Linux kernel can use had been increased over years, watermark gap between "kswapd should start background reclaim" and "current thread must start foreground reclaim" also increased. Then, randomly allocating small amount of pages from interrupt context (or atomic context) without waking up will not needlessly increase possibility of reaching "current thread must start foreground reclaim" watermark. Then, reducing locking dependency by not waking up becomes a gain. KASAN developers, I'm waiting for your response on How is the importance of memory allocation in __stack_depot_save() ? If allocation failure is welcome, maybe we should not trigger OOM killer by clearing __GFP_NORETRY when alloc_flags contained __GFP_FS ... part.