From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B63C9C5AD49 for ; Mon, 26 May 2025 09:31:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D6626B0089; Mon, 26 May 2025 05:31:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 360C66B008A; Mon, 26 May 2025 05:31:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DAEF6B008C; Mon, 26 May 2025 05:31:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F196D6B0089 for ; Mon, 26 May 2025 05:31:55 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 961B55B034 for ; Mon, 26 May 2025 09:31:55 +0000 (UTC) X-FDA: 83484542190.19.9C5B283 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 2CEE54000A for ; Mon, 26 May 2025 09:31:53 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SynZe3li; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748251913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/XLyBebhEX0yPOpQIkvL2NlYt1fyBiGgkOJDYGtN/9k=; b=2edVnRpIDsGwtkcq5ihqIttuLjmIKc8O25kPihbFgq2lUjYS4FNFCgkElLPOE3LkllhQWI l8fM1HB+fbOlSiyclfJwQffE+55sAjRqJjsKwy+KoqDwCECtoX5wiwUhZBmy2+z5dYfLhb Q76pUMrHESP4gUNP29NXdQKLxn6CnnY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SynZe3li; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748251913; a=rsa-sha256; cv=none; b=fY3fq2yLoIqk1gXZmLU/x4XTw8iKYKAymw+VPcqd127C5sgqEh1wGdzsxUcKwbu6ONNeUP 2eF0pRXM6QgOATeuIHYzlmFjG5mWvJQWEvLprDXH8XkCpNyWbUHisbCTsVBpQVXbUPzW8X HGq/TIMiAwnbDA9I6Wcpa+jITLT7bSY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748251912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/XLyBebhEX0yPOpQIkvL2NlYt1fyBiGgkOJDYGtN/9k=; b=SynZe3liZUbAgjR6mtMl6M8/D1eccFIdmf3mOPFNtFKWutLrfD1+DnbJFDdEZ7oSPiHhQQ XhttaSWde0zEIXmmEMLTeIVrF2YZ0aVXUvdsOErfOvh5baegqYMJBSOqVMZJKZKfn1wQzt ebLC8YWUcdSAdNXBQZuHBQFi7NDvITA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-dy5tyWAeM1KPQB8B2xlibQ-1; Mon, 26 May 2025 05:31:49 -0400 X-MC-Unique: dy5tyWAeM1KPQB8B2xlibQ-1 X-Mimecast-MFC-AGG-ID: dy5tyWAeM1KPQB8B2xlibQ_1748251908 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-440667e7f92so10062115e9.3 for ; Mon, 26 May 2025 02:31:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748251908; x=1748856708; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/XLyBebhEX0yPOpQIkvL2NlYt1fyBiGgkOJDYGtN/9k=; b=b8CPpE6jGPPd0jhVqCe53gpLJU1Igouozu4q+BdwUXTZcxS8dWnKs8i7s8UtYKQd74 ye4mKQabMo/rnhGnNas9Gi2MBiSj+GstfXH3YeupsOceEmeh3fg3DtPblljXJ+cLb/k4 eC9Lg1GF32CqAvT5czynMbxh0TTROc2GCqUhMALJWr0Na33zFQGgVkRoyOu3SnxWweYM PSyHjfu1y1kqFZEA6MXlIrEoQcm1ALAmxkl4rX26ZHbY9D5cHm/23rtMPcPBJm7WSFSW INswuy4DyrU/we3czXC5+bZ6+m2rDy3wO/fVXuifKkSM3wirw2o5sTsQxzvgZBK8WTwe U5hA== X-Forwarded-Encrypted: i=1; AJvYcCXU04ZLUXPeMTBDqCczNNJHNFAnE3Ex0zaCigwEYOarFQfZoXLqCy3zSE2eiTyk/mm+UzZKaDImFA==@kvack.org X-Gm-Message-State: AOJu0YxKZgiYYQKokNil+hpRdCTH2FQu2F17Glg33gf1U/ZHZa2AMZ2D gdz9AG5wpfJhPxnHfqCIp6oNsZGUfseIWCz4KSgw2qTOhMhqnq6F/IZE9/BfL/tcz/1ao7Ao/mq 2zyoxWFNFt4tsvM+ipEZR4rHYcAvzRX6u9ECOzOqgfs+fScwqczfR X-Gm-Gg: ASbGncuA6XOw9nTG/4rVbt5GfkOeDPbuzsRwICf10Nl+h3DcwBMwHQytJEGVOXgeF7z NbTQF11cMbEY/KR2dQ87uGASTERKF3cLuTzoOA8Cud9e2/uCAwJquobJMO2kR5JRNv5FytGIz9Z ms+7wmfFyY5iMfbA7NX9fWCuxmeYEai+C+l3/xtROwbl2UNeiHC12oBm6coCxUXyOjQGGLigJaB fQRSU2TBm3D/rWWPBJY+bFYD2JdbQk+WlS1LVkeWktR4YQBLufNMNT0971C+FF36nZl23lOHhA+ uGlfmO/7wbQ6Fxx/T0aC897/13sVffQjh8h/EoWvRIk= X-Received: by 2002:a05:600c:4f43:b0:442:e0e0:250 with SMTP id 5b1f17b1804b1-44c933ed7efmr68532735e9.29.1748251908518; Mon, 26 May 2025 02:31:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHs3J0qcSv60bV2fhE2qc9oW0xcWjwfT1qs3rtNYOm5owzJ2k+nBhn/osIPvoq63ms9KZzPdw== X-Received: by 2002:a05:600c:4f43:b0:442:e0e0:250 with SMTP id 5b1f17b1804b1-44c933ed7efmr68532395e9.29.1748251908145; Mon, 26 May 2025 02:31:48 -0700 (PDT) Received: from [192.168.3.141] (p57a1aec8.dip0.t-ipconnect.de. [87.161.174.200]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442eb85a3b1sm276832265e9.0.2025.05.26.02.31.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 May 2025 02:31:47 -0700 (PDT) Message-ID: Date: Mon, 26 May 2025 11:31:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/damon: rename primitives to operations To: SeongJae Park , Enze Li Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, enze.li@gmx.com References: <20250524162910.67889-1-sj@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250524162910.67889-1-sj@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NXrJNY1RfaVPD7GMZaYX88-aU0XMpAZRTURSgbbURcE_1748251908 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2CEE54000A X-Stat-Signature: twh857ufj63nf5pgpjtgmxzaezgojrnz X-Rspam-User: X-HE-Tag: 1748251912-87841 X-HE-Meta: U2FsdGVkX1+7Sk+AEQzipojbePAGFuMrob0QIrKXct0X+DN1gEqfWpG/v07H/9CUqMKJbJ5/jr1QBlgCTf1lhPJUdd7P9tcatN1vK+9LmU68F1LCjaAuYsI6oBjoUop7p5jfc8E7VUKyzqf+frmmiigORXwho1sLp0uIOWq5p9WzovnunyKS6mROsQ4rBK5Bh9eTqm1Kauj8SsOqjAM8PewJK+d/EYXUHL8L5Opnc0i9EQO2P74fIQ7DTVkK4FuiA8fx3vDJNOcZJLgwY3LjdK3AjdGdvmAob1vOyzAp97Xjd7gGyw0LCzcmHYxYc198P51+lIz9L7bHJamkd5iooZ7NtYK7sPuf9UFUeWN6KWMMfV9yFHe+Z3SeRd2bgfAqTp1YxW2N65Ov/gXcgZ/wa9vcA073tsuvnEyo1OIoPiVYAMtQMy5hSsM+cTvzXdi5eNnhcpQeCkx9ew/uUdnRFXr9XDjKQnjCfPscgvmCl3OVseBby0vbV9st3zdk6tJDl3OXuUmLL6xdnWKwhwA9qz89XrC2RJwDDoCwHYrJTDKU501k4tKhe0METCejWf6Za2Tnu8vtPrB1CM2DCerIlDcXhfFtwpKaFr8GUQqu9lGxeR3mS2G3bnKZRNM6EMEX42zmHmylt6aXlEt+3X30nbIJ45Y1oIkF11XUszhxCxaKkx5tCAnVDhS9Xdv99NZkmYpgCJ3WVRadWH04TUxUiSx8bVv8G1Z02w6jvUdGsy01g6bd93qdH4qByd+yTa1FXC5Q/m0lWuNIcGmMQZTfb6ogN6zC3mijhEV7g3yy5tX3E9W1/9Aec1G7F91mpiAdt69nogoHkzNGK9HFHI699Fw0hZhyjt+Tu4Vx8dRn4hYTlOSrZoXihud7vDwu+SecIrV30auS3mkk3VTkCS9dUkDjvyI48+8MJjMinsP0uPXXf8lpB/pFGdHLmtqNUFMd9xgjm84gY3XneEQTLhA CQWLqfWr 47MYY5IxS1Ct60AWGKl4f9MEw/tJygBrhnhVsQWp8XeRJHNfWVOYM0Ez5F46yU3VJZxL7TOE7MjpT31iOmATj/j0JzUuHopuqHcsm+8Ma4ycp3Rap5kUoKAZAHNMjAaRwVtErEc+xOXHi4cB9/5KDGK/LL9xZA+f/kUqo8xpV5MphcJbc+oSRHHSbun3WMqhPRHwjrk+M9dOtUuLaq2OJnWFnq/h30LWuig4nFAMSn8n1iOrNMj7epSC54V8fSBZjO+SAAlNScfnrT5/gEQQFfT19p+YKcQuMs8//trXmaR91EpQSsXvcPBhCKeVMMF/rVuc9UkKVPInRlllvnRR2GywNpV7uAlYOReiQNoeOI8DQsKKWOmp0BKASZBDNvs2lVUK2MZZe4/RUog1AnZ5LPqqI/to4OZ8J+zev X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.05.25 18:29, SeongJae Park wrote: > Hi Enze, > > On Sat, 24 May 2025 20:55:36 +0800 Enze Li wrote: > >> The word 'primitive' is not explicit and has been deprecated in DAMON's >> context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to >> damon_operations"). To make the code easier to be understand, this >> commit renames remaining 'primitives' to 'operations' in header comments >> of DAMON source files. > > Thank you for this patch! The description makes sense to me. > > The title makes me bit confused, though. By reading it, I was assuming this > patch is changing some code. But this is changing only comments. Could you > please make the title more clearly specify that? E.g., "fix outdated comments > for monitoring primitives"? Heh, but wouldn't we be calling this things "primitives" in the current context? "don't refer to common code as 'primitives'" -- Cheers, David / dhildenb