From: David Hildenbrand <david@redhat.com>
To: SeongJae Park <sj@kernel.org>, Enze Li <lienze@kylinos.cn>
Cc: akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, enze.li@gmx.com
Subject: Re: [PATCH] mm/damon: rename primitives to operations
Date: Mon, 26 May 2025 11:31:45 +0200 [thread overview]
Message-ID: <dc5391f3-6e0a-4e6a-b319-0c602af29202@redhat.com> (raw)
In-Reply-To: <20250524162910.67889-1-sj@kernel.org>
On 24.05.25 18:29, SeongJae Park wrote:
> Hi Enze,
>
> On Sat, 24 May 2025 20:55:36 +0800 Enze Li <lienze@kylinos.cn> wrote:
>
>> The word 'primitive' is not explicit and has been deprecated in DAMON's
>> context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to
>> damon_operations"). To make the code easier to be understand, this
>> commit renames remaining 'primitives' to 'operations' in header comments
>> of DAMON source files.
>
> Thank you for this patch! The description makes sense to me.
>
> The title makes me bit confused, though. By reading it, I was assuming this
> patch is changing some code. But this is changing only comments. Could you
> please make the title more clearly specify that? E.g., "fix outdated comments
> for monitoring primitives"?
Heh, but wouldn't we be calling this things "primitives" in the current
context?
"don't refer to common code as 'primitives'"
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-05-26 9:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-24 12:55 Enze Li
2025-05-24 16:29 ` SeongJae Park
2025-05-26 6:25 ` Enze Li
2025-05-26 18:09 ` SeongJae Park
2025-05-30 1:57 ` Enze Li
2025-05-26 9:31 ` David Hildenbrand [this message]
2025-05-26 17:55 ` SeongJae Park
2025-05-29 17:26 ` SeongJae Park
2025-05-30 5:47 ` Enze Li
2025-05-26 6:09 ` [PATCH v2] mm/damon: fix outdated comments for monitoring primitives Enze Li
2025-05-26 18:12 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc5391f3-6e0a-4e6a-b319-0c602af29202@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=enze.li@gmx.com \
--cc=lienze@kylinos.cn \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox