From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C123C2BD09 for ; Tue, 9 Jul 2024 13:45:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4E986B00A0; Tue, 9 Jul 2024 09:45:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFECC6B00A6; Tue, 9 Jul 2024 09:45:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9E376B00BD; Tue, 9 Jul 2024 09:45:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 87A456B00A0 for ; Tue, 9 Jul 2024 09:45:01 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2A6F3A3B05 for ; Tue, 9 Jul 2024 13:45:01 +0000 (UTC) X-FDA: 82320335202.08.0F54080 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf25.hostedemail.com (Postfix) with ESMTP id 9CC4CA0023 for ; Tue, 9 Jul 2024 13:44:58 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=liwK4rqQ; spf=pass (imf25.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720532683; a=rsa-sha256; cv=none; b=Qwlkf1/PzZhjEi2KW7eUArKM3+EHFmIkLc1ydpLlyqIePqxvtKkiRnMlsxxdDU6wJ7hyKK KO1lMUEQrgi0GVIXXhqWxRRN6tN7mijQrAIvyBRKPgTT2QpxUduxLrZsRA99RreeJqflOT +nkG99vc1EGCo4CHBZ4RJyfO/Zv707w= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=liwK4rqQ; spf=pass (imf25.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720532683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7foDdIEaEZarA83YlTWrhHr9eoerSIsWhAOzAv0tLhI=; b=ryb/WhXBVwlwbJEQonrtgD0KIyB2qSwo54BYpCoaoCodnSGXV6Xz7kx6gqW9v7tURgFM/K /X+QC7LwiuRXHNVCpJh2txcjHDcLLBeHH0ZN4B9Lln3QJlTacbL0/o0cukD583UoghX4b5 aKnxHLInH51gpd3D6GvMZHTsgTcHMnM= Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 469DHa72011922; Tue, 9 Jul 2024 13:44:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding:mime-version; s=pp1; bh= 7foDdIEaEZarA83YlTWrhHr9eoerSIsWhAOzAv0tLhI=; b=liwK4rqQ7AluTZr6 +LKrd/bVOzY0KEzaWRNBY4DDhSs+AOeE67w62fMa2ln9weyUF4obFqRml6kcPz9l jHtgRBSFAFd/leIVGRH6l3Npsd7aBckaYEfsDuEtdQX4H4BF4ldNJLq6almPBWxq PYtwz7xNHKcBMAeywbQrRpfvEIX+W3ttrloNYNGp5TDGFdQ+k56w+V031ugUmqU4 EqkHRCAVo2L2wFYFgCf9cMNma+CZYOQBEbxT+qVDXLsIrNBrC65s6F+hinpzHbSG lwV8qNS1Nqni9wlO5KDZpa0uU+8bSJD9lNT67m+chuMV8uPYI9yoD8kU7V5EF/2U dja7dA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4095p6g4t8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jul 2024 13:44:50 +0000 (GMT) Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 469DinE1017947; Tue, 9 Jul 2024 13:44:49 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4095p6g4t5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jul 2024 13:44:49 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 469CFoFr025952; Tue, 9 Jul 2024 13:44:48 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 407hrmmnw6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jul 2024 13:44:48 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 469DijcR5571106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 9 Jul 2024 13:44:47 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 44AEF5805A; Tue, 9 Jul 2024 13:44:45 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 26E545803F; Tue, 9 Jul 2024 13:44:40 +0000 (GMT) Received: from [9.171.46.21] (unknown [9.171.46.21]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 9 Jul 2024 13:44:39 +0000 (GMT) Message-ID: Date: Tue, 9 Jul 2024 19:14:38 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] fs/hugetlbfs/inode.c: Ensure generic_hugetlb_get_unmapped_area() returns higher address than mmap_min_addr To: Oscar Salvador Cc: Andrew Morton , Muchun Song , "Kirill A . Shutemov" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Mike Rapoport , David Hildenbrand , Matthew Wilcox , Tony Battersby , "Aneesh Kumar K . V" , Nicholas Piggin , Alexei Starovoitov , Andy Lutomirski References: <20240709092122.41232-1-donettom@linux.ibm.com> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: sX8uQD2cqGnSx0zO7QMgNZVXilHOgZJk X-Proofpoint-ORIG-GUID: FVvQT8ST0Em3L7vbxTE95hA4ljwIkHqV Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-09_03,2024-07-09_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1011 mlxlogscore=999 priorityscore=1501 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407090085 X-Stat-Signature: 8u8p9ruinbog1bh7pdq3peczmusr46j9 X-Rspamd-Queue-Id: 9CC4CA0023 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720532698-596060 X-HE-Meta: U2FsdGVkX18IDNcUM6X5X9uwd43XbtsWQd3eq9TEo9SPSd4cElBKerxR0fX0woBDlUiOHG2CB5y1zfSL0GhRH9Xg71Ks4+DnvOGviKMBL05hf9GDJgkTsZ1d3BF5S+4+DRBTekSBOacPw0BKCVrhb/kN0MChcnXylG9mNlPOvhj+j3AxF9hz+Nw/KUPPTBUjIwY0frJSAIVJrgE5lDpoIFi0xHrcEPImyDDkcXzJe5KojGGe4BBEV4oY25TAMxxRiQh6gY7ZGOm/Vy4Ii2p5Vxj+BFj9EbSwjoiUGi54A5wP5bq8wRy57m2Rj2zW1h6e8cEWNfkWm7wkZUSZUTyz5Q1XnX9/q0Oq9+g21jSaobamh5qxs4+lzGflZ3M//rymMyHvMLdqvmNjlXBnIXGs6pShfc2Hqy9JYDNnbADetGOGbARa1Z+O2fZrNmw29qM6SkJtPjp75TxCV+/qH9T8YSQZ0s2GlvziDAb9ZfzzJsy52A4nznOUIgPQiw2OUrBaZKv+VdFrG6W88Ex0Gt5JwomrWqX3c+WmPPqD6KnFrBM+EiD337CTsRz+JSTo7zg52tRsYUqVsAqrPKYo0RU1+AEcakF5QREPocx5QuSzhpz9PXn+brsJQJyscmyoJJKBY5vxee2kdptRhvB/uHakgS6Z3NHNJ2Yp2zNvYBJU4qiAArPb+Y0fUIkEB74IZSf9JmteqdAZdLM2VMTL5vWocY40xgNhJlvJ/L0zEoCqCNbldM9dZKUlAq0IY4zqDc2ctsAbQ4bbLA/QEHfJv4iwDlcsOfL2Qm3DjYTYwFALlbDjzeaktvN2KSYSwjnr1z5vA0+4wdX2H/fIoJBUMQIfT/rACNVeJt06gbkqDXhN8hVv7tF2qYP3Agnd4eUwqkInCMyIfunyb1CV2JUZZUe/7mX8rKvlbsrhVhLIZZpNJZBGpMk59WXJUux3t8h0GccDvkuK425dOuyrvI+xeVR UCZ9rcNM ZmSFT03T2HG3GrlweDBL9AaDFh7rEJ5bxV+yrSnO8b0x3o7fobsMYi1uMxQWhxsRxttveWyhnKCMTwCJlLf5HOldFHPjCgFVjOU8FQaK6An6+JRgEo5On92hr7WN78VKP2H5I8XVow571Na+AY6KD+lW0s1vYE2OsX7FJgT5gi64d4aCmgDab+OupOGgQAeeIBdNZ/Ejw/T1VJml/gmzpXZh5XPmyQdg9GeFKE/64zATIe+jFNqci62ZuzBbEqZDAI6f7Bpiycsq4DnUBzZDep4Eh+SYjmhJnLai5fTPL4Xcsv6vPwVxczSvV+vin1NXiEeEJOT9d/KnMbunDyWCykx8LQ2BTnq71kv7O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/9/24 15:26, Oscar Salvador wrote: > On Tue, Jul 09, 2024 at 04:21:22AM -0500, Donet Tom wrote: >> generic_hugetlb_get_unmapped_area() was returning an address less >> than mmap_min_addr if the mmap argument addr, after alignment, was >> less than mmap_min_addr, causing mmap to fail. >> >> This is because current generic_hugetlb_get_unmapped_area() code does >> not take into account mmap_min_addr. >> >> This patch ensures that generic_hugetlb_get_unmapped_area() always returns >> an address that is greater than mmap_min_addr. Additionally, similar to >> generic_get_unmapped_area(), vm_end_gap() checks are included to ensure >> that the address is within the limit. > Hi Donet, > > jfyi: I am already working on other parts of the kernel to avoid hugetlb code > duplication vs mm core. > I am also working on getting rid of hugetlb-unmapped_area specific code > [1]. > I still need to perform some more tests but looks promising > code-deletion-wise: > > arch/parisc/mm/hugetlbpage.c | 23 ------- > arch/powerpc/mm/book3s64/slice.c | 49 ++++++++------ > arch/s390/mm/hugetlbpage.c | 84 ------------------------ > arch/s390/mm/mmap.c | 14 +++- > arch/sparc/kernel/sys_sparc_32.c | 16 +++-- > arch/sparc/kernel/sys_sparc_64.c | 36 ++++++++--- > arch/sparc/mm/hugetlbpage.c | 108 ------------------------------- > arch/x86/kernel/sys_x86_64.c | 27 +++++--- > arch/x86/mm/hugetlbpage.c | 100 ---------------------------- > fs/hugetlbfs/inode.c | 97 ++------------------------- > include/linux/hugetlb.h | 10 +++ > mm/mmap.c | 25 ++++++- > 12 files changed, 139 insertions(+), 450 deletions(-) > > I plan to post it in a day or two. > > [1] https://github.com/leberus/linux/tree/hugetlb-unmapped-area Thank you Oscar. The issue I am trying to fix will also get fixed by this new changes right. So should we drop my patch or should we continue it? -Donet