From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE15C282C4 for ; Tue, 12 Feb 2019 18:06:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C18AE2229F for ; Tue, 12 Feb 2019 18:05:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CzgdcPGo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C18AE2229F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 614CF8E0003; Tue, 12 Feb 2019 13:05:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C56B8E0001; Tue, 12 Feb 2019 13:05:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48D798E0003; Tue, 12 Feb 2019 13:05:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by kanga.kvack.org (Postfix) with ESMTP id 0BAA78E0001 for ; Tue, 12 Feb 2019 13:05:59 -0500 (EST) Received: by mail-pf1-f198.google.com with SMTP id b8so3020369pfe.10 for ; Tue, 12 Feb 2019 10:05:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:subject:to:cc:references:from :openpgp:autocrypt:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=d7SmRWbmaj++sZxRtUNFrmJpFRPcgviznHNC+zl6BPk=; b=jHIOdMsCIbLQ5vjwGcZZpC/HsqO60loxyuBna3+WWKdxeK4iLWB4CBaLpyzoL1mk7k ZXDCm/ol6Z3qDq4/jn3PWth7dMgyrFPmMl8lWth5SA6GC+peUeKPbw9a9gc7kEfsgz++ d10XrMjulz8P+Qe6yskdGUhJYUKN9vQGPY2j8AV/A6w1t8qJjwCPsKtXxlb75n9+a6cJ 5jq7xbOHfb0CvPUV1sj7Qq7kvABz1i6p5OmDL3mZV42g24anzkEQMCHGZ2Bp4q2j2svt OogQmOYbJjlntjGQ/2JlFdbmfpHWRqS58aoUIiyHBnAZeu1QbyH+ZG5/hRC8S/Op0Ttn R4+A== X-Gm-Message-State: AHQUAuZq0vDolBiFVsv1mdKzn4AZd/zrek1k+Uqiu7AmCco1Wt3FSd2y smQerhwX+Doz5M4HgpfDGeN8XYYw4Eyn4YmB/xkT4FXWZzUN7WgGwP00tkRLUn2ie2mDqONHpPi ptIyDtn++YVJ079TZSQRn05GzBMr2k1rTUu2wD5EGUPcoxr1oGX01FkDJt4Q2p5ssX/0cCjcRtY r/ZQGWYeFzbbT6cTmhXqLON1UF9Zak45p56iwwbGqlBALfuSKjkc5CaHpDwjxz6G7jRXDTwMAOu JsllJknWcOWqouBbkqCjBoHKWcgAu9OMDLVgOyeLVPR3o97TI4gZcbBu6enx6Fj71n/sFptVePI D9BQx5spy9HqeWFcsbuiVraBu9/2qFykN1QT2AlvwTtzU5lyJvEQYSUl4hLOBWKIFktF2J+sQct P X-Received: by 2002:a63:29c3:: with SMTP id p186mr4816815pgp.24.1549994758666; Tue, 12 Feb 2019 10:05:58 -0800 (PST) X-Received: by 2002:a63:29c3:: with SMTP id p186mr4816758pgp.24.1549994758041; Tue, 12 Feb 2019 10:05:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549994758; cv=none; d=google.com; s=arc-20160816; b=G3djHgkhB+w6FxFlXmnWpxOtdLYr1JdxnT6RMVkCutZDXvvI77SWQOlDe8AjU7tjD5 VsyNj6WA6Y9dY4v+H9vtwugPWEJC+//bVtpGes8ppufRQzmLyDJbPlEYCi2UrmG3zs2+ LuqArGrb/im+V16UoiDrVFdr6AJuqBH5j6J3UlaQV49fnZIa7yohsYKbCvAdy4sXI5x6 Rt51SgJdJOHis30DqW3bIvapv88QqgRrLkeJOfoJr/9UiTFHbgwmmuMHI3nEDjSL+cS0 2IoLNWke+rnV7TUO+BaF/g6YJBipplIcuCrab/Jvg/F70AR7sHbVhsfFZ7/gbjdCiE7w bdlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:autocrypt:openpgp:from:references:cc:to :subject:dkim-signature; bh=d7SmRWbmaj++sZxRtUNFrmJpFRPcgviznHNC+zl6BPk=; b=ywC7FXvhBtVe6AV8A4JlDXZj1VCF5l2FICQCsqkpj0Gip5N4zeeGm/dFprBglAd290 6eJsT/WIaOXOFkye/mj9cFAtmdJIq/Pz/1izkotDiBh1pwFeCJ6BEpVj9OfM67QoHEV3 s7FYJUUizSB46BP4aTAIf7zkLHY+TIWW/XjBWoCewOb7xzLYoRjUdh2/QtNHEPJUAFzt Nr240mt9RVyIpkt8248mQo+xZPrplSfq5vepmBNDKbZ3289+7/OTgb4jGzLu/7vpGIO7 t0LTBtQB+I15MSIHDUICQZUOK40HZcGUH0QK4pAe4ufqoq9D2vVoCQW1YzT/Ss4yVumg zKVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CzgdcPGo; spf=pass (google.com: domain of f.fainelli@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=f.fainelli@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id g10sor20149271pgq.32.2019.02.12.10.05.57 for (Google Transport Security); Tue, 12 Feb 2019 10:05:58 -0800 (PST) Received-SPF: pass (google.com: domain of f.fainelli@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CzgdcPGo; spf=pass (google.com: domain of f.fainelli@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=f.fainelli@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d7SmRWbmaj++sZxRtUNFrmJpFRPcgviznHNC+zl6BPk=; b=CzgdcPGoCpHwue57iwalp3JdTUZ1KWLS3UE07ooZic1Kt4E60h1uWXfnbiKYiKMm7D tuFdpU9i6FNga3Ha7bvNGeQbzFgSeCP0lqJfMgpJVRBaJjmTUAtMJwaqtzWrh/d+xaDZ BfmgQKz0xktiDyCV3r0H9ygpQCDMjpMyeDHmuS3Sy4+MoRX+4u25QV6mUz7SjO2Y/BO4 h17jgXp4RaiK/fSoqhBML3pTb9EaJV48T81Fs9cAUmmfX1Hx5psT42FxIYZdwxMoxleX I9I7gyk/iWapSZbA5b9QM0YzgtQTFC+yvtshLZNhJ9aKk7X4nZpnOrkZJ+/sC3q7NfVw bapA== X-Google-Smtp-Source: AHgI3IYsS4MY7VyHsC/0jHe2XplHy9uQAwNpKViCqG1cS/cSNur9X455vibyd+Vq7PliI2Yl0eeKqA== X-Received: by 2002:a63:d52:: with SMTP id 18mr4779270pgn.377.1549994757285; Tue, 12 Feb 2019 10:05:57 -0800 (PST) Received: from [10.67.48.220] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id t65sm28604734pfi.117.2019.02.12.10.05.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 10:05:56 -0800 (PST) Subject: Re: [net-next PATCH V2 1/3] mm: add dma_addr_t to struct page To: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org Cc: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Ilias Apalodimas , willy@infradead.org, Saeed Mahameed , Alexander Duyck , Andrew Morton , mgorman@techsingularity.net, "David S. Miller" , Tariq Toukan References: <154998290571.8783.11827147914798438839.stgit@firesoul> <154998294324.8783.9045146111677125556.stgit@firesoul> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Tue, 12 Feb 2019 10:05:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <154998294324.8783.9045146111677125556.stgit@firesoul> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/12/19 6:49 AM, Jesper Dangaard Brouer wrote: > The page_pool API is using page->private to store DMA addresses. > As pointed out by David Miller we can't use that on 32-bit architectures > with 64-bit DMA > > This patch adds a new dma_addr_t struct to allow storing DMA addresses > > Signed-off-by: Jesper Dangaard Brouer > Signed-off-by: Ilias Apalodimas > Acked-by: Andrew Morton > --- > include/linux/mm_types.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 2c471a2c43fa..581737bd0878 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -95,6 +95,13 @@ struct page { > */ > unsigned long private; > }; > + struct { /* page_pool used by netstack */ > + /** > + * @dma_addr: page_pool requires a 64-bit value even on > + * 32-bit architectures. > + */ Nit: might require? dma_addr_t, as you mention in the commit may have a different size based on CONFIG_ARCH_DMA_ADDR_T_64BIT. -- Florian