linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Vitaly Wool <vitaly.wool@konsulko.com>
Cc: Linux-MM <linux-mm@kvack.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] z3fold: stricter locking and more careful reclaim
Date: Sat, 05 Dec 2020 19:09:42 +0100	[thread overview]
Message-ID: <dc1afe6aa8ee0199b9be3b4a9a7de1865b192fe1.camel@gmx.de> (raw)
In-Reply-To: <CAM4kBB++pMOF75zcaqX+_Fb9KptR_OWCe8dGkMMxS-jP4M6-Mg@mail.gmail.com>

On Sat, 2020-12-05 at 12:38 +0100, Vitaly Wool wrote:
> On Fri, Dec 4, 2020 at 10:47 PM Mike Galbraith <efault@gmx.de> wrote:
> >
> > On Fri, 2020-12-04 at 22:04 +0200, Vitaly Wool wrote:
> > > Use temporary slots in reclaim function to avoid possible race when
> > > freeing those.
> > >
> > > While at it, make sure we check CLAIMED flag under page lock in the
> > > reclaim function to make sure we are not racing with z3fold_alloc().
> > >
> > > Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.com>
> >
> > FYI, with this applied, ltp::mm still crashes the RT kernel, with the
> > same rwlock corruption being what takes it down.
>
> So sad it does, but thanks a lot for the quick response.

Thanks for taking a poke at it.  Intuitive switch to write_lock() in
__release_z3fold_page() "fixed" the darn thing, but staring at it since
has yet to inspire a clear "and that works because...".

	-Mike



      reply	other threads:[~2020-12-05 18:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 20:04 Vitaly Wool
2020-12-04 21:47 ` Mike Galbraith
2020-12-05 11:38   ` Vitaly Wool
2020-12-05 18:09     ` Mike Galbraith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc1afe6aa8ee0199b9be3b4a9a7de1865b192fe1.camel@gmx.de \
    --to=efault@gmx.de \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-mm@kvack.org \
    --cc=vitaly.wool@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox