From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 616A4D0C5EA for ; Fri, 25 Oct 2024 08:40:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E95446B007B; Fri, 25 Oct 2024 04:40:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1E286B0082; Fri, 25 Oct 2024 04:40:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C49D86B0083; Fri, 25 Oct 2024 04:40:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A1B966B007B for ; Fri, 25 Oct 2024 04:40:38 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7C563C022F for ; Fri, 25 Oct 2024 08:40:17 +0000 (UTC) X-FDA: 82711477674.08.167E09E Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf21.hostedemail.com (Postfix) with ESMTP id C26441C0002 for ; Fri, 25 Oct 2024 08:39:57 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=DXfMeW5T; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=PHCCQOJT; spf=pass (imf21.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729845557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aX5MkTIcDOqCifeUjqp/Yge6LyR4nr0aIyPylSbVwNg=; b=lzmjf4n8V2NzHFd3UmioA0pbsx3tWyVqE4xITH/7J9vbkMeK7RJH+r7eyo8irqwUOtOHx3 JHviKfTZ851/qSymIlLpiHGU5q+rtlgBvSQU3PDwNbFDRXGziVM7GGKFfdoOMjXMiMS4ns Am08XuRSAYo4U3bmvil4B/8vX1j3p4M= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=DXfMeW5T; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=PHCCQOJT; spf=pass (imf21.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729845557; a=rsa-sha256; cv=pass; b=q3RnCPT0Cp9FlOJa4dhTB4SAL/4cM38tTi4qdysip8ybnNMK7Z9CJJGFXO15NlwbxYyjd5 Evwa7IfM58A0XGYE80AsimDTdlUrpq4MDtz0YoUxLzHep/y5Y+S6/lwBPiRXxgVx5+FELL mf2WnLdG6M4sKH6dB6XYiyQt9vMF23o= Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49P8BjDv021126; Fri, 25 Oct 2024 08:40:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=aX5MkTIcDOqCifeUjq p/Yge6LyR4nr0aIyPylSbVwNg=; b=DXfMeW5T7OK4NAsuGECAlAwKu/byP5AkRu 7b75fBg6g2dd2209ERPqNrfEATKxFQ1Q1QJ/4J6fvttmGhzZim5/NFSo76HvgP9v 8+gBeSSoAtVs2m9RKeYfBpjmplB5OyHDdILhOU3mlqUhBSdmkcBud+Dp1422WKZw UnpxBmZbX79HRmMwGaoUwKvgCWPhEQ51qi9SSqnKnhGmpvK1k7yD8PirmJQD9+FX ka6oQMw942unogZBM90E7zI42ad3Pukyew3vD7wSkykm9vXSHg1SHFYtxbCd7xY3 PtdpRoC3n+DB7iGQDAEBuiYrW3xMzW3YCPeYfCvR9WEnPqhvoE7A== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c545ckfw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 08:40:32 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49P7k2wa036033; Fri, 25 Oct 2024 08:40:31 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2176.outbound.protection.outlook.com [104.47.58.176]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42emh52a3g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 08:40:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MvpNdj+Zux/P5L8fXAH6LTUl/B66YGXo9H997+5f2G5UrV+V9VCLqAxZ9YZFa+HCzve64Sy40PlQnhnCH2x4xAroL1Vm82mVML/wEWQGW2/eDpiqDJbGJsYb9YdFpJ0VcUww2CvDmx79jYLJb3BWEfZGHfjzImUo16ayl9vLDGa5g9p+eXcamFmgSaxac+oNLcAo85c1gvvLlD1+StDxh+w9keyWU5BTmaBFTBEcwhnGILy22DoM21yeWqBiU/QPcV6LIOOY0BtISlsdJ/3tTfniXSq9T284ZN55reHQ/BMzX6zF6fluf/aLrxotD+LrN5wN4jRwRooLK3HEf+C2Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aX5MkTIcDOqCifeUjqp/Yge6LyR4nr0aIyPylSbVwNg=; b=pydJ8ry/45aMg8F3WsNmqplGw1AntuV3Q0jvaNB8QjRRQSdt+FIGs+j2SCrlKyegj+/s7/CdGnMG1ZMdQAuHODzyCH9HZoG7pK5dJDa/Fqk95ESfSHawVAuQVS3o7dLknbKYN8710aset3KMLhd4Z52PsSWyS6ttIx3Qp3H3xUwbaZ0Ql9dlruAegp6CcRZ988xAfzlu0K8G51v2ZfJupEkquum+LvhZQSHiSeLUn03YSJCjPG32R+JoMuwm+X+avpBkVjXiXRM8u9H5FjjGAZJ8jgPWrvXlZkHvyK+4wi7wQEHTBXGhyc4X3zByJEJ4jFjsdtJ3PXn2xqbJla6Plg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aX5MkTIcDOqCifeUjqp/Yge6LyR4nr0aIyPylSbVwNg=; b=PHCCQOJTEa/eUnOtvSVM1puuSe2HCt2Nnh8+jymXwJbDFHEwKnu4Khl9SXvgrM+xKw2p3h/UtFMNWHKRFoclKwqJcvgTtCpiHSNowwA44QMG4A/N8au3jeAu/B8QuvHPAfmPa1UjSFJ0H7yt61kMAEHPxUnIRZtiLCnlbslSx0I= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by CH3PR10MB7648.namprd10.prod.outlook.com (2603:10b6:610:179::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.23; Fri, 25 Oct 2024 08:40:28 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8093.014; Fri, 25 Oct 2024 08:40:28 +0000 Date: Fri, 25 Oct 2024 09:40:25 +0100 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/vma: miss to restore vmi.index on expansion failure Message-ID: References: <20241025031847.6274-1-richard.weiyang@gmail.com> <20241025031847.6274-2-richard.weiyang@gmail.com> <848b5701-9dec-4c69-bcca-f9186090978a@lucifer.local> <20241025075955.hczpuimxcfqhjv5x@master> <978e1d13-bb8b-437e-adc2-8af389064ae3@lucifer.local> <20241025083227.nt3twr5mgq7ssg3d@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025083227.nt3twr5mgq7ssg3d@master> X-ClientProxiedBy: LO2P123CA0032.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::20) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|CH3PR10MB7648:EE_ X-MS-Office365-Filtering-Correlation-Id: e44b7a35-89ee-4e4c-2a88-08dcf4d0ad9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xptGag6EBp4rxVyoyGGH0UQWWpZWd3vIWSO6RG5hyA7YrObBUdVHTtbiHyM5?= =?us-ascii?Q?TnMa19eY5qfndytyCuhZrwdB3W88tyLQDYh+BxtAbiqQMX0u52G4JaiPTp3O?= =?us-ascii?Q?mOJFH97reImGhlpzV6EAxKGdSVBYPID2HQOYbKPQvKGd5/nPW3hYLwql9DaC?= =?us-ascii?Q?3iMITvz0bN+Vto8VYZUpfWo4tziJm9YawjirtZAP6IYAQYFdT1pDQ37ouXmS?= =?us-ascii?Q?f1AdQAR/70YeCJsK6k7wxdF5qZYqA6p127N2zqghSCTYJ/Oo6Wk08SqWzSg7?= =?us-ascii?Q?gi2ANOXB1yA8c94T4K7IP/HiW3fsYOa+1pE7MvAhqZbbYx3xQK6RG6stVfgw?= =?us-ascii?Q?oTVtba3s0T3tadFF9NSWUhKQ5BdRodIKIG1p5d8cibtIJt4TAvl2yoooCOVt?= =?us-ascii?Q?qn0+/pDqGyYVYVSFfT4n4Iw5JEHb9qWXHO1E6sNhea+gxQMg12ogSrq2nlET?= =?us-ascii?Q?RjM/eixBPSwxC6gdcKjlHZ0z2OuvmwltGKGsmakyIbAFp861RCYfIr+lB71c?= =?us-ascii?Q?50u8bl9GVElA/MzsxWSbQ1SbD/EZ647tAGCVvQPt9501hRh6S7eAM8li/e7W?= =?us-ascii?Q?ZxExNMaZ9cUem9PJqikwnwbItrMfRBZMoa+AaH8ITVkfTIgHe07A0JzhgHak?= =?us-ascii?Q?fKF9Svq4cHjWmJniKXUIUcutEsjmBryYI4VVmzd15wF5IGfV1YIXKjB7pg6y?= =?us-ascii?Q?Ecuv9dwkckprdOt0cEZxi6otrqeIEdMFgzaSxAaV6jLdq9zX7iJx/+DQTr80?= =?us-ascii?Q?oBBiHy1FT/Bio92/oDVepl83L3Eqg5FdpxO5o3GXHHO28IDDkkLX3D7RnMKR?= =?us-ascii?Q?Uzpso7re5b0PhJiWxT5FQLTVEJ/8B9l/jSeP9n2fFYUthSrSabaWSzucErff?= =?us-ascii?Q?WlQ7rOAQDv+oVRwUwsnE0BVPWszPYpwCsHuTZ4Zc+Ok2ywb9SiW7c0aE/5yL?= =?us-ascii?Q?h38+oFHKZTHpbiUafxn4VYkhx2eF75uT5wTWEhTQ3IlyGaEaQ9WEHxlZax9K?= =?us-ascii?Q?iWCBTCL0bFLQ05m5bwXLaF0H7GxB+aHHH2A/8POoOAylso7b+yDvdFo4oexO?= =?us-ascii?Q?OG93rPjBX44WZcYs2Zq4Pjr+qM+64JGB4uytzV1FmmoMDqPP884W+tt4ku1s?= =?us-ascii?Q?BZw5/kNXrglEAbVDsFxj6e2e70JTd9mALur9Mbe/Qci5aS/XO/NLOKrrXxEW?= =?us-ascii?Q?3T+l9oeEbxM6YK0mqH8pv86K/HU5jALgGkjTIiPmRRbxYho0cO+i4Yn6iY1m?= =?us-ascii?Q?Vbd6f97sJroGJra2humQH6CP0VKH3Irk33oXZu0tDILM7z7ywD/2K2JDqZvE?= =?us-ascii?Q?JOPJlB7Dh75PH4HJRXNtl5fe?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(10070799003)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?THNsgHwzdfuQOQSc9wgmDE6yHmB419JYUPeFvwy/F02NlCjpBc1STSgV1rha?= =?us-ascii?Q?q+5rBxt38/UPlUqsR8V6TDZw588D4Y5AcANMwryBg6AYe7zabnYaVeYMwPaE?= =?us-ascii?Q?s08tVUmBosam3YlxScX3XMTMLS6HMQ4KhdiUrTJnKVoh5f/iRrelMGyMZwXZ?= =?us-ascii?Q?Bo/ajlkNThTaUorGY7GUaq19uss4NB6IE7oC6JUz2vSEPgVPqNhG9FwZ+uUo?= =?us-ascii?Q?ra/I93G5xgGY+3lwLSPYWRTpoO9nwwxd+cx/QSSy/i9UM09HT4CJ0GqPIpUc?= =?us-ascii?Q?llwGD2f+FjMNc/Qa/jQJT+eRiFMheuDIwss1Aa132y5OcSloSzWoPfc5Yfk3?= =?us-ascii?Q?dP3kbc9rV0cy6OVZEr3daRQsUfTL/R7N+jyLlAKlF8PbLuPeVXJGZ3kCdAm9?= =?us-ascii?Q?HU2POjDhIaK1QoJAQGz7ksYSuQkPTJEvZKAe0ERT8cNC6CIKZUfuZu2I9gJb?= =?us-ascii?Q?dxDc8QhZxT1cP/IpBVWowswm7B19F5jNLP+47gNa4AAOqIPphhUSuAHklTCQ?= =?us-ascii?Q?WjGXzDhsAzf1b8gx0zixrPGcfWlnPzntMfvFKn05zXD/IP19K2r3XwztY20p?= =?us-ascii?Q?ZMRVxBe6/rsnTNf6pi1FXNx9MXJidER324z7FRvxJ+jMcECw9fiKEVSaZoDF?= =?us-ascii?Q?NhraJItS+8N/ct6/KjvGIBqsE4CZTdDWr1X5cnt2qdzEDgvw2XZOSGhOrcO9?= =?us-ascii?Q?MEvHy26dVGnJi9aQKt0tH3tLX5+fVajEH8lLDGdeGwkiE0a8WIeBDnUte5pL?= =?us-ascii?Q?r0q7Nb/t0mNu7NL5w81TwU6lAJqkzxC7WY1/UIyp1+6R7A2MTo+4HBHdo4zf?= =?us-ascii?Q?dBbDYc6yUECNkdnXcJmsoLb1vetWzNUzexodYTf9x3f29qVBASDibzRUt3xm?= =?us-ascii?Q?UYZWhdWSekyQtQ4mzdeiP0U9B3Xw3lqiQi3DKJ5YargwTd8HErfV7mDyNuqm?= =?us-ascii?Q?lRI/csg22VAKMJsV3sPIu/Fck6SGRAJyVHOdGSkzU8cY7HweuHRYa9a/9S50?= =?us-ascii?Q?9bPDEv0y1jkou/XJapp/zfHlo7ka8O+Fczrrge1Uy1+1Nt7Trr51cm0axbE6?= =?us-ascii?Q?TlCf4M7PYgmqwhmQfSJlwLWsQ+XtORkRqkEnDM8xvQmJKsfyD34+VRau8cfV?= =?us-ascii?Q?DnuNkM/Q0tGnE6/4ucpuNIz3mBncXf23eKim+8oEVIrnD/GL8clEb01/thLx?= =?us-ascii?Q?r5X5wSOrROsRseOlDLNNg9P8Rh00afGIq6uehUJTIv9UbfusL/HKw+awO+Jz?= =?us-ascii?Q?Xo+Mq9tjjEFzZUqPHgD1aiQGI/CNKlvoVMpO5GmlfplANDjD+hR7t9ziiWos?= =?us-ascii?Q?/u0270GbcyVr4wlp1shiMpXbyfKqOqguxr8RxYJlAGhqm/a1jgEQgK1jupUY?= =?us-ascii?Q?2YsEAo1vyUE0FyYZg5422ZWtj4HBz3HiOlhH5jiuCR1E5mHC/NZRdsVcABAI?= =?us-ascii?Q?sk91mbOEsVTsBXMFnB1LyyhNagDT+GBSaDrgRpPOu435QT7j38Bn+43T5Ms1?= =?us-ascii?Q?rGYtohdavXMpTHv+urwe+8/9IgwFcibwerafeb33uRkbcos70qELm+qLnn0o?= =?us-ascii?Q?DHdYyxqlnwplXHmF/BCbU5U/7b3YC2BJsgc8wC3QRrhz47Vx+8uefwtCuZpI?= =?us-ascii?Q?nGocCiEgLUerQkSPuyrwnwHYHoGIoFfNu+MEORhbe1k9sV6uq5pU8+cGj9C3?= =?us-ascii?Q?pDCLVw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ixlQkxj2PRou0lQQ2S1Js639G8n7trr8vBmwKiTznFXw30XGhUut6RCae7R9THaQcbzayLZcCOYl4iCI7xpZBNfTCX41+YJsMO7yqD8xAQ8b6NsqgvBNXH6+n27hBTwy1KmnRzyxcQIVSYyH0zv2FfOXUBNaOcJ8BKPpsBNRnJhHNoM4w63iSolKPDS+oNKBU4SssB4/V9zIIUk+3eVSxjCsBPXdEsa0PcdBbBSaSZmtErbVRsCopOBLlK0VFtqpic0QslJW4yiHddSxJ6ktViefR+kAD4eL8YItHQp5+GhxpyhMhjggQkg83rYXenJOdlRd+TyqWdyJVjZmkSAMA6PR3ieqbF1jyn6vF34vaCHQ4araxHoUtTFINMOG2foPreKSemcGkHChaN+APlUvTa6S+DX2iPdm0+F13pptfOnEw/ZDBtQDsfAm+19DyMvn7R6KkMOn2XjutwgWVfCfxt1j4fxZsCBxv8CYyLjgesCHKeM8IvEnRchlpQR35CQ2QpK5GkJ5ONf99YWbEOSTrJr/fkHxv4CZQptjpBnFkoqnyWAH6XB0XAaw3yUk5/nZyx+oIjs5Z7bzI7ueQxu1yLaoS+4tZHPLfIL8pSDmJxY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e44b7a35-89ee-4e4c-2a88-08dcf4d0ad9d X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 08:40:28.3938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qfBVVDW10Mv1EwmvYs3OHiRQDSFkm60IwS+YaOf6c57O2n9ecYVVJaShVHoULQD3jHWdSkKe+XlRYC+Ugm9Bc/YBKo6OGPxqXnlRJocZG+c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7648 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-25_06,2024-10-25_02,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 mlxlogscore=809 mlxscore=0 bulkscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410250066 X-Proofpoint-ORIG-GUID: B6clGaAblt97-ozMAYgHnx1GjXHKEiQE X-Proofpoint-GUID: B6clGaAblt97-ozMAYgHnx1GjXHKEiQE X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: C26441C0002 X-Stat-Signature: r47pgskdmf1bf34xoyzo5w57rjzbitxm X-HE-Tag: 1729845597-220977 X-HE-Meta: U2FsdGVkX1/OdWhH+HerJMi+PxfXuzqtwqJknyU+VjGi4Cr5cEP0zM2YnWgFUrW4EvgBjp9pGokzJrrwLAv2RANZZZN4GeRLPumLu0U+HjuANRHmaPkjBFoXLG7YZUK5GK6msSLimgU78ymUCuBesgwpcXec916F+vtYxRjUebQ5Nm0Qy43UC3WdnFRtQc+o/c4eepUrHqL1K74yYIfdOAgH2I3LaRH/a1nP7GzrCcEfzTH+lszBSfRuAqym/k4U0B8beNDrObzhFMIjpnqU5OwEMOAU2YX8heXub+Gma6Kn4zKy074igQPzuR9Yzn2iB83emZ8KrDlJl+FDhysuysJIT4IIUwiKgYAorxOxLpLEs4AqBFv67BqmJ9vJsx1QwTHE2c0RL08ma9rUvgiPM+WN8dB5RjHzup4vpZcnd23vIeTt7QlM9ao3R+JHKOHdKPtImtriMq5sjVnkhycqsTQB2VZ59IXRjCqpQia5rHMr68Gj68nCh0MwQFGvNu01Mnr0/h9I48he0NPbbwCNedc/QoFhnWEDb835Ed0kBCvN+wov40SEqKlU9z7V7lE4YQvEVQrcWrTEus7fUZnE999faEdOCkSMgp6q048FxNf2BDT4rbTvoCWtUPwT1f0/ZkkoExd7oHsUh4lyjpCbgaJjjUT6yJFqm5GhNNoN2jgP/fsO/mv905AN69XW8dSJn8kjAdToTRXpY+7T6rI30SpJXbr60Rt5TGDcrXmclbBmHxR23un6gFM7LX9njloTVUcyPStOj9FoiDbv/KmDA+3gauhI94u9i85cHp76spJNzuqnD0zRK7yys86Sdx/c7X+Xaz2+plcfjKt9ru+9MHcXgRMNunRN4pOaVnOQXTkVVmqIsv92dZlufd4L1lQ/vZJwPy0L/P40415N1n17EGM79eE5+prqgMCGJKfH9S6A6YQu5XKMqHpPpa3HWVBsjh/IyJnK4dPYKv1eNVO Cn8xiNom mG4HkJbqIkpnEVpqZkQTgrJN92tIHSPtUD+tyA9bQGTHserHvjv4F10t2Aw6ffxk4difNDddO9/cr06sdABaQlVveGJp6ST8lWUDLBQUZ2FbRK/SDopmgaylAn5ckaVq3eiUSnyiAbmdEfBm6ncKL/MfIll8lZSJfkNhxuVyusqa1IbEXrR6lvE6h8/4n34t0LAYNJDBbYVXIofqQQz7AJ7YJ0aafNGOfFYPTudaQx+faVsqgmOAf8NAAM393mIbei0yZg9dxjUtPnzxKor9N9lhvn+E8YsZY9PTsp9Rui6Ra0LThRBUalFYNHVViiL1dyP9dqGUwWa4HJxbPWXaeeb4/ezmYMzBqmL09Bre2U7WoFHOOARUCQhg7/Z1KVMgqNFJWJMlQ2WItnbex94vlLTOM4OcTOp/8cYRU4UegyPpiyYSIS92cfTFGTTjmrCNFRBsn4geWsOQfo+jrIMBz4Cy0FBP9ylYUusXCi8g6N4imAa4i3DESomXfSng+YVXFvtAn77tLqeONMOMaFYNiyUkVNYkF+Zl53MDUlnKmMhe+tWor+Yx2h4oHmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 08:32:27AM +0000, Wei Yang wrote: > > But I have a question on your introduction of VMG_FLAG_JUST_EXPAND. > > Lets say just_expand is true and can_merge_left is true. Now we will adjust > vmg->start/vma/pgoff in if (can_merge_left). If we fail expansion, we won't > restore vmg->vma/start/pgoff, since just_expand is true. > > Is this what you expect? Yes, I explicitly wrote it to do that so it'd be a bit odd if I didn't realise :) Actually at this point, I don't think we need a follow up patch, sorry. As I think perhaps I will make this change as part of an existing series where I am reworking mmap_region(), since this is the only place where it matters, and it would make everything a hell of a lot clearer. Thanks for pointing this out, it's very useful (and an embarrassing oversight on my part...!), but I think it'd be better reworked this way. Thanks!