From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49CEC83F17 for ; Tue, 15 Jul 2025 20:48:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5740C6B0093; Tue, 15 Jul 2025 16:48:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54BEC6B0096; Tue, 15 Jul 2025 16:48:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 488AD6B0099; Tue, 15 Jul 2025 16:48:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3A78E6B0093 for ; Tue, 15 Jul 2025 16:48:41 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D8D9C57141 for ; Tue, 15 Jul 2025 20:48:40 +0000 (UTC) X-FDA: 83667687600.07.81557C4 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf08.hostedemail.com (Postfix) with ESMTP id 2812F160004 for ; Tue, 15 Jul 2025 20:48:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="y/UtC21L"; spf=pass (imf08.hostedemail.com: domain of hughd@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752612519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=FTTKwFRyrhD6+ykU2GdsaP5SBuru1chdmpkgyExGgG0=; b=zhVD5I4OPyS0FsOUVzSjiCoo6vVavcuetINma+bOYwCUBmBN9Eh5G/OhUu9HqyZTS/kBio 4YAAeZnxIoTTVXK4F6odyXIf8RiMPDsnNHKrlRjbVf8p6pIvprl0oFdpfXGPzeD+eFdpWi z2pDQHIBdMND738Aw74vfZFl+jyTJy8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="y/UtC21L"; spf=pass (imf08.hostedemail.com: domain of hughd@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752612519; a=rsa-sha256; cv=none; b=tkmOqVWgJd8VF2p/vKRTra80Kt0Ku0Q2pWve/f80QX/br1HUBAGf1PtH3hfbTaggBv93HM /I55CNAF6bIdgIQcPqdM53fERyLuKnyayzvDfzk/4WdhcllCrJIu/eJ3glhuS49OP5Qmws AOjA9e89G0C+wPV61ONH7yn8kuI/Uw8= Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-e82278e3889so4492296276.2 for ; Tue, 15 Jul 2025 13:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752612518; x=1753217318; darn=kvack.org; h=mime-version:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=FTTKwFRyrhD6+ykU2GdsaP5SBuru1chdmpkgyExGgG0=; b=y/UtC21LT8KbUR8uxwNJ52i9wGvWN/YQRg4DKK5CRcG4CKxy/eAPi1MrcJ2HFzNaQR y91SV/jcmNr0lXnOeMmr9zsrxg8M38qsIT21AlEVgL6IRJtg9Y4MMY/aFZx+9NQC3F1L kcBvZvy4dUBYOt8PD2ZkoEzwZD5D3lPFRY016C9aSLSiGE4RJiPwGJ2WuSthe81407Vi e3yJJrzR5UAVQFKQT2dYB8GhOOIflesRnfhmep6aJOipdTYTvHpDveJhcGb8tUBhAwpA AqMzU8e3QWJXbMBMDqzvA53vLdyh7+rxyeDGgoKCB1+y/hSUQo9vTmnjr7aP8MhRFrAd MjCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752612518; x=1753217318; h=mime-version:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FTTKwFRyrhD6+ykU2GdsaP5SBuru1chdmpkgyExGgG0=; b=BPxKNdgZ9EKwogQOjL0j3U+Hjjh0sfegHVxh/B7CUNxfoH6E/mGrZGSfXpgJd1OOwF Wzb3Ul9KR9D67WeGrmccxVG7ndELREiOQMsHvF07bc0OeeEPHTTzz9Ya6M83PP0H1n+2 R4EpKoFYgn3jAOWx2gJFyVxdCG7sI7zIl7Jyo8kHhLzKJB1REktkkTA8YCoa7rXrf1M4 lM0MCz6jbuFGIEhrovXzeLy4PAiMa4Bkk86wsnM8qOB+QZFT4mo2C/1yfiWx+43uAckR LJgHq+27AfZlBSP8UoLvfkCeg/V+EuQcnLs9ioLAzQvZhGgmdYRU5cxu9UpGOGEvznk3 Ws3w== X-Forwarded-Encrypted: i=1; AJvYcCVP3/0P5JYj2L5nm9ytPNJ0LcU3NDTlqNlyUKQBIwCQj1TE5moHlazQJwSebd+lLFPO38HGGVWLvA==@kvack.org X-Gm-Message-State: AOJu0YxXnRbGWrz3mIzcRlbiINmR19Io1xM/1kr5ym9d+6NbIv7Bdxf1 93JKxfrsyUfUYDKjioOnUjNjW17STEvtbtdJ3/eL8U9vt7eYuoOJSY0Ua6IpSmbTzCvsM9QLu8h 1DX28WA== X-Gm-Gg: ASbGnctJ5tdFebx6vtMrnUwdKtBQ8TwpnD+I/NVsm7G8+70Gn+NFOD39T16YD3JExzj EPg6oaaqyU+wA/Vz8F+rZZxWcDgtQ2kN1inSOTmpsv5TlphcZxIbqKMkyWwHelxsZ0KUWwh6XPe WJmZNOdX1VStCaJmxuDGEITf3iPErNPpcFCEytEparIMys7Qt4wVE/xOB3Wt9/9SFd5HxFpU9Or bNGioSG/EcsA6o1XOs6L/XqfjXF+7DZUh2LtkE9UZ5Yws2b5TzXEjGGg9ylA+83RafctO5x1V3/ AN7yYlu9dGpuzZ2/srWabekOyWqOycJrJsfHcmUr6IikishSoYoUsJlxBfO0xY9HIR4ElfmPBKg BfeGUx6ApeR/g3K2FIopT1A7E1584/Mwdf766vSki0EdSpnOBEf2LYUZz13boO5QhbG8gVXYyXa ySG0xlkjU= X-Google-Smtp-Source: AGHT+IHOSAtY659G5+exp7yCZF33W8srGQeyL3j/oH2/gamsU+onlzAGHnDWaxqTroAYTbNdtvu8Gw== X-Received: by 2002:a05:690c:600a:b0:70e:18c0:dac5 with SMTP id 00721157ae682-71834fd4cffmr12050927b3.10.1752612517888; Tue, 15 Jul 2025 13:48:37 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 00721157ae682-71823fedc2dsm5402727b3.95.2025.07.15.13.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 13:48:36 -0700 (PDT) Date: Tue, 15 Jul 2025 13:48:25 -0700 (PDT) From: Hugh Dickins To: Andrew Morton cc: Hugh Dickins , Shakeel Butt , Roman Gushchin , Johannes Weiner , Lorenzo Stoakes , Michal Hocko , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH mm-new] mm: optimize lru_note_cost() by adding lru_note_cost_unlock_irq() fix Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Queue-Id: 2812F160004 X-Rspamd-Server: rspam06 X-Stat-Signature: 1mersw3p68sgebrah8wk6widuokhrg84 X-HE-Tag: 1752612519-201193 X-HE-Meta: U2FsdGVkX19kTxrwxWkZWbQslKMcJjIVKS7dda4sx54+0/ncesxAFNkLpNVA5f+ZGUosoln5gOCp1UMGFJKlCb+wGjgPZ2GwQgEJM+0mpykBxDB1j0DEkiIRbASN1ve69HU2m/V7x9eIVmRD3jRxF5AvnmOtcOomVZgmvxYgK+sq3YZw89FdJWOWPJcI7PzQ5f/8CEGbvSBvsVCMN5oCJjHvs1f8/oIjflkNA34QY00F4M+HiIejz4lmx4AElFEmOrJ3bWB/ZwWkG8XGDvnzfLkKIlTuAZnQqK2kQ9gV+a/d14S8TYBF1HQr1n38jUo2B/lcm3H1yCOe2H1H04LtUSNE6pZk+JV4S/Kv70MtDd3yF6722E1Jn2/pRj39J+LGZ2vwByt+E1Ty6SYFpdDVw/784bK3N/fiK9Ksv020dcB0FYXc3e6L14/Gm8HjO2+a9bIBKQO/wsDtZnbqtK98xvymkM2xb62hhE2uXwqSQLCUORrpmrVQsfDfjV6hwKip9GQVlg5oFIHVjXbIZmZ6GsPX0tJbYqDXGy6fU86kRqRc6TrdOOSJhxYFZFDCI/fRJKmk5ylGQJYQ/eBNo7jvXeMkhMP99Yg+CrTKlTrFCbMJmCfzgj20L9sOA1QHW0r8s/9xJlVsMtINJ4Hl87Jcc7YkT8JSkzY3AftkFwl6l8ZlHAgmszDwd5LfthfkEFU0tE5VDfsqWdCzd+i4tSWBC1XiGggkH1QQ3ZhNB1uDOiqw5ANEGmeae4SqrLOYFa6cH+E3BaA/7vB+pjZJLl35WwaWBeWmYCXzw2hNkNJvTOnSPfRjzDNVb57LkL/eRP0k87OB68Vb7fU+J0jex7XzWLBGj0dudl82IZio4c0IuR8T8EPRnUCnZbRG1jbqz1D193YHgGELa43/Q6iVX5fxh3C6IOfquF8jtsLWgIx3EJZyIAJ5uQEbqxRwCBitVugHRW9TPNZgXz/D29dXTxh mdEq3tT4 PbZwN2TU7uX6TmHvCAL5SNNU7sqtGOl5ysQRqtRjlDtjMtYXVkZ0N3UuZ/JVOLs29DrGYUn8JrgtaOZDNe+/twHvV1BhqCRTgT+1rJHlNtiyMhSJgLbrCvS8HnyKup/ZwBG4uVenEr5t8bBKDbDuTIVdCxYANuUCsipwMr12RTjP3UAQ62STQWxY8JX328BLFlL7UfK4fjt/lyTCxewW0aDJnHwfNgoTDEG5z7DQmBkPpBE+0DmNtAPmnwE6n1r6MBLf/bPLVMiC0xeg8k0iPM77j/R9zq3TVqC/yTF2b2e9DGLx/O7FL3IpPsGbops0NC6n6ONvxXx+LmwSyYcSg8ukmnlBxUDDbewvX6NyvhQgf3bay83X860p2D/AKuuwyfxhWt1B3hqXPfOljZI2B3cfu5k2v/Nfsp9iEpzLwQjHntRJC9nq5q8yHd29K+OGtFuIBBuz0EFVXz8k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Delete the comment from above the deleted spin_lock_irq(): it was all to justify the first iteration's spin_lock_irq(), none suitable for moving down to where the parent's spin_lock_irq() is now done. Signed-off-by: Hugh Dickins --- Thank you all for the warm reception! Sorry, I missed this deletion. mm/swap.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/mm/swap.c b/mm/swap.c index 37053f222a6e..3632dd061beb 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -259,13 +259,6 @@ void lru_note_cost_unlock_irq(struct lruvec *lruvec, bool file, for (;;) { unsigned long lrusize; - /* - * Hold lruvec->lru_lock is safe here, since - * 1) The pinned lruvec in reclaim, or - * 2) From a pre-LRU page during refault (which also holds the - * rcu lock, so would be safe even if the page was on the LRU - * and could move simultaneously to a new lruvec). - */ /* Record cost event */ if (file) lruvec->file_cost += cost; -- 2.43.0