From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6259C10F1A for ; Tue, 7 May 2024 11:34:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 670156B00A7; Tue, 7 May 2024 07:34:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61FCA6B00A9; Tue, 7 May 2024 07:34:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 498A86B00AA; Tue, 7 May 2024 07:34:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 289956B00A7 for ; Tue, 7 May 2024 07:34:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C26FE121203 for ; Tue, 7 May 2024 11:34:44 +0000 (UTC) X-FDA: 82091392488.20.5972DB8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 71649C0010 for ; Tue, 7 May 2024 11:34:42 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=adw1elwy; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715081682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lan3cPUG5Yt6IkXc7I5/Riqtez6kdkIxfaTCOYdRoEo=; b=OiBMeMectF07uqc6gsQl+HesvKJFaHcSEW1H2/S6lqUQ/JBytzPm9vY9DjfCzKzZJFRZ47 ivdVcgIvpinZpr8Tk9sh7bmxOuzx0PBVsjb2DrxMX6/LUxUlQkFqvvjzzak6CcVvVc7qjS fS3Z13t9FnKECoRboYenZgqWdHf8yzc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=adw1elwy; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715081682; a=rsa-sha256; cv=none; b=3gC+FmT8BuDPIeIxJqWqC5sJh8lgDMvUG28qJ6FbwxfSd/3ok1ZoHwx6RCHoIbYV1+F+WE gZWKsWjsBXHBjg4R9QFK50gCOYSkmYex/Y3yer2xP69LYoXXzp+PKRLvFB/mq/23iTOl9w Zpo3dHyfLyVDeDcqoQzYUq/5K/QQ0gM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715081681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lan3cPUG5Yt6IkXc7I5/Riqtez6kdkIxfaTCOYdRoEo=; b=adw1elwyb7PGtdgqGNma9FHZcbxQc/cVQtHJUpyBKs9fHFat2c6tmaZ5vvU5i5vwGGcrKK y6CW4+wwncE4kap/lcQ8vAsb9onuvKgXOlmKjyBtLM8ulDd8cC9yhjPLhfaWhQpskiNUNW 75KX21HleprwRS4GwASA2QU7jHc/sBw= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-YdqK5MEFP76ykvA9A4UF0g-1; Tue, 07 May 2024 07:34:40 -0400 X-MC-Unique: YdqK5MEFP76ykvA9A4UF0g-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2e289eec4d1so28010381fa.0 for ; Tue, 07 May 2024 04:34:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715081678; x=1715686478; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lan3cPUG5Yt6IkXc7I5/Riqtez6kdkIxfaTCOYdRoEo=; b=s+iwGGYExNDCaZqRYKziP3ZbBOhNjN/+T5uVPN+cBOK68d5xbMXhdjrRZYGFD412Mu gGk624chtd7N4YhCB4j0fOW1eHB6rLMFj+KJrPqRc919hjXgAdib8PA3r2+M4LJtlSYP XlikVHWGnWE35zvFd7A9+4cM+VFZwOa75bJd4h/DRr1Qyk3qpljWrKpjG5rUuR4cVIgZ 5s0+XkwizeNteu6xsOrCVR9mKwaYi9fQvMu5TG06h5IPAPHo5R0bITvQuTAwr2xkOUOW z6tcERDdXC6T89ikmBKAhjRA7EqQ3FTWj+CqwAoTY6civD7Cz1nuDxr9Mg5C1V9zyBtB cqgw== X-Forwarded-Encrypted: i=1; AJvYcCVge2434gRpfQcUhClVOJ7bHw+zMmpurIp3DgxIMXtN1zxzrAlWEESpyPIFoTp2He3Rr/QGZPhoaUxJomr3SspNDzo= X-Gm-Message-State: AOJu0Ywp9IOSXdHQ3+f04z2LQ4PcgCk3THLWSs3DUfXWNYGXw1qW7hgu NF4wn4REUUdprVb15CewHwOwzyKDxV8rxHmmRHtk0dmgituMKz4iLRgwbP3VP8lbJnC4UeNUJWR mNLHDzIciEIo6IIkVFlpIRB7NOXFcY1/WIe31RBJwFZcJh0R6 X-Received: by 2002:a2e:9b4b:0:b0:2d8:dd28:8748 with SMTP id o11-20020a2e9b4b000000b002d8dd288748mr7781738ljj.1.1715081678656; Tue, 07 May 2024 04:34:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+mDDQ39EUx4ebsA/rmu4L/kvQUKoeQ38AgoHx9LxP0m2OurW75+DxCcQHk3R5cG0fpCoW8g== X-Received: by 2002:a2e:9b4b:0:b0:2d8:dd28:8748 with SMTP id o11-20020a2e9b4b000000b002d8dd288748mr7781717ljj.1.1715081678165; Tue, 07 May 2024 04:34:38 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id h11-20020adfe98b000000b00343d1d09550sm12779722wrm.60.2024.05.07.04.34.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 May 2024 04:34:37 -0700 (PDT) Message-ID: Date: Tue, 7 May 2024 13:34:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH] mm: align larger anonymous mappings on THP boundaries To: Ryan Roberts , Kefeng Wang , Yang Shi Cc: Matthew Wilcox , Yang Shi , riel@surriel.com, cl@linux.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ze Zuo References: <20231214223423.1133074-1-yang@os.amperecomputing.com> <1e8f5ac7-54ce-433a-ae53-81522b2320e1@arm.com> <1dc9a561-55f7-4d65-8b86-8a40fa0e84f9@arm.com> <6016c0e9-b567-4205-8368-1f1c76184a28@huawei.com> <2c14d9ad-c5a3-4f29-a6eb-633cdf3a5e9e@redhat.com> <4e7ce57f-cad1-44d5-a1d8-4cd47683a358@arm.com> <9ce8a0f4-d1af-44ea-87b5-57ebdb3d2910@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9ce8a0f4-d1af-44ea-87b5-57ebdb3d2910@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4udhz3y3ornss5cikf634wty5m1uz9gb X-Rspam-User: X-Rspamd-Queue-Id: 71649C0010 X-Rspamd-Server: rspam05 X-HE-Tag: 1715081682-578950 X-HE-Meta: U2FsdGVkX1+paNfeVh6niGl0GqmohWL/4ZKHlHgiO5v5Mg9AiVUz/padQMvUJkDM7e8kx3JSuDrr9eta4w726wuX/zX6BFhir5fHyQKsCsQv7dh+H1a/vCzN343nkx8hJ0jyfDocUhQxme15OpLTIZ6rOwEjE96S08kQ2D7h7JwrvuOF1d0Wlxly77VitjeKhfr9njBVpuXISu5qFzhoiBR/66wMUdSexmNpWBy+PH9SXeNAiI4zqAFJKyTOUoCAD4MEud3A28MGjY7Mf63oysoCDTOIQ4Pc7emNGqeEFCTzBBOjCQVYswj+yE0/Uzp02uCziZzudVZJqS/J0qUyRWK5nCIxlDHO0xVJ58/KVPcL18gFWqfPci5WTdnBw4H6HVHmbM2Q/SJx8aIxC6P6fiwQ++txZvQNmIrddho3IjKDrcGYNrnpko3d++hsS6LOEbnD2YeaiqsxcBSj/MR1MLmAG8ng8MPDcVOxpRgno9nL5ZmMEBSCbPOdCmzlWLWvVmudSZalJu6kgQ//5UMfQ5n/nhpfZaNG8w+a4d+8lRHVGeIDV1Qcu5w64LYyt7iF54kUZ4nQI0WljAdxA9UFIETJfe3cW2lpL17YCRKUgNoBC8Cs1e+zKKNwiNFTwiaDjR50Ly6FkMkXYUVGRJfCcv3cAVML/C+4SaPdM/b7dFfw/3lb4LE39ArPDhDdNefXXIUYvk0YiQVyysvvRIjk/aPodIL87YMDZ01BQZm2+oS4Lsb2tdHor65MoVdbJzebU9UlVZIicMieRNzZvMVdIzl8nEcT+kOtPDTJn03hU0Gvgs5pK2JEVGtOnbbnstGCpxTbAr5ODSdiXJRo0wG2sPJMJ4ppnxe4+Cp05WCXpKkdRv34LiKJ796NDErz0GTwURyK+qfn89PBnT3kWpZEmtFMxypicoV0bzOr39gPoyCy9isNcV119EtVoTDeJNtE3G/iAESbqxLSBnIXrxp 70qqjtCn SJ7qSO7y6J/D6UnAyEiH6JCORTgZDdFqZAynycj1e/PDjgbTMgzF8G5lzetyYvW0qRzU6Cvx7yt0YpYUgRDXD797fwN/3brXSS92bXtKBJ+eoMZdD2LwAM/ZNel/8ePA2alFwzfuOeuLChafnBWv7YnxXcVskmn4GO6ij+joNMoNArT6scxIUMaskrr2yocJ1qoQ0va7p5hmETAAb6VcxbZCke50zl7+8ZR67X5zMEXtX/ZilG67PsvzICyNjILF9E4jwQs54OEyURYbWHZFvR7y1WZ/Rhf3rfbUWpvu8Jm1widw/kNUwYSpY+U5pmd053xVd44jV8xQVypp+I4bi4yuWHZCIdkt0soF48TBJIK9so/8u8wb5bLddUVIklpavwCxnsGtYHZ8eB17xAp/9pLd0JEUNV76c5VaNXYRflW/7qC7i+QrFHP/rAIFbjYURoeos2SEtM0HYujUQ0XI8hjNRliChjeiOrw7iQc7u2NAwXQwoirARv3MMDXlBE/AoJSOYtcUtA+dwUEtqrT5JFSaLmowvdGfvebPK713pDGcDBUo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.05.24 13:26, Ryan Roberts wrote: > On 07/05/2024 12:14, Ryan Roberts wrote: >> On 07/05/2024 12:13, David Hildenbrand wrote: >>> >>>> https://github.com/intel/lmbench/blob/master/src/lat_mem_rd.c#L95 >>>> >>>>> suggest. If you want to try something semi-randomly; it might be useful to rule >>>>> out the arm64 contpte feature. I don't see how that would be interacting here if >>>>> mTHP is disabled (is it?). But its new for 6.9 and arm64 only. Disable with >>>>> ARM64_CONTPTE (needs EXPERT) at compile time. >>>> I don't enabled mTHP, so it should be not related about ARM64_CONTPTE, >>>> but will have a try. >>> >>> cont-pte can get active if we're just lucky when allocating pages in the right >>> order, correct Ryan? >> >> No it shouldn't do; it requires the pages to be in the same folio. Ah, my memory comes back. That's also important for folio_pte_batch() to currently work as expected I think. We could change that, though, and let cont-pte batch across folios. >> > > That said, if we got lucky in allocating the "right" pages, then we will end up > doing an extra function call and a bit of maths per every 16 PTEs in order to > figure out that the span is not contained by a single folio, before backing out > of an attempt to fold. That would probably be just about measurable. > > But the regression doesn't kick in until 96K, which is the step after 64K. I'd > expect to see the regression on 64K too if that was the issue. The cacheline is > 64K so I suspect it could be something related to the cache? > -- Cheers, David / dhildenb