From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F21C87FC9 for ; Wed, 30 Jul 2025 09:50:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 506B36B009E; Wed, 30 Jul 2025 05:50:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DECD6B009F; Wed, 30 Jul 2025 05:50:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CCF06B00A0; Wed, 30 Jul 2025 05:50:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2D1466B009E for ; Wed, 30 Jul 2025 05:50:21 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CE51FC02DC for ; Wed, 30 Jul 2025 09:50:20 +0000 (UTC) X-FDA: 83720460600.09.62C83D8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 3EADD80002 for ; Wed, 30 Jul 2025 09:50:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dxvADw85; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753869018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QUgKZRVMDl3NhvMSN0LsfGZHWOZBeE6am+rhVof/Ejg=; b=cf81cDAmzFxuQ+yAoJ5GFUOA4LFvqAUbWcMHrg0R2EkTwDTdq1XqbrfOW2RiViaIvDbgJw 65AGWNFAmFRxvaRvOVb9Yq8Azr1Z44sF5lTIJJMWzpExEN90NSm2zZ5RaRJwDKvbjXuMqM FzGvn9kmfpaOp3w5oQs57YnLEPuNqyA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dxvADw85; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753869018; a=rsa-sha256; cv=none; b=FEvwyC9iZxBjAMICZXIBWbAncGWXgin65msM16KBMN/YCWrV7DXqHDZpnhVJ3MsyvqqP59 vqoDx2abShTbLBajoguoJGdGQKsBwlOSXaO0CYnRZ4dYfYHoMi+lLLtBADJipV99qiuNaU 7kMy6kB8FaZGvsVB3Kl2TrkCAL6+OJ0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753869017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QUgKZRVMDl3NhvMSN0LsfGZHWOZBeE6am+rhVof/Ejg=; b=dxvADw85FkbCKmr94h7fM/lhIXo9RGzULYDTDRVxUL0PYcd7sPOCxndbNR+nE0JE3SeJDt 1YfjJN8PhrG3MJkWBnnRE4zGzm6k1tMtiyc7NBG8yJJ9h35ZvWtv96xwAmGvdpqiVHYbsk vx3vgBf7TR9Mx6059Z5RE9frHr98Sek= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-SP7wrm9CMieHDCWYHPgsCg-1; Wed, 30 Jul 2025 05:50:15 -0400 X-MC-Unique: SP7wrm9CMieHDCWYHPgsCg-1 X-Mimecast-MFC-AGG-ID: SP7wrm9CMieHDCWYHPgsCg_1753869015 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3b79629bd88so287812f8f.0 for ; Wed, 30 Jul 2025 02:50:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753869015; x=1754473815; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QUgKZRVMDl3NhvMSN0LsfGZHWOZBeE6am+rhVof/Ejg=; b=iiO+TzAGnAVe5n11DLwHmn09OEG80v7lqEtFTMQBSIStKfyQi5KtWPcgZSjFGfy+k5 Ct5PHOkz7IPWl0+S88mhpmg+2Fk1yS1MFnslVZnkKsswvy3ut5PeeWdR2gsmLar49R+b 2o/jS2htjBe/cbbCxz3hvriBe6A4FZF4KJoFdNudVNqAz7y5gTStBJhdVFVFoHxV/mWU 9KZ3br6EdCGD1gAPQ9V6ovGs3fps7id3i9ZJcg9YH1TohceOyQbC9iKkRc7NpYfQyOE7 PZuEC/YHb4i+vCKLQ8FCygWQLhma/Ltl7JoVBRJSDWQEbek5VVUtN6Im1lpEjcLLGf9J JqAw== X-Forwarded-Encrypted: i=1; AJvYcCVP7BcIe8134HcpEvFa09alVZRexoTPYC5eEnkMmslIZ8wlSh5T9FskUtl4tHuumlHQbHrY6iamSQ==@kvack.org X-Gm-Message-State: AOJu0YyzQ5/X5EIYkaRi7NZ3xfze5haP5DmiCaYUwzkkA7DOau50RQZw jSRwoFyLWiL0cTbwRLhyCIZveA5h5gZHlsnC5dq99B4AegedYOA3m+fZozW5avyYQzr54CL17+5 5bgNF87dV8m8DBe92fOF39rn9f3xOEgpyEZ89HxzutM/6WOYVtSEw X-Gm-Gg: ASbGncsfWpw4fYEaaOB5IUg2WQvuAtfefQ8YmTCVTbKG2Dit6ucRZgvJ5ADRJXZvARd l8+hDTTuDeSKScwgWQhRVIqa7OPW0pzM9zTQ0Eoqim+xOPjy8OcyhsdMUegwAl5P6tm2qNDY5lM jxyplSKSgQEyO6UcfRYBSAlMDNK2DRLcgOmvBhAul9nHWSYSrPI+BwZJdt5Ib6k8P4zdRnvXSpx iNK0wFyDTwlsA+C3jn+yMz/zDeEPjSCa2Qzjuu4bS6vW/7wOoq27+F3t8963fplch20Kej+lvnn pRAWCkeL6+fweANwgzibfQ9/+EokXbp4CzLq0CPtIzBS+UthyeylEyg2/o7NgQ== X-Received: by 2002:a05:6000:2212:b0:3b7:944d:e5e6 with SMTP id ffacd0b85a97d-3b794ff1593mr1943251f8f.36.1753869014486; Wed, 30 Jul 2025 02:50:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHqBKdJ+PU+n21Ilgc5DHwWl9Q+AlsJ7MBOHJX8HsuwQakd63Pz2XTTFoHVvEo2YgYITY4RRw== X-Received: by 2002:a05:6000:2212:b0:3b7:944d:e5e6 with SMTP id ffacd0b85a97d-3b794ff1593mr1943199f8f.36.1753869013969; Wed, 30 Jul 2025 02:50:13 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b788f5f255sm9239196f8f.13.2025.07.30.02.50.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jul 2025 02:50:13 -0700 (PDT) Message-ID: Date: Wed, 30 Jul 2025 11:50:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v2 01/11] mm/zone_device: support large zone device private folios To: Balbir Singh , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Shuah Khan , Barry Song , Baolin Wang , Ryan Roberts , Matthew Wilcox , Peter Xu , Zi Yan , Kefeng Wang , Jane Chu , Alistair Popple , Donet Tom , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20250730092139.3890844-1-balbirs@nvidia.com> <20250730092139.3890844-2-balbirs@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250730092139.3890844-2-balbirs@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 87sy6rC80o7S-ibZaXKt6Pcqdq1rKFqIYMC9DS3z-Gk_1753869015 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 31qipjwph8df86w41xczu6jorypwz9rc X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3EADD80002 X-Rspam-User: X-HE-Tag: 1753869018-669343 X-HE-Meta: U2FsdGVkX1+2DPmNl3A29ma4sKfDiN2ywTbxH05jJHJBQR/ww0dHiD3Z4w7ssMBo5PZRh6jeg9h+XAxZUMP2nvWL07oGA0RSzpV17nHulK34mSmgJ6wOJUp9lFOrSECoPW4KdWY2njnqwB4vN7x0JQS4bdtpqTFHzJPtcmDJBi08uOvodGt9qdmfxrIf8StndCmoPqdvpLlW0GCZUVKJKy5mtJ1KybUd2P3f2t3kgcaJDcCnlrPsvjZ1cKFr2TDLKuo5eq8KQu8GR3sJDPWgVaoIXo0H+S4e+EQ/1/KAUU8XVYrbMtbHvuunYMasedYxLez/jyr00fgWiDp4+qC3H0+hAFbfj9NoCVPxF6MzNj3vQ6fgEGw6iKtFRFlKWtS73HIWIbeVR8EwwMC02ev6tFiL6HARgdLh/3QFQxIUGAroA2+xQLkdSH9nM9wEZjrN3t4KO++OwU3TEx7MjZY832YjnLebgHDOdKN5JGu7nRaYKQ54LHSRpm1zoeKZY0OJPQtA9e0g6qyY/reY085DxfewQHQBvLqPCCgwkemZ+rAVzp2HNi3Qd+ZPYtopzVlgJrF02snhtdcUugm3TT5IECCoXVFY1M+UrJ2kC/qOKBJPJvL5Pnr7yqwKZum52pkenNkqcghLe50lcgsCgXkzwIYVZRyuZfMW/LwLdmxMifVdSadwNSdduq+zPd1207HSu/aiz7TOQRfwTR7aXNk48+SgfbGrhtprG339ygVF3rOjOFXc+EvJajBPnYsG28LeF9yA+8Mq4K49Xv4Yj8sA+ZvFPV+YqORKW37TIIC4l4k8H4EjpOjZBhTYcXy/CUtjS5vb8wVLDaWMyu7KHAKs16yS+PI5w2eatyWnZbJ2AFcwomFWdYF5mHceZAhxcyUYmJqscIHx0DUauV3/EjuwkeH4mQ+KxOc/BiQUNpu6CMnzfW0qUpBM3K7osb+V5U28frLzzukcxby5tD+52SK 5N58y9MQ NVOUFOCVdoYcuHjnuIfCoFSt8aNPU1vpH3adDIKZRrqbCqtv7Yt0zzdIdmOZZRrB4Res3OjVN0Z8ItgRatBvePbnKwX1SDiYlwuAdm+7daoNuYzoFzM8O8j1UIqD/7++ZeR+f7lE239hqw4A/u/5K3rVSEAD0MZ/V3zgZEU8DbyC6Z49XvtkFwrqgewcuvcrMFsCyX8rsMw4vw1Z0+BQN7NSexbWglJDapRSsZHK8X7c6rakBaS+BvP68EL9m8N9toorobFSBzkJh0qEp8KXxKanXsy7YsWIDzUgdRzZiOhGqPgiCmIRxKQyemEOwz3mrYgZ5A9RONoY64zw9vjzE3WIitUEp7hZ+iyxI2V12AZR6wPp3Py6ik5gY21u87zKbmYYvbpAooVvlRm/DC7aEUjvBrnzPfB7OsZQ9w/o/gxBd8E/spOgiXv4RVu252svX6zVTRVR5gKL/zyC8j9t8as1Z7JzWryT32umzsuZN58gYZCCRpAh/gI4qX4qC0jUBu1a7sMMC4FtgH+0Eeal9ZOFd1ZzNCcyuBP1V6TlPCGoDqqaqSkYYkG8EK+V0Q6Rxrw/UuMoMHBZrsv0ilqHssw5LfLIWCrb6VApGKC0FgZTz1qtZM6kyotpFj0ZEyLZdKfsApP+4NAOrd4K0gDsJuS7+VkH5YlxYJP5ZPkgLrBIYjosiL2Ygsl1d3YXjKBW74qTUqbzzysvl90txlzqPLOq0T0rQU5B2Aac9SB3oqkGF7v7VdKwSCMfTywhL0Nfm7BG0UZLMiFzjlQzXeLDOc4j0htKm3xEH2pJMprVrsq7/P+FVra3zkIzmGY3yjIy7H++A+LxU/MT2L2hMI+XCR0v0pF74Zi0BIz9H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.07.25 11:21, Balbir Singh wrote: > Add routines to support allocation of large order zone device folios > and helper functions for zone device folios, to check if a folio is > device private and helpers for setting zone device data. > > When large folios are used, the existing page_free() callback in > pgmap is called when the folio is freed, this is true for both > PAGE_SIZE and higher order pages. > > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danilo Krummrich > Cc: David Airlie > Cc: Simona Vetter > Cc: "Jérôme Glisse" > Cc: Shuah Khan > Cc: David Hildenbrand > Cc: Barry Song > Cc: Baolin Wang > Cc: Ryan Roberts > Cc: Matthew Wilcox > Cc: Peter Xu > Cc: Zi Yan > Cc: Kefeng Wang > Cc: Jane Chu > Cc: Alistair Popple > Cc: Donet Tom > Cc: Ralph Campbell > Cc: Mika Penttilä > Cc: Matthew Brost > Cc: Francois Dugast > > Signed-off-by: Balbir Singh > --- > include/linux/memremap.h | 10 ++++++++- > mm/memremap.c | 48 +++++++++++++++++++++++++++++----------- > 2 files changed, 44 insertions(+), 14 deletions(-) > > diff --git a/include/linux/memremap.h b/include/linux/memremap.h > index 4aa151914eab..a0723b35eeaa 100644 > --- a/include/linux/memremap.h > +++ b/include/linux/memremap.h > @@ -199,7 +199,7 @@ static inline bool folio_is_fsdax(const struct folio *folio) > } > > #ifdef CONFIG_ZONE_DEVICE > -void zone_device_page_init(struct page *page); > +void zone_device_folio_init(struct folio *folio, unsigned int order); > void *memremap_pages(struct dev_pagemap *pgmap, int nid); > void memunmap_pages(struct dev_pagemap *pgmap); > void *devm_memremap_pages(struct device *dev, struct dev_pagemap *pgmap); > @@ -209,6 +209,14 @@ struct dev_pagemap *get_dev_pagemap(unsigned long pfn, > bool pgmap_pfn_valid(struct dev_pagemap *pgmap, unsigned long pfn); > > unsigned long memremap_compat_align(void); > + > +static inline void zone_device_page_init(struct page *page) > +{ > + struct folio *folio = page_folio(page); > + > + zone_device_folio_init(folio, 0); > +} > + > #else > static inline void *devm_memremap_pages(struct device *dev, > struct dev_pagemap *pgmap) > diff --git a/mm/memremap.c b/mm/memremap.c > index b0ce0d8254bd..3ca136e7455e 100644 > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -427,20 +427,19 @@ EXPORT_SYMBOL_GPL(get_dev_pagemap); > void free_zone_device_folio(struct folio *folio) > { > struct dev_pagemap *pgmap = folio->pgmap; > + unsigned int nr = folio_nr_pages(folio); > + int i; "unsigned long" is to be future-proof. (folio_nr_pages() returns long and probably soon unsigned long) [ I'd probably all it "nr_pages" ] > > if (WARN_ON_ONCE(!pgmap)) > return; > > mem_cgroup_uncharge(folio); > > - /* > - * Note: we don't expect anonymous compound pages yet. Once supported > - * and we could PTE-map them similar to THP, we'd have to clear > - * PG_anon_exclusive on all tail pages. > - */ > if (folio_test_anon(folio)) { > - VM_BUG_ON_FOLIO(folio_test_large(folio), folio); > - __ClearPageAnonExclusive(folio_page(folio, 0)); > + for (i = 0; i < nr; i++) > + __ClearPageAnonExclusive(folio_page(folio, i)); > + } else { > + VM_WARN_ON_ONCE(folio_test_large(folio)); > } > > /* > @@ -464,11 +463,20 @@ void free_zone_device_folio(struct folio *folio) > > switch (pgmap->type) { > case MEMORY_DEVICE_PRIVATE: > + if (folio_test_large(folio)) { Could do "nr > 1" if we already have that value around. > + folio_unqueue_deferred_split(folio); I think I asked that already but maybe missed the reply: Should these folios ever be added to the deferred split queue and is there any value in splitting them under memory pressure in the shrinker? My gut feeling is "No", because the buddy cannot make use of these folios, but maybe there is an interesting case where we want that behavior? > + > + percpu_ref_put_many(&folio->pgmap->ref, nr - 1); > + } > + pgmap->ops->page_free(&folio->page); > + percpu_ref_put(&folio->pgmap->ref); Coold you simply do a percpu_ref_put_many(&folio->pgmap->ref, nr); here, or would that be problematic? > + folio->page.mapping = NULL; > + break; > case MEMORY_DEVICE_COHERENT: > if (WARN_ON_ONCE(!pgmap->ops || !pgmap->ops->page_free)) > break; > - pgmap->ops->page_free(folio_page(folio, 0)); > - put_dev_pagemap(pgmap); > + pgmap->ops->page_free(&folio->page); > + percpu_ref_put(&folio->pgmap->ref); > break; > > case MEMORY_DEVICE_GENERIC: > @@ -491,14 +499,28 @@ void free_zone_device_folio(struct folio *folio) > } > } > > -void zone_device_page_init(struct page *page) > +void zone_device_folio_init(struct folio *folio, unsigned int order) > { > + struct page *page = folio_page(folio, 0); > + > + VM_WARN_ON_ONCE(order > MAX_ORDER_NR_PAGES); > + > + /* > + * Only PMD level migration is supported for THP migration > + */ Talking about something that does not exist yet (and is very specific) sounds a bit weird. Should this go into a different patch, or could we rephrase the comment to be a bit more generic? In this patch here, nothing would really object to "order" being intermediate. (also, this is a device_private limitation? shouldn't that check go somehwere where we can perform this device-private limitation check?) > + WARN_ON_ONCE(order && order != HPAGE_PMD_ORDER); > + > /* > * Drivers shouldn't be allocating pages after calling > * memunmap_pages(). > */ > - WARN_ON_ONCE(!percpu_ref_tryget_live(&page_pgmap(page)->ref)); > - set_page_count(page, 1); > + WARN_ON_ONCE(!percpu_ref_tryget_many(&page_pgmap(page)->ref, 1 << order)); > + folio_set_count(folio, 1); > lock_page(page); > + > + if (order > 1) { > + prep_compound_page(page, order); > + folio_set_large_rmappable(folio); > + } > } > -EXPORT_SYMBOL_GPL(zone_device_page_init); > +EXPORT_SYMBOL_GPL(zone_device_folio_init); -- Cheers, David / dhildenb