From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8503C19F32 for ; Fri, 7 Mar 2025 13:05:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 152E96B0083; Fri, 7 Mar 2025 08:05:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DA406B0085; Fri, 7 Mar 2025 08:05:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E489B6B0088; Fri, 7 Mar 2025 08:05:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C2C986B0083 for ; Fri, 7 Mar 2025 08:05:12 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A664A80A2F for ; Fri, 7 Mar 2025 13:05:13 +0000 (UTC) X-FDA: 83194775706.02.E771E29 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf24.hostedemail.com (Postfix) with ESMTP id 3D94D180013 for ; Fri, 7 Mar 2025 13:05:10 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=hn3sqhdP; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=RLgu4gx9; spf=pass (imf24.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741352710; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n0fwKgudzheSlnzVGCu1yzcMSow1KyEzps6AIzbk/Z8=; b=Q1bQYQk8SdeT4LYHvDrELCj4vKt2hb3MXh01J0qT1Cv5EGgUZXD0F/OFYgDxWPn7/uP0jv 805KTawYYn3E094L1Txgg52Rz03RVs4pmXSQPNnWJJdqP5uLz9baF7RcQPJ+Zy3PCN3RUC qy4Du0XQmY3Qpt2RklXUrZ9YINK3uok= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=hn3sqhdP; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=RLgu4gx9; spf=pass (imf24.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741352710; a=rsa-sha256; cv=pass; b=F1AlhCxRyJYhEqQCo7XUAHuN1onXCw8VTVbfzQC7BgagOo6wjoWY/pz4A8sbNjb5JVV5iy hOuuwdy0g16oW4My31Q8tRUa4z6LRkyGW4fO8PleXF1BD46l6UbTV91BYc5S9XaFGxTi89 /JJsNATD7n92onccS6CYbl7xg+I5R60= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5271u2NH031499; Fri, 7 Mar 2025 13:05:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=n0fwKgudzheSlnzVGC u1yzcMSow1KyEzps6AIzbk/Z8=; b=hn3sqhdPrmidnvjW5tQKJvCen5saxQl+YI sXLabLQBC/AqSO9a7/ccrxByAjruLiHlvOC9SwbzWR6Yci5YZwHuCckyOQaqkRME HmbD8jgTFs2vUwcaty2gWj/yUNN8KGyWttGu2EnkWVLByzDeHl3rBN3HwGC81pj5 EMVOvaDcBc+tvYz4LHuNJusLIGSgE8xkrYA/aOVaAihR8/8jcUWYqsQvTG6H3Twi yeeNzeHNRXGX+QklP5jVMH+lCGYjfqbKfz6wkAB6eXip6/abaK38twBHIfVjCu+W Yeig3eVQg1N0/N2xiArUPNTcFv2CZvu0viUG/1jKr1uufmf1YOlQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 453u86v3ca-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Mar 2025 13:05:07 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 527CO9bG015762; Fri, 7 Mar 2025 13:05:06 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2172.outbound.protection.outlook.com [104.47.73.172]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 453rpek28w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Mar 2025 13:05:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XECKonIU/8sSgOZ4gScPw6p2vvT+Iv+BK6dq0WPK+RkSPyiOFWnuhiG2BGhlOEuKue/mWhtXSQbhjgqeEJp6R+p4bDdyKjc7zYiyIaQg1RzhTBnwkWun1cJ+xnxSEpYl09SwpA3whGqzoL75qAOqDL44O1VNRdBtBRcByyndkoGd8u/9I285lsTia1Q/ndXH1MkhFEGyVZcAkOexU0EW+X/4riQ5SrblOMHvgQkR5P2XPDgedsAA4oILS2fnu6XtmLTfAK8lXF+JhTf1fmsflFdwa5p6+/BAF0E14vRIluze1yuNdjZHHJAA4sD8NrrgqXGxYrj8ZklkxwLsBnjYyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n0fwKgudzheSlnzVGCu1yzcMSow1KyEzps6AIzbk/Z8=; b=H6QkQz4HH+FIDaq6IJDXuYzIemTGihhI55PLryXcxZG+bK8kU7AzTn3L6pxcKZJ0ZnCmP0o6y29B9OowZPOn5nrO5LFdhQ/5UROB68+4eGdcJeE0bhBKTu/WXvDVRsv/cdyaobbCDF+htO1ZJf8VcrLdpsmQvE+zldfNIfj4gJWQ5K1ajc0sIrrGFwkyBp/6sWZfgGbM10Yq1jqpc1zsURJVWEr56wUFZGm0EX3RCRQUjsSnF86VztWbDp6rJ010QB+2rKUEUEPy2FnpiOO+BTx/dND1vqh9zqgXh7fn9vG0Zo9hv/UFnxF07vdVwqY9LCa0ztRwiid/TPId0XCRCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n0fwKgudzheSlnzVGCu1yzcMSow1KyEzps6AIzbk/Z8=; b=RLgu4gx9qZE5wdUpWg/v4oxobrgkGTY46RARmRRRPnXIonIztx1wgefHXg71Mmefaq26k1ixLuxUu95V80hBq4Y2OdyekgIbT6XJgiexNmAieNCpMSn+6DjUNYuZeu3itARFWIm8UqW44N+hLxbCV+X8zURyDzbSMED1DOXgn/g= Received: from MN2PR10MB4112.namprd10.prod.outlook.com (2603:10b6:208:11e::33) by SJ0PR10MB5565.namprd10.prod.outlook.com (2603:10b6:a03:3d2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Fri, 7 Mar 2025 13:05:03 +0000 Received: from MN2PR10MB4112.namprd10.prod.outlook.com ([fe80::3256:3c8c:73a9:5b9c]) by MN2PR10MB4112.namprd10.prod.outlook.com ([fe80::3256:3c8c:73a9:5b9c%7]) with mapi id 15.20.8489.025; Fri, 7 Mar 2025 13:05:02 +0000 Date: Fri, 7 Mar 2025 13:04:57 +0000 From: Lorenzo Stoakes To: Ryan Roberts Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v1] mm/madvise: Always set ptes via arch helpers Message-ID: References: <20250307123307.262298-1-ryan.roberts@arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250307123307.262298-1-ryan.roberts@arm.com> X-ClientProxiedBy: LO2P265CA0405.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::33) To MN2PR10MB4112.namprd10.prod.outlook.com (2603:10b6:208:11e::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB4112:EE_|SJ0PR10MB5565:EE_ X-MS-Office365-Filtering-Correlation-Id: 44af6571-318f-492b-1a74-08dd5d78abe4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?27xAqfx4WLtWTSuKqSdfuwIOzsNh9Q31fNFVqCwL15X2yxmvr+pGrAm43ESp?= =?us-ascii?Q?DdI40J/+OML+gX6yvXaH5YwWut8z8IhUPrFHWcgqdMRcgVf0eP7APeWpYTA7?= =?us-ascii?Q?pobTG2BDlATFwHcou3OVSKElRouvsgzYCGgIxrZoXHds2Moyf6YrHUVQ58VY?= =?us-ascii?Q?3mLAa+bfEi/ZgOfWoqcatlxaiBphDPqNJ1BQC4n+RPXI+36QZXJRMd9tvNm+?= =?us-ascii?Q?F19914TIJalH/TltvlehBYam5P0wpw2vctAiUuspCO1I1lNu2KlVpYtcvcE3?= =?us-ascii?Q?hREu9XzOOZrVucttAA+HZ4e81r/GQK/tWHfRU0sLWIkL1IJLfuMUg8ST/kJJ?= =?us-ascii?Q?uoQUDSZ/rlKOn7hxMV+KnTrtQ2L4AM3OWDJcer1EAnA0xc0FsszcWYMIC796?= =?us-ascii?Q?Mvxd1Dx8MvdVxVodvxsOH3eivbFngBSI6bORAGErw3mRb0jku1FbCD8ds2qH?= =?us-ascii?Q?1KKP+xSbS1+xWhKbnpWQ4mAQR409gwUpQJ6t6XRKStd+godVM2gbs2uTr1IN?= =?us-ascii?Q?yt+pzP08gMrFFX7DOC/X6ntMTEj46r5rlvSj0bwEVCOTa5k9DvaoWqqrf5Kb?= =?us-ascii?Q?3BuvuWlrfNyzrLhqIZX0Cmsk2YzXnjDjmv1DGDmsnp68134O6x07C5mMsY3y?= =?us-ascii?Q?laWQSwagcfXfMNyeCm9kZEUerumb6ZdgzkshS73Dv9Au7wV5sqzQSerPQmdV?= =?us-ascii?Q?ENKyQ1CEy3X3U+y+07qD2s/j8uO0pJR2onb38LIR1MGuNIk8aG5kHWP7V4Wv?= =?us-ascii?Q?l5Bb9qt9wWeI+WL8XAxOcx3loUrLWyEGomFaY3M/euK88Uc1LMhx4pTK7kJK?= =?us-ascii?Q?fTyXYHksyOa/335U4UMJcYR8Nulb0eDw0lvzBJbtSii0r8vwSNVU2ntvqFRe?= =?us-ascii?Q?rI65Kgr0YV+sH9CaO7Q6TZCYfUxyym13lmaJXc0T3ug8rtK9AecicMp4LlDn?= =?us-ascii?Q?d/C/UatRAKChBbIVDQBd7aKhjHVS+kEpSs8gBTA2ZrxHDDCHZ2ePR/xs4D53?= =?us-ascii?Q?X54rDOmD79daT3fMKNkS3x1T6aULfyxfQwy1/ze6+/VUaHfuGOIXBT1PMZKT?= =?us-ascii?Q?93EhUJ1UmPFl7LEIwwVAIKuEvQOKbHScEWwY4C4YbC8ArY5sZW4xLaCVYkMD?= =?us-ascii?Q?UKDfd0Y241t06hzBlRfVwBncPZKj1+3oAxWTzzpWWZtl1lyVHuaVu+IXFmyJ?= =?us-ascii?Q?LcA3LhFLYDcct3Qu78G5UVjmjastlKMZm0nYEUpl849On9GfeDLI4+93E5l5?= =?us-ascii?Q?tmarW0qMPu3SmyzopEREygietj3SYYG+9Gp85tOVnE28z0aoJ2kJYmpDO5A4?= =?us-ascii?Q?V3Quk45fD3VuomEK8S/xFfpZYDf0+Yljxd1xl8fGWiFzRYelpPmPbhA1yiIb?= =?us-ascii?Q?m8KpKSOxgRQ2eU8mQ5H4tixSeNpz?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB4112.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l5uGcnOX6A26K93UHMq0Y4TqAQSBOcd6Dpwsk0nhVO+bkPm7L1r32X1QF+sG?= =?us-ascii?Q?HFekWKuXe0tcSDM3Gs346iq2vdInnFrVqQQn7gz6fv6ECeNmDJ1agzeY8oS6?= =?us-ascii?Q?AS2pD6eLICbR4rTuPQIdlnwGraAJCcOLVl4faPzhgzzq+mZNoAh3HUuFtSkv?= =?us-ascii?Q?BpVulVLfkB+D634Tf9bWKwyQXk41rUbKRCuqBGO1rsAcdEMA29Ky8VIbxF0N?= =?us-ascii?Q?VMWybCBSiKd7nH42InxdakKoHebHeCtFClCU5kw0TRMiR/il+N8RO5IEjA9A?= =?us-ascii?Q?vMZNFZM7U87fLpktjT/QkJs+YzvA1n234DQoX6M9fs1me0ArPU5nuGA86T2d?= =?us-ascii?Q?dnfCdj57ho/D7UJUCGiOkaD9V+Ody+c8YOnZayMdivH3+JHu/rjs+5kN2rAE?= =?us-ascii?Q?oL4Hq2EYGFbj/A01u+5TkMbnsp/9NwB24d8nTSTKpOdLRAOrEgEl9lZ2azp/?= =?us-ascii?Q?VKwU4U0+5a+VS4VwAN9FYKflgklhJSZZgbF98GH0RUVZYYHU06zH3FUWosBu?= =?us-ascii?Q?wEHb3C6SIoEaaqxN3Km7ZhaeJ0RoTdXaHFjooTQbYFnNArRsU1Z0K0cTWy7z?= =?us-ascii?Q?AjoJflqcmZWSjzbtDn1+NNet7daVuHsvgb+1Ab2gBKIcjFfxpRv+i8tnfR7I?= =?us-ascii?Q?ddlEmBZ/GVqXX1gmVhSyxQ51zkSH8xPcyfCE8cIzQ/7jRzLoiwigKiXQuXR+?= =?us-ascii?Q?aklpLGzQ4LwxBHhBPMFkP0ZcRoTmnwhW7gfR6z57KFvOHWdeozqUUBcsD+XG?= =?us-ascii?Q?MDX0CNXzPQ1/86UKknni9JAUR4PFTt2tOa4uF36pbWJkRuIpxtV/SGTh7Nwz?= =?us-ascii?Q?qx1rlb4fjRksl9s5QOum6VmGtbIamCpGkX3jklFtpyMgW/8g6H4Jz5/eh9eg?= =?us-ascii?Q?EmlNojAqWiL+9xC/P7v1ZRd/gqFT+Y+HY6O89nz1Q9knCg5GQAQI8CoAcJnm?= =?us-ascii?Q?0M3FWB5Izc4is/wVJZFsK3ONyZ2Q+eTUZktH+aQwhjwNJtbonJH7EhKnNDqs?= =?us-ascii?Q?FcgP1isOuBUjSWUsX0jFw77gROPsAocPF+Ct0VIy/FnVlvdrwD1B4aHrqZ5c?= =?us-ascii?Q?6ZDn0ILf7lpGQlcctdKfwdgcdr/FoLZ1ydOa7PebnmkqUNcsQWuDudp0NN3G?= =?us-ascii?Q?Mo5YzpzjWySTLdQjyKGcpYniNjCOrmJF4p6iMFeae5Q470ZOZIv1hmr8bPYF?= =?us-ascii?Q?pp1r3TJq2amJ2kg8Me7e+9Q/rXTOGnGWtI55pWI3RkG5RTdpGQD7aGBDttUC?= =?us-ascii?Q?8yiVdvn9oP5ABNJ9V1UF93OiVp7fYbbtPiy6ZxHcK9/2eDmAQQPWre8nrJEF?= =?us-ascii?Q?2wzEfEaeuKG5qW0sxamOh8EnlvuPrNkyqXLya5wbH5jZRhD3CHTp4lPve/3n?= =?us-ascii?Q?QQYUNJIgiZxZ9sA3jN7XcxXtCdMsxHTQKUS4fuEekwR27B9SsOlZxUPAd6aX?= =?us-ascii?Q?OzjdYZJVZWcTQ/QpiXZOXq0P6Jm0icE4y96MYqIk1B4YM9LnjiuR2XXhMIxJ?= =?us-ascii?Q?+blnJe0XpHpsIJlPFzjze5qrbye721RNomE2/Y34YvmPuVHJMaSgiYcmbMuj?= =?us-ascii?Q?b3h2bvo3/55pQt8n6dVNvjD19+aJ2WftrfJe1VEz71p7GHIkdbihKX5R9N0+?= =?us-ascii?Q?BQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Yf/OYizKzo5VHw3xKA0Cn2ZRC/DZlUEAkSeT83hVVak9rRkZHvR5c76w4wOnpfrRLPoP0Oox0O3WM8l7BLQkZRUrd2oGpxF9bdsJJ4BttHE2yq/labhlLezDxWhmh8SlGAtnx54avNdDEUucmfR5L60o5u0dIb8lPp1C4oOGsgAzyx6buWKOkKFnoG0vQ4ArkJEiHYF6Ktt8YIBcbZJDIxtDoIw2eV/VGbyEO5kvgTTRhVSeiFx67gBHqd2uibaPyy8Kh21X0U9Av6uPSsoSXez0nOCK4wpqHUG2Znx4FUsYHUm/B/RsQIu5D/zSpwTbXK7SNAdNcxv9yZxlTVE+mKXGL0aFMQ2gY8KIWKynqlnQuGVwjcK4hOH3/H+bDF9EE/jzTcVb3bAmEeQpUDiZRgrA8AMBGJQWX5XXpduSrqLwXbL/iSCVrLj2EzKe0+Z4eiEEk6blPxZI+XljfSjWZg2+60VyOvByLcyEX/dBsVBPsqjsACnIUeM+8/NiTEhOPB5uRfslHxICv34zrXHV3KY185vXE/eyyQi4GJF7gtX9GcT62W+2q5SoAXPoKE/SbrrkwlQFTh3yUUZIazGoJufpm5fJQQd19RnLSnjcbk8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44af6571-318f-492b-1a74-08dd5d78abe4 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4112.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2025 13:05:02.0164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OvfX3S7rHLyBLD2Dz2OrtHdoqgqzBeJLfEGLjwvs3W3pQNFBMD2uqB3G/2dP7OzGxqbDsrBBfob2cJe42HHYYQT2U6t650g0pxRnoWs6bgc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5565 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-07_05,2025-03-06_04,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0 mlxlogscore=845 malwarescore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502100000 definitions=main-2503070096 X-Proofpoint-ORIG-GUID: qrX43TuLFdw7XJ7iyV14QnrArFU6CmJQ X-Proofpoint-GUID: qrX43TuLFdw7XJ7iyV14QnrArFU6CmJQ X-Rspam-User: X-Rspamd-Queue-Id: 3D94D180013 X-Rspamd-Server: rspam09 X-Stat-Signature: eqyecnxeykpd64ad931m9rcum31m9oag X-HE-Tag: 1741352710-301911 X-HE-Meta: U2FsdGVkX1/JOObfq1DcEJd9doeQVf/Kqlkfso0ORJsMLFoRzc5n9TeDyxl5l+n29/LjBsEIiaP5qSA330GEiupDAWeHwsoL7TWXy3a7LMgH06ojaRBHK2Au7JLZv9ikgBVKm64iqrV4QhUgXSzTPfXlNMF/y54E5V1qXFZyqQ/d1U+Xs4UDS9PQgF0LWBGoUpSNpMrzB1WRUR/RynLZy2AId3BWcvAXxeFDVLS19021Ozj1BzBpSM+YoJ9OWF6tOYJekP0XYe3MnR1svGR/7MHX6wrXI9rxxqXNoqM2kxPsbJ/TUn+9ZLJdUMiFXdr6j+yQqTdc89pFtrTUhos9gCM9wqg+AOQ047kSxZ64algiSQiRVyseCG3Jj3Cfx5Bpvzs1g0g74S9+z+2Vxdjda1ZQUa7uLCYEs+96ZkKM0yIb0Mx/vw/ye+ZIjSplA2/socONxvyRHckP/eyPZZZzE0OL6/zOEwzJDsVHVNAp3e54oPOW56f1uyfOwBHrXiwhe7x8kbxxfKX2tj1w7ZBtWVMU//ZblTGBv6/qkCOhkM8cufnuDGcvVI/P1wf3O+8QpExcX52UNqMvcMqbBYQLQBjbNnPJ2l6B75pl6PwXDhqbej4cn0jOqv3SdZFR2Kqt66bICkjkCljKiYtLHkBXiLBZtWxrLJRgdBdaLU+SIr9E0i0HEMDy2/aCeamu2PvPduxA3ygoG7Ru/Bj2envmTCXCtoTWfro4IsTreoOcaHp+MQqQsvKaEmMvs8/OtX8JoI5mX5q/JeMU1oPa4ksmCmbWzUEJQhqpEGI4yUujr6aq69RFugSudFMwQJwn8dJZqLMsS1MCl00g1r3fUCr5AijyjSfuMAo6tdrICi5fSGWvZbxnd80L0qjyFZ8R1YaJh8FGGXvLD+phqe9rOEd5Z7TBsFpmeUF3Qs6Q1LmmmF2Jl/6oVEvQ2X3bg/gq+66JZ6fIWiQHFMbIb+XcOgS 2J5W0fUH Q+Rv/LYJAhBfnEOWKB5Tm2WzI+cbvQz9d5k5aSNAus1o+o/3XHicSmj6TqT2+LqyXq1UoxTNpPemm6GfkY1EkReMni6V/U1lSXOcyEChGuzJ9FJZkoJ3d6VrctEa0O+cd+i9f7wiYhnLSHq/enxeYsWL4I72eMSkzn4PTsaGtx77Hv4Cugcbc+9Wv0YOdCM6nn4cOBqazVUUOCg2QfD4k1hBhzgVsaQjhHqODO62fQGHu+aQbqEx/QUQrrvZoztPuh1MRY4/BfFWCqbBhW4rnrKhc6rJlZQrGreYRudT33PGLN0iN/3+lUOhOCnRo+Ye42WoQjltcJW7+KIUT92FbURLbBhYL3QHVgjEOgux0uJdrLOgQ5KOdw+HyZkc1SE2lhrTgEFWXEDBcsHkf0+RqcP5pK9iRY8SMDSOFULh+qGtmJBU+3mePykgrNrGttPdNtU+1R71FHPgpjiRkeIBhTcEpGDM0R6L7Hr383k7TkgDo/Pkz/Au/ezyeTqLTg67v430Yvdw96Hoi3ReVDVyreIjapw7d0l4+DC0s8acaQp1+hw+yHVIDfh/WqY/6N2ysmCzN1DEXGGcrBsZh2h6q0fFkLvpEbNDwCJGS7iMUl3jS/DdwsAZQkyJn9UDVuex4/H3Xy7XfBj91+fbk+8zAJn3l+bB56xxaa7cz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 07, 2025 at 12:33:06PM +0000, Ryan Roberts wrote: > Instead of writing a pte directly into the table, use the set_pte_at() > helper, which gives the arch visibility of the change. > > In this instance we are guaranteed that the pte was originally none and > is being modified to a not-present pte, so there was unlikely to be a > bug in practice (at least not on arm64). But it's bad practice to write > the page table memory directly without arch involvement. > > Cc: > Fixes: 662df3e5c376 ("mm: madvise: implement lightweight guard page mechanism") > Signed-off-by: Ryan Roberts > --- > mm/madvise.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 388dc289b5d1..6170f4acc14f 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -1101,7 +1101,7 @@ static int guard_install_set_pte(unsigned long addr, unsigned long next, > unsigned long *nr_pages = (unsigned long *)walk->private; > > /* Simply install a PTE marker, this causes segfault on access. */ > - *ptep = make_pte_marker(PTE_MARKER_GUARD); > + set_pte_at(walk->mm, addr, ptep, make_pte_marker(PTE_MARKER_GUARD)); I agree with you, but I think perhaps the arg name here is misleading :) If you look at mm/pagewalk.c and specifically, in walk_pte_range_inner(): if (ops->install_pte && pte_none(ptep_get(pte))) { pte_t new_pte; err = ops->install_pte(addr, addr + PAGE_SIZE, &new_pte, walk); if (err) break; set_pte_at(walk->mm, addr, pte, new_pte); ... } So the ptep being assigned here is a stack value, new_pte, which we simply assign to, and _then_ the page walker code handles the set_pte_at() for us. So we are indeed doing the right thing here, just in a different place :P > (*nr_pages)++; > > return 0; > -- > 2.43.0 >