From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48EDDC5478C for ; Tue, 27 Feb 2024 10:30:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEFD780012; Tue, 27 Feb 2024 05:30:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9FC5940008; Tue, 27 Feb 2024 05:30:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B195680012; Tue, 27 Feb 2024 05:30:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9E9A6940008 for ; Tue, 27 Feb 2024 05:30:22 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 496A4A1018 for ; Tue, 27 Feb 2024 10:30:22 +0000 (UTC) X-FDA: 81837214284.21.8C29547 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 1843B180016 for ; Tue, 27 Feb 2024 10:30:19 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hJOeDFk9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709029820; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1zwfUNVq4ctQnkYE/5oSckurcsAe9UrKRRxknc95dzE=; b=WYd03Ds5yAnduesz8Ml27PK/VETcBzvBWKyHyYvCQsAXK6xb5F54zguUAhMOJ0+uxBmI+e 22HVwhbomIQ+43A83hQ2G6AnSjr3RQx2hZvbnO93SMW91kJZbTiXXAvgWelcpVrX4D5KBX elOXy7RNifi+xTXhDe94komoPYCoa7Y= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hJOeDFk9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709029820; a=rsa-sha256; cv=none; b=nyhdPclddLL9r8j8fgIsLw5znhVRBgQtWSyx+p3l96H8NRhIBh/PLYAQCtlhawqVPIqAlZ keCzzr3tZKTJNPJSoSZX6MRHSLSGcUxal4wiMc5YvxjMBas6Hd9k2zV0HcPLIYU4AHKDEo bcabyZSsbASqf0gWNjiIbSyIlxColec= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709029819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1zwfUNVq4ctQnkYE/5oSckurcsAe9UrKRRxknc95dzE=; b=hJOeDFk9tZbW1nNnZKeW4v5UDsZWV45DlR3OQZVR6CUrGVaTyDAwS/eZGlJFUqgn8VmzPr AXQ4+Pkh/Vw9Ept6qRE5aknPO7zLWVm9bDYbIH3L13lEkgzLj8mQUSYk79DJ45tImuvyVS hzTnjuA2SM/foP99H9uAQY9JoPbcvg4= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-AUjSlfluNdqEJjs26mFZZQ-1; Tue, 27 Feb 2024 05:30:18 -0500 X-MC-Unique: AUjSlfluNdqEJjs26mFZZQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-512e6d29386so3217616e87.3 for ; Tue, 27 Feb 2024 02:30:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709029816; x=1709634616; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1zwfUNVq4ctQnkYE/5oSckurcsAe9UrKRRxknc95dzE=; b=lwez7CfGWB+AZif3Z5l0zywSNM5JGkdSoq6lFVkTSRNpYWXiTPxubygEnITsFB+jQ/ geSG4pwrBF5VWA+7z45Sv/22iDeOjGtajaISoipU34Xxi04yufzycnPskYqNvAyCDsM2 7MF/wKXC5ojzI55A9HsTiDiMaDDb+poR7Kkniw8aFR4+5xhwvjT0XaWN/0I3yN0W0Xmr lL3CiSupTnXisqCqrMkArb8XzqgBh/1J/7Nxffwk3RWdH4F4dZGtWbX2XT+ErN4lk/NS nd5yUjR8DXUOnJvXchw4PbSTKkCaLGDsUkQVOHVRJhyWjQtYwxJ/eyCvy2RB0vJgElD2 /CGQ== X-Forwarded-Encrypted: i=1; AJvYcCUCIAA3wuBHHO3oGB6US6wlZq2D0kBMNLPHMHAaeUYQls1QVRd52bY2h3DVHJdv6qYTQgdTodhAJNn8K7ZUBym2fv0= X-Gm-Message-State: AOJu0YyyX0S/4tfauahG98akss7HrmTfVRk5o1bq1dfzyBMEKb4Sfe5n iiBogIE9QoyfgWxvWhDCeDzfGVeWY55E2ANpM0gqe9oNL8zt45QPnIxNUFXw5GI1UbEVrI6pU5q gLI2g2lwYXI0dHNVFTTWtWfMrmaRju5UmAQwlGEmpzhZFUvh2 X-Received: by 2002:a05:6512:12c2:b0:512:f409:7a5c with SMTP id p2-20020a05651212c200b00512f4097a5cmr6035122lfg.0.1709029816607; Tue, 27 Feb 2024 02:30:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IFxCng5CT8SlMkHNXR6TuZWz4aWJdWFP04svym3eClYDXalqfflGFTYJemlH/kN6dmvkDN1sA== X-Received: by 2002:a05:6512:12c2:b0:512:f409:7a5c with SMTP id p2-20020a05651212c200b00512f4097a5cmr6035089lfg.0.1709029816094; Tue, 27 Feb 2024 02:30:16 -0800 (PST) Received: from ?IPV6:2003:cb:c707:7600:5c18:5a7d:c5b7:e7a9? (p200300cbc70776005c185a7dc5b7e7a9.dip0.t-ipconnect.de. [2003:cb:c707:7600:5c18:5a7d:c5b7:e7a9]) by smtp.gmail.com with ESMTPSA id v6-20020a5d59c6000000b0033dd4673a4asm795210wry.71.2024.02.27.02.30.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 02:30:15 -0800 (PST) Message-ID: Date: Tue, 27 Feb 2024 11:30:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: export folio_pte_batch as a couple of modules might need it To: Lance Yang Cc: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Yin Fengwei References: <20240227024050.244567-1-21cnbao@gmail.com> <61b9dfc9-5522-44fd-89a4-140833ede8af@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1843B180016 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: u63hw8qifmot5d6i49ozbn3bix8nhom4 X-HE-Tag: 1709029819-241538 X-HE-Meta: U2FsdGVkX19PwaQU6hVJqHwmIrIztn2O/ABB40fSyje1wRQ+YX42/9O2ZvLiNVisdra69upRocQwp+7hvP+t4OOHqagm9kEFC+kpXXq7Zdc/HS12Sjsbe7a2Yd1zw6JVb9wdr9aDjJo3t89smrtacJXJyrXE5m0kx9+rono/2G2X+AHE8nBVKeH+5v5HE9cn3V7YO3bFp1R/nlp6O2FMr5HU+Ls3k9eVf/laZ747q+lMv+hw1o4Cop0nuB2fP7+FE8LC7Bf+vNindUtFVFlympD3848Rr8rtbhmXuB0oHKDia5E4KNBZc+dwmfVXUNXC/2HDccCv1pY3iJV9xX2YO9i0Id2B3kpKwBu6DSXU4LvEgUtT8CztlClvz4NQkY5Djd8aJkwl+lqY+rknclqzBgMVKDhRace5cgrhWXtR63RBkVpHyfFuTG2XvmPIUaIJAL7uWijnEbox8qp9QMWt/3mDU7L3VZyOfElHw4M/wnVqg3/rjp+/E3Op1ySKwrwRKyDYOw5Dj7vJ+qHVauLJYmzrymdmTV5dkaz09gNLyAoeeRqQliIfiAAXwtY1+Kyh086OM4F5NUJTuT60/Mk5cl18vG2cB8Rbd7OwX7NEKgVdk2gjCh/QdplSVubS+/n9Zw/NjX8hWb5efFhrmCw1yCxfWF5WpEIhr0RUFY7U9dFvYydV6yXrFWsndnKKjDB9/ZUHaUnix9Y+5rkXi0wiH1iA2KhoYqPJLXrIM/JaNVhncCJIfKrJerUGPRLdAHtqiEdcEnUTVg9+sb/Z/iOz4XzO3tsTpY0kP83y82rNtxDe84lvcHIw5SpD//DnqsBcprzCxN2EceZGf7W2Xlhse4hdxjXpHzyuh+hpx7iCNqxbUGO17HXXPx8FPryLdKtaASyW91KTtfNPVIsaTx/gOYOpyOVF41hkv40So4Lljomn2e7ad9TLlz7ajoYZQfWhDZCHh15smvEnLPWg5WW pvyloidx H+bQ5uFJSc9zTx4Oh97YEs7PgB69VBYP1rWDwhDCiIcR8YIGcjSLBmZxpm3SHFglvE0NKiSdinZbwc0Np5BmvBXq3ZX+Yv4tW23pZ6tCXHsURLlt6GNS79qn1O2jkpZfxQULRrpKnMz45oTNWSgQt43SCv0rpwZHTunz0l6QvFFOxqzOG8huZzGsQ8XqnySl4j84JFt5durQjVC7/GUHxW5LjNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.02.24 11:21, Lance Yang wrote: > On Tue, Feb 27, 2024 at 5:14 PM David Hildenbrand wrote: >> >> On 27.02.24 10:07, Ryan Roberts wrote: >>> On 27/02/2024 02:40, Barry Song wrote: >>>> From: Barry Song >>>> >>>> madvise and some others might need folio_pte_batch to check if a range >>>> of PTEs are completely mapped to a large folio with contiguous physcial >>>> addresses. Let's export it for others to use. >>>> >>>> Cc: Lance Yang >>>> Cc: Ryan Roberts >>>> Cc: David Hildenbrand >>>> Cc: Yin Fengwei >>>> Signed-off-by: Barry Song >>>> --- >>>> -v1: >>>> at least two jobs madv_free and madv_pageout depend on it. To avoid >>>> conflicts and dependencies, after discussing with Lance, we prefer >>>> this one can land earlier. >>> >>> I think this will also ultimately be useful for mprotect too, though I haven't >>> looked at it properly yet. >>> >> >> Yes, I think we briefly discussed that. >> >>>> >>>> mm/internal.h | 13 +++++++++++++ >>>> mm/memory.c | 11 +---------- >>>> 2 files changed, 14 insertions(+), 10 deletions(-) >>>> >>>> diff --git a/mm/internal.h b/mm/internal.h >>>> index 13b59d384845..8e2bc304f671 100644 >>>> --- a/mm/internal.h >>>> +++ b/mm/internal.h >>>> @@ -83,6 +83,19 @@ static inline void *folio_raw_mapping(struct folio *folio) >>>> return (void *)(mapping & ~PAGE_MAPPING_FLAGS); >>>> } >>>> >>>> +/* Flags for folio_pte_batch(). */ >>>> +typedef int __bitwise fpb_t; >>>> + >>>> +/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ >>>> +#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) >>>> + >>>> +/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-dirty bit. */ >>>> +#define FPB_IGNORE_SOFT_DIRTY ((__force fpb_t)BIT(1)) >>>> + >>>> +extern int folio_pte_batch(struct folio *folio, unsigned long addr, >>>> + pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags, >>>> + bool *any_writable); >>>> + >>>> void __acct_reclaim_writeback(pg_data_t *pgdat, struct folio *folio, >>>> int nr_throttled); >>>> static inline void acct_reclaim_writeback(struct folio *folio) >>>> diff --git a/mm/memory.c b/mm/memory.c >>>> index 1c45b6a42a1b..319b3be05e75 100644 >>>> --- a/mm/memory.c >>>> +++ b/mm/memory.c >>>> @@ -953,15 +953,6 @@ static __always_inline void __copy_present_ptes(struct vm_area_struct *dst_vma, >>>> set_ptes(dst_vma->vm_mm, addr, dst_pte, pte, nr); >>>> } >>>> >>>> -/* Flags for folio_pte_batch(). */ >>>> -typedef int __bitwise fpb_t; >>>> - >>>> -/* Compare PTEs after pte_mkclean(), ignoring the dirty bit. */ >>>> -#define FPB_IGNORE_DIRTY ((__force fpb_t)BIT(0)) >>>> - >>>> -/* Compare PTEs after pte_clear_soft_dirty(), ignoring the soft-dirty bit. */ >>>> -#define FPB_IGNORE_SOFT_DIRTY ((__force fpb_t)BIT(1)) >>>> - >>>> static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >>>> { >>>> if (flags & FPB_IGNORE_DIRTY) >>>> @@ -982,7 +973,7 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >>>> * If "any_writable" is set, it will indicate if any other PTE besides the >>>> * first (given) PTE is writable. >>>> */ >>> >>> David was talking in Lance's patch thread, about improving the docs for this >>> function now that its exported. Might be worth syncing on that. >> >> Here is my take: >> >> Signed-off-by: David Hildenbrand >> --- >> mm/memory.c | 22 ++++++++++++++++++---- >> 1 file changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index d0b855a1837a8..098356b8805ae 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -971,16 +971,28 @@ static inline pte_t __pte_batch_clear_ignored(pte_t pte, fpb_t flags) >> return pte_wrprotect(pte_mkold(pte)); >> } >> >> -/* >> +/** >> + * folio_pte_batch - detect a PTE batch for a large folio >> + * @folio: The large folio to detect a PTE batch for. >> + * @addr: The user virtual address the first page is mapped at. >> + * @start_ptep: Page table pointer for the first entry. >> + * @pte: Page table entry for the first page. > > Nit: > > - * @pte: Page table entry for the first page. > + * @pte: Page table entry for the first page that must be the first subpage of > + * the folio excluding arm64 for now. > > IIUC, pte_batch_hint is always 1 excluding arm64 for now. > I'm not sure if this modification will be helpful? IIRC, Ryan made sure that this also works when passing another subpage, after when cont-pte is set. Otherwise this would already be broken for fork/zap. So I don't think this comment would actually be correct. -- Cheers, David / dhildenb