From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F653C001DF for ; Fri, 4 Aug 2023 08:23:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD88D2802D2; Fri, 4 Aug 2023 04:23:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C888C8D0002; Fri, 4 Aug 2023 04:23:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B50772802D2; Fri, 4 Aug 2023 04:23:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A55158D0002 for ; Fri, 4 Aug 2023 04:23:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 703FF40940 for ; Fri, 4 Aug 2023 08:23:07 +0000 (UTC) X-FDA: 81085732014.24.806EA3A Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf06.hostedemail.com (Postfix) with ESMTP id EF55418000D for ; Fri, 4 Aug 2023 08:23:03 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691137385; a=rsa-sha256; cv=none; b=l2V3fDwOXhgBAcl1Vj57LfTWVWhhyk3AZoLxajuPw0LGYxOvgvGmFYeDe/T24P8n2TPobR lShs6F2wOyFOjLU9x9ZQHwaxIUs9mOjWqFaYk0BiTYLXOw+lSuGW3yT0uuepH9Yc+69aP1 hg3xUt7HtbyOY2YIeOkjGoElg7k4ydQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691137385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EmrcE5j5c33aOLxs19nvsYiBE1krpLGoBe0uLnnQnms=; b=MIXSORs+vEQg24DX0juqPkF1AceUbe5YfdRKQkjaMA3EgEC9zxr8hzFn27tLew3BjuAZBu MGg65yusgbkq4+pZvpq2ewBvedfmEzrJD3sNwkOE35k10vnoTZiLl577BhyaZ8hX6zUq6A 4io6qxRf2iFeol4rCEQaT7s4OywkwcA= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RHJXk3LFLztRsM; Fri, 4 Aug 2023 16:19:34 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 16:22:57 +0800 Subject: Re: [PATCH] mm: no need to export mm_kobj To: Greg Kroah-Hartman , CC: , Mike Rapoport , Andrew Morton References: <2023080436-algebra-cabana-417d@gregkh> From: Miaohe Lin Message-ID: Date: Fri, 4 Aug 2023 16:22:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <2023080436-algebra-cabana-417d@gregkh> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EF55418000D X-Stat-Signature: byt637uqquzhcfjcpg9h76hm8srpsyjf X-HE-Tag: 1691137383-423918 X-HE-Meta: U2FsdGVkX1+yZ2bopJig9hI3tpmunqKDnPRb4Wt0pVTdNRaZsAPjdQySSWbwCOrI+crCV8L1DawCHQMFCISgBN3SW/zFtPV7AtjAiwbO0eB8iRwMooBCBy/XbrLyt3IFWRDoKMqBrpw5TIVhVVv4rA7JhX5QSJLHOxAFXUCUxipI8Kdjgf8w2ZSCWJc685xwpC3ByAcxD3chYlv2GiGHKCRFECokueMcjUwxcw9Mq7Cyo2NzqxwAmA/yjVvZMrCDlPOanf5O4L97jdILFdIRV9Eipn3h6v/+dZUD7KHy8mQgGb8QXe2qnTGA1duvyh1qSexdgOtoVuWQ06B19LWxZG7FOIv0Rnlao+g6d4RGyP+0ePf/N9dKirAEVA25xdy67oLBSl5aFi0DIRkCP2DCELi7itGKR1cJpXkfFdufkboxI/MxbKHuSkTAXmx9pd0V29LYYet6tdA97DQefY9UOLGdwKC3DIAW8ITqJgZ4O09x6emsTdrrITw7JCgVd4XB7iqzaYHapXwXoxxCOGwVKQ9GhHvr3o4KDufLA6Z2CFjw+sdYeuuKfntkrsr8PSl8o8+OKI9L61JU4nulHIts1MDNmGoK7JMxgRZ3cGnXbOFLWGfRcWPPbsfWT/lD1EX3VXteaxpc0WFj2Qbe+rXV/ii5h9JXD36f46dOFmG+2D4gW1LxmJctzmS83tpJzpACbryTbvWjthu4eamf5LUNizn9sY+f92DNlDZOrS4rItSH38FjITjUoi+FPHZau1hwgRPeFVJDjbuN+yjY8VeGx5hMCWELdC9X9PnCX3LmORe9aaBx9MTTn1zru6HdaTfySSmsg8x+Nm1cGTPZ6tysMY7AZW73NLRE4i51YpG76LMOvEoBNRBKHOGFr6Fi1qIiMdAiLp/9233xXoiaubcvjXXbTeswmlWOjmPPNlnZ8J22u0hpw9xAQR47brGjuq378fXB3dhkH2/1Fdj5T4y GsGwrZE+ 607JeEWivWamuV63d4788RdvJGXWcXOuTKze1TEAZdB45jddBnBOYcVA5v5GG9k1RzmLyK3cieaSpM2ea66WVj+fARQ40e76C/EKdR6WAaHhicyYDqHFZGKHG4ZfUIY5jb/r2FYZwC2rKNuP23s6QAUT4yrP27rnRfRQWXJzKNogdbc6F4R15otpwqd4MBLsMa4CaqQiqNDFuOTWI3LARgoiv1t15FQbtTmbk+PaGUvKqxERbEX3HXAOsenW26NiXv/uiuk12rr7MCSUysMS+VokPihtVxscWQ0Tcr2A0nLZGH6QW3kQzsKxtvQqRowM3jCDxaAM5coRjpgatjYC9I05vrkZH5/kXMLGJA8AkoPF8JklD3hW5eenre0dJ5573SNkD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/4 14:43, Greg Kroah-Hartman wrote: > There are no modules using mm_kobj, so do not export it. Yes, there's only in-kernel user left. Reviewed-by: Miaohe Lin Thanks. > > Cc: Mike Rapoport > Cc: Andrew Morton > Signed-off-by: Greg Kroah-Hartman > --- > mm/mm_init.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index a1963c3322af..1c9d6f428906 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel); > #endif /* CONFIG_DEBUG_MEMORY_INIT */ > > struct kobject *mm_kobj; > -EXPORT_SYMBOL_GPL(mm_kobj); > > #ifdef CONFIG_SMP > s32 vm_committed_as_batch = 32; >