From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7982FC7EE2C for ; Wed, 24 May 2023 09:12:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 121BF280004; Wed, 24 May 2023 05:12:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D266900003; Wed, 24 May 2023 05:12:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F033F280004; Wed, 24 May 2023 05:12:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DE3BA900003 for ; Wed, 24 May 2023 05:12:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B8E4D1602EE for ; Wed, 24 May 2023 09:12:35 +0000 (UTC) X-FDA: 80824583070.11.61E6731 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 7A03C180005 for ; Wed, 24 May 2023 09:12:33 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b0uoMtGM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684919553; a=rsa-sha256; cv=none; b=j2FxltLflDWJ+F3YxVxCcGovK/eRFg3AG3xcUIrHUq+oKtfLhQ4W09RKjKkAaFmObt8i0T vR0Mdx9OF58vM0TDYssGLLlJOWuXm8Sq3y/cTjzShUaQpyVgsTyHbYS4UtxXYPwRR/SzNM z9K+gKpPW+h9eCXk3iET3z3dMO+KoUI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b0uoMtGM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684919553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jrqSvOCbN1bUrkFrXD85UYULBUCaviBKiC2zpb1JIAE=; b=yyx2ry+BPhgg10/QTh+smVPNSHKpdp0PrEG9oJa6zqZ/Fp+cj4ZtJrFeWtkTAfJxfs9/aF V6PVylQBKHkWUtr5FGu30PlVn9Xz8AsZhdfBPNvWtenoBsTl6g4lOnCbQy4j5v9vcYf6C6 /4s5OiitXOvo1OcHTmcZ2I81gSlXi9I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684919552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jrqSvOCbN1bUrkFrXD85UYULBUCaviBKiC2zpb1JIAE=; b=b0uoMtGM03oaUp3tLHS5x1nM+NRT8cvGUiDhOL8T5Izy6l9wsTj3rchHU3yfZkSLV29xM8 +IoGKzjOaga7llxONgwDvCJgwbiopwwkXGDRE0QWKaPAU9qwfupuve+mpC8KOjL5d2+JVV GJswX4sfTW2Flos6xokxpgPLeahBTqI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-yRrh6yV2PTKjp-B7iUH3Hw-1; Wed, 24 May 2023 05:12:31 -0400 X-MC-Unique: yRrh6yV2PTKjp-B7iUH3Hw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-30a8f6d7bbdso211323f8f.0 for ; Wed, 24 May 2023 02:12:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684919550; x=1687511550; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jrqSvOCbN1bUrkFrXD85UYULBUCaviBKiC2zpb1JIAE=; b=Df+d/9H7LSCqzRlUpSFyahms8/MBB2pTwve74CdHdEM5xB4QgVPdjPEAUgPuPM20ph f/aZukhI7iH7w9X1ZdiE/PifuGF1sWiS8yFcn6LxHHs3GgEJJ90C12ncKAeXJnIsN4jG 8r1ach8+UPiHocpZbd6DIDHZWPrJfx1t8OTUbTIfjiW5l4mT/JpyUX6X65OOfFDS2yru /KZOsfWJsQsGDDeLZPeO+yv05Pdwpzp0ILSFNOBoA40zp1VnuBGgo4G+ujO29cmec96O Pe1YRvurmQ29pm/sORpYAIWMXixvBPTFpCTUmCxm9RqaPYPLmrr9/07dz0qgE6BUWsKk v3oQ== X-Gm-Message-State: AC+VfDyOya7P7zDu5LOSJfIuNtVgMqonYC2vNZip77pO5KvXFiGcbDW8 2EY/H/GwavbBG9BXVZaUaFuH3soHx/vVWCSRIsJDbwx6Z3iDHUBmHcD4ei/jHsFRGSQDkD3FEOF e+orh92jB6KI= X-Received: by 2002:adf:cc87:0:b0:30a:37aa:1fab with SMTP id p7-20020adfcc87000000b0030a37aa1fabmr8852634wrj.6.1684919550331; Wed, 24 May 2023 02:12:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5KEz68EhkHsWcVdsA09XQqIpRXbaC7tJWwJQAZfHW8aAT/2OB/Js7JWIccTRjRqRb9blus8Q== X-Received: by 2002:adf:cc87:0:b0:30a:37aa:1fab with SMTP id p7-20020adfcc87000000b0030a37aa1fabmr8852620wrj.6.1684919550092; Wed, 24 May 2023 02:12:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:f700:24cd:855:1c60:1ff4? (p200300cbc70df70024cd08551c601ff4.dip0.t-ipconnect.de. [2003:cb:c70d:f700:24cd:855:1c60:1ff4]) by smtp.gmail.com with ESMTPSA id a3-20020adff7c3000000b0030795b2be15sm13704737wrq.103.2023.05.24.02.12.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 02:12:29 -0700 (PDT) Message-ID: Date: Wed, 24 May 2023 11:12:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v9 0/5] ksm: support tracking KSM-placed zero-pages To: yang.yang29@zte.com.cn, akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn, jiang.xuexin@zte.com.cn References: <202305241351365661923@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <202305241351365661923@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7A03C180005 X-Stat-Signature: yg77h4btx45pxt7dipadypf8s8paxj51 X-HE-Tag: 1684919553-130719 X-HE-Meta: U2FsdGVkX19nfMqBR+lP0dmVkCXLikbVFVpge75qjaoNq17/GAexOU8D40Wrzrj4Jo+tAtiJxb08Zo5dt7WWBdr329sR4dkIfgRbd0xRzZ2L8JxZhnNuFCN8rpqCpnYu0bVhDUMzIzTpGQtpYpW55GTgUVdRNJ76pzWQ3/o0zfKoNIQj8FXBMSLfdTuSg4fIG3sNOUXjT8fhN4/gE1ox60N3G0+k6Ynu1A3gjid3yuU3ECsHSGLoV2PyP9ijy4zZSVaKRzJobUPoKZgrQ01iwsaSl0LAcNlzeHRar2u5eBbH9wYk0T/NsM2Qti7hXiRMv6s51azhyBqlFd+sxlIQ4K22hPZsg7aI4E3lYG3hbTAg+8rV5PzCLk0V1iQ+OPDogsnZ/HKUxjL6Ezumd42Kx+yF7Y2EVlCNp+1iw19fCmpENlPy9HQZjiJJ79cVpnPtVIRjiM1X1M1G9WvqbAb+z/iI6kM6O56QGIb22iNYn6Xun3N+SUeubCoIfyPNq6Jqf2y2aR8wDjHRdJ0UNnanyr2M5FiPbw/PFoHM4lDDnPOctQGgjmApOowHs++Rjp2xpJk+HneceiJ2i8/21f7NUgbMmIEVEguNxdPkZGOCbSdK+LwWO2K10L6ATw0geKIJFlWN/cGBALL9owxcHvCegBj9fWFrVl3YQH5ByO6acsWSQMpNa4zoXIBwUXKDohvFt3mxxxIK8hbC2VJWdgNtdgy/qvAatf5lIh1JNGhyO0fMcgpsBrLjU49gWOxZt/INJyNJRI6RVTguPb4zoGtB691LTFPiS4mCh4HKUhKN3fOvST6dnv3P+evwWfgevJQscF5KzqsllfJQc40fNj7f54eHc5aktru7Kgy5GwrFVHwjFflRyQ61KM7Rz7Zz9L1/09rGVSWibcXaV4Q5pexh11Pkb8sWZjSyO8OL4Ko2M/0IB2Nh8Jk0L5YOqmknx+SF8idnyew6mG7G88WvBmV 4A34o6Gt G88OhKolCm2fWDIPdo8on30TK3zgUzTRhN39ZvN9k7DPlOI8TeFTWmF+NqhbIuUwKQUI1i3OxRMXx1AaCp17xb6T4/66liFjWat4s8DCq7jOL3uRTJYArLbFanAHd99a4tn7nZ98tq41d65q3i17NFAMNtJ8xJaglg2CITo9wjrjbq7MZpFKjwt6xaUuRJA+dyU4VuOejf6V01rVt8Xid9lKQ9eW6RtfNUmH6YUa8DG6q38HVToPRFdXIVvOyeCpWq3YUc9Lwy4PduS3wvU3H6WBPQBS5h6uTbfQ1b3O7NThwmguzykkLiHAoJiF1eTUCJXex/S056JpBeD2X8klxSZme7gWU7dpVZz4Cj2CHSIp9Y/ppejAp1s/WvvzkjzeAEhgO8bEnERazr6zh2jyOcLssQW59Cneirsw24zzo6gccl0M8qt96i7t0s/KwIuR8Pfxnjg3npK5yczohbkUMCYtucE54/1TiNvcRHtDIt5lH5AaskTN9CAX4shTYh0v9kxqKgB/jWpUj+H1iSjcT/nYSwuy8x5wph71AlX7X+Mg4U5OmczI35av1JTxH4JQDqnEGsNUrnFg9zL6B4ac2n4PEpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.05.23 07:51, yang.yang29@zte.com.cn wrote: > From: xu xin > > The core idea of this patch set is to enable users to perceive the number > of any pages merged by KSM, regardless of whether use_zero_page switch has > been turned on, so that users can know how much free memory increase is > really due to their madvise(MERGEABLE) actions. But the problem is, when > enabling use_zero_pages, all empty pages will be merged with kernel zero > pages instead of with each other as use_zero_pages is disabled, and then > these zero-pages are no longer monitored by KSM. > > The motivations to do this is seen at: > https://lore.kernel.org/lkml/202302100915227721315@zte.com.cn/ > > In one word, we hope to implement the support for KSM-placed zero pages > tracking without affecting the feature of use_zero_pages, so that app > developer can also benefit from knowing the actual KSM profit by getting > KSM-placed zero pages to optimize applications eventually when > /sys/kernel/mm/ksm/use_zero_pages is enabled. > Ran the tests and they worked as expected. I only had some remaining feedback for the last patch, otherwise LGTM. -- Thanks, David / dhildenb