From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 389E3C77B75 for ; Fri, 5 May 2023 15:46:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2F3B6B0072; Fri, 5 May 2023 11:46:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADEB26B0075; Fri, 5 May 2023 11:46:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A6576B007B; Fri, 5 May 2023 11:46:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by kanga.kvack.org (Postfix) with ESMTP id 60E666B0072 for ; Fri, 5 May 2023 11:46:05 -0400 (EDT) Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-64115eef620so20541452b3a.1 for ; Fri, 05 May 2023 08:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683301565; x=1685893565; h=content-transfer-encoding:in-reply-to:cc:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=14XV5Ll65TOApPPeoQLTwgb99K7woaMphSjWr5nwqL0=; b=dEFGTEXubye+Kebcakt9ySML0/ViMX0kAK0i0JB8BNXCG68HT7MXaKjwIwrcfpiREY ekKSopDtQHkkjVLiHgNbP0Ivn5Gv7Q++qsYz8+szcxNYA1Ckc9f8/pJWSiylf4ksdfbV lvHvt+x2BSq+/arN9f5IV/5sVHpK6nGvVGD9sG/Zw8KqZmlz/Rg89nj9wl/rBCIuU9Qo palpZYvYcUlJRVQa2M4J4OxqHbWyk51bzOP5sLyJO7dfHQqAisZ9rKKPZUFIzBrFIMsW KUFXVdiuouh3stEV4r3N7ipwjDIAprdo2w4Wx4n9t0Q/jrMraN/yLu7FYe/uxoXA5wZA hdmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683301565; x=1685893565; h=content-transfer-encoding:in-reply-to:cc:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=14XV5Ll65TOApPPeoQLTwgb99K7woaMphSjWr5nwqL0=; b=e0KGVnQPBbxxUKQAqn6afOFvIi8SJLne9ZMOvDtYTBht1YCooZ0i15tuhL6EAOi7+/ a6tAFUlDCAJh3V5KbIYsNgvJV+Q0JCEqUIWQls9lIM3Ebmap+5uEJ9WqEKIqDv+T4yL3 OhBaTaTneaHnhEX8o7Ak4Oi3KK++EmGWT5F12xAWZ9Hho2qoCLdV4SW9IyPXFjDil85R wp6m2JzNqVjeXBz16D+ewnI/StLK6vcvREqBx+rqj3ip3rv2acW83oBgC4CJZNtOI3jA iM+Agt2QTMtajkGUKxwCZq4oqHfjaXF1smzXBvLWeumd5TjAKkK622T6iPAknFvf9bKJ fxDg== X-Gm-Message-State: AC+VfDzzO6GttJ7WLTkIIcNZ0Z32I7iyr4hNiE4Slvwp9Hpw88/JHt3S PrdUN+Bmi7Udh+8KAv3Joe8= X-Google-Smtp-Source: ACHHUZ60IvK6iB/d/fxfnRozqHgaFRsFR1B6l4caTbh7weLnGyVxRIX7cJR6k4/JBKNJNIEXid/j/g== X-Received: by 2002:a05:6a20:258e:b0:f0:3fc4:744f with SMTP id k14-20020a056a20258e00b000f03fc4744fmr2720340pzd.8.1683301564611; Fri, 05 May 2023 08:46:04 -0700 (PDT) Received: from [10.200.10.82] ([139.177.225.232]) by smtp.gmail.com with ESMTPSA id m6-20020aa79006000000b00640e12b6464sm1837486pfo.178.2023.05.05.08.46.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 08:46:04 -0700 (PDT) Message-ID: Date: Fri, 5 May 2023 23:45:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] maple_tree: Make maple state reusable after mas_empty_area() To: "Liam R. Howlett" References: <20230504175509.2195838-1-Liam.Howlett@oracle.com> <4912002a-4fa8-c1c0-a8c4-690b6dd76449@gmail.com> <20230505131620.2o2cv5bj6jxwlztz@revolver> From: Peng Zhang Cc: Michael Keyes , Stable@vger.kernel.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, "Edgecombe, Rick P" , Tad In-Reply-To: <20230505131620.2o2cv5bj6jxwlztz@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/5/5 21:16, Liam R. Howlett 写道: > * Peng Zhang [230504 23:23]: >> >> >> 在 2023/5/5 01:55, Liam R. Howlett 写道: >>> Do not update the min and max of the maple state to the slot of the leaf >>> node. Leaving the min and max to the node entry allows for the maple >>> state to be used in other operations. >>> >>> Users would get unexpected results from other operations on the maple >>> state after calling the affected function. >>> >>> Reported-by: "Edgecombe, Rick P" >>> Reported-by: Tad >>> Reported-by: Michael Keyes >>> Link: https://lore.kernel.org/linux-mm/32f156ba80010fd97dbaf0a0cdfc84366608624d.camel@intel.com/ >>> Link: https://lore.kernel.org/linux-mm/e6108286ac025c268964a7ead3aab9899f9bc6e9.camel@spotco.us/ >>> Fixes: Fixes: 54a611b60590 ("Maple Tree: add new data structure") >>> Cc: >>> Signed-off-by: Liam R. Howlett >>> --- >>> lib/maple_tree.c | 15 +-------------- >>> 1 file changed, 1 insertion(+), 14 deletions(-) >>> >>> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >>> index 110a36479dced..1c4bc7a988ed3 100644 >>> --- a/lib/maple_tree.c >>> +++ b/lib/maple_tree.c >>> @@ -5285,10 +5285,6 @@ static inline int mas_sparse_area(struct ma_state *mas, unsigned long min, >>> int mas_empty_area(struct ma_state *mas, unsigned long min, >>> unsigned long max, unsigned long size) >>> { >>> - unsigned char offset; >>> - unsigned long *pivots; >>> - enum maple_type mt; >>> - >>> if (min >= max) >>> return -EINVAL; >>> @@ -5311,18 +5307,9 @@ int mas_empty_area(struct ma_state *mas, unsigned long min, >>> if (unlikely(mas_is_err(mas))) >>> return xa_err(mas->node); >>> - offset = mas->offset; >>> - if (unlikely(offset == MAPLE_NODE_SLOTS)) >>> + if (unlikely(mas->offset == MAPLE_NODE_SLOTS)) >>> return -EBUSY; >>> - mt = mte_node_type(mas->node); >>> - pivots = ma_pivots(mas_mn(mas), mt); >>> - if (offset) >>> - mas->min = pivots[offset - 1] + 1; >>> - >>> - if (offset < mt_pivots[mt]) >>> - mas->max = pivots[offset]; >>> - >>> if (mas->index < mas->min) >>> mas->index = mas->min; >> This will bring new bugs, mas->index should take the maximum >> value with mas->index and mas_safe_min(mas, pivots, offset), >> otherwise there will be overwriting allocation. > > Yes, you are right. Both mas->index and mas->last should be set when > the gap is found, but we aren't currently doing this. > >> >> Maybe you have forgotten, I have posted a patch[1] with the same >> function last week. I didn't know of a place where mas was used >> after mas_empty_area() before. That patch does not introduce new >> bugs, but the code style has not been updated yet. If using this >> patch will bring more conflicts with my patch set, so what should >> I do? 😁 >> >> [1] https://lore.kernel.org/lkml/20230425110511.11680-3-zhangpeng.00@bytedance.com/ > > I did forget about that, my apologies. I really wish I had remembered > instead of tracking down the same bug. > > This has become an issue because the maple state is reused for the stack > guard checks. > > We should use your patch as you sent it first and both need revisions. > We need this soon and it will need to be backported. > > Can you please take it out of your series and make the necessary > adjustments and send v2? It seems isolated enough that it won't be > difficult. Be sure to Cc everyone I have on my patch and include the > fixes tag so it can be backported as necessary. > > In the future, I'd like mas->index/mas->last to point to the gap located > to better align with mas_*_range() interface that will soon be added. > It makes more sense to record the entire gap found when returning from > the search. I think this entire area needs modernisation/attention and > optimisation, but for now, we should fix the bug. Yes, alignment can be done in mas_*_range() interface. When you post the code, I can review it. I am very interested in various data structures especially maple tree and have read most of maple tree code and verify its correctness. If there is work around maple tree in the future, I can help a little. I have some small maple tree optimization ideas, but I need some time to verify that it works. Also, I found that many codes written in maple tree are very complicated, and it will be difficult to maintain, so I will make some simplifications appropriately. Thanks, Peng > > Thanks, > Liam > >