From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E16DFC369C2 for ; Thu, 24 Apr 2025 03:40:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 193456B0006; Wed, 23 Apr 2025 23:40:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 142C06B0007; Wed, 23 Apr 2025 23:40:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFCBC6B0008; Wed, 23 Apr 2025 23:40:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CD92E6B0006 for ; Wed, 23 Apr 2025 23:40:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B139C1CF97F for ; Thu, 24 Apr 2025 03:40:36 +0000 (UTC) X-FDA: 83367535272.25.B2B369D Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012047.outbound.protection.outlook.com [52.101.126.47]) by imf24.hostedemail.com (Postfix) with ESMTP id C86E6180004 for ; Thu, 24 Apr 2025 03:40:33 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=vivo.com header.s=selector2 header.b=GZ98z1hJ; dmarc=pass (policy=quarantine) header.from=vivo.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf24.hostedemail.com: domain of link@vivo.com designates 52.101.126.47 as permitted sender) smtp.mailfrom=link@vivo.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1745466034; a=rsa-sha256; cv=pass; b=WfbVdKto/dyKAeAsSPEBac3KFNiU1qF+FytRtjwU/XlMIYIfu3h14gjZeTBfXv/u8IMhhU AKVAXMtzkRoMAaYSW7dj4h9uxZO5enkX8aJxsC2gr0GzSxzKscFlsCmXAvoXM0svmRRQQZ Wf5diL73+gZgPzhhKabYvBvBqA0OQ14= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=vivo.com header.s=selector2 header.b=GZ98z1hJ; dmarc=pass (policy=quarantine) header.from=vivo.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf24.hostedemail.com: domain of link@vivo.com designates 52.101.126.47 as permitted sender) smtp.mailfrom=link@vivo.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745466034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UvcVYYlHVSqlJsxJ9hJ4hSdxdX4E7WO4vGPa2EOnkmM=; b=AzL1jgmDd8Nn+EJ6CtU73KSfbreQzuy3xOQR5hTbRNIv2GwVce2as0JXj6YMU4rYEfHyEX q6/e66Hv68r1LjBc9FhIQfEG7J6/jcaeOj104SNNTT3fGhDhPEij0yZ/rIEDiJRojzrt2H sIQO/J56GYHgn52I2i5A0z+dE2dVZwg= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tUk0R1dLrWGuWzRWt+Fkei/koS86NrxIBCUsUxtMsLji3hsoxvJO2+RAZYrBpI5KJgR0CGBiKfCJ7tCCzBqb2F7Iuu22NhUcqM+nCvmIvjmiPTjoZroqiVGNsv8b+GAoqdShJy1sZ0wW07HR0616kG+jBL54lerxWH0B/X26Qcg6HpEVw1mxcspAgtIDLfSGdaoNx8usYXhlrkDUVPW0g89o0qNDjZhPmwL0Pm7fO9yXgct04VBjIEkc8XdxLbrgY2WXsDM513zFISA3RU0VifLnqfnrc2Bkt0u+bse6azD1vrUSpepStSlrPA9rLsAYlRnjh58R2AMOI89bdTOJjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UvcVYYlHVSqlJsxJ9hJ4hSdxdX4E7WO4vGPa2EOnkmM=; b=vPPB7Fu8HoNBaMEeMXIWPQVgzJB9qsnc976dK/r6VaJ5W7IrxwtjFAXXAmD3iE4rhrpTl+2cz3Ybh52EpJildYmhiy9gcasDaC/4YTdKEdBLNx9JEwJs6/Lk5N89PTZT5ww+EQvsblJVmtASWRJSuWmliGcS4U48iFk4gs1YTsWxLwcfp8kqF0qb6ClRP5QnBuum+LiUQoS8ZlD2gikif1YuIceQoJfEj3U8As3YkarkmiLxllf+/hEEmt5KEplZwKSqypD61jar6pw0Jg32KibJhwySpjprX0qwnaRS0d0z5o6Bun77Q7kMivJymUKBlZelZEFV9jpHEs7xzruZiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UvcVYYlHVSqlJsxJ9hJ4hSdxdX4E7WO4vGPa2EOnkmM=; b=GZ98z1hJdXkJL1kOgLo+df2ppePjef4R8Wxt/mjwFixmfrH2qQNA/IRl0AAsbgWZ5zlrICsfnUuN+Ej6tMPpZRE7BJXB6WDxEiqx6/mbRZ51E5qaxZming+ESZalvEfTygEM8RpgfVn9TrAu1ib53bQSupGLfrPLzbv8E+YLepOSzfUERdwE115upsmf0H+sgp26WmFQS8XeW3rflQidOcds9KZPdFXXyYk/KdVHEZkCOGJiGXJCY34ugZ71j8PIImOF9pLPgJFVOK0yyrgJtqErXqkMJY9rwRjiBXhqz3Yle3rBZQ1mVx6s2FnqDJx0QSe0Dj6juaz/C55G8gB8+A== Received: from PUZPR06MB5676.apcprd06.prod.outlook.com (2603:1096:301:f8::10) by TYZPR06MB6619.apcprd06.prod.outlook.com (2603:1096:400:451::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.23; Thu, 24 Apr 2025 03:40:28 +0000 Received: from PUZPR06MB5676.apcprd06.prod.outlook.com ([fe80::a00b:f422:ac44:636f]) by PUZPR06MB5676.apcprd06.prod.outlook.com ([fe80::a00b:f422:ac44:636f%6]) with mapi id 15.20.8632.036; Thu, 24 Apr 2025 03:40:27 +0000 Message-ID: Date: Thu, 24 Apr 2025 11:40:23 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/memcg: use kmem_cache when alloc memcg To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com References: <20250423084306.65706-1-link@vivo.com> <20250423084306.65706-2-link@vivo.com> <20250423145912.3e0062864b6969b3623c8ff6@linux-foundation.org> <142e6a02-80bf-4e7e-9165-1b5690fde690@vivo.com> <3txgkddzf62xhxwlzm63ip3tqv3r2tmd4elnka2z5ya7ngqr62@f554paqdco5s> From: Huan Yang In-Reply-To: <3txgkddzf62xhxwlzm63ip3tqv3r2tmd4elnka2z5ya7ngqr62@f554paqdco5s> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SGAP274CA0014.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::26) To PUZPR06MB5676.apcprd06.prod.outlook.com (2603:1096:301:f8::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PUZPR06MB5676:EE_|TYZPR06MB6619:EE_ X-MS-Office365-Filtering-Correlation-Id: ad051eed-8d10-4989-1cc6-08dd82e1c0e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bHN1NndMT25vYzdqUnVpRUNVMUpsdUlYeE5KZWw1bXB2b2E1WHRHbXRnajQ5?= =?utf-8?B?V2oxYjJmb0ZFMWFFYTVoSU9ubFVuVStIOGlVdEtNaUV1dTFHbWxFWlpnRTIw?= =?utf-8?B?TTB6OFYvamlHV3E2Skc0ZFBwRmJ3bzE4ZElFWG0wOFZZcjVSSEg3YWx1bkMz?= =?utf-8?B?SFVySVZlL2NydlJzZ0o5QlhjRUx0Y2JlOTFkU3pSN3M5TTEvWTUrZWxWQTV6?= =?utf-8?B?WGl3TUJENGtjb3VsRG9ETlFiZUkyNjdZYmhtd29HUHFDLzM5ZkczOEdPRCth?= =?utf-8?B?VnRUL1B4L3JvQ25TS050bUJCd0ErSVBLUDF4cjc3UGk2UVVjVjBKME9TaTk0?= =?utf-8?B?UmZaeFZ4ajRRUTJwZ054VUJjeU54RTZJdStPekMyOVcyUFAyb3lFNlhSK2kr?= =?utf-8?B?aGE2bFRYcHNkUHhDVFJ0YnlxQUhGL2MvdVJjOG1zZ0tRWThJT2ZUSFE1YmJ2?= =?utf-8?B?UENkSEV1QWRyb3VSanlmZ0RJbUZsRUVXUGM0SElhcU5mUDd1WkEveGpIZVA5?= =?utf-8?B?N2o2K0YrSmNCYmdHbHNyc2l0YnIwMEJlZnRZU3EweGJyUHg0ZzBsTERBeENq?= =?utf-8?B?TVBTWnF3dDlPazlEeHAzZEYwWCs0UkRhTDVtWnhIZVFkRnJZY3NpWWlwOUx5?= =?utf-8?B?bjh6eCt2NGVGMU5KZlRLakg4aHh5V1htTU44bEM1cko1ckxMbEZWeFY0Sitt?= =?utf-8?B?TkhNUitQSk1zSEpFN2RlMmFWQ1V3Tmp1L3VyTGtNdnFJcFY4UkQ1WnQ0eHVj?= =?utf-8?B?Z2pkVC9pWGI0MWZxRFNXS1lRS05oV2kyQnBVSkhyTzkvaVdSSmt2S3ZXMU10?= =?utf-8?B?b2FsT1ZpYStDSG44N0ZzVEQwZk1YNk9kNVZpWjU2dVhoTEFEQU9UL25IRVlJ?= =?utf-8?B?Vnp3VEd4eFJ0OEtQeVNCSUdsSWpjdDV1UFhKMVZLZW9xbEh5QXhDYllmOWQx?= =?utf-8?B?eHd0NHJXMk40VTdrUG5SN052dThlRlUxdHptbUFMbkVxeU9yVk16N1J0dlZQ?= =?utf-8?B?UlZxalowRW9lTUtRb3BrS2NySTdHSGV0Zm5kZUdSV2dJRU5vbXhvNGcvSlcv?= =?utf-8?B?WTdCVXNvWkJETmRqTU9OdnU4QjNtV1p6T0cvTUphUjlvYVhaOHRPajlYK00w?= =?utf-8?B?UDhmZG1JOVYrOW1wTm04MTlpSjdJTkxUa3RoNkxmVEpzMVZKNzNXbWFKTmVZ?= =?utf-8?B?amppVWgrVTRhQy9iOUdUZEdIL2tYd0FEaFRTaFE0M01XNzNwOVV0YVBjZysr?= =?utf-8?B?Tk1HOVpSTW9BRVYrUmZ4bHYzQVRhNUVEdnVSMlNpbUNmWjRHZUpuVHFTL0J3?= =?utf-8?B?dDBpTTF2aVlFNmhvdnRXUjVzOUZsMisvSms2b0lyK2M0SzN6YythMlRMZjZE?= =?utf-8?B?K0ozNXJZQ2lvRnUwVVJkQ0xTcDZuNWliWmpHRGVQa3kzai9scG0xZ3B0VVdC?= =?utf-8?B?bDhzeEVrM2szdUtJZFBiRXlTNlgxeVFBQ3lFMFNmNTVzTEpYdTdpMzlLWDZP?= =?utf-8?B?Rkhmc0drcXNORW9OVVMvRXdRV0tNWUtDWEFPU1hQcGFxNlVralpvK0FBR0l0?= =?utf-8?B?Nmp4TkdTL1A4TTJCTHB5WGVUb0g1dDZiOWJmZE8vUklHaXowcm84M29sT2JK?= =?utf-8?B?MGgzaDc0bTlnK2ppelBBTGJPcnliNUFxTTZQY2RLWGFTM1UrUTgxVEFLNUVT?= =?utf-8?B?QzQxT3dyNWdYKzd2WkNuQUFxbEFTdGlwM1JUTzBXZ1RieUk3R2ZTNEYycFUy?= =?utf-8?B?Z3A2aFljOGU1NkFKY2gyc2orZnN2RlBIRkJna3ByMWxEb2tpWXdaalUvMjJt?= =?utf-8?B?WmMrOVAyWnZwcFNZa0NuakEwZ0k1WkVOVHJCR1MrMCtjRFR3VjdZNlE4T2lx?= =?utf-8?B?QTR3U3FRcWpwaklpVXJMK0JadUhmQ1BNUGFTTFBvRUdRb3lQdm4zR1FKUGUw?= =?utf-8?B?VEhlOWtsOTZEY0tGZUxtS2pXSTh4MGJTK0JEa1FuNXZmM2JoaDNLZjVGVTBi?= =?utf-8?B?M2xRVXJsYTN3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PUZPR06MB5676.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFA2V0hPZFFDb1g1OHB0cXdSaG1OVXFna0t3Nnc2elJKYUtGeTFOcXBwUFg2?= =?utf-8?B?NmEzZDNxSnZVUkNweHJDN1k5MXo3SjY3a0dEL3E4Z09BbzdsckU1dDF3QjRR?= =?utf-8?B?Zy9rTndQVVJHUlVkMjBSZExydlZBWnBXbTQ0SnNNcGJpbDdaOCt4a1ZqNHlV?= =?utf-8?B?dXNWTXlWcTNqWWZSbDZDQStCd2ZzL0VpNW83SUtYNGRuWUcyb1V2VHhSdVhm?= =?utf-8?B?TCtLM1FuTlcweGhHYVJFVllJSXdBUXg5UEk1UlIrRFVFMU1FSWhqREd5N05I?= =?utf-8?B?Q3dTemhGWGRKNzhRNU1mMDNoc0Zvd09iM2dZZk5xNVJFeU10K1NmZ243SUFv?= =?utf-8?B?RFoxOFU2U0JiR0ZPaFBDd1M5MGJCK2NUK2pIMTNHdmg2RHVIcFMxVjV1ZzY3?= =?utf-8?B?RVlTSDY3Z0xpcTdvaEc2ZHVWbHAvVXVaOWJPQWwzREF4RWRPV3JUQ00vOFdN?= =?utf-8?B?RjkzL3JleE52emsvOThwS2N6d2FLUFd4anRoQ3g0TlpvZHZEby9hWEMyT216?= =?utf-8?B?VldzRFFBdFp6bk9zdGxyWUd1WTMvL1NJeHJ6RVhsdHlScThabU90SEFhTVRG?= =?utf-8?B?SVJHYVd6ZzRaTmhWOWZhUkY3RVpKVHpPb29VUnVubEFXMnFXOXluaXRhRHNK?= =?utf-8?B?RDJpUk44WGtlZkJkVDFFb0N3TkkyeVo3bDRnV3lacm1RVnAxMmtKNzdTdjFN?= =?utf-8?B?M3AxNENVQU9Ja1cxa1VhNmJaekRHY2QwVDJaOW5LRkpqMnY4djZBVTZMZysv?= =?utf-8?B?REtuR05tT0pwaHcxdkgyYXdlQlVKUXdoRTQ1N1Q0NEFDN3k2R2NxTlBkOVFx?= =?utf-8?B?L1IxcjFtOG5mZ0l4RDEwVERFVVdJaStweWJ0U2UwQzlTbW1pUG1jWjcvNFRz?= =?utf-8?B?disyNVg5b3VvN0ZpTXduQXZucS80TnRHL1VZYWdreHF6Wjh0VVpnQ2FtRjJF?= =?utf-8?B?UzA2WmUrNnVPSTBKTm45MGNPdEtJWmpjOEFQcmRWOWFKMTNkdXV1Wk81cHNv?= =?utf-8?B?NUI5akdYamtOS2NCY25lNE9MMEdqWFF6YTNjZll6aGdpakJIVmtrZHV1RHEz?= =?utf-8?B?TjI2ZjB4OUVta3dIUnQwdWtPRWpQWHBwM1luZFQxUVRGM083UnVtdE9ZUGtX?= =?utf-8?B?YlNEN1N6bmVJZ0hBdGVJMnk5RnFDNk1oY0lGbDIrVWZwVVZUaG5FT0Z1Y25y?= =?utf-8?B?RjVjTEd5WGl1aGE5UFVTRWdPeHVSTEp4YWRDVk13SkhXb0pub0NsV2lCclVk?= =?utf-8?B?N0xxVE9XaitJbW1SNGQrLy90SC83UHM2eEgzcm5UUUdHUEhrL2xaSTJVSjdS?= =?utf-8?B?ZDBiTTUvVTFCQ3AzM1ljZkdTWEdCR0xsZXg5dmFYSlluZE56VGp3OUlvQ3ox?= =?utf-8?B?aWZkVTE5Uks2NXVZZkNnNnRnaG14N3NYK3YvTXhYK3V0MnlvZ2tWckVEZzQw?= =?utf-8?B?U1NmWmRTYU1tMWlNdG93aVkweHhxa1pEeEhLbVpic1Fhd3lJVjBRUm15dGI3?= =?utf-8?B?WkxBd0dlamszK1lxdENHT1o4V24rclZ2NldTYkJnbVkzSVJqSlpUNWk4N210?= =?utf-8?B?OTFWT3pTaFlManpVcXI0bUZUbTFENTN5cjR2WTlHSlJnM1NsSWF5UEZJS092?= =?utf-8?B?ZXBBMzdMY09sWEMzOTNyWWk1MTV3MnFRUlhRbk54bCtsQ1ljY2NjeDNiRExS?= =?utf-8?B?NVZjSWgzcnJXcVE4Mkp6NDhCUHFjL2pxN1NjM2pBeFRQNDlSZlIzaHdUQmlJ?= =?utf-8?B?cFNBZERIMDlHSkJlNkVsRVJuN0tvMXF2SmFQdWJDblFIK0tGRFM3WHlCeGJv?= =?utf-8?B?NmFXT1VFNHNpbXVudFVUenVNQjR1R0VUM0xWZElVdlJUK24ydWkzOUtXbENq?= =?utf-8?B?dUI3YWpKQ01KT29qUHVCM3JSTXZKaExrTGpJaTNlT0lvYmdRanQzdmdoZDgz?= =?utf-8?B?MjhUYk9qSE9QS1JJRmlKL2lmZUcvTzlCSmxnMlpuUWlPNHpYSVJUaWVIYmxk?= =?utf-8?B?SWRYbjdiRTZ6TFBkTnNWMHA1MzdzOHVzVzR1MkRoRzZqdCswVloyZGlBNlVW?= =?utf-8?B?aHNTUGh1L0gxU0tOY1I2bVgvdjFFellDdVRpblRHSmNCZ2hXWVJxdmJ0K3Zr?= =?utf-8?Q?dsZAQxRn1mOxnZ0DyaGs7PO+D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad051eed-8d10-4989-1cc6-08dd82e1c0e7 X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5676.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2025 03:40:27.3868 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MxMAKCD5RmRRaCAajN5FOLL9AbYpY47xXIT0ZCEQFQLnUGMMgpLFMEhZKiSIArY8gfQMxnLlSe5Dr/UA86U+Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6619 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C86E6180004 X-Stat-Signature: 4h796rfk1jh7hckein3d73dm4bfbywxw X-HE-Tag: 1745466033-949254 X-HE-Meta: U2FsdGVkX19BYJU54br62TlEaaPuhmxzqr85YbHAT6tVjhBHZ+IJrJah6onnAnW9YVYMZ4di37M3IrGpZF4fkXrGJmih1KjZ9GjpFmzYG408c/PAN1TvqGWDNIbrprsJsttNlqZoUY1Ml/vFbpARcoUE3JC631AWBCCLbfyUBQ/E3AAtrdVgYkCfMLD2Fwe6GVysemvPzlMTabSoI93CkU77oC52r8QKZ9LZzrjQZR4jYoAuy5acRKYHzRIUJvSTlkGzzkT/vKpKvto+xOSqNoTyaj7BupiZ/yb0zSwHFtoU55pufhYc8Oone2jNwVUqEVu402oLHJW4IU4my9GORom82L9z5lLBeiM+j5C8xvOwyq90uG4qICa+4d/rHpUPCVozSgQRdeu07A6JCSCi0coFBXF48md4wN9bxLSjy+4mzbRe2B/CdpE2oMp24uKsJpShE4A59yNAE952WjOk0AzzsoAJr/frAThjtendqyyLU72svWdiibIjrpW7rAZR1pTq0ELZ6lcBauLILdL/WFzpaj7CRNE+fMRua9DfXBx/HIQupFC6nqyMWQJnjk7LoU8N0fmFy1W/RZJy4IaEwMchqiYOao2J5f/8hdNSdgu9u0HQqSMuRxn7CiZ3OuBo1sV7qHoAqioT862ZQ8EraN2U+ysqchbbl99GiL92g8xNKGWr5cED9aFijRjqzZiu2OHfXerkV74BkRM5II0AAVCsE7M6UOVI6XZy4AzybOV3QqZgDhljPiVPLWZml8e0ibvnJlGKa3DiZe065mhCNxd8ZqdzpMDJEv2DRzw7tR9GlwaUWX8RwL8Hb+cU2FbZVeQvUmX/buTIksx/KpnXrE5DL8keYmQ5wuRkS3bsFEsSl0ndp3+Pm9kXwMafdnY4ypucEFmisUUrRpOVblnM1GZpllaVc+I+E1fGe/8LiqOzCtgIA2qHoRTEPmnUVvQPpZHMcxQEFWNYYRTu2UF LoSsX63W cWqOdJ5yk0qCe7ni3dxc+Dvif3FDjce2pVqTjw9qCYwZRS3baOhXWStXPhwD2kgUahUI/WkHaWMv/ftYAK2rgICqzmgsVN1n0czRhgBp4vX17Wv6fZwLeA1ihFOk/zo2VxchmX1hl/a4TlNjMuDIysWDcUAFqY6uGqK4Lou+qDpAJS+h2pE/QqQGBN3PkyVB60OiVehj25LZH06A7aGfkHYkJJfqAvhfrbZFb16NaJmYWNSew2PE0cy10v3QdAvGJvwfzd1wcJyBnu961MES5INPUjInGCvCR7VxdHRUgA6elapixZgVntrnHqr+7DepRbXk8dxtSKJ/KtBsaO/dSuIc4KVgQCXcjLNQeeO623a5fZzjVdSZwdMnr/Ntkr4SScnUdquQZL48A8UAt56VONENVZWA9MtaT2LGhhs3iXWw9uE7tCZo5nstvhpZdkY2OdQGoUqpGfQtQwTRLcAGeP3pVHA9KUQ+PiJMlXq83SiUGiuwiuqA5aclEEBmeL64CULE4Bwt22Pypjcbb7tsGsqUhPwSzBQ+TRnF9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Shakeel 在 2025/4/24 11:31, Shakeel Butt 写道: > On Thu, Apr 24, 2025 at 10:45:05AM +0800, Huan Yang wrote: >> Hi Shakeel >> >> 在 2025/4/24 06:13, Shakeel Butt 写道: >>> On Wed, Apr 23, 2025 at 02:59:12PM -0700, Andrew Morton wrote: >>>> On Wed, 23 Apr 2025 16:43:04 +0800 Huan Yang wrote: >>>> >>>>> @@ -3652,7 +3654,10 @@ static struct mem_cgroup *mem_cgroup_alloc(struct mem_cgroup *parent) >>>>> int __maybe_unused i; >>>>> long error; >>>>> - memcg = kzalloc(struct_size(memcg, nodeinfo, nr_node_ids), GFP_KERNEL); >>>>> + memcg = likely(memcg_cachep) ? >>>>> + kmem_cache_zalloc(memcg_cachep, GFP_KERNEL) : >>>>> + kzalloc(struct_size(memcg, nodeinfo, nr_node_ids), >>>>> + GFP_KERNEL); >>>> Why are we testing for memcg_cachep=NULL? >>>> >>>>> @@ -5055,6 +5061,10 @@ static int __init mem_cgroup_init(void) >>>>> INIT_WORK(&per_cpu_ptr(&memcg_stock, cpu)->work, >>>>> drain_local_stock); >>>>> + memcg_size = struct_size_t(struct mem_cgroup, nodeinfo, nr_node_ids); >>>>> + memcg_cachep = kmem_cache_create("mem_cgroup", memcg_size, 0, >>>>> + SLAB_PANIC | SLAB_HWCACHE_ALIGN, NULL); >>>> If it's because this allocation might have failed then let's not >>>> bother. If an __init-time allocation failed, this kernel is unusable >>>> anyway. >>>> >>>> +1 to Andrew's point. SLAB_PANIC is used here, so, memcg_cachep can't be >>>> NULL later. >> I see cgroup_init(in start_kernel) ahead of initcall( which in rest_init->kernel_init->...->initcall). So, root_mem_cgroup create use >> >> cachep will trigger NULL pointer access. > So, either create a new function which creates this kmem cache before > cgroup_init() or just call mem_cgroup_init() before cgroup_init() > (similar to cpuset_init()). Do you mean like this: diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 5264d148bdd9..e9a4fc5aabc7 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -348,6 +348,7 @@ enum objext_flags {  #ifdef CONFIG_MEMCG +extern int mem_cgroup_init(void);  static inline bool folio_memcg_kmem(struct folio *folio);  /* @@ -1059,6 +1060,8 @@ static inline u64 cgroup_id_from_mm(struct mm_struct *mm)  #else /* CONFIG_MEMCG */ +static inline int mem_cgroup_init(void) { return 0; } +  #define MEM_CGROUP_ID_SHIFT    0  static inline struct mem_cgroup *folio_memcg(struct folio *folio) diff --git a/init/main.c b/init/main.c index 6b14e6116a1f..d9c646960fdd 100644 --- a/init/main.c +++ b/init/main.c @@ -50,6 +50,7 @@  #include  #include  #include +#include  #include  #include  #include @@ -1087,6 +1088,7 @@ void start_kernel(void)      nsfs_init();      pidfs_init();      cpuset_init(); +    mem_cgroup_init();      cgroup_init();      taskstats_init_early();      delayacct_init(); diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 5e2ea8b8a898..1537562c01c2 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -5029,14 +5029,12 @@ static int __init cgroup_memory(char *s)  __setup("cgroup.memory=", cgroup_memory);  /* - * subsys_initcall() for memory controller. - *   * Some parts like memcg_hotplug_cpu_dead() have to be initialized from this   * context because of lock dependencies (cgroup_lock -> cpu hotplug) but   * basically everything that doesn't depend on a specific mem_cgroup structure   * should be initialized from here.   */ -static int __init mem_cgroup_init(void) +int __init mem_cgroup_init(void)  {      int cpu; @@ -5057,7 +5055,6 @@ static int __init mem_cgroup_init(void)      return 0;  } -subsys_initcall(mem_cgroup_init);  #ifdef CONFIG_SWAP  /** Anyway, I'll test it.:) Thanks for your suggestion. Thank you, Huan