From: David Hildenbrand <david@redhat.com>
To: alexs@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
zik.eidus@ravellosystems.com, willy@infradead.org,
aarcange@redhat.com, hughd@google.com, chrisw@sous-sol.org
Subject: Re: [PATCH v5 0/10] transfer page to folio in KSM
Date: Thu, 11 Apr 2024 09:55:28 +0200 [thread overview]
Message-ID: <db95e01f-9334-4db8-8f8b-83f25a7dda87@redhat.com> (raw)
In-Reply-To: <20240411061713.1847574-1-alexs@kernel.org>
On 11.04.24 08:17, alexs@kernel.org wrote:
> From: "Alex Shi (tencent)" <alexs@kernel.org>
>
> This is the first part of page to folio transfer on KSM. Since only
> single page could be stored in KSM, we could safely transfer stable tree
> pages to folios.
> This patchset could reduce ksm.o 57kbytes from 2541776 bytes on latest
> akpm/mm-stable branch with CONFIG_DEBUG_VM enabled. It pass the KSM testing
> in LTP and kernel selftest.
Just a nit (no need to address for this patch set): "transfer page to
folio" sounds very misleading to me. I'm not a native speaker, but I'd
have called this patch set
"mm/ksm: convert some KSM code to use folios"
It's rather code conversion/transformation, not a transfer.
But again, I'm not a native speaker ...
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-04-11 7:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 6:17 alexs
2024-04-11 6:17 ` [PATCH v5 01/10] mm/ksm: add ksm_get_folio alexs
2024-04-11 6:17 ` [PATCH v5 02/10] mm/ksm: use folio in remove_rmap_item_from_tree alexs
2024-04-11 6:17 ` [PATCH v5 03/10] mm/ksm: add folio_set_stable_node alexs
2024-04-11 6:17 ` [PATCH v5 04/10] mm/ksm: use folio in remove_stable_node alexs
2024-04-11 6:17 ` [PATCH v5 05/10] mm/ksm: use folio in stable_node_dup alexs
2024-04-11 6:17 ` [PATCH v5 06/10] mm/ksm: use ksm_get_folio in scan_get_next_rmap_item alexs
2024-04-11 6:17 ` [PATCH v5 07/10] mm/ksm: use folio in write_protect_page alexs
2024-04-11 6:17 ` [PATCH v5 08/10] mm/ksm: Convert chain series funcs and replace get_ksm_page alexs
[not found] ` <8a79bfbd-b01d-4425-8fd9-de2d3e6cd1af@redhat.com>
2024-04-11 11:38 ` Alex Shi
2024-04-11 6:17 ` [PATCH v5 09/10] mm/ksm: rename get_ksm_page_flags() to ksm_get_folio_flags alexs
[not found] ` <192aaa5c-3ff3-40c1-b12a-b674518bf5de@redhat.com>
2024-04-11 11:42 ` Alex Shi
[not found] ` <47686d5e-efd3-4431-b72c-620f749faeaa@redhat.com>
2024-04-11 20:42 ` Andrew Morton
2024-04-12 1:57 ` Alex Shi
2024-04-11 6:17 ` [PATCH v5 10/10] mm/ksm: replace set_page_stable_node by folio_set_stable_node alexs
2024-04-11 7:55 ` David Hildenbrand [this message]
2024-04-11 11:45 ` [PATCH v5 0/10] transfer page to folio in KSM Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db95e01f-9334-4db8-8f8b-83f25a7dda87@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=chrisw@sous-sol.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=zik.eidus@ravellosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox